* Back-ports of dwc2 commit break peripheral-only builds
@ 2021-05-28 10:19 Phil Elwell
2021-05-30 12:18 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Phil Elwell @ 2021-05-28 10:19 UTC (permalink / raw)
To: stable
Hi,
Back-ports of [1] - a Fix to the dwc2 driver - cause build errors for
configurations including CONFIG_USB_DWC2_PERIPHERAL=y because in the stable
branches the bus_suspended member of struct dwc2_hsotg is not present with that
setting. [1] depends on [2] to move bus_suspended into a common part of
dwc2_hsotg, but because [2] is not a fix it hasn't been back-ported to stable
branches. [2] does not apply cleanly on its own (e.g. to linux-5.10.y) , so
either more commits must be back-ported, [1] must be reverted, or a subset of
[2] could be used for the back-ports.
Phil
[1] 24d209dba5a3 ("usb: dwc2: Fix hibernation between host and device modes")
[2] 012466fc8ccc0 ("usb: dwc2: Add device clock gating support functions")
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Back-ports of dwc2 commit break peripheral-only builds
2021-05-28 10:19 Back-ports of dwc2 commit break peripheral-only builds Phil Elwell
@ 2021-05-30 12:18 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-05-30 12:18 UTC (permalink / raw)
To: Phil Elwell; +Cc: stable
On Fri, May 28, 2021 at 11:19:00AM +0100, Phil Elwell wrote:
> Hi,
>
> Back-ports of [1] - a Fix to the dwc2 driver - cause build errors for
> configurations including CONFIG_USB_DWC2_PERIPHERAL=y because in the stable
> branches the bus_suspended member of struct dwc2_hsotg is not present with
> that setting. [1] depends on [2] to move bus_suspended into a common part of
> dwc2_hsotg, but because [2] is not a fix it hasn't been back-ported to
> stable branches. [2] does not apply cleanly on its own (e.g. to
> linux-5.10.y) , so either more commits must be back-ported, [1] must be
> reverted, or a subset of [2] could be used for the back-ports.
>
> Phil
>
> [1] 24d209dba5a3 ("usb: dwc2: Fix hibernation between host and device modes")
>
> [2] 012466fc8ccc0 ("usb: dwc2: Add device clock gating support functions")
Do you have a "working" version of this patch that we could take for the
older kernel trees that does not break the build? That might be the
best thing here.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-30 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-28 10:19 Back-ports of dwc2 commit break peripheral-only builds Phil Elwell
2021-05-30 12:18 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.