* [PATCH] Revert "staging: nvec: ps2: change serio type to passthrough"
@ 2016-10-25 12:10 ` Paul Fertser
0 siblings, 0 replies; 6+ messages in thread
From: Paul Fertser @ 2016-10-25 12:10 UTC (permalink / raw)
To: devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b
Cc: Paul Fertser, Marc Dietrich, Greg Kroah-Hartman,
ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt,
linux-tegra-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
This reverts commit 36b30d6138f4677514aca35ab76c20c1604baaad.
This is necessary to detect paz00 (ac100) touchpad properly as one
speaking ETPS/2 protocol. Without it X.org's synaptics driver doesn't
work as the touchpad is detected as an ImPS/2 mouse instead.
Commit ec6184b1c717b8768122e25fe6d312f609cc1bb4 changed the way
auto-detection is performed on ports marked as pass through and made the
issue apparent.
A pass through port is an additional PS/2 port used to connect a slave
device to a master device that is using PS/2 to communicate with the
host (so slave's PS/2 communication is tunneled over master's PS/2
link). "Synaptics PS/2 TouchPad Interfacing Guide" describes such a
setup (PS/2 PASS-THROUGH OPTION section).
Since paz00's embedded controller is not connected to a PS/2 port
itself, the PS/2 interface it exposes is not a pass-through one.
Acked-by: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
Signed-off-by: Paul Fertser <fercerpav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/staging/nvec/nvec_ps2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nvec_ps2.c
index a324322..c83eeb4 100644
--- a/drivers/staging/nvec/nvec_ps2.c
+++ b/drivers/staging/nvec/nvec_ps2.c
@@ -112,7 +112,7 @@ static int nvec_mouse_probe(struct platform_device *pdev)
if (!ser_dev)
return -ENOMEM;
- ser_dev->id.type = SERIO_PS_PSTHRU;
+ ser_dev->id.type = SERIO_8042;
ser_dev->write = ps2_sendcommand;
ser_dev->start = ps2_startstreaming;
ser_dev->stop = ps2_stopstreaming;
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] Revert "staging: nvec: ps2: change serio type to passthrough"
@ 2016-10-25 12:10 ` Paul Fertser
0 siblings, 0 replies; 6+ messages in thread
From: Paul Fertser @ 2016-10-25 12:10 UTC (permalink / raw)
To: devel
Cc: Paul Fertser, Marc Dietrich, Greg Kroah-Hartman, ac100,
linux-tegra, linux-kernel
This reverts commit 36b30d6138f4677514aca35ab76c20c1604baaad.
This is necessary to detect paz00 (ac100) touchpad properly as one
speaking ETPS/2 protocol. Without it X.org's synaptics driver doesn't
work as the touchpad is detected as an ImPS/2 mouse instead.
Commit ec6184b1c717b8768122e25fe6d312f609cc1bb4 changed the way
auto-detection is performed on ports marked as pass through and made the
issue apparent.
A pass through port is an additional PS/2 port used to connect a slave
device to a master device that is using PS/2 to communicate with the
host (so slave's PS/2 communication is tunneled over master's PS/2
link). "Synaptics PS/2 TouchPad Interfacing Guide" describes such a
setup (PS/2 PASS-THROUGH OPTION section).
Since paz00's embedded controller is not connected to a PS/2 port
itself, the PS/2 interface it exposes is not a pass-through one.
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
---
drivers/staging/nvec/nvec_ps2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nvec_ps2.c
index a324322..c83eeb4 100644
--- a/drivers/staging/nvec/nvec_ps2.c
+++ b/drivers/staging/nvec/nvec_ps2.c
@@ -112,7 +112,7 @@ static int nvec_mouse_probe(struct platform_device *pdev)
if (!ser_dev)
return -ENOMEM;
- ser_dev->id.type = SERIO_PS_PSTHRU;
+ ser_dev->id.type = SERIO_8042;
ser_dev->write = ps2_sendcommand;
ser_dev->start = ps2_startstreaming;
ser_dev->stop = ps2_stopstreaming;
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "staging: nvec: ps2: change serio type to passthrough"
2016-10-25 12:10 ` Paul Fertser
@ 2016-10-25 12:24 ` Marc Dietrich
-1 siblings, 0 replies; 6+ messages in thread
From: Marc Dietrich @ 2016-10-25 12:24 UTC (permalink / raw)
To: Paul Fertser; +Cc: devel, Greg Kroah-Hartman, linux-tegra, linux-kernel, ac100
[-- Attachment #1.1: Type: text/plain, Size: 1847 bytes --]
Hi Paul, Greg,
Am Dienstag, 25. Oktober 2016, 15:10:55 CEST schrieb Paul Fertser:
> This reverts commit 36b30d6138f4677514aca35ab76c20c1604baaad.
>
> This is necessary to detect paz00 (ac100) touchpad properly as one
> speaking ETPS/2 protocol. Without it X.org's synaptics driver doesn't
> work as the touchpad is detected as an ImPS/2 mouse instead.
>
> Commit ec6184b1c717b8768122e25fe6d312f609cc1bb4 changed the way
> auto-detection is performed on ports marked as pass through and made the
> issue apparent.
>
> A pass through port is an additional PS/2 port used to connect a slave
> device to a master device that is using PS/2 to communicate with the
> host (so slave's PS/2 communication is tunneled over master's PS/2
> link). "Synaptics PS/2 TouchPad Interfacing Guide" describes such a
> setup (PS/2 PASS-THROUGH OPTION section).
>
> Since paz00's embedded controller is not connected to a PS/2 port
> itself, the PS/2 interface it exposes is not a pass-through one.
>
> Acked-by: Marc Dietrich <marvin24@gmx.de>
> Signed-off-by: Paul Fertser <fercerpav@gmail.com>
In fact I was a bit to fast to ack. Turns out I booted the wrong kernel. So
please hold off this one, until some issues with this patch are fixed.
Marc
> ---
> drivers/staging/nvec/nvec_ps2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/nvec/nvec_ps2.c
> b/drivers/staging/nvec/nvec_ps2.c index a324322..c83eeb4 100644
> --- a/drivers/staging/nvec/nvec_ps2.c
> +++ b/drivers/staging/nvec/nvec_ps2.c
> @@ -112,7 +112,7 @@ static int nvec_mouse_probe(struct platform_device
> *pdev) if (!ser_dev)
> return -ENOMEM;
>
> - ser_dev->id.type = SERIO_PS_PSTHRU;
> + ser_dev->id.type = SERIO_8042;
> ser_dev->write = ps2_sendcommand;
> ser_dev->start = ps2_startstreaming;
> ser_dev->stop = ps2_stopstreaming;
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Revert "staging: nvec: ps2: change serio type to passthrough"
@ 2016-10-25 12:24 ` Marc Dietrich
0 siblings, 0 replies; 6+ messages in thread
From: Marc Dietrich @ 2016-10-25 12:24 UTC (permalink / raw)
To: Paul Fertser; +Cc: devel, Greg Kroah-Hartman, ac100, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1847 bytes --]
Hi Paul, Greg,
Am Dienstag, 25. Oktober 2016, 15:10:55 CEST schrieb Paul Fertser:
> This reverts commit 36b30d6138f4677514aca35ab76c20c1604baaad.
>
> This is necessary to detect paz00 (ac100) touchpad properly as one
> speaking ETPS/2 protocol. Without it X.org's synaptics driver doesn't
> work as the touchpad is detected as an ImPS/2 mouse instead.
>
> Commit ec6184b1c717b8768122e25fe6d312f609cc1bb4 changed the way
> auto-detection is performed on ports marked as pass through and made the
> issue apparent.
>
> A pass through port is an additional PS/2 port used to connect a slave
> device to a master device that is using PS/2 to communicate with the
> host (so slave's PS/2 communication is tunneled over master's PS/2
> link). "Synaptics PS/2 TouchPad Interfacing Guide" describes such a
> setup (PS/2 PASS-THROUGH OPTION section).
>
> Since paz00's embedded controller is not connected to a PS/2 port
> itself, the PS/2 interface it exposes is not a pass-through one.
>
> Acked-by: Marc Dietrich <marvin24@gmx.de>
> Signed-off-by: Paul Fertser <fercerpav@gmail.com>
In fact I was a bit to fast to ack. Turns out I booted the wrong kernel. So
please hold off this one, until some issues with this patch are fixed.
Marc
> ---
> drivers/staging/nvec/nvec_ps2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/nvec/nvec_ps2.c
> b/drivers/staging/nvec/nvec_ps2.c index a324322..c83eeb4 100644
> --- a/drivers/staging/nvec/nvec_ps2.c
> +++ b/drivers/staging/nvec/nvec_ps2.c
> @@ -112,7 +112,7 @@ static int nvec_mouse_probe(struct platform_device
> *pdev) if (!ser_dev)
> return -ENOMEM;
>
> - ser_dev->id.type = SERIO_PS_PSTHRU;
> + ser_dev->id.type = SERIO_8042;
> ser_dev->write = ps2_sendcommand;
> ser_dev->start = ps2_startstreaming;
> ser_dev->stop = ps2_stopstreaming;
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drivers: staging: nvec: remove bogus reset command for PS/2 interface
2016-10-25 12:24 ` Marc Dietrich
(?)
@ 2016-10-27 13:55 ` Paul Fertser
2016-10-27 13:59 ` Marc Dietrich
-1 siblings, 1 reply; 6+ messages in thread
From: Paul Fertser @ 2016-10-27 13:55 UTC (permalink / raw)
To: devel; +Cc: Paul Fertser, Greg Kroah-Hartman, linux-tegra, ac100
This command was sent behind serio's back and the answer to it was
confusing atkbd probe function which lead to the elantech touchpad
getting detected as a keyboard.
To prevent this from happening just let every party do its part of the
job.
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
---
drivers/staging/nvec/nvec_ps2.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nvec_ps2.c
index c83eeb4..910e87b 100644
--- a/drivers/staging/nvec/nvec_ps2.c
+++ b/drivers/staging/nvec/nvec_ps2.c
@@ -106,7 +106,6 @@ static int nvec_mouse_probe(struct platform_device *pdev)
{
struct nvec_chip *nvec = dev_get_drvdata(pdev->dev.parent);
struct serio *ser_dev;
- char mouse_reset[] = { NVEC_PS2, SEND_COMMAND, PSMOUSE_RST, 3 };
ser_dev = devm_kzalloc(&pdev->dev, sizeof(struct serio), GFP_KERNEL);
if (!ser_dev)
@@ -127,9 +126,6 @@ static int nvec_mouse_probe(struct platform_device *pdev)
serio_register_port(ser_dev);
- /* mouse reset */
- nvec_write_async(nvec, mouse_reset, sizeof(mouse_reset));
-
return 0;
}
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drivers: staging: nvec: remove bogus reset command for PS/2 interface
2016-10-27 13:55 ` [PATCH] drivers: staging: nvec: remove bogus reset command for PS/2 interface Paul Fertser
@ 2016-10-27 13:59 ` Marc Dietrich
0 siblings, 0 replies; 6+ messages in thread
From: Marc Dietrich @ 2016-10-27 13:59 UTC (permalink / raw)
To: Paul Fertser; +Cc: devel, Greg Kroah-Hartman, linux-tegra, ac100
[-- Attachment #1.1: Type: text/plain, Size: 1389 bytes --]
Hi Paul,
thanks for finding the issue!
Am Donnerstag, 27. Oktober 2016, 16:55:14 CEST schrieb Paul Fertser:
> This command was sent behind serio's back and the answer to it was
> confusing atkbd probe function which lead to the elantech touchpad
> getting detected as a keyboard.
>
> To prevent this from happening just let every party do its part of the
> job.
>
> Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Please send a complete patch in a new thread (or titled with V2) with the
serio type change included.
Thanks,
Marc
> ---
> drivers/staging/nvec/nvec_ps2.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec_ps2.c
> b/drivers/staging/nvec/nvec_ps2.c index c83eeb4..910e87b 100644
> --- a/drivers/staging/nvec/nvec_ps2.c
> +++ b/drivers/staging/nvec/nvec_ps2.c
> @@ -106,7 +106,6 @@ static int nvec_mouse_probe(struct platform_device
> *pdev) {
> struct nvec_chip *nvec = dev_get_drvdata(pdev->dev.parent);
> struct serio *ser_dev;
> - char mouse_reset[] = { NVEC_PS2, SEND_COMMAND, PSMOUSE_RST, 3 };
>
> ser_dev = devm_kzalloc(&pdev->dev, sizeof(struct serio), GFP_KERNEL);
> if (!ser_dev)
> @@ -127,9 +126,6 @@ static int nvec_mouse_probe(struct platform_device
> *pdev)
>
> serio_register_port(ser_dev);
>
> - /* mouse reset */
> - nvec_write_async(nvec, mouse_reset, sizeof(mouse_reset));
> -
> return 0;
> }
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-27 13:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-25 12:10 [PATCH] Revert "staging: nvec: ps2: change serio type to passthrough" Paul Fertser
2016-10-25 12:10 ` Paul Fertser
2016-10-25 12:24 ` Marc Dietrich
2016-10-25 12:24 ` Marc Dietrich
2016-10-27 13:55 ` [PATCH] drivers: staging: nvec: remove bogus reset command for PS/2 interface Paul Fertser
2016-10-27 13:59 ` Marc Dietrich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.