Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Elena Ufimtseva]

----- JBeulich@suse.com wrote:

> >>> On 09.07.15 at 13:13, <elena.ufimtseva@oracle.com> wrote:
> > On Thu, Jul 09, 2015 at 09:10:06AM +0100, Jan Beulich wrote:
> >> >>> On 08.07.15 at 19:27, <konrad.wilk@oracle.com> wrote:
> >> > On Tue, Jun 30, 2015 at 07:33:59PM -0400,
> elena.ufimtseva@oracle.com wrote:
> >> >> From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> >> >> 
> >> > 
> >> > You usually say why you need this patch. Something as simple as:
> >> > 
> >> > "In preperation for patch XXXX which will use it" is OK.
> >> 
> >> Or, even better, add such macros when the first user appears. Iirc
> >> I said so before...
> >>
> > Yes, I realized this late. Will move over in the next version if
> needed. 
> 
> Don't you need to rebase on top of v6 of "dmar: device scope mem
> leak fix" anyway? Or does the series not conflict with those changes?

You are right, it needs to be rebased. I can post later rebased on memory leak fix version, if you thin its a way to go.
> 
> Jan

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Jan Beulich]

>>> On 09.07.15 at 14:07, <elena.ufimtseva@oracle.com> wrote:
> You are right, it needs to be rebased. I can post later rebased on memory 
> leak fix version, if you thin its a way to go.

I didn't look at v9 yet, and can't predict when I will be able to.

Jan

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Elena Ufimtseva]

----- wei.liu2@citrix.com wrote:

> On Thu, Jul 09, 2015 at 05:00:45PM +0100, Jan Beulich wrote:
> > >>> On 09.07.15 at 17:53, <elena.ufimtseva@oracle.com> wrote:
> > > ----- JBeulich@suse.com wrote:
> > >> >>> On 09.07.15 at 14:07, <elena.ufimtseva@oracle.com> wrote:
> > >> > You are right, it needs to be rebased. I can post later rebased
> on
> > >> memory 
> > >> > leak fix version, if you thin its a way to go.
> > >> 
> > >> I didn't look at v9 yet, and can't predict when I will be able
> to.
> > > 
> > > Would you like me to post v10 with memory leak patch included in
> the 
> > > patchset before you start looking at v9?
> > 
> > If there is a dependency on the changes in the leak fix v6, then
> > this would be a good idea. If not, you can keep things as they are
> > now. I view the entire set more as a bug fix than a feature anyway,
> > and hence see no reason not to get this in after the freeze. But
> I'm
> > adding Wei just in case...
> > 
> 

Thanks Jan.
The dependency exists on memory leak patch, so I will add it to this series and 
squash the first patch from v9.
 
> I just looked at v9. The first three patches are quite mechanical.
> The
> fourth patch is relatively bigger but it's also quite straightforward
> (mostly parsing input). All in all, this series itself is
> self-contained.
> 
> I'm don't think OSSTest is able to test that, so it would not cause
> visible regression on our side.
> 
> I also agree it's a bug fix. Preferably this series should be applied
> before first RC.
> 
> Wei.

Thank you Wei.
> 
> > Jan

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Elena Ufimtseva]

----- JBeulich@suse.com wrote:

> >>> On 09.07.15 at 14:07, <elena.ufimtseva@oracle.com> wrote:
> > You are right, it needs to be rebased. I can post later rebased on
> memory 
> > leak fix version, if you thin its a way to go.
> 
> I didn't look at v9 yet, and can't predict when I will be able to.
> 
> Jan

Jan 

Would you like me to post v10 with memory leak patch included in the patchset before you start looking at v9?

Elena

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Jan Beulich]

>>> On 09.07.15 at 17:53, <elena.ufimtseva@oracle.com> wrote:
> ----- JBeulich@suse.com wrote:
>> >>> On 09.07.15 at 14:07, <elena.ufimtseva@oracle.com> wrote:
>> > You are right, it needs to be rebased. I can post later rebased on
>> memory 
>> > leak fix version, if you thin its a way to go.
>> 
>> I didn't look at v9 yet, and can't predict when I will be able to.
> 
> Would you like me to post v10 with memory leak patch included in the 
> patchset before you start looking at v9?

If there is a dependency on the changes in the leak fix v6, then
this would be a good idea. If not, you can keep things as they are
now. I view the entire set more as a bug fix than a feature anyway,
and hence see no reason not to get this in after the freeze. But I'm
adding Wei just in case...

Jan

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Wei Liu]

On Thu, Jul 09, 2015 at 05:00:45PM +0100, Jan Beulich wrote:
> >>> On 09.07.15 at 17:53, <elena.ufimtseva@oracle.com> wrote:
> > ----- JBeulich@suse.com wrote:
> >> >>> On 09.07.15 at 14:07, <elena.ufimtseva@oracle.com> wrote:
> >> > You are right, it needs to be rebased. I can post later rebased on
> >> memory 
> >> > leak fix version, if you thin its a way to go.
> >> 
> >> I didn't look at v9 yet, and can't predict when I will be able to.
> > 
> > Would you like me to post v10 with memory leak patch included in the 
> > patchset before you start looking at v9?
> 
> If there is a dependency on the changes in the leak fix v6, then
> this would be a good idea. If not, you can keep things as they are
> now. I view the entire set more as a bug fix than a feature anyway,
> and hence see no reason not to get this in after the freeze. But I'm
> adding Wei just in case...
> 

I just looked at v9. The first three patches are quite mechanical. The
fourth patch is relatively bigger but it's also quite straightforward
(mostly parsing input). All in all, this series itself is
self-contained.

I'm don't think OSSTest is able to test that, so it would not cause
visible regression on our side.

I also agree it's a bug fix. Preferably this series should be applied
before first RC.

Wei.

> Jan

[PATCH v8 0/4] iommu: add rmrr Xen command line option

[elena.ufimtseva]

From: Elena Ufimtseva <elena.ufimtseva@oracle.com>

v8 of rmrr comman line patches.                                                 
                                                                                
Add Xen command line option rmrr to specify RMRR                                
regions for devices that are not defined in ACPI thus                           
causing IO Page Fault while booting dom0 in PVH mode.                           
These additional regions will be added to the list of                           
RMRR regions parsed from ACPI.                                                  
                                                                                
Changes in v8:                                                                  
 - removed bogus debug in patch 1 with non-functional changes;                  
 - changed PRI_RMRRL macro for formatting to reflect the fact that two arguments
   are used, so make it PRI_RMRR(s,e) for formatting inclusive RMRR range;      
   'L' is also removed from macro name, which meant to server as a type of arguments (%lx);
 - added overlapping check with RMRRs from ACPI;                                
 - added check based on paddr_bits for pfn's in extra RMRR range (not sure if   
   its redundant with mfn_valid);                                               
 - addressed while loop exit condition in extra RMRRs parser; 
      
Changes in v7:                                                                  
 - make sure RMRRs ranges are being checked correctly;                          
 - dont interrupt RMRRs checking if some of checks fails, instead               
 continue to next RMRR;                                                         
 - make rmrr variable names more obvious;                                       
 - fix debug output formatting to match type of rmrr range;                     
 - fix typos in rmrr command line document and in comments;                     
                                                                                
Changes in v6:                                                                  
 - make __parse_pci return correct result and error codes;                      
 - move add_extra_rmrr                                                          
 - previous patch was missing RMRR addresses in range check, add it here;       
 - add overlap check and range boundaries check;                                
 - moved extra rmrr structure definition to dmar.c;                             
 - change def_seg in __parse_pci type from int to bool_t;                       
 - change name for extra rmrr range to reflect they hold now pfns;   

Changes in v5:                                                                  
 - make parse_pci a wrapper and add __parse_pci with additional def_seg param   
   to identify if segment was specified;                                        
 - make possible not to define segment for each device within same rmrr;        
 - limit number of pages for one RMRR by 16;                                    
 - run mfn_valid check for every address in RMRR range;                         
 - add PCI_SBDF macro;                                                          
 - remove list for extra rmrrs as they are kept in static array;                
                                              
Elena Ufimtseva (4):
  pci: add PCI_SBDF and PCI_SEG macros
  iommu VT-d: separate rmrr addition function
  pci: add wrapper for parse_pci
  iommu: add rmrr Xen command line option for extra rmrrs

 docs/misc/xen-command-line.markdown |  13 ++
 xen/drivers/passthrough/vtd/dmar.c  | 360 ++++++++++++++++++++++++++++--------
 xen/drivers/pci/pci.c               |  11 ++
 xen/include/xen/pci.h               |   5 +
 4 files changed, 311 insertions(+), 78 deletions(-)

-- 
2.1.3

[PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[elena.ufimtseva]

From: Elena Ufimtseva <elena.ufimtseva@oracle.com>

Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
---
 xen/include/xen/pci.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index 3908146..414106a 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -33,6 +33,8 @@
 #define PCI_DEVFN2(bdf) ((bdf) & 0xff)
 #define PCI_BDF(b,d,f)  ((((b) & 0xff) << 8) | PCI_DEVFN(d,f))
 #define PCI_BDF2(b,df)  ((((b) & 0xff) << 8) | ((df) & 0xff))
+#define PCI_SBDF(s,b,d,f) ((((s) & 0xffff) << 16) | PCI_BDF(b,d,f))
+#define PCI_SEG(sbdf) (((sbdf) >> 16) & 0xffff)
 
 struct pci_dev_info {
     bool_t is_extfn;
-- 
2.1.3

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Konrad Rzeszutek Wilk]

On Tue, Jun 30, 2015 at 07:33:59PM -0400, elena.ufimtseva@oracle.com wrote:
> From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> 

You usually say why you need this patch. Something as simple as:

"In preperation for patch XXXX which will use it" is OK.

> Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> ---
>  xen/include/xen/pci.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
> index 3908146..414106a 100644
> --- a/xen/include/xen/pci.h
> +++ b/xen/include/xen/pci.h
> @@ -33,6 +33,8 @@
>  #define PCI_DEVFN2(bdf) ((bdf) & 0xff)
>  #define PCI_BDF(b,d,f)  ((((b) & 0xff) << 8) | PCI_DEVFN(d,f))
>  #define PCI_BDF2(b,df)  ((((b) & 0xff) << 8) | ((df) & 0xff))
> +#define PCI_SBDF(s,b,d,f) ((((s) & 0xffff) << 16) | PCI_BDF(b,d,f))
> +#define PCI_SEG(sbdf) (((sbdf) >> 16) & 0xffff)
>  
>  struct pci_dev_info {
>      bool_t is_extfn;
> -- 
> 2.1.3
> 

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Jan Beulich]

>>> On 08.07.15 at 19:27, <konrad.wilk@oracle.com> wrote:
> On Tue, Jun 30, 2015 at 07:33:59PM -0400, elena.ufimtseva@oracle.com wrote:
>> From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
>> 
> 
> You usually say why you need this patch. Something as simple as:
> 
> "In preperation for patch XXXX which will use it" is OK.

Or, even better, add such macros when the first user appears. Iirc
I said so before...

Jan

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Elena Ufimtseva]

On Thu, Jul 09, 2015 at 09:10:06AM +0100, Jan Beulich wrote:
> >>> On 08.07.15 at 19:27, <konrad.wilk@oracle.com> wrote:
> > On Tue, Jun 30, 2015 at 07:33:59PM -0400, elena.ufimtseva@oracle.com wrote:
> >> From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> >> 
> > 
> > You usually say why you need this patch. Something as simple as:
> > 
> > "In preperation for patch XXXX which will use it" is OK.
> 
> Or, even better, add such macros when the first user appears. Iirc
> I said so before...
>
Yes, I realized this late. Will move over in the next version if needed. 
> Jan
> 

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Jan Beulich]

>>> On 09.07.15 at 13:13, <elena.ufimtseva@oracle.com> wrote:
> On Thu, Jul 09, 2015 at 09:10:06AM +0100, Jan Beulich wrote:
>> >>> On 08.07.15 at 19:27, <konrad.wilk@oracle.com> wrote:
>> > On Tue, Jun 30, 2015 at 07:33:59PM -0400, elena.ufimtseva@oracle.com wrote:
>> >> From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
>> >> 
>> > 
>> > You usually say why you need this patch. Something as simple as:
>> > 
>> > "In preperation for patch XXXX which will use it" is OK.
>> 
>> Or, even better, add such macros when the first user appears. Iirc
>> I said so before...
>>
> Yes, I realized this late. Will move over in the next version if needed. 

Don't you need to rebase on top of v6 of "dmar: device scope mem
leak fix" anyway? Or does the series not conflict with those changes?

Jan