Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Elena Ufimtseva]

----- JBeulich@suse.com wrote:

> >>> On 09.07.15 at 14:07, <elena.ufimtseva@oracle.com> wrote:
> > You are right, it needs to be rebased. I can post later rebased on
> memory 
> > leak fix version, if you thin its a way to go.
> 
> I didn't look at v9 yet, and can't predict when I will be able to.
> 
> Jan

Jan 

Would you like me to post v10 with memory leak patch included in the patchset before you start looking at v9?

Elena

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Jan Beulich]

>>> On 09.07.15 at 17:53, <elena.ufimtseva@oracle.com> wrote:
> ----- JBeulich@suse.com wrote:
>> >>> On 09.07.15 at 14:07, <elena.ufimtseva@oracle.com> wrote:
>> > You are right, it needs to be rebased. I can post later rebased on
>> memory 
>> > leak fix version, if you thin its a way to go.
>> 
>> I didn't look at v9 yet, and can't predict when I will be able to.
> 
> Would you like me to post v10 with memory leak patch included in the 
> patchset before you start looking at v9?

If there is a dependency on the changes in the leak fix v6, then
this would be a good idea. If not, you can keep things as they are
now. I view the entire set more as a bug fix than a feature anyway,
and hence see no reason not to get this in after the freeze. But I'm
adding Wei just in case...

Jan

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Wei Liu]

On Thu, Jul 09, 2015 at 05:00:45PM +0100, Jan Beulich wrote:
> >>> On 09.07.15 at 17:53, <elena.ufimtseva@oracle.com> wrote:
> > ----- JBeulich@suse.com wrote:
> >> >>> On 09.07.15 at 14:07, <elena.ufimtseva@oracle.com> wrote:
> >> > You are right, it needs to be rebased. I can post later rebased on
> >> memory 
> >> > leak fix version, if you thin its a way to go.
> >> 
> >> I didn't look at v9 yet, and can't predict when I will be able to.
> > 
> > Would you like me to post v10 with memory leak patch included in the 
> > patchset before you start looking at v9?
> 
> If there is a dependency on the changes in the leak fix v6, then
> this would be a good idea. If not, you can keep things as they are
> now. I view the entire set more as a bug fix than a feature anyway,
> and hence see no reason not to get this in after the freeze. But I'm
> adding Wei just in case...
> 

I just looked at v9. The first three patches are quite mechanical. The
fourth patch is relatively bigger but it's also quite straightforward
(mostly parsing input). All in all, this series itself is
self-contained.

I'm don't think OSSTest is able to test that, so it would not cause
visible regression on our side.

I also agree it's a bug fix. Preferably this series should be applied
before first RC.

Wei.

> Jan

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Elena Ufimtseva]

----- wei.liu2@citrix.com wrote:

> On Thu, Jul 09, 2015 at 05:00:45PM +0100, Jan Beulich wrote:
> > >>> On 09.07.15 at 17:53, <elena.ufimtseva@oracle.com> wrote:
> > > ----- JBeulich@suse.com wrote:
> > >> >>> On 09.07.15 at 14:07, <elena.ufimtseva@oracle.com> wrote:
> > >> > You are right, it needs to be rebased. I can post later rebased
> on
> > >> memory 
> > >> > leak fix version, if you thin its a way to go.
> > >> 
> > >> I didn't look at v9 yet, and can't predict when I will be able
> to.
> > > 
> > > Would you like me to post v10 with memory leak patch included in
> the 
> > > patchset before you start looking at v9?
> > 
> > If there is a dependency on the changes in the leak fix v6, then
> > this would be a good idea. If not, you can keep things as they are
> > now. I view the entire set more as a bug fix than a feature anyway,
> > and hence see no reason not to get this in after the freeze. But
> I'm
> > adding Wei just in case...
> > 
> 

Thanks Jan.
The dependency exists on memory leak patch, so I will add it to this series and 
squash the first patch from v9.
 
> I just looked at v9. The first three patches are quite mechanical.
> The
> fourth patch is relatively bigger but it's also quite straightforward
> (mostly parsing input). All in all, this series itself is
> self-contained.
> 
> I'm don't think OSSTest is able to test that, so it would not cause
> visible regression on our side.
> 
> I also agree it's a bug fix. Preferably this series should be applied
> before first RC.
> 
> Wei.

Thank you Wei.
> 
> > Jan

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Jan Beulich]

>>> On 09.07.15 at 14:07, <elena.ufimtseva@oracle.com> wrote:
> You are right, it needs to be rebased. I can post later rebased on memory 
> leak fix version, if you thin its a way to go.

I didn't look at v9 yet, and can't predict when I will be able to.

Jan

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Elena Ufimtseva]

----- JBeulich@suse.com wrote:

> >>> On 09.07.15 at 13:13, <elena.ufimtseva@oracle.com> wrote:
> > On Thu, Jul 09, 2015 at 09:10:06AM +0100, Jan Beulich wrote:
> >> >>> On 08.07.15 at 19:27, <konrad.wilk@oracle.com> wrote:
> >> > On Tue, Jun 30, 2015 at 07:33:59PM -0400,
> elena.ufimtseva@oracle.com wrote:
> >> >> From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> >> >> 
> >> > 
> >> > You usually say why you need this patch. Something as simple as:
> >> > 
> >> > "In preperation for patch XXXX which will use it" is OK.
> >> 
> >> Or, even better, add such macros when the first user appears. Iirc
> >> I said so before...
> >>
> > Yes, I realized this late. Will move over in the next version if
> needed. 
> 
> Don't you need to rebase on top of v6 of "dmar: device scope mem
> leak fix" anyway? Or does the series not conflict with those changes?

You are right, it needs to be rebased. I can post later rebased on memory leak fix version, if you thin its a way to go.
> 
> Jan

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Jan Beulich]

>>> On 09.07.15 at 13:13, <elena.ufimtseva@oracle.com> wrote:
> On Thu, Jul 09, 2015 at 09:10:06AM +0100, Jan Beulich wrote:
>> >>> On 08.07.15 at 19:27, <konrad.wilk@oracle.com> wrote:
>> > On Tue, Jun 30, 2015 at 07:33:59PM -0400, elena.ufimtseva@oracle.com wrote:
>> >> From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
>> >> 
>> > 
>> > You usually say why you need this patch. Something as simple as:
>> > 
>> > "In preperation for patch XXXX which will use it" is OK.
>> 
>> Or, even better, add such macros when the first user appears. Iirc
>> I said so before...
>>
> Yes, I realized this late. Will move over in the next version if needed. 

Don't you need to rebase on top of v6 of "dmar: device scope mem
leak fix" anyway? Or does the series not conflict with those changes?

Jan

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Elena Ufimtseva]

On Thu, Jul 09, 2015 at 09:10:06AM +0100, Jan Beulich wrote:
> >>> On 08.07.15 at 19:27, <konrad.wilk@oracle.com> wrote:
> > On Tue, Jun 30, 2015 at 07:33:59PM -0400, elena.ufimtseva@oracle.com wrote:
> >> From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> >> 
> > 
> > You usually say why you need this patch. Something as simple as:
> > 
> > "In preperation for patch XXXX which will use it" is OK.
> 
> Or, even better, add such macros when the first user appears. Iirc
> I said so before...
>
Yes, I realized this late. Will move over in the next version if needed. 
> Jan
> 

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Jan Beulich]

>>> On 08.07.15 at 19:27, <konrad.wilk@oracle.com> wrote:
> On Tue, Jun 30, 2015 at 07:33:59PM -0400, elena.ufimtseva@oracle.com wrote:
>> From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
>> 
> 
> You usually say why you need this patch. Something as simple as:
> 
> "In preperation for patch XXXX which will use it" is OK.

Or, even better, add such macros when the first user appears. Iirc
I said so before...

Jan

Re: [PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[Konrad Rzeszutek Wilk]

On Tue, Jun 30, 2015 at 07:33:59PM -0400, elena.ufimtseva@oracle.com wrote:
> From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> 

You usually say why you need this patch. Something as simple as:

"In preperation for patch XXXX which will use it" is OK.

> Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> ---
>  xen/include/xen/pci.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
> index 3908146..414106a 100644
> --- a/xen/include/xen/pci.h
> +++ b/xen/include/xen/pci.h
> @@ -33,6 +33,8 @@
>  #define PCI_DEVFN2(bdf) ((bdf) & 0xff)
>  #define PCI_BDF(b,d,f)  ((((b) & 0xff) << 8) | PCI_DEVFN(d,f))
>  #define PCI_BDF2(b,df)  ((((b) & 0xff) << 8) | ((df) & 0xff))
> +#define PCI_SBDF(s,b,d,f) ((((s) & 0xffff) << 16) | PCI_BDF(b,d,f))
> +#define PCI_SEG(sbdf) (((sbdf) >> 16) & 0xffff)
>  
>  struct pci_dev_info {
>      bool_t is_extfn;
> -- 
> 2.1.3
> 

[PATCH v8 1/4] pci: add PCI_SBDF and PCI_SEG macros

[elena.ufimtseva]

From: Elena Ufimtseva <elena.ufimtseva@oracle.com>

Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
---
 xen/include/xen/pci.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index 3908146..414106a 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -33,6 +33,8 @@
 #define PCI_DEVFN2(bdf) ((bdf) & 0xff)
 #define PCI_BDF(b,d,f)  ((((b) & 0xff) << 8) | PCI_DEVFN(d,f))
 #define PCI_BDF2(b,df)  ((((b) & 0xff) << 8) | ((df) & 0xff))
+#define PCI_SBDF(s,b,d,f) ((((s) & 0xffff) << 16) | PCI_BDF(b,d,f))
+#define PCI_SEG(sbdf) (((sbdf) >> 16) & 0xffff)
 
 struct pci_dev_info {
     bool_t is_extfn;
-- 
2.1.3