From: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>,
Xiong Yining <xiongyining1480@phytium.com.cn>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: rad@semihalf.com, peter.maydell@linaro.org, quic_llindhol@quicinc.com
Subject: Re: [PATCH v4 1/1] hw/arm/sbsa-ref: Enable CPU cluster on ARM sbsa machine
Date: Mon, 29 Apr 2024 08:35:07 +0200 [thread overview]
Message-ID: <559cc23e-f581-4f0d-bf59-94a516d1ef56@linaro.org> (raw)
In-Reply-To: <a25e01c0-5f6e-4568-93ec-970987eb6d07@linaro.org>
W dniu 26.04.2024 o 18:06, Richard Henderson pisze:
>
> Isn't this basically what MPIDR_EL1 is supposed to indicate?
> We do not yet implement all of that in QEMU, but should.
QEMU has socket/cluster/core/thread model which could map to
aff3/aff2/aff1/aff0 (or aff0/1/2/3) of MPIDR_EL1 register, right? But it
does not.
Nevermind which combination of socket/cluster/core/thread I use all I
have is this:
cpu 0x000 mpidr 00000000 00000000
cpu 0x001 mpidr 00000000 00000001
cpu 0x002 mpidr 00000000 00000010
cpu 0x003 mpidr 00000000 00000011
cpu 0x004 mpidr 00000000 00000100
cpu 0x005 mpidr 00000000 00000101
cpu 0x006 mpidr 00000000 00000110
cpu 0x007 mpidr 00000000 00000111
cpu 0x008 mpidr 00000001 00000000
cpu 0x009 mpidr 00000001 00000001
cpu 0x00a mpidr 00000001 00000010
cpu 0x00b mpidr 00000001 00000011
cpu 0x00c mpidr 00000001 00000100
cpu 0x00d mpidr 00000001 00000101
cpu 0x00e mpidr 00000001 00000110
cpu 0x00f mpidr 00000001 00000111
Eight cpu cores per unit. Probably leftover from GICv2 times where there
was 8 cores per GIC limit.
So looks like adding mapping of topology to MPIDR_EL1 into QEMU would be
a better option. May require checking for more than 256 of one kind then.
> Why does the same info need to be replicated in devicetree?
One of things we had on todolist: export cpu topology in PPTT table.
With MPIDR being 2 level while topology can be 4 level.
next prev parent reply other threads:[~2024-04-29 6:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 7:35 [PATCH v4 0/1] ARM Sbsa-ref: Enable CPU cluster topology Xiong Yining
2024-04-26 7:35 ` [PATCH v4 1/1] hw/arm/sbsa-ref: Enable CPU cluster on ARM sbsa machine Xiong Yining
2024-04-26 10:59 ` Marcin Juszkiewicz
2024-04-26 16:06 ` Richard Henderson
2024-04-28 2:12 ` xiongyining1480
2024-04-29 6:35 ` Marcin Juszkiewicz [this message]
2024-04-29 12:21 ` Richard Henderson
2024-05-23 18:47 ` Marcin Juszkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559cc23e-f581-4f0d-bf59-94a516d1ef56@linaro.org \
--to=marcin.juszkiewicz@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=richard.henderson@linaro.org \
--cc=xiongyining1480@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.