From: Yakir Yang <ykk@rock-chips.com> To: Jingoo Han <jingoohan1@gmail.com>, "'Heiko Stuebner'" <heiko@sntech.de>, "'Russell King'" <rmk+kernel@arm.linux.org.uk>, "'Fabio Estevam'" <fabio.estevam@freescale.com>, "'Inki Dae'" <inki.dae@samsung.com> Cc: djkurtz@google.com, dianders@google.com, "'Takashi Iwai'" <tiwai@suse.de>, "'Andrzej Hajda'" <a.hajda@samsung.com>, "'Thierry Reding'" <treding@nvidia.com>, "'Philipp Zabel'" <p.zabel@pengutronix.de>, "'David Airlie'" <airlied@linux.ie>, "'Gustavo Padovan'" <gustavo.padovan@collabora.co.uk>, "'Seung-Woo Kim'" <sw0312.kim@samsung.com>, "'Kyungmin Park'" <kyungmin.park@samsung.com>, "'Krzysztof Kozlowski'" <k.kozlowski@samsung.com>, "'Kukjin Kim'" <kgene@kernel.org>, "'Ajay Kumar'" <ajaykumar.rs@samsung.com>, "'Joonyoung Shim'" <jy0922.shim@samsung.com>, "'Vincent Palatin'" <vpalatin@chromium.org>, "'Mark Yao'" <mark.yao@rock-chips.com>, "'Andy Yan'" <andy.yan@rock-chips.com>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 0/8] Add Analogix Core Display Port Driver Date: Thu, 6 Aug 2015 23:00:47 +0800 [thread overview] Message-ID: <55C3769F.2010405@rock-chips.com> (raw) In-Reply-To: <000201d0d056$06cff040$146fd0c0$@com> Jingoo, 在 2015/8/6 22:41, Jingoo Han 写道: > On Thursday, August 06, 2015 10:49 PM, Yakir Yang wrote: >> Hi all, >> Samsung exynos and Rockchip rk3288 almost share same dp controller, >> so I split the common code out, then rk3288 and exynos can re-used the >> same dp core driver. Cause I can't find the exact IP name of exynos dp >> controller, so I decide to name dp core driver with "analogix" which I >> find in rk3288 eDP TRM ;) > > OK, I see. > The Samsung Exynos eDP contoller and Rockchip rk3288 eDP contoller share > the same IP. So, a lot of parts can be re-used. I agree with this. > However, we have to review the code carefully, as others did. Yeah, feel happy to be reviewed ;) > I also cannot find the exact IP name. The "analogix" may be the vendor name > of this IP. Okay, so "analogix" is okay for now Thanks, - Yakir > Best regards, > Jingoo Han > >> Beyond that, there are three light registers setting differents bewteen >> exynos and rk3288. >> 1. RK3288 have five special pll resigters which not indicata in exynos >> dp controller. >> 2. The address of DP_PHY_PD(dp phy power manager register) are different >> between rk3288 and exynos. >> 3. Rk3288 and exynos have different setting with AUX_HW_RETRY_CTL(dp debug >> register). >> >> My series patches can be divider into two parts: One for spliting the >> analogix_dp code from exynos dp driver. Another are trying to add rk3288 >> dp driver support. >> >> Best regards, >> - Yakir >> >> >> -- >> 2.1.2 > > > >
WARNING: multiple messages have this Message-ID (diff)
From: ykk@rock-chips.com (Yakir Yang) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 0/8] Add Analogix Core Display Port Driver Date: Thu, 6 Aug 2015 23:00:47 +0800 [thread overview] Message-ID: <55C3769F.2010405@rock-chips.com> (raw) In-Reply-To: <000201d0d056$06cff040$146fd0c0$@com> Jingoo, ? 2015/8/6 22:41, Jingoo Han ??: > On Thursday, August 06, 2015 10:49 PM, Yakir Yang wrote: >> Hi all, >> Samsung exynos and Rockchip rk3288 almost share same dp controller, >> so I split the common code out, then rk3288 and exynos can re-used the >> same dp core driver. Cause I can't find the exact IP name of exynos dp >> controller, so I decide to name dp core driver with "analogix" which I >> find in rk3288 eDP TRM ;) > > OK, I see. > The Samsung Exynos eDP contoller and Rockchip rk3288 eDP contoller share > the same IP. So, a lot of parts can be re-used. I agree with this. > However, we have to review the code carefully, as others did. Yeah, feel happy to be reviewed ;) > I also cannot find the exact IP name. The "analogix" may be the vendor name > of this IP. Okay, so "analogix" is okay for now Thanks, - Yakir > Best regards, > Jingoo Han > >> Beyond that, there are three light registers setting differents bewteen >> exynos and rk3288. >> 1. RK3288 have five special pll resigters which not indicata in exynos >> dp controller. >> 2. The address of DP_PHY_PD(dp phy power manager register) are different >> between rk3288 and exynos. >> 3. Rk3288 and exynos have different setting with AUX_HW_RETRY_CTL(dp debug >> register). >> >> My series patches can be divider into two parts: One for spliting the >> analogix_dp code from exynos dp driver. Another are trying to add rk3288 >> dp driver support. >> >> Best regards, >> - Yakir >> >> >> -- >> 2.1.2 > > > >
next prev parent reply other threads:[~2015-08-06 15:00 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-06 13:49 [RFC PATCH 0/8] Add Analogix Core Display Port Driver Yakir Yang 2015-08-06 13:49 ` Yakir Yang 2015-08-06 13:58 ` [RFC PATCH 1/8] drm: exynos/dp: fix code style Yakir Yang 2015-08-06 13:58 ` Yakir Yang 2015-08-06 14:04 ` Yakir Yang 2015-08-06 14:04 ` Yakir Yang 2015-08-06 15:05 ` Joe Perches 2015-08-06 15:05 ` Joe Perches 2015-08-06 15:05 ` Joe Perches 2015-08-06 15:20 ` Yakir Yang 2015-08-06 15:20 ` Yakir Yang 2015-08-06 15:20 ` Yakir Yang 2015-08-06 14:07 ` [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode Yakir Yang 2015-08-06 14:07 ` Yakir Yang 2015-08-06 14:19 ` Jingoo Han 2015-08-06 14:19 ` Jingoo Han 2015-08-06 14:19 ` Jingoo Han 2015-08-06 14:29 ` Yakir Yang 2015-08-06 14:29 ` Yakir Yang 2015-08-06 14:29 ` Yakir Yang 2015-08-07 11:25 ` Daniel Vetter 2015-08-07 11:25 ` Daniel Vetter 2015-08-07 13:18 ` Yakir Yang 2015-08-07 13:18 ` Yakir Yang 2015-08-06 14:19 ` [RFC PATCH 3/8] drm: bridge: analogix_dp: split exynos dp driver to bridge dir Yakir Yang 2015-08-06 14:19 ` Yakir Yang 2015-08-06 14:33 ` Jingoo Han 2015-08-06 14:33 ` Jingoo Han 2015-08-06 14:57 ` Yakir Yang 2015-08-06 14:57 ` Yakir Yang 2015-08-06 14:57 ` Yakir Yang 2015-08-06 14:19 ` [RFC PATCH 4/8] drm: rockchip/dp: add rockchip platform dp driver Yakir Yang 2015-08-06 14:19 ` Yakir Yang 2015-08-06 14:19 ` Yakir Yang 2015-08-06 14:19 ` [RFC PATCH 5/8] drm: bridge/analogix_dp: add platform device type support Yakir Yang 2015-08-06 14:19 ` Yakir Yang 2015-08-06 14:19 ` Yakir Yang 2015-08-06 14:22 ` [RFC PATCH 6/8] drm: bridge: analogix_dp: add some rk3288 special registers setting Yakir Yang 2015-08-06 14:22 ` Yakir Yang 2015-08-06 14:22 ` Yakir Yang 2015-08-06 14:24 ` [RFC PATCH 7/8] drm: bridge: analogix_dp: try force hpd after plug in lookup failed Yakir Yang 2015-08-06 14:24 ` Yakir Yang 2015-08-06 14:24 ` Yakir Yang 2015-08-06 14:26 ` [RFC PATCH 8/8] drm: bridge/analogix_dp: expand the delay time for hpd detect Yakir Yang 2015-08-06 14:26 ` Yakir Yang 2015-08-06 14:26 ` Yakir Yang 2015-08-06 14:41 ` [RFC PATCH 0/8] Add Analogix Core Display Port Driver Jingoo Han 2015-08-06 14:41 ` Jingoo Han 2015-08-06 14:41 ` Jingoo Han 2015-08-06 15:00 ` Yakir Yang [this message] 2015-08-06 15:00 ` Yakir Yang 2015-08-07 6:11 ` Ajay kumar 2015-08-07 8:17 ` Yakir Yang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55C3769F.2010405@rock-chips.com \ --to=ykk@rock-chips.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=ajaykumar.rs@samsung.com \ --cc=andy.yan@rock-chips.com \ --cc=dianders@google.com \ --cc=djkurtz@google.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=fabio.estevam@freescale.com \ --cc=gustavo.padovan@collabora.co.uk \ --cc=heiko@sntech.de \ --cc=inki.dae@samsung.com \ --cc=jingoohan1@gmail.com \ --cc=jy0922.shim@samsung.com \ --cc=k.kozlowski@samsung.com \ --cc=kgene@kernel.org \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mark.yao@rock-chips.com \ --cc=p.zabel@pengutronix.de \ --cc=rmk+kernel@arm.linux.org.uk \ --cc=sw0312.kim@samsung.com \ --cc=tiwai@suse.de \ --cc=treding@nvidia.com \ --cc=vpalatin@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.