* [PATCH v2 1/2] x265: add x265 recipe @ 2020-02-08 0:01 Scott Branden 2020-02-08 0:01 ` [PATCH v2 2/2] ffmpeg: add PACKAGECONFIG support for x265 Scott Branden 2020-02-08 1:12 ` [PATCH v2 1/2] x265: add x265 recipe Khem Raj 0 siblings, 2 replies; 11+ messages in thread From: Scott Branden @ 2020-02-08 0:01 UTC (permalink / raw) To: openembedded-core Add x265 recipe from latest revision of stable branch. Signed-off-by: Scott Branden <scott.branden@broadcom.com> --- meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 meta/recipes-multimedia/x265/x265_git.bb diff --git a/meta/recipes-multimedia/x265/x265_git.bb b/meta/recipes-multimedia/x265/x265_git.bb new file mode 100644 index 0000000000..796fbbc13a --- /dev/null +++ b/meta/recipes-multimedia/x265/x265_git.bb @@ -0,0 +1,20 @@ +SUMMARY = "H.265/HEVC video encoder" +DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format." +HOMEPAGE = "http://www.videolan.org/developers/x265.html" + +LICENSE = "GPLv2" +LICENSE_FLAGS = "commercial" +LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091" + +DEPENDS = "gnutls zlib libpcre" + +SRC_URI = "git://github.com/videolan/x265;branch=stable \ + " + +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526" + +S = "${WORKDIR}/git/source" + +inherit lib_package pkgconfig cmake + +AS[unexport] = "1" -- 2.17.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 2/2] ffmpeg: add PACKAGECONFIG support for x265 2020-02-08 0:01 [PATCH v2 1/2] x265: add x265 recipe Scott Branden @ 2020-02-08 0:01 ` Scott Branden 2020-02-08 1:12 ` [PATCH v2 1/2] x265: add x265 recipe Khem Raj 1 sibling, 0 replies; 11+ messages in thread From: Scott Branden @ 2020-02-08 0:01 UTC (permalink / raw) To: openembedded-core Add PACKAGECONFIG support for x265 in ffmpeg. Signed-off-by: Scott Branden <scott.branden@broadcom.com> --- meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.2.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.2.bb b/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.2.bb index a3cf0c1a37..0c27663cf6 100644 --- a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.2.bb +++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.2.bb @@ -43,7 +43,7 @@ DEPENDS = "nasm-native" inherit autotools pkgconfig PACKAGECONFIG ??= "avdevice avfilter avcodec avformat swresample swscale postproc avresample \ - alsa bzlib gpl lzma theora x264 zlib \ + alsa bzlib gpl lzma theora x264 x265 zlib \ ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xv xcb', '', d)}" # libraries to build in addition to avutil @@ -74,6 +74,7 @@ PACKAGECONFIG[vaapi] = "--enable-vaapi,--disable-vaapi,libva" PACKAGECONFIG[vdpau] = "--enable-vdpau,--disable-vdpau,libvdpau" PACKAGECONFIG[vpx] = "--enable-libvpx,--disable-libvpx,libvpx" PACKAGECONFIG[x264] = "--enable-libx264,--disable-libx264,x264" +PACKAGECONFIG[x265] = "--enable-libx265,--disable-libx265,x265" PACKAGECONFIG[xcb] = "--enable-libxcb,--disable-libxcb,libxcb" PACKAGECONFIG[xv] = "--enable-outdev=xv,--disable-outdev=xv,libxv" PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib" -- 2.17.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] x265: add x265 recipe 2020-02-08 0:01 [PATCH v2 1/2] x265: add x265 recipe Scott Branden 2020-02-08 0:01 ` [PATCH v2 2/2] ffmpeg: add PACKAGECONFIG support for x265 Scott Branden @ 2020-02-08 1:12 ` Khem Raj 2020-02-08 4:02 ` Scott Branden 1 sibling, 1 reply; 11+ messages in thread From: Khem Raj @ 2020-02-08 1:12 UTC (permalink / raw) To: Scott Branden; +Cc: openembedded-core [-- Attachment #1: Type: text/plain, Size: 1651 bytes --] On Fri, Feb 7, 2020 at 4:01 PM Scott Branden via Openembedded-core < openembedded-core@lists.openembedded.org> wrote: > Add x265 recipe from latest revision of stable branch. I wonder if it belongs to core are there deps on it that we need in common metadata > > > Signed-off-by: Scott Branden <scott.branden@broadcom.com> > --- > meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 meta/recipes-multimedia/x265/x265_git.bb > > diff --git a/meta/recipes-multimedia/x265/x265_git.bb > b/meta/recipes-multimedia/x265/x265_git.bb > new file mode 100644 > index 0000000000..796fbbc13a > --- /dev/null > +++ b/meta/recipes-multimedia/x265/x265_git.bb > @@ -0,0 +1,20 @@ > +SUMMARY = "H.265/HEVC video encoder" > +DESCRIPTION = "A free software library and application for encoding video > streams into the H.265/HEVC format." > +HOMEPAGE = "http://www.videolan.org/developers/x265.html" > + > +LICENSE = "GPLv2" > +LICENSE_FLAGS = "commercial" > +LIC_FILES_CHKSUM = > "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091" > + > +DEPENDS = "gnutls zlib libpcre" > + > +SRC_URI = "git://github.com/videolan/x265;branch=stable \ > + " > + > +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526" > + > +S = "${WORKDIR}/git/source" > + > +inherit lib_package pkgconfig cmake > + > +AS[unexport] = "1" > -- > 2.17.1 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > [-- Attachment #2: Type: text/html, Size: 3058 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] x265: add x265 recipe 2020-02-08 1:12 ` [PATCH v2 1/2] x265: add x265 recipe Khem Raj @ 2020-02-08 4:02 ` Scott Branden 2020-02-08 19:18 ` Khem Raj 0 siblings, 1 reply; 11+ messages in thread From: Scott Branden @ 2020-02-08 4:02 UTC (permalink / raw) To: Khem Raj; +Cc: openembedded-core [-- Attachment #1: Type: text/plain, Size: 2439 bytes --] Hi Khem, On 2020-02-07 5:12 p.m., Khem Raj wrote: > > > On Fri, Feb 7, 2020 at 4:01 PM Scott Branden via Openembedded-core > <openembedded-core@lists.openembedded.org > <mailto:openembedded-core@lists.openembedded.org>> wrote: > > Add x265 recipe from latest revision of stable branch. > > > I wonder if it belongs to core are there deps on it that we need in > common metadata I simply followed where x264 recipe is located and placed x265 beside it. Both are needed when enabled in ffmpeg. I don't know if that answers your question as to where they should be located. > > > > Signed-off-by: Scott Branden <scott.branden@broadcom.com > <mailto:scott.branden@broadcom.com>> > --- > meta/recipes-multimedia/x265/x265_git.bb <http://x265_git.bb> | > 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 meta/recipes-multimedia/x265/x265_git.bb > <http://x265_git.bb> > > diff --git a/meta/recipes-multimedia/x265/x265_git.bb > <http://x265_git.bb> b/meta/recipes-multimedia/x265/x265_git.bb > <http://x265_git.bb> > new file mode 100644 > index 0000000000..796fbbc13a > --- /dev/null > +++ b/meta/recipes-multimedia/x265/x265_git.bb <http://x265_git.bb> > @@ -0,0 +1,20 @@ > +SUMMARY = "H.265/HEVC video encoder" > +DESCRIPTION = "A free software library and application for > encoding video streams into the H.265/HEVC format." > +HOMEPAGE = "http://www.videolan.org/developers/x265.html" > + > +LICENSE = "GPLv2" > +LICENSE_FLAGS = "commercial" > +LIC_FILES_CHKSUM = > "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091" > + > +DEPENDS = "gnutls zlib libpcre" > + > +SRC_URI = "git://github.com/videolan/x265;branch=stable > <http://github.com/videolan/x265;branch=stable> \ > + " > + > +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526" > + > +S = "${WORKDIR}/git/source" > + > +inherit lib_package pkgconfig cmake > + > +AS[unexport] = "1" > -- > 2.17.1 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > <mailto:Openembedded-core@lists.openembedded.org> > http://lists.openembedded.org/mailman/listinfo/openembedded-core > [-- Attachment #2: Type: text/html, Size: 5296 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] x265: add x265 recipe 2020-02-08 4:02 ` Scott Branden @ 2020-02-08 19:18 ` Khem Raj 2020-02-09 19:27 ` Scott Branden 0 siblings, 1 reply; 11+ messages in thread From: Khem Raj @ 2020-02-08 19:18 UTC (permalink / raw) To: Scott Branden; +Cc: Patches and discussions about the oe-core layer On Fri, Feb 7, 2020 at 8:02 PM Scott Branden <scott.branden@broadcom.com> wrote: > > Hi Khem, > > On 2020-02-07 5:12 p.m., Khem Raj wrote: > > > > On Fri, Feb 7, 2020 at 4:01 PM Scott Branden via Openembedded-core <openembedded-core@lists.openembedded.org> wrote: >> >> Add x265 recipe from latest revision of stable branch. > > > I wonder if it belongs to core are there deps on it that we need in common metadata > > I simply followed where x264 recipe is located and placed x265 beside it. > Both are needed when enabled in ffmpeg. > > I don't know if that answers your question as to where they should be located. >> idea is to keep small and therefore we should assess the inclusions in core we have many packageconfigs which require packages from other layers so if ffmpeg needs it and is optional then it should be fine to keep it in meta-multimedia and packageconfig in ffmpeg disabled by default. >> >> >> Signed-off-by: Scott Branden <scott.branden@broadcom.com> >> --- >> meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> create mode 100644 meta/recipes-multimedia/x265/x265_git.bb >> >> diff --git a/meta/recipes-multimedia/x265/x265_git.bb b/meta/recipes-multimedia/x265/x265_git.bb >> new file mode 100644 >> index 0000000000..796fbbc13a >> --- /dev/null >> +++ b/meta/recipes-multimedia/x265/x265_git.bb >> @@ -0,0 +1,20 @@ >> +SUMMARY = "H.265/HEVC video encoder" >> +DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format." >> +HOMEPAGE = "http://www.videolan.org/developers/x265.html" >> + >> +LICENSE = "GPLv2" >> +LICENSE_FLAGS = "commercial" >> +LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091" >> + >> +DEPENDS = "gnutls zlib libpcre" >> + >> +SRC_URI = "git://github.com/videolan/x265;branch=stable \ >> + " >> + >> +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526" >> + >> +S = "${WORKDIR}/git/source" >> + >> +inherit lib_package pkgconfig cmake >> + >> +AS[unexport] = "1" >> -- >> 2.17.1 >> >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] x265: add x265 recipe 2020-02-08 19:18 ` Khem Raj @ 2020-02-09 19:27 ` Scott Branden 2020-02-09 23:35 ` Khem Raj 0 siblings, 1 reply; 11+ messages in thread From: Scott Branden @ 2020-02-09 19:27 UTC (permalink / raw) To: Khem Raj; +Cc: Patches and discussions about the oe-core layer On 2020-02-08 11:18 a.m., Khem Raj wrote: > On Fri, Feb 7, 2020 at 8:02 PM Scott Branden <scott.branden@broadcom.com> wrote: >> Hi Khem, >> >> On 2020-02-07 5:12 p.m., Khem Raj wrote: >> >> >> >> On Fri, Feb 7, 2020 at 4:01 PM Scott Branden via Openembedded-core <openembedded-core@lists.openembedded.org> wrote: >>> Add x265 recipe from latest revision of stable branch. >> >> I wonder if it belongs to core are there deps on it that we need in common metadata >> >> I simply followed where x264 recipe is located and placed x265 beside it. >> Both are needed when enabled in ffmpeg. >> >> I don't know if that answers your question as to where they should be located. > idea is to keep small and therefore we should assess the inclusions in core > we have many packageconfigs which require packages from other layers > so if ffmpeg needs it and is optional then it should be fine to keep > it in meta-multimedia and packageconfig in ffmpeg disabled by default. I don't see why x264 would be in core and x265 in meta-multimedia. Both should be moved to meta-multimedia then? I think you would also require a bbappend to fffmpeg recipe to add x264 and x265 to ffmpeg packageconfig. if that is the case, why not move ffmpeg to meta-multimedia as well? > >>> >>> Signed-off-by: Scott Branden <scott.branden@broadcom.com> >>> --- >>> meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++ >>> 1 file changed, 20 insertions(+) >>> create mode 100644 meta/recipes-multimedia/x265/x265_git.bb >>> >>> diff --git a/meta/recipes-multimedia/x265/x265_git.bb b/meta/recipes-multimedia/x265/x265_git.bb >>> new file mode 100644 >>> index 0000000000..796fbbc13a >>> --- /dev/null >>> +++ b/meta/recipes-multimedia/x265/x265_git.bb >>> @@ -0,0 +1,20 @@ >>> +SUMMARY = "H.265/HEVC video encoder" >>> +DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format." >>> +HOMEPAGE = "http://www.videolan.org/developers/x265.html" >>> + >>> +LICENSE = "GPLv2" >>> +LICENSE_FLAGS = "commercial" >>> +LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091" >>> + >>> +DEPENDS = "gnutls zlib libpcre" >>> + >>> +SRC_URI = "git://github.com/videolan/x265;branch=stable \ >>> + " >>> + >>> +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526" >>> + >>> +S = "${WORKDIR}/git/source" >>> + >>> +inherit lib_package pkgconfig cmake >>> + >>> +AS[unexport] = "1" >>> -- >>> 2.17.1 >>> >>> -- >>> _______________________________________________ >>> Openembedded-core mailing list >>> Openembedded-core@lists.openembedded.org >>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] x265: add x265 recipe 2020-02-09 19:27 ` Scott Branden @ 2020-02-09 23:35 ` Khem Raj 2020-02-10 6:15 ` Scott Branden 0 siblings, 1 reply; 11+ messages in thread From: Khem Raj @ 2020-02-09 23:35 UTC (permalink / raw) To: Scott Branden; +Cc: Patches and discussions about the oe-core layer On Sun, Feb 9, 2020 at 11:27 AM Scott Branden <scott.branden@broadcom.com> wrote: > > > > On 2020-02-08 11:18 a.m., Khem Raj wrote: > > On Fri, Feb 7, 2020 at 8:02 PM Scott Branden <scott.branden@broadcom.com> wrote: > >> Hi Khem, > >> > >> On 2020-02-07 5:12 p.m., Khem Raj wrote: > >> > >> > >> > >> On Fri, Feb 7, 2020 at 4:01 PM Scott Branden via Openembedded-core <openembedded-core@lists.openembedded.org> wrote: > >>> Add x265 recipe from latest revision of stable branch. > >> > >> I wonder if it belongs to core are there deps on it that we need in common metadata > >> > >> I simply followed where x264 recipe is located and placed x265 beside it. > >> Both are needed when enabled in ffmpeg. > >> > >> I don't know if that answers your question as to where they should be located. > > idea is to keep small and therefore we should assess the inclusions in core > > we have many packageconfigs which require packages from other layers > > so if ffmpeg needs it and is optional then it should be fine to keep > > it in meta-multimedia and packageconfig in ffmpeg disabled by default. > I don't see why x264 would be in core and x265 in meta-multimedia. > Both should be moved to meta-multimedia then? > I followed the thread a bit and I see there are followups where usecase for other recipes in core is now established, where this seemed a leaf package being added to oe-core, So perhaps it should be added to validation loops as well like x264. > I think you would also require a bbappend to fffmpeg recipe to add x264 > and x265 to ffmpeg packageconfig. > if that is the case, why not move ffmpeg to meta-multimedia as well? > You would not go down that line of thought since these packages are in the dependency chain for validating reference images in core along with they being used by other packages from other layers. > > > >>> > >>> Signed-off-by: Scott Branden <scott.branden@broadcom.com> > >>> --- > >>> meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++ > >>> 1 file changed, 20 insertions(+) > >>> create mode 100644 meta/recipes-multimedia/x265/x265_git.bb > >>> > >>> diff --git a/meta/recipes-multimedia/x265/x265_git.bb b/meta/recipes-multimedia/x265/x265_git.bb > >>> new file mode 100644 > >>> index 0000000000..796fbbc13a > >>> --- /dev/null > >>> +++ b/meta/recipes-multimedia/x265/x265_git.bb > >>> @@ -0,0 +1,20 @@ > >>> +SUMMARY = "H.265/HEVC video encoder" > >>> +DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format." > >>> +HOMEPAGE = "http://www.videolan.org/developers/x265.html" > >>> + > >>> +LICENSE = "GPLv2" > >>> +LICENSE_FLAGS = "commercial" > >>> +LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091" > >>> + > >>> +DEPENDS = "gnutls zlib libpcre" > >>> + > >>> +SRC_URI = "git://github.com/videolan/x265;branch=stable \ > >>> + " > >>> + > >>> +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526" > >>> + > >>> +S = "${WORKDIR}/git/source" > >>> + > >>> +inherit lib_package pkgconfig cmake > >>> + > >>> +AS[unexport] = "1" > >>> -- > >>> 2.17.1 > >>> > >>> -- > >>> _______________________________________________ > >>> Openembedded-core mailing list > >>> Openembedded-core@lists.openembedded.org > >>> http://lists.openembedded.org/mailman/listinfo/openembedded-core > >> > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] x265: add x265 recipe 2020-02-09 23:35 ` Khem Raj @ 2020-02-10 6:15 ` Scott Branden 2020-02-10 11:42 ` Alexander Kanavin 0 siblings, 1 reply; 11+ messages in thread From: Scott Branden @ 2020-02-10 6:15 UTC (permalink / raw) To: Khem Raj; +Cc: Patches and discussions about the oe-core layer On 2020-02-09 3:35 p.m., Khem Raj wrote: > On Sun, Feb 9, 2020 at 11:27 AM Scott Branden > <scott.branden@broadcom.com> wrote: >> >> >> On 2020-02-08 11:18 a.m., Khem Raj wrote: >>> On Fri, Feb 7, 2020 at 8:02 PM Scott Branden <scott.branden@broadcom.com> wrote: >>>> Hi Khem, >>>> >>>> On 2020-02-07 5:12 p.m., Khem Raj wrote: >>>> >>>> >>>> >>>> On Fri, Feb 7, 2020 at 4:01 PM Scott Branden via Openembedded-core <openembedded-core@lists.openembedded.org> wrote: >>>>> Add x265 recipe from latest revision of stable branch. >>>> I wonder if it belongs to core are there deps on it that we need in common metadata >>>> >>>> I simply followed where x264 recipe is located and placed x265 beside it. >>>> Both are needed when enabled in ffmpeg. >>>> >>>> I don't know if that answers your question as to where they should be located. >>> idea is to keep small and therefore we should assess the inclusions in core >>> we have many packageconfigs which require packages from other layers >>> so if ffmpeg needs it and is optional then it should be fine to keep >>> it in meta-multimedia and packageconfig in ffmpeg disabled by default. >> I don't see why x264 would be in core and x265 in meta-multimedia. >> Both should be moved to meta-multimedia then? >> > I followed the thread a bit and I see there are followups where > usecase for other recipes in core is now > established, where this seemed a leaf package being added to oe-core, > So perhaps it should be added > to validation loops as well like x264. I leave it to the powers that be to decide where to place this recipe. > >> I think you would also require a bbappend to fffmpeg recipe to add x264 >> and x265 to ffmpeg packageconfig. >> if that is the case, why not move ffmpeg to meta-multimedia as well? >> > You would not go down that line of thought since these packages are in > the dependency chain for validating reference > images in core along with they being used by other packages from other layers. > >>>>> Signed-off-by: Scott Branden <scott.branden@broadcom.com> >>>>> --- >>>>> meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++ >>>>> 1 file changed, 20 insertions(+) >>>>> create mode 100644 meta/recipes-multimedia/x265/x265_git.bb >>>>> >>>>> diff --git a/meta/recipes-multimedia/x265/x265_git.bb b/meta/recipes-multimedia/x265/x265_git.bb >>>>> new file mode 100644 >>>>> index 0000000000..796fbbc13a >>>>> --- /dev/null >>>>> +++ b/meta/recipes-multimedia/x265/x265_git.bb >>>>> @@ -0,0 +1,20 @@ >>>>> +SUMMARY = "H.265/HEVC video encoder" >>>>> +DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format." >>>>> +HOMEPAGE = "http://www.videolan.org/developers/x265.html" >>>>> + >>>>> +LICENSE = "GPLv2" >>>>> +LICENSE_FLAGS = "commercial" >>>>> +LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091" >>>>> + >>>>> +DEPENDS = "gnutls zlib libpcre" >>>>> + >>>>> +SRC_URI = "git://github.com/videolan/x265;branch=stable \ >>>>> + " >>>>> + >>>>> +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526" >>>>> + >>>>> +S = "${WORKDIR}/git/source" >>>>> + >>>>> +inherit lib_package pkgconfig cmake >>>>> + >>>>> +AS[unexport] = "1" >>>>> -- >>>>> 2.17.1 >>>>> >>>>> -- >>>>> _______________________________________________ >>>>> Openembedded-core mailing list >>>>> Openembedded-core@lists.openembedded.org >>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] x265: add x265 recipe 2020-02-10 6:15 ` Scott Branden @ 2020-02-10 11:42 ` Alexander Kanavin 2020-02-10 16:01 ` Khem Raj 0 siblings, 1 reply; 11+ messages in thread From: Alexander Kanavin @ 2020-02-10 11:42 UTC (permalink / raw) To: Scott Branden; +Cc: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 4202 bytes --] As long as we're consistent, I'm ok with either option. I think it's ultimately up to RP to make the call. Alex On Mon, 10 Feb 2020 at 07:16, Scott Branden via Openembedded-core < openembedded-core@lists.openembedded.org> wrote: > > > On 2020-02-09 3:35 p.m., Khem Raj wrote: > > On Sun, Feb 9, 2020 at 11:27 AM Scott Branden > > <scott.branden@broadcom.com> wrote: > >> > >> > >> On 2020-02-08 11:18 a.m., Khem Raj wrote: > >>> On Fri, Feb 7, 2020 at 8:02 PM Scott Branden < > scott.branden@broadcom.com> wrote: > >>>> Hi Khem, > >>>> > >>>> On 2020-02-07 5:12 p.m., Khem Raj wrote: > >>>> > >>>> > >>>> > >>>> On Fri, Feb 7, 2020 at 4:01 PM Scott Branden via Openembedded-core < > openembedded-core@lists.openembedded.org> wrote: > >>>>> Add x265 recipe from latest revision of stable branch. > >>>> I wonder if it belongs to core are there deps on it that we need in > common metadata > >>>> > >>>> I simply followed where x264 recipe is located and placed x265 beside > it. > >>>> Both are needed when enabled in ffmpeg. > >>>> > >>>> I don't know if that answers your question as to where they should be > located. > >>> idea is to keep small and therefore we should assess the inclusions in > core > >>> we have many packageconfigs which require packages from other layers > >>> so if ffmpeg needs it and is optional then it should be fine to keep > >>> it in meta-multimedia and packageconfig in ffmpeg disabled by default. > >> I don't see why x264 would be in core and x265 in meta-multimedia. > >> Both should be moved to meta-multimedia then? > >> > > I followed the thread a bit and I see there are followups where > > usecase for other recipes in core is now > > established, where this seemed a leaf package being added to oe-core, > > So perhaps it should be added > > to validation loops as well like x264. > I leave it to the powers that be to decide where to place this recipe. > > > >> I think you would also require a bbappend to fffmpeg recipe to add x264 > >> and x265 to ffmpeg packageconfig. > >> if that is the case, why not move ffmpeg to meta-multimedia as well? > >> > > You would not go down that line of thought since these packages are in > > the dependency chain for validating reference > > images in core along with they being used by other packages from other > layers. > > > >>>>> Signed-off-by: Scott Branden <scott.branden@broadcom.com> > >>>>> --- > >>>>> meta/recipes-multimedia/x265/x265_git.bb | 20 > ++++++++++++++++++++ > >>>>> 1 file changed, 20 insertions(+) > >>>>> create mode 100644 meta/recipes-multimedia/x265/x265_git.bb > >>>>> > >>>>> diff --git a/meta/recipes-multimedia/x265/x265_git.bb > b/meta/recipes-multimedia/x265/x265_git.bb > >>>>> new file mode 100644 > >>>>> index 0000000000..796fbbc13a > >>>>> --- /dev/null > >>>>> +++ b/meta/recipes-multimedia/x265/x265_git.bb > >>>>> @@ -0,0 +1,20 @@ > >>>>> +SUMMARY = "H.265/HEVC video encoder" > >>>>> +DESCRIPTION = "A free software library and application for encoding > video streams into the H.265/HEVC format." > >>>>> +HOMEPAGE = "http://www.videolan.org/developers/x265.html" > >>>>> + > >>>>> +LICENSE = "GPLv2" > >>>>> +LICENSE_FLAGS = "commercial" > >>>>> +LIC_FILES_CHKSUM = > "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091" > >>>>> + > >>>>> +DEPENDS = "gnutls zlib libpcre" > >>>>> + > >>>>> +SRC_URI = "git://github.com/videolan/x265;branch=stable \ > >>>>> + " > >>>>> + > >>>>> +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526" > >>>>> + > >>>>> +S = "${WORKDIR}/git/source" > >>>>> + > >>>>> +inherit lib_package pkgconfig cmake > >>>>> + > >>>>> +AS[unexport] = "1" > >>>>> -- > >>>>> 2.17.1 > >>>>> > >>>>> -- > >>>>> _______________________________________________ > >>>>> Openembedded-core mailing list > >>>>> Openembedded-core@lists.openembedded.org > >>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > [-- Attachment #2: Type: text/html, Size: 6962 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] x265: add x265 recipe 2020-02-10 11:42 ` Alexander Kanavin @ 2020-02-10 16:01 ` Khem Raj 2020-02-10 21:17 ` Scott Branden 0 siblings, 1 reply; 11+ messages in thread From: Khem Raj @ 2020-02-10 16:01 UTC (permalink / raw) To: Alexander Kanavin; +Cc: Patches and discussions about the oe-core layer On Mon, Feb 10, 2020 at 3:42 AM Alexander Kanavin <alex.kanavin@gmail.com> wrote: > > As long as we're consistent, I'm ok with either option. I think it's ultimately up to RP to make the call. > > The usecase is fine, as long as we add x265 support to gst plugins and ffmeg and it gets tested via reference images, I see no issues adding it. > Alex > > On Mon, 10 Feb 2020 at 07:16, Scott Branden via Openembedded-core <openembedded-core@lists.openembedded.org> wrote: >> >> >> >> On 2020-02-09 3:35 p.m., Khem Raj wrote: >> > On Sun, Feb 9, 2020 at 11:27 AM Scott Branden >> > <scott.branden@broadcom.com> wrote: >> >> >> >> >> >> On 2020-02-08 11:18 a.m., Khem Raj wrote: >> >>> On Fri, Feb 7, 2020 at 8:02 PM Scott Branden <scott.branden@broadcom.com> wrote: >> >>>> Hi Khem, >> >>>> >> >>>> On 2020-02-07 5:12 p.m., Khem Raj wrote: >> >>>> >> >>>> >> >>>> >> >>>> On Fri, Feb 7, 2020 at 4:01 PM Scott Branden via Openembedded-core <openembedded-core@lists.openembedded.org> wrote: >> >>>>> Add x265 recipe from latest revision of stable branch. >> >>>> I wonder if it belongs to core are there deps on it that we need in common metadata >> >>>> >> >>>> I simply followed where x264 recipe is located and placed x265 beside it. >> >>>> Both are needed when enabled in ffmpeg. >> >>>> >> >>>> I don't know if that answers your question as to where they should be located. >> >>> idea is to keep small and therefore we should assess the inclusions in core >> >>> we have many packageconfigs which require packages from other layers >> >>> so if ffmpeg needs it and is optional then it should be fine to keep >> >>> it in meta-multimedia and packageconfig in ffmpeg disabled by default. >> >> I don't see why x264 would be in core and x265 in meta-multimedia. >> >> Both should be moved to meta-multimedia then? >> >> >> > I followed the thread a bit and I see there are followups where >> > usecase for other recipes in core is now >> > established, where this seemed a leaf package being added to oe-core, >> > So perhaps it should be added >> > to validation loops as well like x264. >> I leave it to the powers that be to decide where to place this recipe. >> > >> >> I think you would also require a bbappend to fffmpeg recipe to add x264 >> >> and x265 to ffmpeg packageconfig. >> >> if that is the case, why not move ffmpeg to meta-multimedia as well? >> >> >> > You would not go down that line of thought since these packages are in >> > the dependency chain for validating reference >> > images in core along with they being used by other packages from other layers. >> > >> >>>>> Signed-off-by: Scott Branden <scott.branden@broadcom.com> >> >>>>> --- >> >>>>> meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++ >> >>>>> 1 file changed, 20 insertions(+) >> >>>>> create mode 100644 meta/recipes-multimedia/x265/x265_git.bb >> >>>>> >> >>>>> diff --git a/meta/recipes-multimedia/x265/x265_git.bb b/meta/recipes-multimedia/x265/x265_git.bb >> >>>>> new file mode 100644 >> >>>>> index 0000000000..796fbbc13a >> >>>>> --- /dev/null >> >>>>> +++ b/meta/recipes-multimedia/x265/x265_git.bb >> >>>>> @@ -0,0 +1,20 @@ >> >>>>> +SUMMARY = "H.265/HEVC video encoder" >> >>>>> +DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format." >> >>>>> +HOMEPAGE = "http://www.videolan.org/developers/x265.html" >> >>>>> + >> >>>>> +LICENSE = "GPLv2" >> >>>>> +LICENSE_FLAGS = "commercial" >> >>>>> +LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091" >> >>>>> + >> >>>>> +DEPENDS = "gnutls zlib libpcre" >> >>>>> + >> >>>>> +SRC_URI = "git://github.com/videolan/x265;branch=stable \ >> >>>>> + " >> >>>>> + >> >>>>> +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526" >> >>>>> + >> >>>>> +S = "${WORKDIR}/git/source" >> >>>>> + >> >>>>> +inherit lib_package pkgconfig cmake >> >>>>> + >> >>>>> +AS[unexport] = "1" >> >>>>> -- >> >>>>> 2.17.1 >> >>>>> >> >>>>> -- >> >>>>> _______________________________________________ >> >>>>> Openembedded-core mailing list >> >>>>> Openembedded-core@lists.openembedded.org >> >>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/2] x265: add x265 recipe 2020-02-10 16:01 ` Khem Raj @ 2020-02-10 21:17 ` Scott Branden 0 siblings, 0 replies; 11+ messages in thread From: Scott Branden @ 2020-02-10 21:17 UTC (permalink / raw) To: Khem Raj, Alexander Kanavin Cc: Patches and discussions about the oe-core layer On 2020-02-10 8:01 a.m., Khem Raj wrote: > On Mon, Feb 10, 2020 at 3:42 AM Alexander Kanavin > <alex.kanavin@gmail.com> wrote: >> As long as we're consistent, I'm ok with either option. I think it's ultimately up to RP to make the call. >> >> > The usecase is fine, as long as we add x265 support to gst plugins and > ffmeg and it gets tested via reference > images, I see no issues adding it. I'm changing my opinion now and leaning toward meta-multimedia as Khem originally suggested. For the simple reason that I think x265 only builds (easily) for x86 based platforms. That being the case: we only add the packageconfig option to ffmpeg but don't enable by default in the PACKAGECONFIG default in the ffmpeg recipe. PACKAGECONFIG[x265] = "--enable-libx265,--disable-libx265,x265" And add the x265 recipe to meta-multimedia and limit to x86 at this time. Is this what I would set in the x265 recipe? COMPATIBLE_MACHINE_x86 = "(.*)" COMPATIBLE_MACHINE_x86-64 = "(.*)" >> Alex >> >> On Mon, 10 Feb 2020 at 07:16, Scott Branden via Openembedded-core <openembedded-core@lists.openembedded.org> wrote: >>> >>> >>> On 2020-02-09 3:35 p.m., Khem Raj wrote: >>>> On Sun, Feb 9, 2020 at 11:27 AM Scott Branden >>>> <scott.branden@broadcom.com> wrote: >>>>> >>>>> On 2020-02-08 11:18 a.m., Khem Raj wrote: >>>>>> On Fri, Feb 7, 2020 at 8:02 PM Scott Branden <scott.branden@broadcom.com> wrote: >>>>>>> Hi Khem, >>>>>>> >>>>>>> On 2020-02-07 5:12 p.m., Khem Raj wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Fri, Feb 7, 2020 at 4:01 PM Scott Branden via Openembedded-core <openembedded-core@lists.openembedded.org> wrote: >>>>>>>> Add x265 recipe from latest revision of stable branch. >>>>>>> I wonder if it belongs to core are there deps on it that we need in common metadata >>>>>>> >>>>>>> I simply followed where x264 recipe is located and placed x265 beside it. >>>>>>> Both are needed when enabled in ffmpeg. >>>>>>> >>>>>>> I don't know if that answers your question as to where they should be located. >>>>>> idea is to keep small and therefore we should assess the inclusions in core >>>>>> we have many packageconfigs which require packages from other layers >>>>>> so if ffmpeg needs it and is optional then it should be fine to keep >>>>>> it in meta-multimedia and packageconfig in ffmpeg disabled by default. >>>>> I don't see why x264 would be in core and x265 in meta-multimedia. >>>>> Both should be moved to meta-multimedia then? >>>>> >>>> I followed the thread a bit and I see there are followups where >>>> usecase for other recipes in core is now >>>> established, where this seemed a leaf package being added to oe-core, >>>> So perhaps it should be added >>>> to validation loops as well like x264. >>> I leave it to the powers that be to decide where to place this recipe. >>>>> I think you would also require a bbappend to fffmpeg recipe to add x264 >>>>> and x265 to ffmpeg packageconfig. >>>>> if that is the case, why not move ffmpeg to meta-multimedia as well? >>>>> >>>> You would not go down that line of thought since these packages are in >>>> the dependency chain for validating reference >>>> images in core along with they being used by other packages from other layers. >>>> >>>>>>>> Signed-off-by: Scott Branden <scott.branden@broadcom.com> >>>>>>>> --- >>>>>>>> meta/recipes-multimedia/x265/x265_git.bb | 20 ++++++++++++++++++++ >>>>>>>> 1 file changed, 20 insertions(+) >>>>>>>> create mode 100644 meta/recipes-multimedia/x265/x265_git.bb >>>>>>>> >>>>>>>> diff --git a/meta/recipes-multimedia/x265/x265_git.bb b/meta/recipes-multimedia/x265/x265_git.bb >>>>>>>> new file mode 100644 >>>>>>>> index 0000000000..796fbbc13a >>>>>>>> --- /dev/null >>>>>>>> +++ b/meta/recipes-multimedia/x265/x265_git.bb >>>>>>>> @@ -0,0 +1,20 @@ >>>>>>>> +SUMMARY = "H.265/HEVC video encoder" >>>>>>>> +DESCRIPTION = "A free software library and application for encoding video streams into the H.265/HEVC format." >>>>>>>> +HOMEPAGE = "http://www.videolan.org/developers/x265.html" >>>>>>>> + >>>>>>>> +LICENSE = "GPLv2" >>>>>>>> +LICENSE_FLAGS = "commercial" >>>>>>>> +LIC_FILES_CHKSUM = "file://../COPYING;md5=c9e0427bc58f129f99728c62d4ad4091" >>>>>>>> + >>>>>>>> +DEPENDS = "gnutls zlib libpcre" >>>>>>>> + >>>>>>>> +SRC_URI = "git://github.com/videolan/x265;branch=stable \ >>>>>>>> + " >>>>>>>> + >>>>>>>> +SRCREV = "4ef6b67fd46e1584e52a11a264812edcaef02526" >>>>>>>> + >>>>>>>> +S = "${WORKDIR}/git/source" >>>>>>>> + >>>>>>>> +inherit lib_package pkgconfig cmake >>>>>>>> + >>>>>>>> +AS[unexport] = "1" >>>>>>>> -- >>>>>>>> 2.17.1 >>>>>>>> >>>>>>>> -- >>>>>>>> _______________________________________________ >>>>>>>> Openembedded-core mailing list >>>>>>>> Openembedded-core@lists.openembedded.org >>>>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >>> -- >>> _______________________________________________ >>> Openembedded-core mailing list >>> Openembedded-core@lists.openembedded.org >>> http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-02-10 21:17 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-02-08 0:01 [PATCH v2 1/2] x265: add x265 recipe Scott Branden 2020-02-08 0:01 ` [PATCH v2 2/2] ffmpeg: add PACKAGECONFIG support for x265 Scott Branden 2020-02-08 1:12 ` [PATCH v2 1/2] x265: add x265 recipe Khem Raj 2020-02-08 4:02 ` Scott Branden 2020-02-08 19:18 ` Khem Raj 2020-02-09 19:27 ` Scott Branden 2020-02-09 23:35 ` Khem Raj 2020-02-10 6:15 ` Scott Branden 2020-02-10 11:42 ` Alexander Kanavin 2020-02-10 16:01 ` Khem Raj 2020-02-10 21:17 ` Scott Branden
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.