All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH u-boot-marvell 1/1] clk: armada-37xx-periph: fix DDR PHY clock divider values
Date: Wed, 15 Apr 2020 08:37:09 +0200	[thread overview]
Message-ID: <5625034c-f057-b8d3-2161-fdeda506138d@denx.de> (raw)
In-Reply-To: <20200414225918.12844-1-marek.behun@nic.cz>

On 15.04.20 00:59, Marek Beh?n wrote:
> Register value table for DDR PHY clock divider are wrong. They should be
> 0 or 1 for divide-by-2 or divide-by-4, respectively. Not 1 or 2. Current
> values do not make sense, since 2 cannot be achieved, because the
> register is only 1 bit long (mask is set to 1).
> 
> This fixes clk dump reporting DDR PHY clock rate differently from Linux.
> 
> Signed-off-by: Marek Beh?n <marek.behun@nic.cz>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   drivers/clk/mvebu/armada-37xx-periph.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mvebu/armada-37xx-periph.c
> index 068e48ea04..855f979b4f 100644
> --- a/drivers/clk/mvebu/armada-37xx-periph.c
> +++ b/drivers/clk/mvebu/armada-37xx-periph.c
> @@ -89,8 +89,8 @@ static const struct clk_div_table div_table1[] = {
>   };
>   
>   static const struct clk_div_table div_table2[] = {
> -	{ 2, 1 },
> -	{ 4, 2 },
> +	{ 2, 0 },
> +	{ 4, 1 },
>   	{ 0, 0 },
>   };
>   
> 


Viele Gr??e,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de

      reply	other threads:[~2020-04-15  6:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 22:59 [PATCH u-boot-marvell 1/1] clk: armada-37xx-periph: fix DDR PHY clock divider values Marek Behún
2020-04-15  6:37 ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5625034c-f057-b8d3-2161-fdeda506138d@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.