From: Simon Arlott <simon@fire.lp0.eu> To: Jonas Gorski <jogo@openwrt.org> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Ralf Baechle <ralf@linux-mips.org>, Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>, Marc Zyngier <marc.zyngier@arm.com>, Kevin Cernekee <cernekee@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Wim Van Sebroeck <wim@iguana.be>, Miguel Gaio <miguel.gaio@efixo.com>, Maxime Bizon <mbizon@freebox.fr>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, MIPS Mailing List <linux-mips@linux-mips.org>, linux-watchdog@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org> Subject: [PATCH (v2) 1/10] clocksource: Add brcm,bcm6345-timer device tree binding Date: Mon, 23 Nov 2015 18:55:38 +0000 [thread overview] Message-ID: <5653612A.4050309@simon.arlott.org.uk> (raw) In-Reply-To: <CAOiHx=k0Aa+qrBT1J7_cQaQRxndBmwsgSgi3x0eJOYTAy6Zq7Q@mail.gmail.com> Add device tree bindings for the BCM6345/BCM6318 timers. This is required for the BCM6345 watchdog which needs to respond to one of the timer interrupts. Signed-off-by: Simon Arlott <simon@fire.lp0.eu> --- On 23/11/15 15:33, Jonas Gorski wrote: > On Sat, Nov 21, 2015 at 8:02 PM, Simon Arlott <simon@fire.lp0.eu> wrote: >> +- compatible: should be "brcm,bcm<soc>-timer", "brcm,bcm6345-timer" > > Since bcm6318 uses a slightly different register layout than the > earlier SoCs, I'd argue that using bcm6345-timer as a compatible for > bcm6318 is wrong. I've split them out into two very similar bindings. Patches 1/4 and 2/4 are replaced with (v2) 1/10 and (v2) 2/10. .../bindings/timer/brcm,bcm6318-timer.txt | 44 ++++++++++++++++++++ .../bindings/timer/brcm,bcm6345-timer.txt | 47 ++++++++++++++++++++++ 2 files changed, 91 insertions(+) create mode 100644 Documentation/devicetree/bindings/timer/brcm,bcm6318-timer.txt create mode 100644 Documentation/devicetree/bindings/timer/brcm,bcm6345-timer.txt diff --git a/Documentation/devicetree/bindings/timer/brcm,bcm6318-timer.txt b/Documentation/devicetree/bindings/timer/brcm,bcm6318-timer.txt new file mode 100644 index 0000000..cf4be7e --- /dev/null +++ b/Documentation/devicetree/bindings/timer/brcm,bcm6318-timer.txt @@ -0,0 +1,44 @@ +Broadcom BCM6318 Timer + +This block is a timer that is connected to multiple interrupts on the main +interrupt controller and functions as a programmable interrupt controller for +timer events. There is a main timer interrupt for all timers. + +- 4 independent timers with their own interrupt, and own maskable level + interrupt bit in the main timer interrupt + +- 1 watchdog timer with an unmaskable level interrupt bit in the main timer + interrupt + +- Contains one enable/status word pair + +- No atomic set/clear operations + +Required properties: + +- compatible: should be "brcm,bcm<soc>-timer", "brcm,bcm6318-timer" +- reg: specifies the base physical address and size of the registers, excluding + the watchdog registers +- interrupt-controller: identifies the node as an interrupt controller +- #interrupt-cells: specifies the number of cells needed to encode an interrupt + source, should be 1. +- interrupt-parent: specifies the phandle to the parent interrupt controller(s) + this one is cascaded from +- interrupts: specifies the interrupt line(s) in the interrupt-parent controller + node for the main timer interrupt, followed by the individual timer + interrupts; valid values depend on the type of parent interrupt controller +- clocks: phandle of timer reference clock (periph) + +Example: + +timer: timer@10000040 { + compatible = "brcm,bcm63148-timer", "brcm,bcm6318-timer"; + reg = <0x10000040 0x28>; + + interrupt-controller; + #interrupt-cells = <1>; + + interrupt-parent = <&periph_intc>; + interrupts = <31>, <0>, <1>, <2>, <3>; + clock = <&periph_osc>; +}; diff --git a/Documentation/devicetree/bindings/timer/brcm,bcm6345-timer.txt b/Documentation/devicetree/bindings/timer/brcm,bcm6345-timer.txt new file mode 100644 index 0000000..03250dd --- /dev/null +++ b/Documentation/devicetree/bindings/timer/brcm,bcm6345-timer.txt @@ -0,0 +1,47 @@ +Broadcom BCM6345 Timer + +This block is a timer that is connected to one interrupt on the main interrupt +controller and functions as a programmable interrupt controller for timer +events. + +- 3 independent timers with their own maskable level interrupt bit (but not + per CPU because there is only one parent interrupt and the timers share it) + +- 1 watchdog timer with an unmaskable level interrupt + +- Contains one enable/status word pair + +- No atomic set/clear operations + +The lack of per CPU ability of timers makes them unusable as a set of +clockevent devices, otherwise they could be attached to the remaining +interrupts. + +Required properties: + +- compatible: should be "brcm,bcm<soc>-timer", "brcm,bcm6345-timer" +- reg: specifies the base physical address and size of the registers, excluding + the watchdog registers +- interrupt-controller: identifies the node as an interrupt controller +- #interrupt-cells: specifies the number of cells needed to encode an interrupt + source, should be 1. +- interrupt-parent: specifies the phandle to the parent interrupt controller(s) + this one is cascaded from +- interrupts: specifies the interrupt line(s) in the interrupt-parent controller + node for the timer interrupt; valid values depend on the type of parent + interrupt controller +- clocks: phandle of timer reference clock (periph) + +Example: + +timer: timer@10000080 { + compatible = "brcm,bcm63168-timer", "brcm,bcm6345-timer"; + reg = <0x10000080 0x1c>; + + interrupt-controller; + #interrupt-cells = <1>; + + interrupt-parent = <&periph_intc>; + interrupts = <0>; + clock·=·<&periph_osc>; +}; -- 2.1.4 -- Simon Arlott
WARNING: multiple messages have this Message-ID (diff)
From: Simon Arlott <simon-A6De1vDTPLDsq35pWSNszA@public.gmane.org> To: Jonas Gorski <jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org> Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>, Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>, Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>, Kevin Cernekee <cernekee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>, Miguel Gaio <miguel.gaio-HH44TBFINEIAvxtiuMwx3w@public.gmane.org>, Maxime Bizon <mbizon-MmRyKUhfbQ9GWvitb5QawA@public.gmane.org>, Linux Kernel Mailing List <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, MIPS Mailing List <linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>, Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Subject: [PATCH (v2) 1/10] clocksource: Add brcm,bcm6345-timer device tree binding Date: Mon, 23 Nov 2015 18:55:38 +0000 [thread overview] Message-ID: <5653612A.4050309@simon.arlott.org.uk> (raw) In-Reply-To: <CAOiHx=k0Aa+qrBT1J7_cQaQRxndBmwsgSgi3x0eJOYTAy6Zq7Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> Add device tree bindings for the BCM6345/BCM6318 timers. This is required for the BCM6345 watchdog which needs to respond to one of the timer interrupts. Signed-off-by: Simon Arlott <simon-A6De1vDTPLDsq35pWSNszA@public.gmane.org> --- On 23/11/15 15:33, Jonas Gorski wrote: > On Sat, Nov 21, 2015 at 8:02 PM, Simon Arlott <simon-A6De1vDTPLDsq35pWSNszA@public.gmane.org> wrote: >> +- compatible: should be "brcm,bcm<soc>-timer", "brcm,bcm6345-timer" > > Since bcm6318 uses a slightly different register layout than the > earlier SoCs, I'd argue that using bcm6345-timer as a compatible for > bcm6318 is wrong. I've split them out into two very similar bindings. Patches 1/4 and 2/4 are replaced with (v2) 1/10 and (v2) 2/10. .../bindings/timer/brcm,bcm6318-timer.txt | 44 ++++++++++++++++++++ .../bindings/timer/brcm,bcm6345-timer.txt | 47 ++++++++++++++++++++++ 2 files changed, 91 insertions(+) create mode 100644 Documentation/devicetree/bindings/timer/brcm,bcm6318-timer.txt create mode 100644 Documentation/devicetree/bindings/timer/brcm,bcm6345-timer.txt diff --git a/Documentation/devicetree/bindings/timer/brcm,bcm6318-timer.txt b/Documentation/devicetree/bindings/timer/brcm,bcm6318-timer.txt new file mode 100644 index 0000000..cf4be7e --- /dev/null +++ b/Documentation/devicetree/bindings/timer/brcm,bcm6318-timer.txt @@ -0,0 +1,44 @@ +Broadcom BCM6318 Timer + +This block is a timer that is connected to multiple interrupts on the main +interrupt controller and functions as a programmable interrupt controller for +timer events. There is a main timer interrupt for all timers. + +- 4 independent timers with their own interrupt, and own maskable level + interrupt bit in the main timer interrupt + +- 1 watchdog timer with an unmaskable level interrupt bit in the main timer + interrupt + +- Contains one enable/status word pair + +- No atomic set/clear operations + +Required properties: + +- compatible: should be "brcm,bcm<soc>-timer", "brcm,bcm6318-timer" +- reg: specifies the base physical address and size of the registers, excluding + the watchdog registers +- interrupt-controller: identifies the node as an interrupt controller +- #interrupt-cells: specifies the number of cells needed to encode an interrupt + source, should be 1. +- interrupt-parent: specifies the phandle to the parent interrupt controller(s) + this one is cascaded from +- interrupts: specifies the interrupt line(s) in the interrupt-parent controller + node for the main timer interrupt, followed by the individual timer + interrupts; valid values depend on the type of parent interrupt controller +- clocks: phandle of timer reference clock (periph) + +Example: + +timer: timer@10000040 { + compatible = "brcm,bcm63148-timer", "brcm,bcm6318-timer"; + reg = <0x10000040 0x28>; + + interrupt-controller; + #interrupt-cells = <1>; + + interrupt-parent = <&periph_intc>; + interrupts = <31>, <0>, <1>, <2>, <3>; + clock = <&periph_osc>; +}; diff --git a/Documentation/devicetree/bindings/timer/brcm,bcm6345-timer.txt b/Documentation/devicetree/bindings/timer/brcm,bcm6345-timer.txt new file mode 100644 index 0000000..03250dd --- /dev/null +++ b/Documentation/devicetree/bindings/timer/brcm,bcm6345-timer.txt @@ -0,0 +1,47 @@ +Broadcom BCM6345 Timer + +This block is a timer that is connected to one interrupt on the main interrupt +controller and functions as a programmable interrupt controller for timer +events. + +- 3 independent timers with their own maskable level interrupt bit (but not + per CPU because there is only one parent interrupt and the timers share it) + +- 1 watchdog timer with an unmaskable level interrupt + +- Contains one enable/status word pair + +- No atomic set/clear operations + +The lack of per CPU ability of timers makes them unusable as a set of +clockevent devices, otherwise they could be attached to the remaining +interrupts. + +Required properties: + +- compatible: should be "brcm,bcm<soc>-timer", "brcm,bcm6345-timer" +- reg: specifies the base physical address and size of the registers, excluding + the watchdog registers +- interrupt-controller: identifies the node as an interrupt controller +- #interrupt-cells: specifies the number of cells needed to encode an interrupt + source, should be 1. +- interrupt-parent: specifies the phandle to the parent interrupt controller(s) + this one is cascaded from +- interrupts: specifies the interrupt line(s) in the interrupt-parent controller + node for the timer interrupt; valid values depend on the type of parent + interrupt controller +- clocks: phandle of timer reference clock (periph) + +Example: + +timer: timer@10000080 { + compatible = "brcm,bcm63168-timer", "brcm,bcm6345-timer"; + reg = <0x10000080 0x1c>; + + interrupt-controller; + #interrupt-cells = <1>; + + interrupt-parent = <&periph_intc>; + interrupts = <0>; + clock·=·<&periph_osc>; +}; -- 2.1.4 -- Simon Arlott -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-23 18:55 UTC|newest] Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-21 19:02 [PATCH 1/4] clocksource: Add brcm,bcm6345-timer device tree binding Simon Arlott 2015-11-21 19:02 ` Simon Arlott 2015-11-21 19:03 ` [PATCH 2/4] MIPS: bmips: Add bcm6345-l2-timer interrupt controller Simon Arlott 2015-11-21 19:04 ` [PATCH 3/4] watchdog: Add brcm,bcm6345-wdt device tree binding Simon Arlott 2015-11-22 22:13 ` Rob Herring 2015-11-22 22:13 ` Rob Herring 2015-11-21 19:05 ` [PATCH 4/4] MIPS: bmips: Convert bcm63xx_wdt to use WATCHDOG_CORE Simon Arlott 2015-11-21 19:05 ` Simon Arlott 2015-11-21 21:32 ` Guenter Roeck 2015-11-21 21:44 ` Simon Arlott 2015-11-21 21:44 ` Simon Arlott 2015-11-22 2:32 ` Guenter Roeck 2015-11-22 14:02 ` [PATCH 4/10] (Was: [PATCH 4/4]) " Simon Arlott 2015-11-22 14:05 ` [PATCH 4/10] watchdog: bcm63xx_wdt: Handle hardware interrupt and remove software timer Simon Arlott 2015-11-24 18:21 ` Guenter Roeck 2015-11-24 18:21 ` Guenter Roeck 2015-11-24 18:21 ` Guenter Roeck 2015-11-25 20:14 ` Jonas Gorski 2015-11-25 20:14 ` Jonas Gorski 2015-11-25 20:28 ` Simon Arlott 2015-11-25 20:28 ` Simon Arlott 2015-11-25 22:33 ` [PATCH (v2) " Simon Arlott 2015-11-25 22:33 ` Simon Arlott 2015-11-22 14:06 ` [PATCH 5/10] watchdog: bcm63xx_wdt: Use WATCHDOG_CORE Simon Arlott 2015-11-22 14:06 ` Simon Arlott 2015-11-25 2:44 ` Guenter Roeck 2015-11-25 2:44 ` Guenter Roeck 2015-11-25 13:02 ` Simon Arlott 2015-11-25 14:10 ` Guenter Roeck 2015-11-25 14:10 ` Guenter Roeck 2015-11-25 19:43 ` Simon Arlott 2015-11-25 19:43 ` Simon Arlott 2015-11-25 22:40 ` [PATCH (v3) 5/11] " Simon Arlott 2015-11-25 22:40 ` Simon Arlott 2015-11-22 14:07 ` [PATCH 6/10] watchdog: bcm63xx_wdt: Obtain watchdog clock HZ from "periph" clk Simon Arlott 2015-11-22 14:07 ` Simon Arlott 2015-11-23 15:02 ` Jonas Gorski 2015-11-23 15:02 ` Jonas Gorski 2015-11-23 18:19 ` Florian Fainelli 2015-11-23 18:19 ` Florian Fainelli 2015-11-23 19:00 ` Simon Arlott 2015-11-23 19:00 ` Simon Arlott 2015-11-24 22:12 ` [PATCH (v2) " Simon Arlott 2015-11-24 22:42 ` Florian Fainelli 2015-11-24 22:42 ` Florian Fainelli 2015-11-25 22:47 ` [PATCH (v3) 6/11] " Simon Arlott 2015-11-25 22:47 ` Simon Arlott 2015-11-22 14:09 ` [PATCH 7/10] watchdog: bcm63xx_wdt: Add get_timeleft function Simon Arlott 2015-11-22 14:09 ` Simon Arlott 2015-11-24 22:15 ` [PATCH (v2) " Simon Arlott 2015-11-24 22:15 ` Simon Arlott 2015-11-24 22:43 ` Florian Fainelli 2015-11-24 22:43 ` Florian Fainelli 2015-11-25 2:51 ` Guenter Roeck 2015-11-25 2:51 ` Guenter Roeck 2015-11-25 8:17 ` Simon Arlott 2015-11-25 8:17 ` Simon Arlott 2015-11-25 22:50 ` [PATCH (v3) 7/11] " Simon Arlott 2015-11-25 22:50 ` Simon Arlott 2015-11-25 22:54 ` [PATCH (v4) " Simon Arlott 2015-11-25 22:54 ` Simon Arlott 2015-11-25 22:57 ` [PATCH (v4) 8/11] watchdog: bcm63xx_wdt: Warn if the watchdog is currently running Simon Arlott 2015-11-25 22:57 ` Simon Arlott 2015-11-22 14:11 ` [PATCH 8/10] watchdog: bcm63xx_wdt: Remove dependency on mach-bcm63xx functions/defines Simon Arlott 2015-11-22 14:11 ` Simon Arlott 2015-11-22 14:12 ` [PATCH 9/10] watchdog: bcm63xx_wdt: Use bcm63xx_timer interrupt directly Simon Arlott 2015-11-22 14:12 ` Simon Arlott 2015-11-25 23:03 ` [PATCH (v2) 10/11] " Simon Arlott 2015-11-25 23:03 ` Simon Arlott 2015-11-22 14:14 ` [PATCH 10/10] watchdog: bcm63xx_wdt: Use brcm,bcm6345-wdt device tree binding Simon Arlott 2015-11-22 14:14 ` Simon Arlott 2015-11-25 23:09 ` [PATCH (v2) 11/11] " Simon Arlott 2015-11-25 23:09 ` Simon Arlott 2015-11-22 22:12 ` [PATCH 1/4] clocksource: Add brcm,bcm6345-timer " Rob Herring 2015-11-23 15:33 ` Jonas Gorski 2015-11-23 18:55 ` Simon Arlott [this message] 2015-11-23 18:55 ` [PATCH (v2) 1/10] " Simon Arlott 2015-11-23 18:57 ` [PATCH (v2) 2/10] MIPS: bmips: Add bcm6345-l2-timer interrupt controller Simon Arlott 2015-11-23 18:57 ` Simon Arlott 2015-11-24 22:10 ` [PATCH (v3) " Simon Arlott 2015-11-24 22:10 ` Simon Arlott 2015-11-24 22:36 ` Florian Fainelli 2015-11-24 22:36 ` Florian Fainelli 2015-11-26 22:32 ` [PATCH (v4) 2/11] " Simon Arlott 2015-11-27 8:37 ` Thomas Gleixner 2015-11-27 8:37 ` Thomas Gleixner 2015-11-28 12:26 ` [PATCH (v5) 3/11] " Simon Arlott 2015-11-28 12:26 ` Simon Arlott 2015-12-01 0:22 ` Guenter Roeck 2015-12-01 0:22 ` Guenter Roeck 2016-05-09 12:01 ` Álvaro Fernández Rojas 2016-05-09 13:06 ` Guenter Roeck 2016-05-09 13:06 ` Guenter Roeck 2016-05-11 6:40 ` [PATCH 2/4] " Álvaro Fernández Rojas 2015-11-25 3:05 ` [PATCH (v2) 1/10] clocksource: Add brcm,bcm6345-timer device tree binding Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5653612A.4050309@simon.arlott.org.uk \ --to=simon@fire.lp0.eu \ --cc=cernekee@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=galak@codeaurora.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=jason@lakedaemon.net \ --cc=jogo@openwrt.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@linux-mips.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=mbizon@freebox.fr \ --cc=miguel.gaio@efixo.com \ --cc=pawel.moll@arm.com \ --cc=ralf@linux-mips.org \ --cc=robh+dt@kernel.org \ --cc=tglx@linutronix.de \ --cc=wim@iguana.be \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.