* [PATCH v2 0/2] usb: renesas_usbhs: More compat strings @ 2015-12-10 5:40 ` Simon Horman 0 siblings, 0 replies; 13+ messages in thread From: Simon Horman @ 2015-12-10 5:40 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Kuninori Morimoto, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh, Simon Horman Hi, this short series adds generic, and soc-specific r8a7792 and r8a7793 compat strings to the Renesas USBHS driver. The intention is to provide a complete set of compat strings for known R-Car SoCs. Changes since v1: * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than a single compatibility string for all of R-Car. *** BLURB HERE *** Simon Horman (2): usb: renesas_usbhs: add fallback compatibility strings usb: renesas_usbhs: add device tree support for r8a779[23] .../devicetree/bindings/usb/renesas_usbhs.txt | 20 +++++++++++++++----- drivers/usb/renesas_usbhs/common.c | 9 +++++++++ 2 files changed, 24 insertions(+), 5 deletions(-) -- 2.1.4 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 0/2] usb: renesas_usbhs: More compat strings @ 2015-12-10 5:40 ` Simon Horman 0 siblings, 0 replies; 13+ messages in thread From: Simon Horman @ 2015-12-10 5:40 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Kuninori Morimoto, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh, Simon Horman Hi, this short series adds generic, and soc-specific r8a7792 and r8a7793 compat strings to the Renesas USBHS driver. The intention is to provide a complete set of compat strings for known R-Car SoCs. Changes since v1: * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than a single compatibility string for all of R-Car. *** BLURB HERE *** Simon Horman (2): usb: renesas_usbhs: add fallback compatibility strings usb: renesas_usbhs: add device tree support for r8a779[23] .../devicetree/bindings/usb/renesas_usbhs.txt | 20 +++++++++++++++----- drivers/usb/renesas_usbhs/common.c | 9 +++++++++ 2 files changed, 24 insertions(+), 5 deletions(-) -- 2.1.4 ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings 2015-12-10 5:40 ` Simon Horman @ 2015-12-10 5:40 ` Simon Horman -1 siblings, 0 replies; 13+ messages in thread From: Simon Horman @ 2015-12-10 5:40 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Kuninori Morimoto, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh, Simon Horman Add fallback compatibility strings for R-Car Gen2 and Gen3. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Also add SoC names. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- v2 * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than a single compatibility string for all of R-Car. --- .../devicetree/bindings/usb/renesas_usbhs.txt | 18 +++++++++++++----- drivers/usb/renesas_usbhs/common.c | 9 +++++++++ 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt index 7d48f63db44e..b959059826cd 100644 --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt @@ -2,10 +2,18 @@ Renesas Electronics USBHS driver Required properties: - compatible: Must contain one of the following: - - "renesas,usbhs-r8a7790" - - "renesas,usbhs-r8a7791" - - "renesas,usbhs-r8a7794" - - "renesas,usbhs-r8a7795" + + - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device + - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device + - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device + - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device + - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatibile device + - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatibile device + + When compatible with the generic version, nodes must list the + SoC-specific version corresponding to the platform first followed + by the generic version. + - reg: Base address and length of the register for the USBHS - interrupts: Interrupt specifier for the USBHS - clocks: A list of phandle + clock specifier pairs @@ -22,7 +30,7 @@ Optional properties: Example: usbhs: usb@e6590000 { - compatible = "renesas,usbhs-r8a7790"; + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; reg = <0 0xe6590000 0 0x100>; interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp7_clks R8A7790_CLK_HSUSB>; diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c index d82fa36c3465..db9a17bd8997 100644 --- a/drivers/usb/renesas_usbhs/common.c +++ b/drivers/usb/renesas_usbhs/common.c @@ -481,6 +481,15 @@ static const struct of_device_id usbhs_of_match[] = { .compatible = "renesas,usbhs-r8a7795", .data = (void *)USBHS_TYPE_RCAR_GEN2, }, + { + .compatible = "renesas,rcar-gen2-usbhs", + .data = (void *)USBHS_TYPE_RCAR_GEN2, + }, + { + /* Gen3 is compatible with Gen2 */ + .compatible = "renesas,rcar-gen3-usbhs", + .data = (void *)USBHS_TYPE_RCAR_GEN2, + }, { }, }; MODULE_DEVICE_TABLE(of, usbhs_of_match); -- 2.1.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings @ 2015-12-10 5:40 ` Simon Horman 0 siblings, 0 replies; 13+ messages in thread From: Simon Horman @ 2015-12-10 5:40 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Kuninori Morimoto, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh, Simon Horman Add fallback compatibility strings for R-Car Gen2 and Gen3. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Also add SoC names. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- v2 * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than a single compatibility string for all of R-Car. --- .../devicetree/bindings/usb/renesas_usbhs.txt | 18 +++++++++++++----- drivers/usb/renesas_usbhs/common.c | 9 +++++++++ 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt index 7d48f63db44e..b959059826cd 100644 --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt @@ -2,10 +2,18 @@ Renesas Electronics USBHS driver Required properties: - compatible: Must contain one of the following: - - "renesas,usbhs-r8a7790" - - "renesas,usbhs-r8a7791" - - "renesas,usbhs-r8a7794" - - "renesas,usbhs-r8a7795" + + - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device + - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device + - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device + - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device + - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatibile device + - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatibile device + + When compatible with the generic version, nodes must list the + SoC-specific version corresponding to the platform first followed + by the generic version. + - reg: Base address and length of the register for the USBHS - interrupts: Interrupt specifier for the USBHS - clocks: A list of phandle + clock specifier pairs @@ -22,7 +30,7 @@ Optional properties: Example: usbhs: usb@e6590000 { - compatible = "renesas,usbhs-r8a7790"; + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; reg = <0 0xe6590000 0 0x100>; interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp7_clks R8A7790_CLK_HSUSB>; diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c index d82fa36c3465..db9a17bd8997 100644 --- a/drivers/usb/renesas_usbhs/common.c +++ b/drivers/usb/renesas_usbhs/common.c @@ -481,6 +481,15 @@ static const struct of_device_id usbhs_of_match[] = { .compatible = "renesas,usbhs-r8a7795", .data = (void *)USBHS_TYPE_RCAR_GEN2, }, + { + .compatible = "renesas,rcar-gen2-usbhs", + .data = (void *)USBHS_TYPE_RCAR_GEN2, + }, + { + /* Gen3 is compatible with Gen2 */ + .compatible = "renesas,rcar-gen3-usbhs", + .data = (void *)USBHS_TYPE_RCAR_GEN2, + }, { }, }; MODULE_DEVICE_TABLE(of, usbhs_of_match); -- 2.1.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings 2015-12-10 5:40 ` Simon Horman (?) @ 2015-12-10 7:28 ` Kuninori Morimoto 2015-12-11 1:09 ` Simon Horman -1 siblings, 1 reply; 13+ messages in thread From: Kuninori Morimoto @ 2015-12-10 7:28 UTC (permalink / raw) To: Simon Horman Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh Hi Simon Thank you for your patch > Add fallback compatibility strings for R-Car Gen2 and Gen3. > This is in keeping with the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Also add SoC names. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- (snip) > Required properties: > - compatible: Must contain one of the following: > - - "renesas,usbhs-r8a7790" > - - "renesas,usbhs-r8a7791" > - - "renesas,usbhs-r8a7794" > - - "renesas,usbhs-r8a7795" > + > + - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device > + - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device > + - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device > + - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device > + - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatibile device > + - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatibile device > + > + When compatible with the generic version, nodes must list the > + SoC-specific version corresponding to the platform first followed > + by the generic version. I think these can be separated ? 1. document update for "renesas,usbhs-r8a77xx" 2. add new "rcar-genX" (this patch) > Example: > usbhs: usb@e6590000 { > - compatible = "renesas,usbhs-r8a7790"; > + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; I think you want - compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-gen2-usbhs"; ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings 2015-12-10 7:28 ` Kuninori Morimoto @ 2015-12-11 1:09 ` Simon Horman 0 siblings, 0 replies; 13+ messages in thread From: Simon Horman @ 2015-12-11 1:09 UTC (permalink / raw) To: Kuninori Morimoto Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh On Thu, Dec 10, 2015 at 07:28:06AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > Thank you for your patch > > > Add fallback compatibility strings for R-Car Gen2 and Gen3. > > This is in keeping with the fallback scheme being adopted wherever > > appropriate for drivers for Renesas SoCs. > > > > Also add SoC names. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > (snip) > > Required properties: > > - compatible: Must contain one of the following: > > - - "renesas,usbhs-r8a7790" > > - - "renesas,usbhs-r8a7791" > > - - "renesas,usbhs-r8a7794" > > - - "renesas,usbhs-r8a7795" > > + > > + - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device > > + - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device > > + - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device > > + - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device > > + - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatibile device > > + - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatibile device > > + > > + When compatible with the generic version, nodes must list the > > + SoC-specific version corresponding to the platform first followed > > + by the generic version. > > I think these can be separated ? > > 1. document update for "renesas,usbhs-r8a77xx" > 2. add new "rcar-genX" (this patch) Sure, will do. > > Example: > > usbhs: usb@e6590000 { > > - compatible = "renesas,usbhs-r8a7790"; > > + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; > > I think you want > > - compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; > + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-gen2-usbhs"; Thanks, I will fix that. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings @ 2015-12-11 1:09 ` Simon Horman 0 siblings, 0 replies; 13+ messages in thread From: Simon Horman @ 2015-12-11 1:09 UTC (permalink / raw) To: Kuninori Morimoto Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh On Thu, Dec 10, 2015 at 07:28:06AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > Thank you for your patch > > > Add fallback compatibility strings for R-Car Gen2 and Gen3. > > This is in keeping with the fallback scheme being adopted wherever > > appropriate for drivers for Renesas SoCs. > > > > Also add SoC names. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > (snip) > > Required properties: > > - compatible: Must contain one of the following: > > - - "renesas,usbhs-r8a7790" > > - - "renesas,usbhs-r8a7791" > > - - "renesas,usbhs-r8a7794" > > - - "renesas,usbhs-r8a7795" > > + > > + - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device > > + - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device > > + - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device > > + - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device > > + - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatibile device > > + - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatibile device > > + > > + When compatible with the generic version, nodes must list the > > + SoC-specific version corresponding to the platform first followed > > + by the generic version. > > I think these can be separated ? > > 1. document update for "renesas,usbhs-r8a77xx" > 2. add new "rcar-genX" (this patch) Sure, will do. > > Example: > > usbhs: usb@e6590000 { > > - compatible = "renesas,usbhs-r8a7790"; > > + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; > > I think you want > > - compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; > + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-gen2-usbhs"; Thanks, I will fix that. ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <1449726033-17117-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* Re: [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings [not found] ` <1449726033-17117-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> @ 2015-12-10 11:59 ` Sergei Shtylyov 0 siblings, 0 replies; 13+ messages in thread From: Sergei Shtylyov @ 2015-12-10 11:59 UTC (permalink / raw) To: Simon Horman, Greg Kroah-Hartman Cc: Kuninori Morimoto, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA Hello. On 12/10/2015 8:40 AM, Simon Horman wrote: > Add fallback compatibility strings for R-Car Gen2 and Gen3. > This is in keeping with the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Also add SoC names. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > v2 > * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than > a single compatibility string for all of R-Car. > --- > .../devicetree/bindings/usb/renesas_usbhs.txt | 18 +++++++++++++----- > drivers/usb/renesas_usbhs/common.c | 9 +++++++++ > 2 files changed, 22 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > index 7d48f63db44e..b959059826cd 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt [...] > @@ -22,7 +30,7 @@ Optional properties: > > Example: > usbhs: usb@e6590000 { > - compatible = "renesas,usbhs-r8a7790"; > + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; You forgot "gen2-" here. [...] MBR, Sergei ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings @ 2015-12-10 11:59 ` Sergei Shtylyov 0 siblings, 0 replies; 13+ messages in thread From: Sergei Shtylyov @ 2015-12-10 11:59 UTC (permalink / raw) To: Simon Horman, Greg Kroah-Hartman Cc: Kuninori Morimoto, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA Hello. On 12/10/2015 8:40 AM, Simon Horman wrote: > Add fallback compatibility strings for R-Car Gen2 and Gen3. > This is in keeping with the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Also add SoC names. > > Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> > --- > v2 > * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than > a single compatibility string for all of R-Car. > --- > .../devicetree/bindings/usb/renesas_usbhs.txt | 18 +++++++++++++----- > drivers/usb/renesas_usbhs/common.c | 9 +++++++++ > 2 files changed, 22 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > index 7d48f63db44e..b959059826cd 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt [...] > @@ -22,7 +30,7 @@ Optional properties: > > Example: > usbhs: usb@e6590000 { > - compatible = "renesas,usbhs-r8a7790"; > + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; You forgot "gen2-" here. [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <1449726033-17117-1-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* [PATCH v2 2/2] usb: renesas_usbhs: add device tree support for r8a779[23] [not found] ` <1449726033-17117-1-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> @ 2015-12-10 5:40 ` Simon Horman 0 siblings, 0 replies; 13+ messages in thread From: Simon Horman @ 2015-12-10 5:40 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Kuninori Morimoto, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA, Simon Horman Simply document new compatibility string. As a previous patch adds a generic R-Car Gen2 compatibility string there appears to be no need for a driver updates. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt index b959059826cd..efb3199a2a80 100644 --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt @@ -5,6 +5,8 @@ Required properties: - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device + - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device + - "renesas,usbhs-r8a7793" for r8a7793 (R-Car M2-N) compatible device - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatibile device -- 2.1.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH v2 2/2] usb: renesas_usbhs: add device tree support for r8a779[23] @ 2015-12-10 5:40 ` Simon Horman 0 siblings, 0 replies; 13+ messages in thread From: Simon Horman @ 2015-12-10 5:40 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Kuninori Morimoto, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA, Simon Horman Simply document new compatibility string. As a previous patch adds a generic R-Car Gen2 compatibility string there appears to be no need for a driver updates. Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt index b959059826cd..efb3199a2a80 100644 --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt @@ -5,6 +5,8 @@ Required properties: - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device + - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device + - "renesas,usbhs-r8a7793" for r8a7793 (R-Car M2-N) compatible device - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatibile device -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <1449726033-17117-3-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* Re: [PATCH v2 2/2] usb: renesas_usbhs: add device tree support for r8a779[23] [not found] ` <1449726033-17117-3-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> @ 2015-12-10 9:33 ` Geert Uytterhoeven 0 siblings, 0 replies; 13+ messages in thread From: Geert Uytterhoeven @ 2015-12-10 9:33 UTC (permalink / raw) To: Simon Horman Cc: Greg Kroah-Hartman, Kuninori Morimoto, Yoshihiro Shimoda, Magnus Damm, USB list, devicetree-u79uwXL29TY76Z2rM5mHXA, Linux-sh list Hi Simon, On Thu, Dec 10, 2015 at 6:40 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > Simply document new compatibility string. > As a previous patch adds a generic R-Car Gen2 compatibility string > there appears to be no need for a driver updates. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > Acked-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > index b959059826cd..efb3199a2a80 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > @@ -5,6 +5,8 @@ Required properties: > > - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device > - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device > + - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device > + - "renesas,usbhs-r8a7793" for r8a7793 (R-Car M2-N) compatible device > - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device > - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device > - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatibile device I see a possible issue here: Old r8a7791 dtsi just has "renesas,usbhs-r8a7791", so it works with the current driver, as the driver matches against "renesas,usbhs-r8a7791". Existing (out-of-tree) r8a7792 dtsi may have followed existing practices, and just have "renesas,usbhs-r8a7792". This won't work with the new driver, as the driver doesn't match again "renesas,usbhs-r8a7792". The same applies to r8a7793. Do we care about this - in upstream? Probably not. - in the BSP? It seems to have r8a7790/r8a7791 usbhs only, though. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/2] usb: renesas_usbhs: add device tree support for r8a779[23] @ 2015-12-10 9:33 ` Geert Uytterhoeven 0 siblings, 0 replies; 13+ messages in thread From: Geert Uytterhoeven @ 2015-12-10 9:33 UTC (permalink / raw) To: Simon Horman Cc: Greg Kroah-Hartman, Kuninori Morimoto, Yoshihiro Shimoda, Magnus Damm, USB list, devicetree-u79uwXL29TY76Z2rM5mHXA, Linux-sh list Hi Simon, On Thu, Dec 10, 2015 at 6:40 AM, Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> wrote: > Simply document new compatibility string. > As a previous patch adds a generic R-Car Gen2 compatibility string > there appears to be no need for a driver updates. > > Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> > Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > --- > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > index b959059826cd..efb3199a2a80 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > @@ -5,6 +5,8 @@ Required properties: > > - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device > - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device > + - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device > + - "renesas,usbhs-r8a7793" for r8a7793 (R-Car M2-N) compatible device > - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device > - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device > - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatibile device I see a possible issue here: Old r8a7791 dtsi just has "renesas,usbhs-r8a7791", so it works with the current driver, as the driver matches against "renesas,usbhs-r8a7791". Existing (out-of-tree) r8a7792 dtsi may have followed existing practices, and just have "renesas,usbhs-r8a7792". This won't work with the new driver, as the driver doesn't match again "renesas,usbhs-r8a7792". The same applies to r8a7793. Do we care about this - in upstream? Probably not. - in the BSP? It seems to have r8a7790/r8a7791 usbhs only, though. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2015-12-11 1:09 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-10 5:40 [PATCH v2 0/2] usb: renesas_usbhs: More compat strings Simon Horman
2015-12-10 5:40 ` Simon Horman
2015-12-10 5:40 ` [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings Simon Horman
2015-12-10 5:40 ` Simon Horman
2015-12-10 7:28 ` Kuninori Morimoto
2015-12-11 1:09 ` Simon Horman
2015-12-11 1:09 ` Simon Horman
[not found] ` <1449726033-17117-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-12-10 11:59 ` Sergei Shtylyov
2015-12-10 11:59 ` Sergei Shtylyov
[not found] ` <1449726033-17117-1-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-12-10 5:40 ` [PATCH v2 2/2] usb: renesas_usbhs: add device tree support for r8a779[23] Simon Horman
2015-12-10 5:40 ` Simon Horman
[not found] ` <1449726033-17117-3-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-12-10 9:33 ` Geert Uytterhoeven
2015-12-10 9:33 ` Geert Uytterhoeven
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.