From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
tglx@linutronix.de, jason@lakedaemon.net, rjw@rjwysocki.net
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
hanjun.guo@linaro.org, tomasz.nowicki@linaro.org,
graeme.gregory@linaro.org, dhdang@apm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v6 4/4] gicv2m: acpi: Introducing GICv2m ACPI support
Date: Thu, 10 Dec 2015 10:11:01 -0600 [thread overview]
Message-ID: <5669A415.60300@amd.com> (raw)
In-Reply-To: <56694272.5050706@arm.com>
On 12/10/2015 3:14 AM, Marc Zyngier wrote:
>> +int __init gicv2m_init(struct fwnode_handle *parent_handle,
>> >+ struct irq_domain *parent)
>> >+{
>> >+ int ret = gicv2m_of_init(parent_handle, parent);
>> >+
>> >+ if (ret)
>> >+ ret = gicv2m_acpi_init(parent);
>> >+ return ret;
> This should really read:
>
> if (is_of_node(parent_handle))
> return gicv2m_of_init(parent_handle, parent);
>
> return gicv2m_acpi_init(parent);
>
> and you can loose the test for NULL in gicv2m_of_init().
>
Right... Your style of returning which is cleaner ;)
I'll update in V7 and send it out shortly.
Thanks,
Suravee
WARNING: multiple messages have this Message-ID (diff)
From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
To: Marc Zyngier <marc.zyngier@arm.com>, <tglx@linutronix.de>,
<jason@lakedaemon.net>, <rjw@rjwysocki.net>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
<hanjun.guo@linaro.org>, <tomasz.nowicki@linaro.org>,
<graeme.gregory@linaro.org>, <dhdang@apm.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v6 4/4] gicv2m: acpi: Introducing GICv2m ACPI support
Date: Thu, 10 Dec 2015 10:11:01 -0600 [thread overview]
Message-ID: <5669A415.60300@amd.com> (raw)
In-Reply-To: <56694272.5050706@arm.com>
On 12/10/2015 3:14 AM, Marc Zyngier wrote:
>> +int __init gicv2m_init(struct fwnode_handle *parent_handle,
>> >+ struct irq_domain *parent)
>> >+{
>> >+ int ret = gicv2m_of_init(parent_handle, parent);
>> >+
>> >+ if (ret)
>> >+ ret = gicv2m_acpi_init(parent);
>> >+ return ret;
> This should really read:
>
> if (is_of_node(parent_handle))
> return gicv2m_of_init(parent_handle, parent);
>
> return gicv2m_acpi_init(parent);
>
> and you can loose the test for NULL in gicv2m_of_init().
>
Right... Your style of returning which is cleaner ;)
I'll update in V7 and send it out shortly.
Thanks,
Suravee
WARNING: multiple messages have this Message-ID (diff)
From: suravee.suthikulpanit@amd.com (Suravee Suthikulanit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 4/4] gicv2m: acpi: Introducing GICv2m ACPI support
Date: Thu, 10 Dec 2015 10:11:01 -0600 [thread overview]
Message-ID: <5669A415.60300@amd.com> (raw)
In-Reply-To: <56694272.5050706@arm.com>
On 12/10/2015 3:14 AM, Marc Zyngier wrote:
>> +int __init gicv2m_init(struct fwnode_handle *parent_handle,
>> >+ struct irq_domain *parent)
>> >+{
>> >+ int ret = gicv2m_of_init(parent_handle, parent);
>> >+
>> >+ if (ret)
>> >+ ret = gicv2m_acpi_init(parent);
>> >+ return ret;
> This should really read:
>
> if (is_of_node(parent_handle))
> return gicv2m_of_init(parent_handle, parent);
>
> return gicv2m_acpi_init(parent);
>
> and you can loose the test for NULL in gicv2m_of_init().
>
Right... Your style of returning which is cleaner ;)
I'll update in V7 and send it out shortly.
Thanks,
Suravee
next prev parent reply other threads:[~2015-12-10 16:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 19:24 [PATCH v6 0/4] gicv2m: acpi: Add ACPI support for GICv2m MSI Suravee Suthikulpanit
2015-12-09 19:24 ` Suravee Suthikulpanit
2015-12-09 19:24 ` Suravee Suthikulpanit
2015-12-09 19:24 ` [PATCH v6 1/4] acpi: pci: Setup MSI domain for ACPI based pci devices Suravee Suthikulpanit
2015-12-09 19:24 ` Suravee Suthikulpanit
2015-12-09 19:24 ` Suravee Suthikulpanit
2015-12-09 19:24 ` [PATCH v6 2/4] irqdomain: introduce is_fwnode_irqchip helper Suravee Suthikulpanit
2015-12-09 19:24 ` Suravee Suthikulpanit
2015-12-09 19:24 ` Suravee Suthikulpanit
2015-12-09 19:24 ` [PATCH v6 3/4] gicv2m: Refactor to prepare for ACPI support Suravee Suthikulpanit
2015-12-09 19:24 ` Suravee Suthikulpanit
2015-12-09 19:24 ` Suravee Suthikulpanit
2015-12-09 19:24 ` [PATCH v6 4/4] gicv2m: acpi: Introducing GICv2m " Suravee Suthikulpanit
2015-12-09 19:24 ` Suravee Suthikulpanit
2015-12-09 19:24 ` Suravee Suthikulpanit
2015-12-10 9:14 ` Marc Zyngier
2015-12-10 9:14 ` Marc Zyngier
2015-12-10 16:11 ` Suravee Suthikulanit [this message]
2015-12-10 16:11 ` Suravee Suthikulanit
2015-12-10 16:11 ` Suravee Suthikulanit
2015-12-10 2:20 ` [PATCH v6 0/4] gicv2m: acpi: Add ACPI support for GICv2m MSI Duc Dang
2015-12-10 2:20 ` Duc Dang
2015-12-10 3:07 ` Suravee Suthikulanit
2015-12-10 3:07 ` Suravee Suthikulanit
2015-12-10 3:07 ` Suravee Suthikulanit
2015-12-10 9:26 ` Marc Zyngier
2015-12-10 9:26 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5669A415.60300@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=Catalin.Marinas@arm.com \
--cc=dhdang@apm.com \
--cc=graeme.gregory@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=jason@lakedaemon.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tomasz.nowicki@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.