From: Vladimir Murzin <vladimir.murzin@arm.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Andreas Färber" <afaerber@suse.de>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Mark Rutland" <Mark.Rutland@arm.com>,
"Pawel Moll" <Pawel.Moll@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Jiri Slaby" <jslaby@suse.cz>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 02/10] clockevents/drivers: add MPS2 Timer driver
Date: Tue, 15 Dec 2015 13:16:11 +0000 [thread overview]
Message-ID: <5670129B.700@arm.com> (raw)
In-Reply-To: <CAL_Jsq+MhvV5BFw+x3TWTDheSpgWHjHjO02+D4V4swr493HXrg@mail.gmail.com>
On 14/12/15 13:56, Rob Herring wrote:
> On Wed, Dec 2, 2015 at 3:33 AM, Vladimir Murzin <vladimir.murzin@arm.com> wrote:
>> MPS2 platform has simple 32 bits general purpose countdown timers.
>>
>> The driver uses the first detected timer as a clocksource and the rest
>> of the timers as a clockevent
>>
>> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
>> ---
>> drivers/clocksource/Kconfig | 5 +
>> drivers/clocksource/Makefile | 1 +
>> drivers/clocksource/mps2-timer.c | 277 ++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 283 insertions(+)
>> create mode 100644 drivers/clocksource/mps2-timer.c
>>
>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>> index 2eb5f0e..8bca09c 100644
>> --- a/drivers/clocksource/Kconfig
>> +++ b/drivers/clocksource/Kconfig
>> @@ -137,6 +137,11 @@ config CLKSRC_STM32
>> depends on OF && ARM && (ARCH_STM32 || COMPILE_TEST)
>> select CLKSRC_MMIO
>>
>> +config CLKSRC_MPS2
>> + bool "Clocksource for MPS2 SoCs" if COMPILE_TEST
>> + depends on OF && ARM
>
> Does this really depend on both of these for COMPILE_TEST?
Not really...
>
> You need to select CLKSRC_OF rather than CLKSRC_MMIO as well.
>
Does it looks better?
config CLKSRC_MPS2
bool "Clocksource for MPS2 SoCs" if COMPILE_TEST
depends on GENERIC_SCHED_CLOCK
select CLKSRC_MMIO
select CLKSRC_OF
Cheers
Vladimir
> Rob
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Murzin <vladimir.murzin-5wv7dgnIgG8@public.gmane.org>
To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "Arnd Bergmann" <arnd-r2nGTMty4D4@public.gmane.org>,
"Russell King - ARM Linux"
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"Greg Kroah-Hartman"
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"Daniel Lezcano"
<daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Thomas Gleixner" <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
"Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>,
"Maxime Coquelin"
<mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Mark Rutland" <Mark.Rutland-5wv7dgnIgG8@public.gmane.org>,
"Pawel Moll" <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
"Ian Campbell"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"Jiri Slaby" <jslaby-AlSwsSmVLrQ@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TZUIDd8j+nm9g@public.gmane.org>
Subject: Re: [PATCH v1 02/10] clockevents/drivers: add MPS2 Timer driver
Date: Tue, 15 Dec 2015 13:16:11 +0000 [thread overview]
Message-ID: <5670129B.700@arm.com> (raw)
In-Reply-To: <CAL_Jsq+MhvV5BFw+x3TWTDheSpgWHjHjO02+D4V4swr493HXrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 14/12/15 13:56, Rob Herring wrote:
> On Wed, Dec 2, 2015 at 3:33 AM, Vladimir Murzin <vladimir.murzin-5wv7dgnIgG8@public.gmane.org> wrote:
>> MPS2 platform has simple 32 bits general purpose countdown timers.
>>
>> The driver uses the first detected timer as a clocksource and the rest
>> of the timers as a clockevent
>>
>> Signed-off-by: Vladimir Murzin <vladimir.murzin-5wv7dgnIgG8@public.gmane.org>
>> ---
>> drivers/clocksource/Kconfig | 5 +
>> drivers/clocksource/Makefile | 1 +
>> drivers/clocksource/mps2-timer.c | 277 ++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 283 insertions(+)
>> create mode 100644 drivers/clocksource/mps2-timer.c
>>
>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>> index 2eb5f0e..8bca09c 100644
>> --- a/drivers/clocksource/Kconfig
>> +++ b/drivers/clocksource/Kconfig
>> @@ -137,6 +137,11 @@ config CLKSRC_STM32
>> depends on OF && ARM && (ARCH_STM32 || COMPILE_TEST)
>> select CLKSRC_MMIO
>>
>> +config CLKSRC_MPS2
>> + bool "Clocksource for MPS2 SoCs" if COMPILE_TEST
>> + depends on OF && ARM
>
> Does this really depend on both of these for COMPILE_TEST?
Not really...
>
> You need to select CLKSRC_OF rather than CLKSRC_MMIO as well.
>
Does it looks better?
config CLKSRC_MPS2
bool "Clocksource for MPS2 SoCs" if COMPILE_TEST
depends on GENERIC_SCHED_CLOCK
select CLKSRC_MMIO
select CLKSRC_OF
Cheers
Vladimir
> Rob
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: vladimir.murzin@arm.com (Vladimir Murzin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 02/10] clockevents/drivers: add MPS2 Timer driver
Date: Tue, 15 Dec 2015 13:16:11 +0000 [thread overview]
Message-ID: <5670129B.700@arm.com> (raw)
In-Reply-To: <CAL_Jsq+MhvV5BFw+x3TWTDheSpgWHjHjO02+D4V4swr493HXrg@mail.gmail.com>
On 14/12/15 13:56, Rob Herring wrote:
> On Wed, Dec 2, 2015 at 3:33 AM, Vladimir Murzin <vladimir.murzin@arm.com> wrote:
>> MPS2 platform has simple 32 bits general purpose countdown timers.
>>
>> The driver uses the first detected timer as a clocksource and the rest
>> of the timers as a clockevent
>>
>> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
>> ---
>> drivers/clocksource/Kconfig | 5 +
>> drivers/clocksource/Makefile | 1 +
>> drivers/clocksource/mps2-timer.c | 277 ++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 283 insertions(+)
>> create mode 100644 drivers/clocksource/mps2-timer.c
>>
>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>> index 2eb5f0e..8bca09c 100644
>> --- a/drivers/clocksource/Kconfig
>> +++ b/drivers/clocksource/Kconfig
>> @@ -137,6 +137,11 @@ config CLKSRC_STM32
>> depends on OF && ARM && (ARCH_STM32 || COMPILE_TEST)
>> select CLKSRC_MMIO
>>
>> +config CLKSRC_MPS2
>> + bool "Clocksource for MPS2 SoCs" if COMPILE_TEST
>> + depends on OF && ARM
>
> Does this really depend on both of these for COMPILE_TEST?
Not really...
>
> You need to select CLKSRC_OF rather than CLKSRC_MMIO as well.
>
Does it looks better?
config CLKSRC_MPS2
bool "Clocksource for MPS2 SoCs" if COMPILE_TEST
depends on GENERIC_SCHED_CLOCK
select CLKSRC_MMIO
select CLKSRC_OF
Cheers
Vladimir
> Rob
>
>
>
next prev parent reply other threads:[~2015-12-15 13:16 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 9:33 [PATCH v1 00/10] Support for Cortex-M Prototyping System Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 01/10] dt-bindings: document the MPS2 timer bindings Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 02/10] clockevents/drivers: add MPS2 Timer driver Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-07 9:25 ` Vladimir Murzin
2015-12-07 9:25 ` Vladimir Murzin
2015-12-07 9:25 ` Vladimir Murzin
2015-12-14 13:36 ` Daniel Lezcano
2015-12-14 13:36 ` Daniel Lezcano
2015-12-14 13:36 ` Daniel Lezcano
2015-12-15 12:47 ` Vladimir Murzin
2015-12-15 12:47 ` Vladimir Murzin
2015-12-15 12:47 ` Vladimir Murzin
2015-12-14 13:56 ` Rob Herring
2015-12-14 13:56 ` Rob Herring
2015-12-14 13:56 ` Rob Herring
2015-12-15 13:16 ` Vladimir Murzin [this message]
2015-12-15 13:16 ` Vladimir Murzin
2015-12-15 13:16 ` Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 03/10] dt-bindings: document the MPS2 UART bindings Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 04/10] serial: mps2-uart: add MPS2 UART driver Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-07 9:26 ` Vladimir Murzin
2015-12-07 9:26 ` Vladimir Murzin
2015-12-07 9:26 ` Vladimir Murzin
2015-12-12 23:39 ` Andy Shevchenko
2015-12-12 23:39 ` Andy Shevchenko
2015-12-12 23:39 ` Andy Shevchenko
2015-12-13 7:00 ` Greg Kroah-Hartman
2015-12-13 7:00 ` Greg Kroah-Hartman
2015-12-15 12:40 ` Vladimir Murzin
2015-12-15 12:40 ` Vladimir Murzin
2015-12-17 13:15 ` Andy Shevchenko
2015-12-17 13:15 ` Andy Shevchenko
2015-12-02 9:33 ` [PATCH v1 05/10] serial: mps2-uart: add support for early console Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 06/10] ARM: mps2: introduce MPS2 platform Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 07/10] ARM: mps2: add low-level debug support Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 08/10] ARM: configs: add MPS2 defconfig Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 09/10] ARM: dts: introduce MPS2 AN385/AN386 Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
2015-12-23 9:33 ` Vladimir Murzin
2015-12-23 9:33 ` Vladimir Murzin
2015-12-23 9:33 ` Vladimir Murzin
2015-12-02 9:33 ` [PATCH v1 10/10] ARM: dts: introduce MPS2 AN399/AN400 Vladimir Murzin
2015-12-02 9:33 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5670129B.700@arm.com \
--to=vladimir.murzin@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=afaerber@suse.de \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jslaby@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.