* [PATCH 1/2] acpi: Tidy up _OSC error spacing
2015-11-19 16:08 [PATCH 0/2] Minor _OSC error handling improvements Andy Lutomirski
@ 2015-11-19 16:08 ` Andy Lutomirski
2015-11-19 21:59 ` Andy Lutomirski
2015-11-19 16:08 ` [PATCH 2/2] acpi: Show _OSC UUID when _OSC fails Andy Lutomirski
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: Andy Lutomirski @ 2015-11-19 16:08 UTC (permalink / raw)
To: Matthew Garrett, Bjorn Helgaas; +Cc: linux-pci, Yijing Wang, Andy Lutomirski
The whitespace in _OSC error reports is weird. Improve it.
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
drivers/acpi/bus.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index a212cefae524..2177ef0b16e4 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -182,12 +182,12 @@ static void acpi_print_osc_error(acpi_handle handle,
if (ACPI_FAILURE(acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer)))
printk(KERN_DEBUG "%s\n", error);
else {
- printk(KERN_DEBUG "%s:%s\n", (char *)buffer.pointer, error);
+ printk(KERN_DEBUG "%s: %s\n", (char *)buffer.pointer, error);
kfree(buffer.pointer);
}
- printk(KERN_DEBUG"_OSC request data:");
+ printk(KERN_DEBUG "_OSC request data:");
for (i = 0; i < context->cap.length; i += sizeof(u32))
- printk("%x ", *((u32 *)(context->cap.pointer + i)));
+ printk(" %x", *((u32 *)(context->cap.pointer + i)));
printk("\n");
}
--
2.5.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 1/2] acpi: Tidy up _OSC error spacing
2015-11-19 16:08 ` [PATCH 1/2] acpi: Tidy up _OSC error spacing Andy Lutomirski
@ 2015-11-19 21:59 ` Andy Lutomirski
2015-11-20 1:01 ` Rafael J. Wysocki
0 siblings, 1 reply; 11+ messages in thread
From: Andy Lutomirski @ 2015-11-19 21:59 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Matthew Garrett, Bjorn Helgaas, linux-pci, Yijing Wang, Linux ACPI
Forwarding to linux-acpi.
On Thu, Nov 19, 2015 at 8:08 AM, Andy Lutomirski <luto@kernel.org> wrote:
> The whitespace in _OSC error reports is weird. Improve it.
>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> drivers/acpi/bus.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index a212cefae524..2177ef0b16e4 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -182,12 +182,12 @@ static void acpi_print_osc_error(acpi_handle handle,
> if (ACPI_FAILURE(acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer)))
> printk(KERN_DEBUG "%s\n", error);
> else {
> - printk(KERN_DEBUG "%s:%s\n", (char *)buffer.pointer, error);
> + printk(KERN_DEBUG "%s: %s\n", (char *)buffer.pointer, error);
> kfree(buffer.pointer);
> }
> - printk(KERN_DEBUG"_OSC request data:");
> + printk(KERN_DEBUG "_OSC request data:");
> for (i = 0; i < context->cap.length; i += sizeof(u32))
> - printk("%x ", *((u32 *)(context->cap.pointer + i)));
> + printk(" %x", *((u32 *)(context->cap.pointer + i)));
> printk("\n");
> }
>
> --
> 2.5.0
>
--
Andy Lutomirski
AMA Capital Management, LLC
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 1/2] acpi: Tidy up _OSC error spacing
2015-11-19 21:59 ` Andy Lutomirski
@ 2015-11-20 1:01 ` Rafael J. Wysocki
0 siblings, 0 replies; 11+ messages in thread
From: Rafael J. Wysocki @ 2015-11-20 1:01 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Andy Lutomirski, Matthew Garrett, Bjorn Helgaas, linux-pci,
Yijing Wang, Linux ACPI
On Thursday, November 19, 2015 01:59:47 PM Andy Lutomirski wrote:
> Forwarding to linux-acpi.
>
> On Thu, Nov 19, 2015 at 8:08 AM, Andy Lutomirski <luto@kernel.org> wrote:
> > The whitespace in _OSC error reports is weird. Improve it.
Both patches look good to me.
I'll be queuing them up for 4.5 if there are no objections.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/2] acpi: Show _OSC UUID when _OSC fails
2015-11-19 16:08 [PATCH 0/2] Minor _OSC error handling improvements Andy Lutomirski
2015-11-19 16:08 ` [PATCH 1/2] acpi: Tidy up _OSC error spacing Andy Lutomirski
@ 2015-11-19 16:08 ` Andy Lutomirski
2015-11-19 22:00 ` Andy Lutomirski
2015-11-19 22:23 ` [PATCH 0/2] Minor _OSC error handling improvements Rafael J. Wysocki
2015-12-03 17:29 ` Bjorn Helgaas
3 siblings, 1 reply; 11+ messages in thread
From: Andy Lutomirski @ 2015-11-19 16:08 UTC (permalink / raw)
To: Matthew Garrett, Bjorn Helgaas; +Cc: linux-pci, Yijing Wang, Andy Lutomirski
When _OSC fails and especially when it fails due to an invalid UUID,
it's helpful to show the UUID that we tried.
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
drivers/acpi/bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 2177ef0b16e4..be2b164f8f2d 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -180,9 +180,9 @@ static void acpi_print_osc_error(acpi_handle handle,
int i;
if (ACPI_FAILURE(acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer)))
- printk(KERN_DEBUG "%s\n", error);
+ printk(KERN_DEBUG "%s: %s\n", context->uuid_str, error);
else {
- printk(KERN_DEBUG "%s: %s\n", (char *)buffer.pointer, error);
+ printk(KERN_DEBUG "%s (%s): %s\n", (char *)buffer.pointer, context->uuid_str, error);
kfree(buffer.pointer);
}
printk(KERN_DEBUG "_OSC request data:");
--
2.5.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 2/2] acpi: Show _OSC UUID when _OSC fails
2015-11-19 16:08 ` [PATCH 2/2] acpi: Show _OSC UUID when _OSC fails Andy Lutomirski
@ 2015-11-19 22:00 ` Andy Lutomirski
0 siblings, 0 replies; 11+ messages in thread
From: Andy Lutomirski @ 2015-11-19 22:00 UTC (permalink / raw)
To: Andy Lutomirski
Cc: Matthew Garrett, Bjorn Helgaas, linux-pci, Yijing Wang, Linux ACPI
Forwarding to linux-acpi.
On Thu, Nov 19, 2015 at 8:08 AM, Andy Lutomirski <luto@kernel.org> wrote:
> When _OSC fails and especially when it fails due to an invalid UUID,
> it's helpful to show the UUID that we tried.
>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> drivers/acpi/bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 2177ef0b16e4..be2b164f8f2d 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -180,9 +180,9 @@ static void acpi_print_osc_error(acpi_handle handle,
> int i;
>
> if (ACPI_FAILURE(acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer)))
> - printk(KERN_DEBUG "%s\n", error);
> + printk(KERN_DEBUG "%s: %s\n", context->uuid_str, error);
> else {
> - printk(KERN_DEBUG "%s: %s\n", (char *)buffer.pointer, error);
> + printk(KERN_DEBUG "%s (%s): %s\n", (char *)buffer.pointer, context->uuid_str, error);
> kfree(buffer.pointer);
> }
> printk(KERN_DEBUG "_OSC request data:");
> --
> 2.5.0
>
--
Andy Lutomirski
AMA Capital Management, LLC
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] Minor _OSC error handling improvements
2015-11-19 16:08 [PATCH 0/2] Minor _OSC error handling improvements Andy Lutomirski
2015-11-19 16:08 ` [PATCH 1/2] acpi: Tidy up _OSC error spacing Andy Lutomirski
2015-11-19 16:08 ` [PATCH 2/2] acpi: Show _OSC UUID when _OSC fails Andy Lutomirski
@ 2015-11-19 22:23 ` Rafael J. Wysocki
2015-12-03 17:29 ` Bjorn Helgaas
3 siblings, 0 replies; 11+ messages in thread
From: Rafael J. Wysocki @ 2015-11-19 22:23 UTC (permalink / raw)
To: Andy Lutomirski; +Cc: Matthew Garrett, Bjorn Helgaas, linux-pci, Yijing Wang
On Thursday, November 19, 2015 08:08:18 AM Andy Lutomirski wrote:
> This doesn't fix any bugs, but it makes the debugging output a
> little more useful.
>
> Andy Lutomirski (2):
> acpi: Tidy up _OSC error spacing
> acpi: Show _OSC UUID when _OSC fails
>
> drivers/acpi/bus.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Can you please CC ACPI-related patches to linux-acpi@vger.kernel.org,
especially when they touch files under drivers/acpi/?
Thanks,
Rafael
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] Minor _OSC error handling improvements
2015-11-19 16:08 [PATCH 0/2] Minor _OSC error handling improvements Andy Lutomirski
` (2 preceding siblings ...)
2015-11-19 22:23 ` [PATCH 0/2] Minor _OSC error handling improvements Rafael J. Wysocki
@ 2015-12-03 17:29 ` Bjorn Helgaas
2015-12-15 3:15 ` Andy Lutomirski
3 siblings, 1 reply; 11+ messages in thread
From: Bjorn Helgaas @ 2015-12-03 17:29 UTC (permalink / raw)
To: Andy Lutomirski; +Cc: Matthew Garrett, Bjorn Helgaas, linux-pci, Yijing Wang
On Thu, Nov 19, 2015 at 08:08:18AM -0800, Andy Lutomirski wrote:
> This doesn't fix any bugs, but it makes the debugging output a
> little more useful.
>
> Andy Lutomirski (2):
> acpi: Tidy up _OSC error spacing
> acpi: Show _OSC UUID when _OSC fails
>
> drivers/acpi/bus.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
These both look fine to me. If you want it:
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 0/2] Minor _OSC error handling improvements
2015-12-03 17:29 ` Bjorn Helgaas
@ 2015-12-15 3:15 ` Andy Lutomirski
0 siblings, 0 replies; 11+ messages in thread
From: Andy Lutomirski @ 2015-12-15 3:15 UTC (permalink / raw)
To: Bjorn Helgaas, Rafael J. Wysocki, Linux API
Cc: Andy Lutomirski, Matthew Garrett, Bjorn Helgaas, linux-pci, Yijing Wang
[cc: linux-acpi and Rafael -- whoops]
Rafael, do you want me to resend these?
--Andy
On Thu, Dec 3, 2015 at 9:29 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Thu, Nov 19, 2015 at 08:08:18AM -0800, Andy Lutomirski wrote:
>> This doesn't fix any bugs, but it makes the debugging output a
>> little more useful.
>>
>> Andy Lutomirski (2):
>> acpi: Tidy up _OSC error spacing
>> acpi: Show _OSC UUID when _OSC fails
>>
>> drivers/acpi/bus.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> These both look fine to me. If you want it:
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
--
Andy Lutomirski
AMA Capital Management, LLC
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] Minor _OSC error handling improvements
@ 2015-12-15 3:15 ` Andy Lutomirski
0 siblings, 0 replies; 11+ messages in thread
From: Andy Lutomirski @ 2015-12-15 3:15 UTC (permalink / raw)
To: Bjorn Helgaas, Rafael J. Wysocki, Linux API
Cc: Andy Lutomirski, Matthew Garrett, Bjorn Helgaas,
linux-pci-u79uwXL29TY76Z2rM5mHXA, Yijing Wang
[cc: linux-acpi and Rafael -- whoops]
Rafael, do you want me to resend these?
--Andy
On Thu, Dec 3, 2015 at 9:29 AM, Bjorn Helgaas <helgaas-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Thu, Nov 19, 2015 at 08:08:18AM -0800, Andy Lutomirski wrote:
>> This doesn't fix any bugs, but it makes the debugging output a
>> little more useful.
>>
>> Andy Lutomirski (2):
>> acpi: Tidy up _OSC error spacing
>> acpi: Show _OSC UUID when _OSC fails
>>
>> drivers/acpi/bus.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> These both look fine to me. If you want it:
>
> Acked-by: Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
--
Andy Lutomirski
AMA Capital Management, LLC
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] Minor _OSC error handling improvements
2015-12-15 3:15 ` Andy Lutomirski
(?)
@ 2015-12-15 16:10 ` Rafael J. Wysocki
-1 siblings, 0 replies; 11+ messages in thread
From: Rafael J. Wysocki @ 2015-12-15 16:10 UTC (permalink / raw)
To: Andy Lutomirski, Bjorn Helgaas, Linux API
Cc: Andy Lutomirski, Matthew Garrett, Bjorn Helgaas, linux-pci, Yijing Wang
On 12/15/2015 4:15 AM, Andy Lutomirski wrote:
> [cc: linux-acpi and Rafael -- whoops]
>
> Rafael, do you want me to resend these?
Yes, please.
Thanks,
Rafael
> On Thu, Dec 3, 2015 at 9:29 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
>> On Thu, Nov 19, 2015 at 08:08:18AM -0800, Andy Lutomirski wrote:
>>> This doesn't fix any bugs, but it makes the debugging output a
>>> little more useful.
>>>
>>> Andy Lutomirski (2):
>>> acpi: Tidy up _OSC error spacing
>>> acpi: Show _OSC UUID when _OSC fails
>>>
>>> drivers/acpi/bus.c | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>> These both look fine to me. If you want it:
>>
>> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread