All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: Peter Oh <poh@qca.qualcomm.com>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: add modparam 'hw_csum' to make HW checksum configurable
Date: Wed, 16 Dec 2015 19:27:28 +0100	[thread overview]
Message-ID: <5671AD10.70004@openwrt.org> (raw)
In-Reply-To: <1450290051-15593-1-git-send-email-poh@qca.qualcomm.com>

On 2015-12-16 19:20, Peter Oh wrote:
> Some hardwares such as QCA988X and QCA99X0 doesn't have
> capability of checksum offload when frame formats are not
> suitable for it such as Mesh frame.
> Hence add a module parameter, hw_csum, to make checksum offload
> configurable during module registration time.
> 
> Signed-off-by: Peter Oh <poh@qca.qualcomm.com>
How about instead of inventing yet another crappy module parameter, you
call skb_checksum_help() in the driver in cases where the hardware is
unable to offload the checksum calculation.

That way the user has to worry about less driver specific hackery ;)

- Felix

WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@openwrt.org>
To: Peter Oh <poh@qca.qualcomm.com>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: add modparam 'hw_csum' to make HW checksum configurable
Date: Wed, 16 Dec 2015 19:27:28 +0100	[thread overview]
Message-ID: <5671AD10.70004@openwrt.org> (raw)
In-Reply-To: <1450290051-15593-1-git-send-email-poh@qca.qualcomm.com>

On 2015-12-16 19:20, Peter Oh wrote:
> Some hardwares such as QCA988X and QCA99X0 doesn't have
> capability of checksum offload when frame formats are not
> suitable for it such as Mesh frame.
> Hence add a module parameter, hw_csum, to make checksum offload
> configurable during module registration time.
> 
> Signed-off-by: Peter Oh <poh@qca.qualcomm.com>
How about instead of inventing yet another crappy module parameter, you
call skb_checksum_help() in the driver in cases where the hardware is
unable to offload the checksum calculation.

That way the user has to worry about less driver specific hackery ;)

- Felix

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2015-12-16 18:27 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 18:20 [PATCH] ath10k: add modparam 'hw_csum' to make HW checksum configurable Peter Oh
2015-12-16 18:20 ` Peter Oh
2015-12-16 18:27 ` Felix Fietkau [this message]
2015-12-16 18:27   ` Felix Fietkau
2015-12-16 20:29   ` Peter Oh
2015-12-16 20:29     ` Peter Oh
2015-12-16 20:35     ` Felix Fietkau
2015-12-16 20:35       ` Felix Fietkau
2015-12-16 20:46       ` Peter Oh
2015-12-16 20:46         ` Peter Oh
2015-12-16 20:53         ` Felix Fietkau
2015-12-16 20:53           ` Felix Fietkau
2015-12-16 21:19           ` Peter Oh
2015-12-16 21:19             ` Peter Oh
2015-12-16 21:54             ` Felix Fietkau
2015-12-16 21:54               ` Felix Fietkau
2015-12-16 23:50               ` Peter Oh
2015-12-16 23:50                 ` Peter Oh
2015-12-16 23:59                 ` Felix Fietkau
2015-12-16 23:59                   ` Felix Fietkau
2015-12-17 22:01                   ` Peter Oh
2015-12-17 22:01                     ` Peter Oh
2015-12-17 22:57                     ` Felix Fietkau
2015-12-17 22:57                       ` Felix Fietkau
2015-12-17 23:16                       ` Peter Oh
2015-12-17 23:16                         ` Peter Oh
2015-12-17  7:29                 ` Michal Kazior
2015-12-17  7:29                   ` Michal Kazior
2015-12-17 21:55                   ` Peter Oh
2015-12-17 21:55                     ` Peter Oh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5671AD10.70004@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=poh@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.