From: Michal Kazior <michal.kazior@tieto.com> To: Peter Oh <poh@codeaurora.org> Cc: Felix Fietkau <nbd@openwrt.org>, Peter Oh <poh@qca.qualcomm.com>, "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>, linux-wireless <linux-wireless@vger.kernel.org> Subject: Re: [PATCH] ath10k: add modparam 'hw_csum' to make HW checksum configurable Date: Thu, 17 Dec 2015 08:29:43 +0100 [thread overview] Message-ID: <CA+BoTQmOg3gACzk5PAtkyDo1a5WJuCauOXPZKqL+cgVi+n1HCg@mail.gmail.com> (raw) In-Reply-To: <5671F8B7.2060801@codeaurora.org> On 17 December 2015 at 00:50, Peter Oh <poh@codeaurora.org> wrote: > On 12/16/2015 01:54 PM, Felix Fietkau wrote: >> On 2015-12-16 22:19, Peter Oh wrote: [...] >>> If mentioned to use the function to mesh frame only without touching >>> mac80211, then how do you suggest it to apply it only to mesh frame >>> without interfere other data frames? >>> Can you share your example? >> >> It's trivial - in ath10k_tx you do this: >> >> if (vif->type == NL80211_IFTYPE_MESH_POINT && >> skb->ip_summed == CHECKSUM_PARTIAL) >> skb_checksum_help(skb); > > Thank you Felix for the quick response. > I agree on your user experience opinion, > but what do you think when ath10k has a new chip supporting HW checksum for > Mesh? You can simply introduce a fw-feature flag saying "supports_mesh_csum_offload" later and skip the skb_checksum_help() if it's set. Michał
WARNING: multiple messages have this Message-ID (diff)
From: Michal Kazior <michal.kazior@tieto.com> To: Peter Oh <poh@codeaurora.org> Cc: Felix Fietkau <nbd@openwrt.org>, linux-wireless <linux-wireless@vger.kernel.org>, "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>, Peter Oh <poh@qca.qualcomm.com> Subject: Re: [PATCH] ath10k: add modparam 'hw_csum' to make HW checksum configurable Date: Thu, 17 Dec 2015 08:29:43 +0100 [thread overview] Message-ID: <CA+BoTQmOg3gACzk5PAtkyDo1a5WJuCauOXPZKqL+cgVi+n1HCg@mail.gmail.com> (raw) In-Reply-To: <5671F8B7.2060801@codeaurora.org> On 17 December 2015 at 00:50, Peter Oh <poh@codeaurora.org> wrote: > On 12/16/2015 01:54 PM, Felix Fietkau wrote: >> On 2015-12-16 22:19, Peter Oh wrote: [...] >>> If mentioned to use the function to mesh frame only without touching >>> mac80211, then how do you suggest it to apply it only to mesh frame >>> without interfere other data frames? >>> Can you share your example? >> >> It's trivial - in ath10k_tx you do this: >> >> if (vif->type == NL80211_IFTYPE_MESH_POINT && >> skb->ip_summed == CHECKSUM_PARTIAL) >> skb_checksum_help(skb); > > Thank you Felix for the quick response. > I agree on your user experience opinion, > but what do you think when ath10k has a new chip supporting HW checksum for > Mesh? You can simply introduce a fw-feature flag saying "supports_mesh_csum_offload" later and skip the skb_checksum_help() if it's set. Michał _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2015-12-17 7:29 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-16 18:20 [PATCH] ath10k: add modparam 'hw_csum' to make HW checksum configurable Peter Oh 2015-12-16 18:20 ` Peter Oh 2015-12-16 18:27 ` Felix Fietkau 2015-12-16 18:27 ` Felix Fietkau 2015-12-16 20:29 ` Peter Oh 2015-12-16 20:29 ` Peter Oh 2015-12-16 20:35 ` Felix Fietkau 2015-12-16 20:35 ` Felix Fietkau 2015-12-16 20:46 ` Peter Oh 2015-12-16 20:46 ` Peter Oh 2015-12-16 20:53 ` Felix Fietkau 2015-12-16 20:53 ` Felix Fietkau 2015-12-16 21:19 ` Peter Oh 2015-12-16 21:19 ` Peter Oh 2015-12-16 21:54 ` Felix Fietkau 2015-12-16 21:54 ` Felix Fietkau 2015-12-16 23:50 ` Peter Oh 2015-12-16 23:50 ` Peter Oh 2015-12-16 23:59 ` Felix Fietkau 2015-12-16 23:59 ` Felix Fietkau 2015-12-17 22:01 ` Peter Oh 2015-12-17 22:01 ` Peter Oh 2015-12-17 22:57 ` Felix Fietkau 2015-12-17 22:57 ` Felix Fietkau 2015-12-17 23:16 ` Peter Oh 2015-12-17 23:16 ` Peter Oh 2015-12-17 7:29 ` Michal Kazior [this message] 2015-12-17 7:29 ` Michal Kazior 2015-12-17 21:55 ` Peter Oh 2015-12-17 21:55 ` Peter Oh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CA+BoTQmOg3gACzk5PAtkyDo1a5WJuCauOXPZKqL+cgVi+n1HCg@mail.gmail.com \ --to=michal.kazior@tieto.com \ --cc=ath10k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=nbd@openwrt.org \ --cc=poh@codeaurora.org \ --cc=poh@qca.qualcomm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.