From: David Daney <ddaney@caviumnetworks.com>
To: Will Deacon <will.deacon@arm.com>
Cc: David Daney <ddaney.cavm@gmail.com>,
<linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, Marc Zyngier <marc.zyngier@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 2/2] pci, pcie-thunder-pem: Add PCIe host driver for ThunderX processors.
Date: Tue, 22 Dec 2015 15:28:48 -0800 [thread overview]
Message-ID: <5679DCB0.4040700@caviumnetworks.com> (raw)
In-Reply-To: <5679A1E9.3050902@caviumnetworks.com>
On 12/22/2015 11:18 AM, David Daney wrote:
> On 12/22/2015 02:03 AM, Will Deacon wrote:
>> On Mon, Dec 21, 2015 at 05:53:42PM -0800, David Daney wrote:
>>> From: David Daney <david.daney@cavium.com>
[...]
>>> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
>>> index f131ba9..16ed9c3 100644
>>> --- a/drivers/pci/host/Kconfig
>>> +++ b/drivers/pci/host/Kconfig
>>> @@ -172,4 +172,10 @@ config PCI_HISI
>>> help
>>> Say Y here if you want PCIe controller support on HiSilicon
>>> HIP05 SoC
>>>
>>> +config PCIE_HOST_THUNDER_PEM
>>> + bool "Cavium Thunder PCIe controller to off-chip devices"
>>> + depends on PCI_HOST_GENERIC && ARM64
>>
>> || COMPILE_TEST ?
>>
>> (or does the use of writeq get you? If so, maybe COMPILE_TEST && 64BIT)
>
> Yes, we must use writeq in the driver, I will change it to
> ||(COMPILE_TEST && 64BIT)
>
Actually, it turns out that this is not easily done.
For x86, it appears difficult to include asm-generic/pci-bridge.h which
includes the needed definition of PCI_PROBE_ONLY. So I think it is not
worth supporting COMPILE_TEST
David Daney
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Will Deacon <will.deacon@arm.com>
Cc: David Daney <ddaney.cavm@gmail.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Marc Zyngier <marc.zyngier@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 2/2] pci, pcie-thunder-pem: Add PCIe host driver for ThunderX processors.
Date: Tue, 22 Dec 2015 15:28:48 -0800 [thread overview]
Message-ID: <5679DCB0.4040700@caviumnetworks.com> (raw)
In-Reply-To: <5679A1E9.3050902@caviumnetworks.com>
On 12/22/2015 11:18 AM, David Daney wrote:
> On 12/22/2015 02:03 AM, Will Deacon wrote:
>> On Mon, Dec 21, 2015 at 05:53:42PM -0800, David Daney wrote:
>>> From: David Daney <david.daney@cavium.com>
[...]
>>> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
>>> index f131ba9..16ed9c3 100644
>>> --- a/drivers/pci/host/Kconfig
>>> +++ b/drivers/pci/host/Kconfig
>>> @@ -172,4 +172,10 @@ config PCI_HISI
>>> help
>>> Say Y here if you want PCIe controller support on HiSilicon
>>> HIP05 SoC
>>>
>>> +config PCIE_HOST_THUNDER_PEM
>>> + bool "Cavium Thunder PCIe controller to off-chip devices"
>>> + depends on PCI_HOST_GENERIC && ARM64
>>
>> || COMPILE_TEST ?
>>
>> (or does the use of writeq get you? If so, maybe COMPILE_TEST && 64BIT)
>
> Yes, we must use writeq in the driver, I will change it to
> ||(COMPILE_TEST && 64BIT)
>
Actually, it turns out that this is not easily done.
For x86, it appears difficult to include asm-generic/pci-bridge.h which
includes the needed definition of PCI_PROBE_ONLY. So I think it is not
worth supporting COMPILE_TEST
David Daney
WARNING: multiple messages have this Message-ID (diff)
From: ddaney@caviumnetworks.com (David Daney)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] pci, pcie-thunder-pem: Add PCIe host driver for ThunderX processors.
Date: Tue, 22 Dec 2015 15:28:48 -0800 [thread overview]
Message-ID: <5679DCB0.4040700@caviumnetworks.com> (raw)
In-Reply-To: <5679A1E9.3050902@caviumnetworks.com>
On 12/22/2015 11:18 AM, David Daney wrote:
> On 12/22/2015 02:03 AM, Will Deacon wrote:
>> On Mon, Dec 21, 2015 at 05:53:42PM -0800, David Daney wrote:
>>> From: David Daney <david.daney@cavium.com>
[...]
>>> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
>>> index f131ba9..16ed9c3 100644
>>> --- a/drivers/pci/host/Kconfig
>>> +++ b/drivers/pci/host/Kconfig
>>> @@ -172,4 +172,10 @@ config PCI_HISI
>>> help
>>> Say Y here if you want PCIe controller support on HiSilicon
>>> HIP05 SoC
>>>
>>> +config PCIE_HOST_THUNDER_PEM
>>> + bool "Cavium Thunder PCIe controller to off-chip devices"
>>> + depends on PCI_HOST_GENERIC && ARM64
>>
>> || COMPILE_TEST ?
>>
>> (or does the use of writeq get you? If so, maybe COMPILE_TEST && 64BIT)
>
> Yes, we must use writeq in the driver, I will change it to
> ||(COMPILE_TEST && 64BIT)
>
Actually, it turns out that this is not easily done.
For x86, it appears difficult to include asm-generic/pci-bridge.h which
includes the needed definition of PCI_PROBE_ONLY. So I think it is not
worth supporting COMPILE_TEST
David Daney
next prev parent reply other threads:[~2015-12-22 23:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 1:53 [PATCH 0/2] pci: Add host controller driver for Cavium ThunderX PCIe David Daney
2015-12-22 1:53 ` David Daney
2015-12-22 1:53 ` David Daney
2015-12-22 1:53 ` [PATCH 1/2] PCI: generic: Refactor code to enable reuse by other drivers David Daney
2015-12-22 1:53 ` David Daney
2015-12-22 1:53 ` David Daney
2015-12-22 10:07 ` Will Deacon
2015-12-22 10:07 ` Will Deacon
2015-12-22 10:07 ` Will Deacon
2015-12-22 18:29 ` David Daney
2015-12-22 18:29 ` David Daney
2015-12-22 18:29 ` David Daney
2015-12-22 21:13 ` Arnd Bergmann
2015-12-22 21:13 ` Arnd Bergmann
2015-12-22 21:13 ` Arnd Bergmann
2015-12-22 1:53 ` [PATCH 2/2] pci, pcie-thunder-pem: Add PCIe host driver for ThunderX processors David Daney
2015-12-22 1:53 ` David Daney
2015-12-22 10:03 ` Will Deacon
2015-12-22 10:03 ` Will Deacon
2015-12-22 19:18 ` David Daney
2015-12-22 19:18 ` David Daney
2015-12-22 19:18 ` David Daney
2015-12-22 23:28 ` David Daney [this message]
2015-12-22 23:28 ` David Daney
2015-12-22 23:28 ` David Daney
2015-12-23 0:43 ` Rob Herring
2015-12-23 0:43 ` Rob Herring
2015-12-23 0:43 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5679DCB0.4040700@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.