From: xuejiancheng <xuejiancheng@huawei.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: <mturquette@baylibre.com>, <sboyd@codeaurora.org>,
<p.zabel@pengutronix.de>, <robh+dt@kernel.org>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
<khilman@linaro.org>, <arnd@arndb.de>, <olof@lixom.net>,
<xuwei5@hisilicon.com>, <haojian.zhuang@linaro.org>,
<zhangfei.gao@linaro.org>, <bintian.wang@huawei.com>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<yanhaifeng@hisilicon.com>, <yanghongwei@hisilicon.com>,
<suwenping@hisilicon.com>, <ml.yang@hisilicon.com>,
<gaofei@hisilicon.com>, <zhangzhenxing@hisilicon.com>,
<xuejiancheng@hisilicon.com>
Subject: Re: [PATCH v5 6/6] ARM: dts: add dts files for Hi3519
Date: Mon, 11 Jan 2016 10:05:57 +0800 [thread overview]
Message-ID: <56930E05.1050009@huawei.com> (raw)
In-Reply-To: <20160108151058.GN19062@n2100.arm.linux.org.uk>
Hello Russell,
On 2016/1/8 23:10, Russell King - ARM Linux wrote:
> On Fri, Jan 08, 2016 at 10:16:40AM +0800, Jiancheng Xue wrote:
>> + uart0: serial@12100000 {
>> + compatible = "arm,pl011", "arm,primecell";
>> + reg = <0x12100000 0x1000>;
>> + interrupts = <0 4 4>;
>
> Should the last digit there be IRQ_TYPE_LEVEL_HIGH (and same for the
> other interrupts= after this?)
>
> Thanks.
>
I'll include <dt-bindings/interrupt-controller/arm-gic.h> and use
IRQ_TYPE_LEVEL_HIGH instead. The interrupts specifier will be wrote
like this "interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;".
Thank you.
Jiancheng
WARNING: multiple messages have this Message-ID (diff)
From: xuejiancheng <xuejiancheng@huawei.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: mturquette@baylibre.com, sboyd@codeaurora.org,
p.zabel@pengutronix.de, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, khilman@linaro.org, arnd@arndb.de,
olof@lixom.net, xuwei5@hisilicon.com, haojian.zhuang@linaro.org,
zhangfei.gao@linaro.org, bintian.wang@huawei.com,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
yanhaifeng@hisilicon.com, yanghongwei@hisilicon.com,
suwenping@hisilicon.com, ml.yang@hisilicon.com,
gaofei@hisilicon.com, zhangzhenxing@hisilicon.com,
xuejiancheng@hisilicon.com
Subject: Re: [PATCH v5 6/6] ARM: dts: add dts files for Hi3519
Date: Mon, 11 Jan 2016 10:05:57 +0800 [thread overview]
Message-ID: <56930E05.1050009@huawei.com> (raw)
In-Reply-To: <20160108151058.GN19062@n2100.arm.linux.org.uk>
Hello Russell,
On 2016/1/8 23:10, Russell King - ARM Linux wrote:
> On Fri, Jan 08, 2016 at 10:16:40AM +0800, Jiancheng Xue wrote:
>> + uart0: serial@12100000 {
>> + compatible = "arm,pl011", "arm,primecell";
>> + reg = <0x12100000 0x1000>;
>> + interrupts = <0 4 4>;
>
> Should the last digit there be IRQ_TYPE_LEVEL_HIGH (and same for the
> other interrupts= after this?)
>
> Thanks.
>
I'll include <dt-bindings/interrupt-controller/arm-gic.h> and use
IRQ_TYPE_LEVEL_HIGH instead. The interrupts specifier will be wrote
like this "interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;".
Thank you.
Jiancheng
WARNING: multiple messages have this Message-ID (diff)
From: xuejiancheng@huawei.com (xuejiancheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 6/6] ARM: dts: add dts files for Hi3519
Date: Mon, 11 Jan 2016 10:05:57 +0800 [thread overview]
Message-ID: <56930E05.1050009@huawei.com> (raw)
In-Reply-To: <20160108151058.GN19062@n2100.arm.linux.org.uk>
Hello Russell,
On 2016/1/8 23:10, Russell King - ARM Linux wrote:
> On Fri, Jan 08, 2016 at 10:16:40AM +0800, Jiancheng Xue wrote:
>> + uart0: serial at 12100000 {
>> + compatible = "arm,pl011", "arm,primecell";
>> + reg = <0x12100000 0x1000>;
>> + interrupts = <0 4 4>;
>
> Should the last digit there be IRQ_TYPE_LEVEL_HIGH (and same for the
> other interrupts= after this?)
>
> Thanks.
>
I'll include <dt-bindings/interrupt-controller/arm-gic.h> and use
IRQ_TYPE_LEVEL_HIGH instead. The interrupts specifier will be wrote
like this "interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;".
Thank you.
Jiancheng
next prev parent reply other threads:[~2016-01-11 2:08 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 2:16 [PATCH v5 0/6] ARM: hisi: Add initial support including clock driver for Hi3519 soc Jiancheng Xue
2016-01-08 2:16 ` Jiancheng Xue
2016-01-08 2:16 ` Jiancheng Xue
2016-01-08 2:16 ` [PATCH v5 1/6] clk: hisilicon: add CRG driver for hi3519 soc Jiancheng Xue
2016-01-08 2:16 ` Jiancheng Xue
2016-01-08 2:16 ` Jiancheng Xue
2016-01-09 6:24 ` kbuild test robot
2016-01-09 6:24 ` kbuild test robot
2016-01-09 6:24 ` kbuild test robot
2016-01-09 15:33 ` Rob Herring
2016-01-09 15:33 ` Rob Herring
2016-01-11 3:47 ` xuejiancheng
2016-01-11 3:47 ` xuejiancheng
2016-01-11 3:47 ` xuejiancheng
2016-01-12 22:12 ` Stephen Boyd
2016-01-12 22:12 ` Stephen Boyd
2016-01-13 3:03 ` xuejiancheng
2016-01-13 3:03 ` xuejiancheng
2016-01-13 3:03 ` xuejiancheng
2016-01-13 18:57 ` Michael Turquette
2016-01-13 18:57 ` Michael Turquette
2016-01-13 18:57 ` Michael Turquette
2016-01-14 13:16 ` xuejiancheng
2016-01-14 13:16 ` xuejiancheng
2016-01-14 13:16 ` xuejiancheng
2016-01-15 7:57 ` xuejiancheng
2016-01-15 7:57 ` xuejiancheng
2016-01-15 7:57 ` xuejiancheng
2016-01-19 18:20 ` Rob Herring
2016-01-19 18:20 ` Rob Herring
2016-01-19 18:20 ` Rob Herring
2016-01-19 18:20 ` Rob Herring
2016-01-20 6:38 ` Tomeu Vizoso
2016-01-20 6:38 ` Tomeu Vizoso
2016-01-20 6:38 ` Tomeu Vizoso
2016-01-20 6:38 ` Tomeu Vizoso
2016-01-22 8:50 ` xuejiancheng
2016-01-22 8:50 ` xuejiancheng
2016-01-22 8:50 ` xuejiancheng
2016-01-22 8:50 ` xuejiancheng
2016-01-22 9:55 ` Tomeu Vizoso
2016-01-22 9:55 ` Tomeu Vizoso
2016-01-22 9:55 ` Tomeu Vizoso
2016-01-22 9:55 ` Tomeu Vizoso
2016-01-08 2:16 ` [PATCH v5 2/6] ARM: hisi: add compatible string for Hi3519 soc Jiancheng Xue
2016-01-08 2:16 ` Jiancheng Xue
2016-01-08 2:16 ` Jiancheng Xue
2016-01-08 2:16 ` [PATCH v5 3/6] ARM: config: hisi: enable CONFIG_RESET_CONTROLLER Jiancheng Xue
2016-01-08 2:16 ` Jiancheng Xue
2016-01-08 2:16 ` Jiancheng Xue
2016-01-08 2:16 ` [PATCH v5 4/6] ARM: debug: add hi3519 debug uart Jiancheng Xue
2016-01-08 2:16 ` Jiancheng Xue
2016-01-08 2:16 ` Jiancheng Xue
2016-01-08 15:08 ` Russell King - ARM Linux
2016-01-08 15:08 ` Russell King - ARM Linux
2016-01-11 2:32 ` xuejiancheng
2016-01-11 2:32 ` xuejiancheng
2016-01-11 2:32 ` xuejiancheng
2016-01-08 2:16 ` [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Jiancheng Xue
2016-01-08 2:16 ` Jiancheng Xue
2016-01-08 2:16 ` Jiancheng Xue
2016-01-08 21:04 ` Rob Herring
2016-01-08 21:04 ` Rob Herring
2016-01-11 5:48 ` Lee Jones
2016-01-11 5:48 ` Lee Jones
2016-01-11 7:50 ` xuejiancheng
2016-01-11 7:50 ` xuejiancheng
2016-01-11 7:50 ` xuejiancheng
2016-01-11 8:55 ` Lee Jones
2016-01-11 8:55 ` Lee Jones
2016-01-12 1:35 ` xuejiancheng
2016-01-12 1:35 ` xuejiancheng
2016-01-12 1:35 ` xuejiancheng
2016-01-12 7:41 ` Lee Jones
2016-01-12 7:41 ` Lee Jones
2016-01-12 8:17 ` xuejiancheng
2016-01-12 8:17 ` xuejiancheng
2016-01-12 8:17 ` xuejiancheng
2016-01-12 8:39 ` Lee Jones
2016-01-12 8:39 ` Lee Jones
2016-01-12 9:28 ` xuejiancheng
2016-01-12 9:28 ` xuejiancheng
2016-01-12 9:28 ` xuejiancheng
2016-01-12 22:51 ` Arnd Bergmann
2016-01-12 22:51 ` Arnd Bergmann
2016-01-13 9:08 ` xuejiancheng
2016-01-13 9:08 ` xuejiancheng
2016-01-13 9:08 ` xuejiancheng
2016-01-13 10:00 ` Arnd Bergmann
2016-01-13 10:00 ` Arnd Bergmann
2016-01-25 14:26 ` Lee Jones
2016-01-25 14:26 ` Lee Jones
2016-01-25 14:45 ` Arnd Bergmann
2016-01-25 14:45 ` Arnd Bergmann
2016-01-08 2:16 ` [PATCH v5 6/6] ARM: dts: add dts files for Hi3519 Jiancheng Xue
2016-01-08 2:16 ` Jiancheng Xue
2016-01-08 2:16 ` Jiancheng Xue
2016-01-08 15:10 ` Russell King - ARM Linux
2016-01-08 15:10 ` Russell King - ARM Linux
2016-01-08 15:10 ` Russell King - ARM Linux
2016-01-11 2:05 ` xuejiancheng [this message]
2016-01-11 2:05 ` xuejiancheng
2016-01-11 2:05 ` xuejiancheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56930E05.1050009@huawei.com \
--to=xuejiancheng@huawei.com \
--cc=arnd@arndb.de \
--cc=bintian.wang@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gaofei@hisilicon.com \
--cc=haojian.zhuang@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=ml.yang@hisilicon.com \
--cc=mturquette@baylibre.com \
--cc=olof@lixom.net \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=suwenping@hisilicon.com \
--cc=xuejiancheng@hisilicon.com \
--cc=xuwei5@hisilicon.com \
--cc=yanghongwei@hisilicon.com \
--cc=yanhaifeng@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
--cc=zhangzhenxing@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.