From: Maxime Coquelin <maxime.coquelin@st.com>
To: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Bruno Herrera" <bruherrera@gmail.com>,
"Patrice CHOTARD" <patrice.chotard@st.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Andreas Färber" <afaerber@suse.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support
Date: Mon, 1 Feb 2016 13:09:15 +0100 [thread overview]
Message-ID: <56AF4AEB.40109@st.com> (raw)
In-Reply-To: <CALszF6DTpcU8jFwA0HL8LpkxfO5ZOdFmpHBUxA7WfYgAj_uFhg@mail.gmail.com>
On 02/01/2016 11:39 AM, Maxime Coquelin wrote:
> 2016-02-01 11:21 GMT+01:00 Arnd Bergmann <arnd@arndb.de>:
>> On Wednesday 27 January 2016 14:16:32 Linus Walleij wrote:
>>> On Thu, Jan 14, 2016 at 1:16 PM, Maxime Coquelin
>>> <mcoquelin.stm32@gmail.com> wrote:
>>>
>>>> This patch adds pinctrl and GPIO support to STMicroelectronic's STM32
>>>> family of MCUs.
>>>>
>>>> While it only supports STM32F429 for now, it has been designed to enable
>>>> support of other MCUs of the family (e.g. STM32F746).
>>>>
>>>> Acked-by: Patrice Chotard <patrice.chotard@st.com>
>>>> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>>> This patch applied for kernel v4.6.
>>>
>> This breaks the kernel build, please revert:
>>
>> drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error: dt-bindings/pinctrl/pinctrl-stm32.h: No such file or directory
> Right, I missed to notify this dependency to Linus, sorry about that.
> This dependency is no more needed, so I could just move the macros to
> the driver side.
>
> Note that I also noticed a breakage at build time due to field
> renaming in gpio_chip structure (dev -> parent).
>
> I propose to rebase the series and move the defines into the driver.
> Is it ok for you?
>
I have rebased the series, taking care to fix the mentioned problems.
Linus, do you confirm you will revert STM32 pinctrl patches from your tree?
Thanks,
Maxime
WARNING: multiple messages have this Message-ID (diff)
From: maxime.coquelin@st.com (Maxime Coquelin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support
Date: Mon, 1 Feb 2016 13:09:15 +0100 [thread overview]
Message-ID: <56AF4AEB.40109@st.com> (raw)
In-Reply-To: <CALszF6DTpcU8jFwA0HL8LpkxfO5ZOdFmpHBUxA7WfYgAj_uFhg@mail.gmail.com>
On 02/01/2016 11:39 AM, Maxime Coquelin wrote:
> 2016-02-01 11:21 GMT+01:00 Arnd Bergmann <arnd@arndb.de>:
>> On Wednesday 27 January 2016 14:16:32 Linus Walleij wrote:
>>> On Thu, Jan 14, 2016 at 1:16 PM, Maxime Coquelin
>>> <mcoquelin.stm32@gmail.com> wrote:
>>>
>>>> This patch adds pinctrl and GPIO support to STMicroelectronic's STM32
>>>> family of MCUs.
>>>>
>>>> While it only supports STM32F429 for now, it has been designed to enable
>>>> support of other MCUs of the family (e.g. STM32F746).
>>>>
>>>> Acked-by: Patrice Chotard <patrice.chotard@st.com>
>>>> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>>> This patch applied for kernel v4.6.
>>>
>> This breaks the kernel build, please revert:
>>
>> drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error: dt-bindings/pinctrl/pinctrl-stm32.h: No such file or directory
> Right, I missed to notify this dependency to Linus, sorry about that.
> This dependency is no more needed, so I could just move the macros to
> the driver side.
>
> Note that I also noticed a breakage at build time due to field
> renaming in gpio_chip structure (dev -> parent).
>
> I propose to rebase the series and move the defines into the driver.
> Is it ok for you?
>
I have rebased the series, taking care to fix the mentioned problems.
Linus, do you confirm you will revert STM32 pinctrl patches from your tree?
Thanks,
Maxime
next prev parent reply other threads:[~2016-02-01 12:09 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 12:16 [PATCH v4 0/9] Add STM32 pinctrl/GPIO driver Maxime Coquelin
2016-01-14 12:16 ` Maxime Coquelin
2016-01-14 12:16 ` [PATCH v4 1/9] ARM: Kconfig: Introduce MACH_STM32F429 flag Maxime Coquelin
2016-01-14 12:16 ` Maxime Coquelin
2016-01-14 12:16 ` [PATCH v4 2/9] Documentation: dt-bindings: Document STM32 pinctrl driver DT bindings Maxime Coquelin
2016-01-14 12:16 ` Maxime Coquelin
2016-01-15 2:59 ` Rob Herring
2016-01-15 2:59 ` Rob Herring
2016-01-27 13:18 ` Linus Walleij
2016-01-27 13:18 ` Linus Walleij
2016-01-14 12:16 ` [PATCH v4 3/9] includes: dt-bindings: Add STM32F429 pinctrl " Maxime Coquelin
2016-01-14 12:16 ` Maxime Coquelin
2016-01-14 12:16 ` [PATCH v4 4/9] pinctrl: Add STM32 MCUs support Maxime Coquelin
2016-01-14 12:16 ` Maxime Coquelin
[not found] ` <1452773795-24216-5-git-send-email-mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-27 13:16 ` Linus Walleij
2016-01-27 13:16 ` Linus Walleij
2016-01-27 13:16 ` Linus Walleij
2016-02-01 10:21 ` Arnd Bergmann
2016-02-01 10:21 ` Arnd Bergmann
2016-02-01 10:39 ` Maxime Coquelin
2016-02-01 10:39 ` Maxime Coquelin
2016-02-01 12:09 ` Maxime Coquelin [this message]
2016-02-01 12:09 ` Maxime Coquelin
2016-02-13 14:48 ` Linus Walleij
2016-02-13 14:48 ` Linus Walleij
2016-02-13 17:14 ` Maxime Coquelin
2016-02-13 17:14 ` Maxime Coquelin
2016-01-14 12:16 ` [PATCH v4 5/9] ARM: mach-stm32: Select pinctrl Maxime Coquelin
2016-01-14 12:16 ` Maxime Coquelin
2016-01-14 12:16 ` [PATCH v4 6/9] ARM: dts: Add pinctrl node to STM32F429 Maxime Coquelin
2016-01-14 12:16 ` Maxime Coquelin
2016-01-14 12:16 ` [PATCH v4 7/9] ARM: dts: Add USART1 pin config to STM32F429 boards Maxime Coquelin
2016-01-14 12:16 ` Maxime Coquelin
2016-01-14 12:16 ` [PATCH v4 8/9] ARM: dts: Add leds support " Maxime Coquelin
2016-01-14 12:16 ` Maxime Coquelin
[not found] ` <1452773795-24216-1-git-send-email-mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-14 12:16 ` [PATCH v4 9/9] ARM: config: Enable GPIO Led driver in stm32_defconfig Maxime Coquelin
2016-01-14 12:16 ` Maxime Coquelin
2016-01-14 12:16 ` Maxime Coquelin
2016-01-27 13:20 ` [PATCH v4 0/9] Add STM32 pinctrl/GPIO driver Linus Walleij
2016-01-27 13:20 ` Linus Walleij
[not found] ` <CACRpkdYGQ1xObWfka2CN9au6YMGhpu4qcTZpu72bzuJjO38tog-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-27 17:00 ` Maxime Coquelin
2016-01-27 17:00 ` Maxime Coquelin
2016-01-27 17:00 ` Maxime Coquelin
2016-01-27 20:59 ` Maxime Coquelin
2016-01-27 20:59 ` Maxime Coquelin
2016-02-05 22:50 ` Linus Walleij
2016-02-05 22:50 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF4AEB.40109@st.com \
--to=maxime.coquelin@st.com \
--cc=afaerber@suse.de \
--cc=arnd@arndb.de \
--cc=bruherrera@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=patrice.chotard@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.