All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: Eric Auger <eric.auger@linaro.org>,
	dmaengine@vger.kernel.org, marc.zyngier@arm.com,
	mark.rutland@arm.com, timur@codeaurora.org,
	devicetree@vger.kernel.org, cov@codeaurora.org,
	vinod.koul@intel.com, jcm@redhat.com
Cc: shankerd@codeaurora.org, vikrams@codeaurora.org,
	agross@codeaurora.org, arnd@arndb.de,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Baptiste Reynal <b.reynal@virtualopensystems.com>
Subject: Re: [PATCH V13 09/10] vfio, platform: add support for ACPI while detecting the reset driver
Date: Mon, 1 Feb 2016 11:16:52 -0500	[thread overview]
Message-ID: <56AF84F4.2080809@codeaurora.org> (raw)
In-Reply-To: <56AF82FA.7000303@linaro.org>

On 2/1/2016 11:08 AM, Eric Auger wrote:
>> For ACPI systems, ACPI HID needs to match and compat in the registered
>> > reset
>> > driver needs to match for ACPI reset driver loading to work.
> Don't really get the sentence. For ACPI systems, a registered reset
> function is selected if its associated ACPI HID matches the device ACPI HID?

Old commit message. I did an internal review before posting the patch. The first
version of the patch was a hack. I simplified the code but forgot to update the 
commit message.

Now, the rule is simple.

- ACPI HID needs match for ACPI systems
- DT compat needs to match for OF systems

as expected. I'll rephrase for the next version.

>> > 
>> > For OF based systems, DT compatible string needs to match and compat in the
>> > registered reset driver needs to match for DT reset driver loading to work.
> same here
> 
> I added Baptiste who is vfio platform driver sub-system maintainer.

Thanks, we should ask Baptiste to get his email into the Maintainer file list.

> 
> On my side I tested with of amd xgbe and I don't observe any regression.
> 
> Best Regards

Can I add your tested by?

-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V13 09/10] vfio, platform: add support for ACPI while detecting the reset driver
Date: Mon, 1 Feb 2016 11:16:52 -0500	[thread overview]
Message-ID: <56AF84F4.2080809@codeaurora.org> (raw)
In-Reply-To: <56AF82FA.7000303@linaro.org>

On 2/1/2016 11:08 AM, Eric Auger wrote:
>> For ACPI systems, ACPI HID needs to match and compat in the registered
>> > reset
>> > driver needs to match for ACPI reset driver loading to work.
> Don't really get the sentence. For ACPI systems, a registered reset
> function is selected if its associated ACPI HID matches the device ACPI HID?

Old commit message. I did an internal review before posting the patch. The first
version of the patch was a hack. I simplified the code but forgot to update the 
commit message.

Now, the rule is simple.

- ACPI HID needs match for ACPI systems
- DT compat needs to match for OF systems

as expected. I'll rephrase for the next version.

>> > 
>> > For OF based systems, DT compatible string needs to match and compat in the
>> > registered reset driver needs to match for DT reset driver loading to work.
> same here
> 
> I added Baptiste who is vfio platform driver sub-system maintainer.

Thanks, we should ask Baptiste to get his email into the Maintainer file list.

> 
> On my side I tested with of amd xgbe and I don't observe any regression.
> 
> Best Regards

Can I add your tested by?

-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

  reply	other threads:[~2016-02-01 16:16 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 22:35 [PATCH V13 00/10] dma: add Qualcomm Technologies HIDMA driver Sinan Kaya
2016-01-29 22:35 ` Sinan Kaya
2016-01-29 22:35 ` [PATCH V13 01/10] dma: qcom_bam_dma: move to qcom directory Sinan Kaya
2016-01-29 22:35   ` Sinan Kaya
2016-01-29 22:35 ` [PATCH V13 02/10] dma: hidma: Add Device Tree binding Sinan Kaya
2016-01-29 22:35   ` Sinan Kaya
2016-01-29 22:35   ` Sinan Kaya
2016-01-29 22:35 ` [PATCH V13 03/10] dma: add Qualcomm Technologies HIDMA management driver Sinan Kaya
2016-01-29 22:35   ` Sinan Kaya
2016-01-29 22:35 ` [PATCH V13 04/10] dma: add Qualcomm Technologies HIDMA channel driver Sinan Kaya
2016-01-29 22:35   ` Sinan Kaya
2016-01-29 22:35   ` Sinan Kaya
2016-01-29 22:35 ` [PATCH V13 05/10] dma: qcom_hidma: implement lower level hardware interface Sinan Kaya
2016-01-29 22:35   ` Sinan Kaya
2016-01-29 22:35 ` [PATCH V13 06/10] dma: qcom_hidma: add debugfs hooks Sinan Kaya
2016-01-29 22:35   ` Sinan Kaya
2016-01-29 22:35 ` [PATCH V13 07/10] dma: qcom_hidma: add support for object hierarchy Sinan Kaya
2016-01-29 22:35   ` Sinan Kaya
2016-01-29 22:35 ` [PATCH V13 08/10] dma: qcom_hidma: read the channel id from HW Sinan Kaya
2016-01-29 22:35   ` Sinan Kaya
2016-02-01 15:14   ` Rob Herring
2016-02-01 15:14     ` Rob Herring
2016-02-03 18:32     ` Sinan Kaya
2016-02-03 18:32       ` Sinan Kaya
2016-02-01 15:35   ` Mark Rutland
2016-02-01 15:35     ` Mark Rutland
2016-02-01 15:46     ` Sinan Kaya
2016-02-01 15:46       ` Sinan Kaya
2016-02-03 18:32     ` Sinan Kaya
2016-02-03 18:32       ` Sinan Kaya
2016-02-03 18:32       ` Sinan Kaya
2016-02-03 18:36       ` Mark Rutland
2016-02-03 18:36         ` Mark Rutland
2016-02-03 18:46         ` Sinan Kaya
2016-02-03 18:46           ` Sinan Kaya
2016-02-07 15:04         ` Sinan Kaya
2016-02-07 15:04           ` Sinan Kaya
2016-02-07 15:04           ` Sinan Kaya
2016-02-09 21:01           ` Sinan Kaya
2016-02-09 21:01             ` Sinan Kaya
2016-01-29 22:35 ` [PATCH V13 09/10] vfio, platform: add support for ACPI while detecting the reset driver Sinan Kaya
2016-01-29 22:35   ` Sinan Kaya
2016-01-30 12:52   ` kbuild test robot
2016-01-30 12:52     ` kbuild test robot
2016-01-30 12:52     ` kbuild test robot
2016-01-31 13:53   ` Sinan Kaya
2016-01-31 13:53     ` Sinan Kaya
2016-01-31 13:53     ` Sinan Kaya
2016-02-01 16:08   ` Eric Auger
2016-02-01 16:08     ` Eric Auger
2016-02-01 16:16     ` Sinan Kaya [this message]
2016-02-01 16:16       ` Sinan Kaya
2016-02-01 16:29       ` Eric Auger
2016-02-01 16:29         ` Eric Auger
2016-02-01 16:44         ` Sinan Kaya
2016-02-01 16:44           ` Sinan Kaya
2016-02-01 16:49           ` Timur Tabi
2016-02-01 16:49             ` Timur Tabi
2016-02-01 16:56             ` Sinan Kaya
2016-02-01 16:56               ` Sinan Kaya
2016-02-03 18:38         ` Sinan Kaya
2016-02-03 18:38           ` Sinan Kaya
2016-01-29 22:35 ` [PATCH V13 10/10] vfio, platform: add QTI HIDMA " Sinan Kaya
2016-01-29 22:35   ` Sinan Kaya
2016-02-01 15:41   ` Eric Auger
2016-02-01 15:41     ` Eric Auger
2016-02-01 15:41     ` Eric Auger
2016-02-01 15:51     ` Sinan Kaya
2016-02-01 15:51       ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56AF84F4.2080809@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=agross@codeaurora.org \
    --cc=arnd@arndb.de \
    --cc=b.reynal@virtualopensystems.com \
    --cc=cov@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=eric.auger@linaro.org \
    --cc=jcm@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=shankerd@codeaurora.org \
    --cc=timur@codeaurora.org \
    --cc=vikrams@codeaurora.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.