All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laura Abbott <labbott@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Jesper Dangaard Brouer <brouer@redhat.com>,
	Laura Abbott <labbott@fedoraproject.org>,
	linux-mm@kvack.org,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled
Date: Wed, 3 Feb 2016 14:30:09 -0800	[thread overview]
Message-ID: <56B27F71.2000700@redhat.com> (raw)
In-Reply-To: <1454537757-3760706-1-git-send-email-arnd@arndb.de>

On 02/03/2016 02:15 PM, Arnd Bergmann wrote:
> The change to move the pagealloc logic broke the slab allocator
> check when it's disabled at compile time:
>
> mm/slab.c: In function 'is_debug_pagealloc_cache':
> mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration]
>
> This adds an inline helper to get it to work again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code")
> ---
>   include/linux/mm.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 5d86eb2e8584..90d600ce56ad 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable)
>   extern bool kernel_page_present(struct page *page);
>   #endif /* CONFIG_HIBERNATION */
>   #else
> +static inline bool debug_pagealloc_enabled(void) { return 0; }
>   static inline void
>   kernel_map_pages(struct page *page, int numpages, int enable) {}
>   #ifdef CONFIG_HIBERNATION
>

I believe this should be fixed with http://article.gmane.org/gmane.linux.kernel.mm/145655

WARNING: multiple messages have this Message-ID (diff)
From: Laura Abbott <labbott@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Jesper Dangaard Brouer <brouer@redhat.com>,
	Laura Abbott <labbott@fedoraproject.org>,
	linux-mm@kvack.org,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled
Date: Wed, 3 Feb 2016 14:30:09 -0800	[thread overview]
Message-ID: <56B27F71.2000700@redhat.com> (raw)
In-Reply-To: <1454537757-3760706-1-git-send-email-arnd@arndb.de>

On 02/03/2016 02:15 PM, Arnd Bergmann wrote:
> The change to move the pagealloc logic broke the slab allocator
> check when it's disabled at compile time:
>
> mm/slab.c: In function 'is_debug_pagealloc_cache':
> mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration]
>
> This adds an inline helper to get it to work again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code")
> ---
>   include/linux/mm.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 5d86eb2e8584..90d600ce56ad 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable)
>   extern bool kernel_page_present(struct page *page);
>   #endif /* CONFIG_HIBERNATION */
>   #else
> +static inline bool debug_pagealloc_enabled(void) { return 0; }
>   static inline void
>   kernel_map_pages(struct page *page, int numpages, int enable) {}
>   #ifdef CONFIG_HIBERNATION
>

I believe this should be fixed with http://article.gmane.org/gmane.linux.kernel.mm/145655

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: labbott@redhat.com (Laura Abbott)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled
Date: Wed, 3 Feb 2016 14:30:09 -0800	[thread overview]
Message-ID: <56B27F71.2000700@redhat.com> (raw)
In-Reply-To: <1454537757-3760706-1-git-send-email-arnd@arndb.de>

On 02/03/2016 02:15 PM, Arnd Bergmann wrote:
> The change to move the pagealloc logic broke the slab allocator
> check when it's disabled at compile time:
>
> mm/slab.c: In function 'is_debug_pagealloc_cache':
> mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration]
>
> This adds an inline helper to get it to work again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code")
> ---
>   include/linux/mm.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 5d86eb2e8584..90d600ce56ad 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable)
>   extern bool kernel_page_present(struct page *page);
>   #endif /* CONFIG_HIBERNATION */
>   #else
> +static inline bool debug_pagealloc_enabled(void) { return 0; }
>   static inline void
>   kernel_map_pages(struct page *page, int numpages, int enable) {}
>   #ifdef CONFIG_HIBERNATION
>

I believe this should be fixed with http://article.gmane.org/gmane.linux.kernel.mm/145655

  reply	other threads:[~2016-02-03 22:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 22:15 [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled Arnd Bergmann
2016-02-03 22:15 ` Arnd Bergmann
2016-02-03 22:15 ` Arnd Bergmann
2016-02-03 22:30 ` Laura Abbott [this message]
2016-02-03 22:30   ` Laura Abbott
2016-02-03 22:30   ` Laura Abbott
2016-02-03 22:51   ` Arnd Bergmann
2016-02-03 22:51     ` Arnd Bergmann
2016-02-03 22:51     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B27F71.2000700@redhat.com \
    --to=labbott@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=brouer@redhat.com \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=labbott@fedoraproject.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.