* [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled
@ 2016-02-03 22:15 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2016-02-03 22:15 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-arm-kernel, Arnd Bergmann, Joonsoo Kim, Christoph Lameter,
Pekka Enberg, David Rientjes, Jesper Dangaard Brouer,
Laura Abbott, linux-mm, Kirill A. Shutemov, Michal Hocko,
Vlastimil Babka, linux-kernel
The change to move the pagealloc logic broke the slab allocator
check when it's disabled at compile time:
mm/slab.c: In function 'is_debug_pagealloc_cache':
mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration]
This adds an inline helper to get it to work again.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code")
---
include/linux/mm.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 5d86eb2e8584..90d600ce56ad 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable)
extern bool kernel_page_present(struct page *page);
#endif /* CONFIG_HIBERNATION */
#else
+static inline bool debug_pagealloc_enabled(void) { return 0; }
static inline void
kernel_map_pages(struct page *page, int numpages, int enable) {}
#ifdef CONFIG_HIBERNATION
--
2.7.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled
@ 2016-02-03 22:15 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2016-02-03 22:15 UTC (permalink / raw)
To: linux-arm-kernel
The change to move the pagealloc logic broke the slab allocator
check when it's disabled at compile time:
mm/slab.c: In function 'is_debug_pagealloc_cache':
mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration]
This adds an inline helper to get it to work again.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code")
---
include/linux/mm.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 5d86eb2e8584..90d600ce56ad 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable)
extern bool kernel_page_present(struct page *page);
#endif /* CONFIG_HIBERNATION */
#else
+static inline bool debug_pagealloc_enabled(void) { return 0; }
static inline void
kernel_map_pages(struct page *page, int numpages, int enable) {}
#ifdef CONFIG_HIBERNATION
--
2.7.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled
@ 2016-02-03 22:15 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2016-02-03 22:15 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-arm-kernel, Arnd Bergmann, Joonsoo Kim, Christoph Lameter,
Pekka Enberg, David Rientjes, Jesper Dangaard Brouer,
Laura Abbott, linux-mm, Kirill A. Shutemov, Michal Hocko,
Vlastimil Babka, linux-kernel
The change to move the pagealloc logic broke the slab allocator
check when it's disabled at compile time:
mm/slab.c: In function 'is_debug_pagealloc_cache':
mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration]
This adds an inline helper to get it to work again.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code")
---
include/linux/mm.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 5d86eb2e8584..90d600ce56ad 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable)
extern bool kernel_page_present(struct page *page);
#endif /* CONFIG_HIBERNATION */
#else
+static inline bool debug_pagealloc_enabled(void) { return 0; }
static inline void
kernel_map_pages(struct page *page, int numpages, int enable) {}
#ifdef CONFIG_HIBERNATION
--
2.7.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled
2016-02-03 22:15 ` Arnd Bergmann
(?)
@ 2016-02-03 22:30 ` Laura Abbott
-1 siblings, 0 replies; 9+ messages in thread
From: Laura Abbott @ 2016-02-03 22:30 UTC (permalink / raw)
To: Arnd Bergmann, Andrew Morton
Cc: linux-arm-kernel, Joonsoo Kim, Christoph Lameter, Pekka Enberg,
David Rientjes, Jesper Dangaard Brouer, Laura Abbott, linux-mm,
Kirill A. Shutemov, Michal Hocko, Vlastimil Babka, linux-kernel
On 02/03/2016 02:15 PM, Arnd Bergmann wrote:
> The change to move the pagealloc logic broke the slab allocator
> check when it's disabled at compile time:
>
> mm/slab.c: In function 'is_debug_pagealloc_cache':
> mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration]
>
> This adds an inline helper to get it to work again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code")
> ---
> include/linux/mm.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 5d86eb2e8584..90d600ce56ad 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable)
> extern bool kernel_page_present(struct page *page);
> #endif /* CONFIG_HIBERNATION */
> #else
> +static inline bool debug_pagealloc_enabled(void) { return 0; }
> static inline void
> kernel_map_pages(struct page *page, int numpages, int enable) {}
> #ifdef CONFIG_HIBERNATION
>
I believe this should be fixed with http://article.gmane.org/gmane.linux.kernel.mm/145655
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled
@ 2016-02-03 22:30 ` Laura Abbott
0 siblings, 0 replies; 9+ messages in thread
From: Laura Abbott @ 2016-02-03 22:30 UTC (permalink / raw)
To: linux-arm-kernel
On 02/03/2016 02:15 PM, Arnd Bergmann wrote:
> The change to move the pagealloc logic broke the slab allocator
> check when it's disabled at compile time:
>
> mm/slab.c: In function 'is_debug_pagealloc_cache':
> mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration]
>
> This adds an inline helper to get it to work again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code")
> ---
> include/linux/mm.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 5d86eb2e8584..90d600ce56ad 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable)
> extern bool kernel_page_present(struct page *page);
> #endif /* CONFIG_HIBERNATION */
> #else
> +static inline bool debug_pagealloc_enabled(void) { return 0; }
> static inline void
> kernel_map_pages(struct page *page, int numpages, int enable) {}
> #ifdef CONFIG_HIBERNATION
>
I believe this should be fixed with http://article.gmane.org/gmane.linux.kernel.mm/145655
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled
@ 2016-02-03 22:30 ` Laura Abbott
0 siblings, 0 replies; 9+ messages in thread
From: Laura Abbott @ 2016-02-03 22:30 UTC (permalink / raw)
To: Arnd Bergmann, Andrew Morton
Cc: linux-arm-kernel, Joonsoo Kim, Christoph Lameter, Pekka Enberg,
David Rientjes, Jesper Dangaard Brouer, Laura Abbott, linux-mm,
Kirill A. Shutemov, Michal Hocko, Vlastimil Babka, linux-kernel
On 02/03/2016 02:15 PM, Arnd Bergmann wrote:
> The change to move the pagealloc logic broke the slab allocator
> check when it's disabled at compile time:
>
> mm/slab.c: In function 'is_debug_pagealloc_cache':
> mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration]
>
> This adds an inline helper to get it to work again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code")
> ---
> include/linux/mm.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 5d86eb2e8584..90d600ce56ad 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable)
> extern bool kernel_page_present(struct page *page);
> #endif /* CONFIG_HIBERNATION */
> #else
> +static inline bool debug_pagealloc_enabled(void) { return 0; }
> static inline void
> kernel_map_pages(struct page *page, int numpages, int enable) {}
> #ifdef CONFIG_HIBERNATION
>
I believe this should be fixed with http://article.gmane.org/gmane.linux.kernel.mm/145655
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled
2016-02-03 22:30 ` Laura Abbott
(?)
@ 2016-02-03 22:51 ` Arnd Bergmann
-1 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2016-02-03 22:51 UTC (permalink / raw)
To: Laura Abbott
Cc: Andrew Morton, linux-arm-kernel, Joonsoo Kim, Christoph Lameter,
Pekka Enberg, David Rientjes, Jesper Dangaard Brouer,
Laura Abbott, linux-mm, Kirill A. Shutemov, Michal Hocko,
Vlastimil Babka, linux-kernel
On Wednesday 03 February 2016 14:30:09 Laura Abbott wrote:
> On 02/03/2016 02:15 PM, Arnd Bergmann wrote:
> > The change to move the pagealloc logic broke the slab allocator
> > check when it's disabled at compile time:
> >
> > mm/slab.c: In function 'is_debug_pagealloc_cache':
> > mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration]
> >
> > This adds an inline helper to get it to work again.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code")
> > ---
> > include/linux/mm.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > index 5d86eb2e8584..90d600ce56ad 100644
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> > @@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable)
> > extern bool kernel_page_present(struct page *page);
> > #endif /* CONFIG_HIBERNATION */
> > #else
> > +static inline bool debug_pagealloc_enabled(void) { return 0; }
> > static inline void
> > kernel_map_pages(struct page *page, int numpages, int enable) {}
> > #ifdef CONFIG_HIBERNATION
> >
>
> I believe this should be fixed with http://article.gmane.org/gmane.linux.kernel.mm/145655
Yes, Christian's version looks nicer too (correct return type).
Thanks,
Arnd
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled
@ 2016-02-03 22:51 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2016-02-03 22:51 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 03 February 2016 14:30:09 Laura Abbott wrote:
> On 02/03/2016 02:15 PM, Arnd Bergmann wrote:
> > The change to move the pagealloc logic broke the slab allocator
> > check when it's disabled at compile time:
> >
> > mm/slab.c: In function 'is_debug_pagealloc_cache':
> > mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration]
> >
> > This adds an inline helper to get it to work again.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code")
> > ---
> > include/linux/mm.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > index 5d86eb2e8584..90d600ce56ad 100644
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> > @@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable)
> > extern bool kernel_page_present(struct page *page);
> > #endif /* CONFIG_HIBERNATION */
> > #else
> > +static inline bool debug_pagealloc_enabled(void) { return 0; }
> > static inline void
> > kernel_map_pages(struct page *page, int numpages, int enable) {}
> > #ifdef CONFIG_HIBERNATION
> >
>
> I believe this should be fixed with http://article.gmane.org/gmane.linux.kernel.mm/145655
Yes, Christian's version looks nicer too (correct return type).
Thanks,
Arnd
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled
@ 2016-02-03 22:51 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2016-02-03 22:51 UTC (permalink / raw)
To: Laura Abbott
Cc: Andrew Morton, linux-arm-kernel, Joonsoo Kim, Christoph Lameter,
Pekka Enberg, David Rientjes, Jesper Dangaard Brouer,
Laura Abbott, linux-mm, Kirill A. Shutemov, Michal Hocko,
Vlastimil Babka, linux-kernel
On Wednesday 03 February 2016 14:30:09 Laura Abbott wrote:
> On 02/03/2016 02:15 PM, Arnd Bergmann wrote:
> > The change to move the pagealloc logic broke the slab allocator
> > check when it's disabled at compile time:
> >
> > mm/slab.c: In function 'is_debug_pagealloc_cache':
> > mm/slab.c:1608:29: error: implicit declaration of function 'debug_pagealloc_enabled' [-Werror=implicit-function-declaration]
> >
> > This adds an inline helper to get it to work again.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 0a244aea1a61 ("mm/slab: clean up DEBUG_PAGEALLOC processing code")
> > ---
> > include/linux/mm.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > index 5d86eb2e8584..90d600ce56ad 100644
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> > @@ -2242,6 +2242,7 @@ kernel_map_pages(struct page *page, int numpages, int enable)
> > extern bool kernel_page_present(struct page *page);
> > #endif /* CONFIG_HIBERNATION */
> > #else
> > +static inline bool debug_pagealloc_enabled(void) { return 0; }
> > static inline void
> > kernel_map_pages(struct page *page, int numpages, int enable) {}
> > #ifdef CONFIG_HIBERNATION
> >
>
> I believe this should be fixed with http://article.gmane.org/gmane.linux.kernel.mm/145655
Yes, Christian's version looks nicer too (correct return type).
Thanks,
Arnd
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-02-03 22:58 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-03 22:15 [PATCH] mm/debug-pagealloc: add missing debug_pagealloc_enabled Arnd Bergmann
2016-02-03 22:15 ` Arnd Bergmann
2016-02-03 22:15 ` Arnd Bergmann
2016-02-03 22:30 ` Laura Abbott
2016-02-03 22:30 ` Laura Abbott
2016-02-03 22:30 ` Laura Abbott
2016-02-03 22:51 ` Arnd Bergmann
2016-02-03 22:51 ` Arnd Bergmann
2016-02-03 22:51 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.