All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <chengang@emindsoft.com.cn>
To: SeongJae Park <sj38.park@gmail.com>
Cc: trivial@kernel.org, akpm@linux-foundation.org, vbabka@suse.cz,
	rientjes@google.com, linux-kernel@vger.kernel.org,
	mhocko@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net,
	vdavydov@virtuozzo.com, dan.j.williams@intel.com,
	linux-mm@kvack.org
Subject: Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
Date: Thu, 25 Feb 2016 22:12:06 +0800	[thread overview]
Message-ID: <56CF0BB6.2040102@emindsoft.com.cn> (raw)
In-Reply-To: <alpine.DEB.2.10.1602250952030.16296@hxeon>

On 2/25/16 09:01, SeongJae Park wrote:
> 
> Well, the indentation for the comment and the '\' looks odd to me.  If
> the 80 column limit is necessary, how about moving the comment to above
> line of the macro as below?  Because comments are usually placed before
> the target they are explaining, I believe this may better to read.
> 
>  -#define __GFP_MOVABLE        ((__force gfp_t)___GFP_MOVABLE)  /* ZONE_MOVABLE allowed */
>  +/* ZONE_MOVABLE allowed */
>  +#define __GFP_MOVABLE        ((__force gfp_t)___GFP_MOVABLE)
> 
> Maybe the opinion can be applied to below similar changes, too.
> 

At least for me, what you said above is OK (it is a common way).

And welcome other members' suggestions.

Thanks.
-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.

WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <chengang@emindsoft.com.cn>
To: SeongJae Park <sj38.park@gmail.com>
Cc: trivial@kernel.org, akpm@linux-foundation.org, vbabka@suse.cz,
	rientjes@google.com, linux-kernel@vger.kernel.org,
	mhocko@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net,
	vdavydov@virtuozzo.com, dan.j.williams@intel.com,
	linux-mm@kvack.org
Subject: Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
Date: Thu, 25 Feb 2016 22:12:06 +0800	[thread overview]
Message-ID: <56CF0BB6.2040102@emindsoft.com.cn> (raw)
In-Reply-To: <alpine.DEB.2.10.1602250952030.16296@hxeon>

On 2/25/16 09:01, SeongJae Park wrote:
> 
> Well, the indentation for the comment and the '\' looks odd to me.  If
> the 80 column limit is necessary, how about moving the comment to above
> line of the macro as below?  Because comments are usually placed before
> the target they are explaining, I believe this may better to read.
> 
>  -#define __GFP_MOVABLE        ((__force gfp_t)___GFP_MOVABLE)  /* ZONE_MOVABLE allowed */
>  +/* ZONE_MOVABLE allowed */
>  +#define __GFP_MOVABLE        ((__force gfp_t)___GFP_MOVABLE)
> 
> Maybe the opinion can be applied to below similar changes, too.
> 

At least for me, what you said above is OK (it is a common way).

And welcome other members' suggestions.

Thanks.
-- 
Chen Gang (e??a??)

Managing Natural Environments is the Duty of Human Beings.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-02-25 14:09 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 22:26 [PATCH trivial] include/linux/gfp.h: Improve the coding styles chengang
2016-02-24 22:26 ` chengang
2016-02-25  1:01 ` SeongJae Park
2016-02-25  1:01   ` SeongJae Park
2016-02-25 14:12   ` Chen Gang [this message]
2016-02-25 14:12     ` Chen Gang
2016-02-25  8:57 ` Michal Hocko
2016-02-25  8:57   ` Michal Hocko
2016-02-25 14:23   ` Chen Gang
2016-02-25 14:23     ` Chen Gang
2016-02-25 14:47     ` Michal Hocko
2016-02-25 14:47       ` Michal Hocko
2016-02-25 22:17       ` Chen Gang
2016-02-25 22:17         ` Chen Gang
2016-02-25  9:27 ` Mel Gorman
2016-02-25  9:27   ` Mel Gorman
2016-02-25 14:38   ` Chen Gang
2016-02-25 14:38     ` Chen Gang
2016-02-25 15:12     ` Jiri Kosina
2016-02-25 15:12       ` Jiri Kosina
2016-02-25 22:19       ` Chen Gang
2016-02-25 22:19         ` Chen Gang
2016-02-25 16:07     ` Mel Gorman
2016-02-25 16:07       ` Mel Gorman
2016-02-25 22:29       ` Chen Gang
2016-02-25 22:29         ` Chen Gang
2016-02-25 22:39         ` Jiri Kosina
2016-02-25 22:39           ` Jiri Kosina
2016-02-26 14:57           ` Chen Gang
2016-02-26 14:57             ` Chen Gang
2016-02-25 23:12         ` SeongJae Park
2016-02-25 23:12           ` SeongJae Park
2016-02-26 15:06           ` Chen Gang
2016-02-26 15:06             ` Chen Gang
2016-02-26  2:32         ` Jianyu Zhan
2016-02-26  2:32           ` Jianyu Zhan
2016-02-26 15:26           ` Chen Gang
2016-02-26 15:26             ` Chen Gang
2016-02-27  2:45             ` Theodore Ts'o
2016-02-27  2:45               ` Theodore Ts'o
2016-02-27 14:32               ` Chen Gang
2016-02-27 14:32                 ` Chen Gang
2016-02-27 16:53                 ` Theodore Ts'o
2016-02-27 16:53                   ` Theodore Ts'o
2016-02-28  0:21                   ` Chen Gang
2016-02-28  0:21                     ` Chen Gang
2016-02-28 13:27                     ` Mel Gorman
2016-02-28 13:27                       ` Mel Gorman
2016-02-28 15:28                       ` Chen Gang
2016-02-28 15:28                         ` Chen Gang
2016-02-27 23:14                 ` Jiri Kosina
2016-02-27 23:14                   ` Jiri Kosina
2016-02-28  0:47                   ` Chen Gang
2016-02-28  0:47                     ` Chen Gang
2016-02-28 22:23                     ` Theodore Ts'o
2016-02-29 15:48                       ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CF0BB6.2040102@emindsoft.com.cn \
    --to=chengang@emindsoft.com.cn \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.cz \
    --cc=rientjes@google.com \
    --cc=sj38.park@gmail.com \
    --cc=trivial@kernel.org \
    --cc=vbabka@suse.cz \
    --cc=vdavydov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.