All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <chengang@emindsoft.com.cn>
To: Jiri Kosina <jikos@kernel.org>
Cc: Mel Gorman <mgorman@techsingularity.net>,
	akpm@linux-foundation.org, vbabka@suse.cz, rientjes@google.com,
	linux-kernel@vger.kernel.org, mhocko@suse.cz, hannes@cmpxchg.org,
	vdavydov@virtuozzo.com, dan.j.williams@intel.com,
	linux-mm@kvack.org, Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
Date: Fri, 26 Feb 2016 06:19:44 +0800	[thread overview]
Message-ID: <56CF7E00.10101@emindsoft.com.cn> (raw)
In-Reply-To: <alpine.LNX.2.00.1602251609120.22700@cbobk.fhfr.pm>


On 2/25/16 23:12, Jiri Kosina wrote:
> On Thu, 25 Feb 2016, Chen Gang wrote:
> 
>> I can understand for your NAK, it is a trivial patch. 
> 
> Not all trivial patches are NAKed :) But they have to be generally useful.
> 
> Shuffling code around, without actually changing / improving it a bit, 
> just for the sole purpose of formatting, is kind of pointless (especially 
> given the fact that the current code as-is is easily readable; it's not 
> like it'd be a horrible mess difficult to understand).
> 
> Sure, it might had been formatted better at the time it was actually 
> merged. But changing it "just because" after being in tree for long time 
> doesn't fix any problem really.
> 

OK, thanks. I have replied the related contents in the other thread.

Welcome any ideas, suggestions, and completions in the other related
thread.

Thanks.
-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.

WARNING: multiple messages have this Message-ID (diff)
From: Chen Gang <chengang@emindsoft.com.cn>
To: Jiri Kosina <jikos@kernel.org>
Cc: Mel Gorman <mgorman@techsingularity.net>,
	akpm@linux-foundation.org, vbabka@suse.cz, rientjes@google.com,
	linux-kernel@vger.kernel.org, mhocko@suse.cz, hannes@cmpxchg.org,
	vdavydov@virtuozzo.com, dan.j.williams@intel.com,
	linux-mm@kvack.org, Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
Date: Fri, 26 Feb 2016 06:19:44 +0800	[thread overview]
Message-ID: <56CF7E00.10101@emindsoft.com.cn> (raw)
In-Reply-To: <alpine.LNX.2.00.1602251609120.22700@cbobk.fhfr.pm>


On 2/25/16 23:12, Jiri Kosina wrote:
> On Thu, 25 Feb 2016, Chen Gang wrote:
> 
>> I can understand for your NAK, it is a trivial patch. 
> 
> Not all trivial patches are NAKed :) But they have to be generally useful.
> 
> Shuffling code around, without actually changing / improving it a bit, 
> just for the sole purpose of formatting, is kind of pointless (especially 
> given the fact that the current code as-is is easily readable; it's not 
> like it'd be a horrible mess difficult to understand).
> 
> Sure, it might had been formatted better at the time it was actually 
> merged. But changing it "just because" after being in tree for long time 
> doesn't fix any problem really.
> 

OK, thanks. I have replied the related contents in the other thread.

Welcome any ideas, suggestions, and completions in the other related
thread.

Thanks.
-- 
Chen Gang (e??a??)

Managing Natural Environments is the Duty of Human Beings.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-02-25 22:16 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 22:26 [PATCH trivial] include/linux/gfp.h: Improve the coding styles chengang
2016-02-24 22:26 ` chengang
2016-02-25  1:01 ` SeongJae Park
2016-02-25  1:01   ` SeongJae Park
2016-02-25 14:12   ` Chen Gang
2016-02-25 14:12     ` Chen Gang
2016-02-25  8:57 ` Michal Hocko
2016-02-25  8:57   ` Michal Hocko
2016-02-25 14:23   ` Chen Gang
2016-02-25 14:23     ` Chen Gang
2016-02-25 14:47     ` Michal Hocko
2016-02-25 14:47       ` Michal Hocko
2016-02-25 22:17       ` Chen Gang
2016-02-25 22:17         ` Chen Gang
2016-02-25  9:27 ` Mel Gorman
2016-02-25  9:27   ` Mel Gorman
2016-02-25 14:38   ` Chen Gang
2016-02-25 14:38     ` Chen Gang
2016-02-25 15:12     ` Jiri Kosina
2016-02-25 15:12       ` Jiri Kosina
2016-02-25 22:19       ` Chen Gang [this message]
2016-02-25 22:19         ` Chen Gang
2016-02-25 16:07     ` Mel Gorman
2016-02-25 16:07       ` Mel Gorman
2016-02-25 22:29       ` Chen Gang
2016-02-25 22:29         ` Chen Gang
2016-02-25 22:39         ` Jiri Kosina
2016-02-25 22:39           ` Jiri Kosina
2016-02-26 14:57           ` Chen Gang
2016-02-26 14:57             ` Chen Gang
2016-02-25 23:12         ` SeongJae Park
2016-02-25 23:12           ` SeongJae Park
2016-02-26 15:06           ` Chen Gang
2016-02-26 15:06             ` Chen Gang
2016-02-26  2:32         ` Jianyu Zhan
2016-02-26  2:32           ` Jianyu Zhan
2016-02-26 15:26           ` Chen Gang
2016-02-26 15:26             ` Chen Gang
2016-02-27  2:45             ` Theodore Ts'o
2016-02-27  2:45               ` Theodore Ts'o
2016-02-27 14:32               ` Chen Gang
2016-02-27 14:32                 ` Chen Gang
2016-02-27 16:53                 ` Theodore Ts'o
2016-02-27 16:53                   ` Theodore Ts'o
2016-02-28  0:21                   ` Chen Gang
2016-02-28  0:21                     ` Chen Gang
2016-02-28 13:27                     ` Mel Gorman
2016-02-28 13:27                       ` Mel Gorman
2016-02-28 15:28                       ` Chen Gang
2016-02-28 15:28                         ` Chen Gang
2016-02-27 23:14                 ` Jiri Kosina
2016-02-27 23:14                   ` Jiri Kosina
2016-02-28  0:47                   ` Chen Gang
2016-02-28  0:47                     ` Chen Gang
2016-02-28 22:23                     ` Theodore Ts'o
2016-02-29 15:48                       ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CF7E00.10101@emindsoft.com.cn \
    --to=chengang@emindsoft.com.cn \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=gang.chen.5i5j@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=jikos@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.cz \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    --cc=vdavydov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.