From: Maxime Coquelin <mcoquelin.stm32@gmail.com>
To: Alexandre TORGUE <alexandre.torgue@gmail.com>,
Arnd Bergmann <arnd@arndb.de>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/4] ARM: STM32: Enable Ethernet in stm32_defconfig
Date: Tue, 1 Mar 2016 18:36:28 +0100 [thread overview]
Message-ID: <56D5D31C.7050908@gmail.com> (raw)
In-Reply-To: <1456483912-32090-5-git-send-email-alexandre.torgue@gmail.com>
Hi Alex, Arnd,
On 02/26/2016 11:51 AM, Alexandre TORGUE wrote:
> Enable basic Ethernet support (IPV4) for stm32 defconfig.
>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@gmail.com>
>
> diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig
> index ec52505..8b8abe0 100644
> --- a/arch/arm/configs/stm32_defconfig
> +++ b/arch/arm/configs/stm32_defconfig
> @@ -33,11 +33,20 @@ CONFIG_XIP_PHYS_ADDR=0x08008000
> CONFIG_BINFMT_FLAT=y
> CONFIG_BINFMT_SHARED_FLAT=y
> # CONFIG_COREDUMP is not set
> +CONFIG_NET=y
> +CONFIG_INET=y
> +# CONFIG_INET_XFRM_MODE_TRANSPORT is not set
> +# CONFIG_INET_XFRM_MODE_TUNNEL is not set
> +# CONFIG_INET_XFRM_MODE_BEET is not set
> +# CONFIG_IPV6 is not set
> CONFIG_DEVTMPFS=y
> CONFIG_DEVTMPFS_MOUNT=y
> # CONFIG_FW_LOADER is not set
> # CONFIG_BLK_DEV is not set
> CONFIG_EEPROM_93CX6=y
> +CONFIG_NETDEVICES=y
> +CONFIG_STMMAC_ETH=y
> +# CONFIG_WLAN is not set
> # CONFIG_INPUT is not set
> # CONFIG_SERIO is not set
> # CONFIG_VT is not set
>
The patch looks good, but I'm not sure I should apply it.
Indeed, not all the stm32 boards have Ethernet interface, and stm32
internal flash size is rather limited (2MB).
Note that your glue layer can be compiled with COMPILE_TEST, so its
build will be covered anyway.
Arnd, do you think we could use Kconfig fragments to enable features
like USB, Ethernet, MTD, etc...?
Maybe we could have a subdirectory in arch/arm/configs where these stm32
specifics fragments could leave?
For example, we could have:
arch/arm/configs/stm32/eth.config
arch/arm/configs/stm32/usb.config
For configuring the Discovery board we would use:
make stm32_defconfig stm32/usb.config
For the Eval board, we cwould use:
make stm32_defconfig eth.config
It would make easy to be able to boot every boards without multiplying
the defconfigs.
Regards,
Maxime
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Coquelin <mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Alexandre TORGUE
<alexandre.torgue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Giuseppe Cavallaro <peppe.cavallaro-qxv4g6HH51o@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 4/4] ARM: STM32: Enable Ethernet in stm32_defconfig
Date: Tue, 1 Mar 2016 18:36:28 +0100 [thread overview]
Message-ID: <56D5D31C.7050908@gmail.com> (raw)
In-Reply-To: <1456483912-32090-5-git-send-email-alexandre.torgue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Alex, Arnd,
On 02/26/2016 11:51 AM, Alexandre TORGUE wrote:
> Enable basic Ethernet support (IPV4) for stm32 defconfig.
>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig
> index ec52505..8b8abe0 100644
> --- a/arch/arm/configs/stm32_defconfig
> +++ b/arch/arm/configs/stm32_defconfig
> @@ -33,11 +33,20 @@ CONFIG_XIP_PHYS_ADDR=0x08008000
> CONFIG_BINFMT_FLAT=y
> CONFIG_BINFMT_SHARED_FLAT=y
> # CONFIG_COREDUMP is not set
> +CONFIG_NET=y
> +CONFIG_INET=y
> +# CONFIG_INET_XFRM_MODE_TRANSPORT is not set
> +# CONFIG_INET_XFRM_MODE_TUNNEL is not set
> +# CONFIG_INET_XFRM_MODE_BEET is not set
> +# CONFIG_IPV6 is not set
> CONFIG_DEVTMPFS=y
> CONFIG_DEVTMPFS_MOUNT=y
> # CONFIG_FW_LOADER is not set
> # CONFIG_BLK_DEV is not set
> CONFIG_EEPROM_93CX6=y
> +CONFIG_NETDEVICES=y
> +CONFIG_STMMAC_ETH=y
> +# CONFIG_WLAN is not set
> # CONFIG_INPUT is not set
> # CONFIG_SERIO is not set
> # CONFIG_VT is not set
>
The patch looks good, but I'm not sure I should apply it.
Indeed, not all the stm32 boards have Ethernet interface, and stm32
internal flash size is rather limited (2MB).
Note that your glue layer can be compiled with COMPILE_TEST, so its
build will be covered anyway.
Arnd, do you think we could use Kconfig fragments to enable features
like USB, Ethernet, MTD, etc...?
Maybe we could have a subdirectory in arch/arm/configs where these stm32
specifics fragments could leave?
For example, we could have:
arch/arm/configs/stm32/eth.config
arch/arm/configs/stm32/usb.config
For configuring the Discovery board we would use:
make stm32_defconfig stm32/usb.config
For the Eval board, we cwould use:
make stm32_defconfig eth.config
It would make easy to be able to boot every boards without multiplying
the defconfigs.
Regards,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: mcoquelin.stm32@gmail.com (Maxime Coquelin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] ARM: STM32: Enable Ethernet in stm32_defconfig
Date: Tue, 1 Mar 2016 18:36:28 +0100 [thread overview]
Message-ID: <56D5D31C.7050908@gmail.com> (raw)
In-Reply-To: <1456483912-32090-5-git-send-email-alexandre.torgue@gmail.com>
Hi Alex, Arnd,
On 02/26/2016 11:51 AM, Alexandre TORGUE wrote:
> Enable basic Ethernet support (IPV4) for stm32 defconfig.
>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@gmail.com>
>
> diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig
> index ec52505..8b8abe0 100644
> --- a/arch/arm/configs/stm32_defconfig
> +++ b/arch/arm/configs/stm32_defconfig
> @@ -33,11 +33,20 @@ CONFIG_XIP_PHYS_ADDR=0x08008000
> CONFIG_BINFMT_FLAT=y
> CONFIG_BINFMT_SHARED_FLAT=y
> # CONFIG_COREDUMP is not set
> +CONFIG_NET=y
> +CONFIG_INET=y
> +# CONFIG_INET_XFRM_MODE_TRANSPORT is not set
> +# CONFIG_INET_XFRM_MODE_TUNNEL is not set
> +# CONFIG_INET_XFRM_MODE_BEET is not set
> +# CONFIG_IPV6 is not set
> CONFIG_DEVTMPFS=y
> CONFIG_DEVTMPFS_MOUNT=y
> # CONFIG_FW_LOADER is not set
> # CONFIG_BLK_DEV is not set
> CONFIG_EEPROM_93CX6=y
> +CONFIG_NETDEVICES=y
> +CONFIG_STMMAC_ETH=y
> +# CONFIG_WLAN is not set
> # CONFIG_INPUT is not set
> # CONFIG_SERIO is not set
> # CONFIG_VT is not set
>
The patch looks good, but I'm not sure I should apply it.
Indeed, not all the stm32 boards have Ethernet interface, and stm32
internal flash size is rather limited (2MB).
Note that your glue layer can be compiled with COMPILE_TEST, so its
build will be covered anyway.
Arnd, do you think we could use Kconfig fragments to enable features
like USB, Ethernet, MTD, etc...?
Maybe we could have a subdirectory in arch/arm/configs where these stm32
specifics fragments could leave?
For example, we could have:
arch/arm/configs/stm32/eth.config
arch/arm/configs/stm32/usb.config
For configuring the Discovery board we would use:
make stm32_defconfig stm32/usb.config
For the Eval board, we cwould use:
make stm32_defconfig eth.config
It would make easy to be able to boot every boards without multiplying
the defconfigs.
Regards,
Maxime
next prev parent reply other threads:[~2016-03-01 17:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 10:51 [PATCH v3 0/4] Add Ethernet support on STM32F429 Alexandre TORGUE
2016-02-26 10:51 ` Alexandre TORGUE
2016-02-26 10:51 ` [PATCH v3 1/4] net: ethernet: dwmac: add Ethernet glue logic for stm32 chip Alexandre TORGUE
2016-02-26 10:51 ` Alexandre TORGUE
2016-02-26 10:51 ` Alexandre TORGUE
2016-02-26 18:08 ` Joachim Eastwood
2016-02-26 18:08 ` Joachim Eastwood
2016-02-26 18:08 ` Joachim Eastwood
2016-02-26 10:51 ` [PATCH v3 2/4] Documentation: Bindings: Add STM32 DWMAC glue Alexandre TORGUE
2016-02-26 10:51 ` Alexandre TORGUE
2016-02-26 10:51 ` Alexandre TORGUE
2016-02-26 17:57 ` Joachim Eastwood
2016-02-26 17:57 ` Joachim Eastwood
2016-02-26 17:57 ` Joachim Eastwood
2016-03-02 18:33 ` Rob Herring
2016-03-02 18:33 ` Rob Herring
2016-03-04 9:04 ` Alexandre Torgue
2016-03-04 9:04 ` Alexandre Torgue
2016-02-26 10:51 ` [PATCH v3 3/4] net: ethernet: stmmac: add support of Synopsys 3.50a MAC IP Alexandre TORGUE
2016-02-26 10:51 ` Alexandre TORGUE
2016-02-26 10:51 ` [PATCH v3 4/4] ARM: STM32: Enable Ethernet in stm32_defconfig Alexandre TORGUE
2016-02-26 10:51 ` Alexandre TORGUE
2016-03-01 17:36 ` Maxime Coquelin [this message]
2016-03-01 17:36 ` Maxime Coquelin
2016-03-01 17:36 ` Maxime Coquelin
2016-02-29 9:36 ` [PATCH v3 0/4] Add Ethernet support on STM32F429 Giuseppe CAVALLARO
2016-02-29 9:36 ` Giuseppe CAVALLARO
2016-02-29 9:36 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D5D31C.7050908@gmail.com \
--to=mcoquelin.stm32@gmail.com \
--cc=alexandre.torgue@gmail.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.