All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: "Jon Hunter" <jonathanh@nvidia.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Jason Cooper" <jason@lakedaemon.net>,
	"Marc Zyngier" <marc.zyngier@arm.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	"Thierry Reding" <thierry.reding@gmail.com>
Cc: Kevin Hilman <khilman@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/15] irqdomain: Ensure type settings match for an existing mapping
Date: Fri, 18 Mar 2016 12:03:30 +0200	[thread overview]
Message-ID: <56EBD272.1040404@ti.com> (raw)
In-Reply-To: <56EAF4E1.5020201@nvidia.com>

On 03/17/2016 08:18 PM, Jon Hunter wrote:
>
> On 17/03/16 14:19, Jon Hunter wrote:
>> When mapping an IRQ, if a mapping already exists, then we simply return
>> the virtual IRQ number. However, we do not check that the type settings
>> for the existing mapping match those for the mapping that is about to be
>> created. It may be unlikely that the type settings would not match, but
>> check for this and don't return a valid IRQ mapping if the type settings
>> do not match.
>>
>> WARN if the type return by irq_domain_translate() has bits outside the
>> sense mask set and then clear these bits. If these bits are not cleared
>> then this will cause the comparision of the type settings for an
>> existing mapping to fail with that of the new mapping even if the sense
>> bit themselves match. The reason being is that the existing type
>> settings are read by calling irq_get_trigger_type() which will clear
>> any bits outside the sense mask. This will allow us to detect irqchips
>> that are not correctly clearing these bits and fix them.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>>   kernel/irq/irqdomain.c | 59 ++++++++++++++++++++++++++++++++++++--------------
>>   1 file changed, 43 insertions(+), 16 deletions(-)
>>
>> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
>> index 3a519a01118b..0ea285baa619 100644
>> --- a/kernel/irq/irqdomain.c
>> +++ b/kernel/irq/irqdomain.c
>> @@ -549,6 +549,13 @@ static int irq_domain_translate(struct irq_domain *d,
>>   				     fwspec->param, fwspec->param_count,
>>   				     hwirq, type);
>>


>> +	/*
>> +	 * WARN if the irqchip returns a type with bits
>> +	 * outside the sense mask set and clear these bits.
>> +	 */
>> +	if (WARN_ON(*type & ~IRQ_TYPE_SENSE_MASK))
>> +		*type &= IRQ_TYPE_SENSE_MASK;

Not sure that this warn and in this place make sense.
type will come unchanged here from caller irq_create_fwspec_mapping()



[...]


-- 
regards,
-grygorii

WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: "Jon Hunter" <jonathanh@nvidia.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Jason Cooper" <jason@lakedaemon.net>,
	"Marc Zyngier" <marc.zyngier@arm.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	"Thierry Reding" <thierry.reding@gmail.com>
Cc: Kevin Hilman <khilman@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	<linux-tegra@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/15] irqdomain: Ensure type settings match for an existing mapping
Date: Fri, 18 Mar 2016 12:03:30 +0200	[thread overview]
Message-ID: <56EBD272.1040404@ti.com> (raw)
In-Reply-To: <56EAF4E1.5020201@nvidia.com>

On 03/17/2016 08:18 PM, Jon Hunter wrote:
>
> On 17/03/16 14:19, Jon Hunter wrote:
>> When mapping an IRQ, if a mapping already exists, then we simply return
>> the virtual IRQ number. However, we do not check that the type settings
>> for the existing mapping match those for the mapping that is about to be
>> created. It may be unlikely that the type settings would not match, but
>> check for this and don't return a valid IRQ mapping if the type settings
>> do not match.
>>
>> WARN if the type return by irq_domain_translate() has bits outside the
>> sense mask set and then clear these bits. If these bits are not cleared
>> then this will cause the comparision of the type settings for an
>> existing mapping to fail with that of the new mapping even if the sense
>> bit themselves match. The reason being is that the existing type
>> settings are read by calling irq_get_trigger_type() which will clear
>> any bits outside the sense mask. This will allow us to detect irqchips
>> that are not correctly clearing these bits and fix them.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>>   kernel/irq/irqdomain.c | 59 ++++++++++++++++++++++++++++++++++++--------------
>>   1 file changed, 43 insertions(+), 16 deletions(-)
>>
>> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
>> index 3a519a01118b..0ea285baa619 100644
>> --- a/kernel/irq/irqdomain.c
>> +++ b/kernel/irq/irqdomain.c
>> @@ -549,6 +549,13 @@ static int irq_domain_translate(struct irq_domain *d,
>>   				     fwspec->param, fwspec->param_count,
>>   				     hwirq, type);
>>


>> +	/*
>> +	 * WARN if the irqchip returns a type with bits
>> +	 * outside the sense mask set and clear these bits.
>> +	 */
>> +	if (WARN_ON(*type & ~IRQ_TYPE_SENSE_MASK))
>> +		*type &= IRQ_TYPE_SENSE_MASK;

Not sure that this warn and in this place make sense.
type will come unchanged here from caller irq_create_fwspec_mapping()



[...]


-- 
regards,
-grygorii

  reply	other threads:[~2016-03-18 10:03 UTC|newest]

Thread overview: 125+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 14:19 [PATCH 00/15] Add support for Tegra210 AGIC Jon Hunter
2016-03-17 14:19 ` [PATCH 01/15] ARM: tegra: Correct interrupt type for ARM TWD Jon Hunter
     [not found]   ` <1458224359-32665-2-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-01 23:25     ` Kevin Hilman
2016-04-01 23:25       ` Kevin Hilman
2016-04-05 14:04     ` Thierry Reding
2016-04-05 14:04       ` Thierry Reding
2016-03-17 14:19 ` [PATCH 02/15] ARM: OMAP: " Jon Hunter
     [not found]   ` <1458224359-32665-3-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-18 15:41     ` Grygorii Strashko
2016-03-18 15:41       ` Grygorii Strashko
     [not found]       ` <56EC2191.2060800-l0cyMroinI0@public.gmane.org>
2016-03-29 14:02         ` Jon Hunter
2016-03-29 14:02           ` Jon Hunter
     [not found]           ` <56FA8AEA.3000208-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-30 21:23             ` Tony Lindgren
2016-03-30 21:23               ` Tony Lindgren
     [not found] ` <1458224359-32665-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-17 14:19   ` [PATCH 03/15] irqchip/gic: Don't unnecessarily write the IRQ configuration Jon Hunter
2016-03-17 14:19     ` Jon Hunter
     [not found]     ` <1458224359-32665-4-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-09 10:50       ` Marc Zyngier
2016-04-09 10:50         ` Marc Zyngier
2016-03-17 14:19   ` [PATCH 04/15] irqchip/gic: WARN if setting the interrupt type fails Jon Hunter
2016-03-17 14:19     ` Jon Hunter
     [not found]     ` <1458224359-32665-5-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-17 14:51       ` Thomas Gleixner
2016-03-17 14:51         ` Thomas Gleixner
2016-03-17 15:04         ` Jon Hunter
2016-03-17 15:18           ` Jason Cooper
     [not found]             ` <20160317151800.GH1184-fahSIxCzskDQ+YiMSub0/l6hYfS7NtTn@public.gmane.org>
2016-03-17 16:20               ` Jon Hunter
2016-03-17 16:20                 ` Jon Hunter
2016-03-18  9:20                 ` Geert Uytterhoeven
     [not found]                   ` <CAMuHMdU8PDUVZ8=S04fkahez1dh7JHjpj2-3w+Vfz05X=ZFMUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-18  9:54                     ` Jon Hunter
2016-03-18  9:54                       ` Jon Hunter
     [not found]                       ` <56EBD061.6030502-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-18 10:22                         ` Geert Uytterhoeven
2016-03-18 10:22                           ` Geert Uytterhoeven
     [not found]           ` <56EAC761.1040801-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-09 10:58             ` Marc Zyngier
2016-04-09 10:58               ` Marc Zyngier
2016-04-11 15:31               ` Jon Hunter
     [not found]                 ` <570BC34A.5030806-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-11 15:39                   ` Marc Zyngier
2016-04-11 15:39                     ` Marc Zyngier
     [not found]                     ` <570BC528.9050601-5wv7dgnIgG8@public.gmane.org>
2016-04-12  8:50                       ` Jon Hunter
2016-04-12  8:50                         ` Jon Hunter
2016-04-12 10:14                         ` Marc Zyngier
2016-03-17 14:19   ` [PATCH 07/15] irqdomain: Don't set type when mapping an IRQ Jon Hunter
2016-03-17 14:19     ` Jon Hunter
     [not found]     ` <1458224359-32665-8-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-17 14:55       ` Thomas Gleixner
2016-03-17 14:55         ` Thomas Gleixner
2016-03-17 15:06         ` Jon Hunter
2016-03-17 18:19       ` Jon Hunter
2016-03-17 18:19         ` Jon Hunter
2016-03-17 14:19   ` [PATCH 08/15] genirq: Add runtime power management support for IRQ chips Jon Hunter
2016-03-17 14:19     ` Jon Hunter
     [not found]     ` <1458224359-32665-9-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-17 15:02       ` Marc Zyngier
2016-03-17 15:02         ` Marc Zyngier
2016-03-17 15:13         ` Jon Hunter
2016-03-17 15:13           ` Jon Hunter
2016-03-17 15:28           ` Marc Zyngier
     [not found]             ` <56EACD21.20309-5wv7dgnIgG8@public.gmane.org>
2016-03-22 11:46               ` Linus Walleij
2016-03-22 11:46                 ` Linus Walleij
2016-03-18 11:11       ` Grygorii Strashko
2016-03-18 11:11         ` Grygorii Strashko
     [not found]         ` <56EBE244.6070400-l0cyMroinI0@public.gmane.org>
2016-03-18 12:27           ` Jon Hunter
2016-03-18 12:27             ` Jon Hunter
2016-03-18 14:23             ` Grygorii Strashko
2016-03-18 14:23               ` Grygorii Strashko
     [not found]               ` <56EC0F7D.8050106-l0cyMroinI0@public.gmane.org>
2016-03-18 14:40                 ` Jon Hunter
2016-03-18 14:40                   ` Jon Hunter
     [not found]                   ` <56EC1362.2000005-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-18 14:56                     ` Jon Hunter
2016-03-18 14:56                       ` Jon Hunter
     [not found]                       ` <56EC1719.5020408-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-18 17:52                         ` Grygorii Strashko
2016-03-18 17:52                           ` Grygorii Strashko
2016-03-21 10:09                           ` Jon Hunter
2016-03-21 10:09                             ` Jon Hunter
2016-03-17 15:02     ` Thomas Gleixner
2016-03-17 15:46       ` Jon Hunter
2016-03-17 15:46         ` Jon Hunter
2016-03-17 14:19 ` [PATCH 05/15] irqchip: Mask the non-type/sense bits when translating an IRQ Jon Hunter
     [not found]   ` <1458224359-32665-6-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-09 11:03     ` Marc Zyngier
2016-04-09 11:03       ` Marc Zyngier
     [not found]       ` <20160409120333.3982c53b-5wv7dgnIgG8@public.gmane.org>
2016-04-19 14:14         ` Jon Hunter
2016-04-19 14:14           ` Jon Hunter
     [not found]           ` <57163D2F.5020005-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-19 14:23             ` Marc Zyngier
2016-04-19 14:23               ` Marc Zyngier
2016-03-17 14:19 ` [PATCH 06/15] irqdomain: Ensure type settings match for an existing mapping Jon Hunter
     [not found]   ` <1458224359-32665-7-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-17 18:18     ` Jon Hunter
2016-03-17 18:18       ` Jon Hunter
2016-03-18 10:03       ` Grygorii Strashko [this message]
2016-03-18 10:03         ` Grygorii Strashko
     [not found]         ` <56EBD272.1040404-l0cyMroinI0@public.gmane.org>
2016-03-18 10:33           ` Jon Hunter
2016-03-18 10:33             ` Jon Hunter
2016-03-17 14:19 ` [PATCH 09/15] irqchip/gic: Don't initialise chip if mapping IO space fails Jon Hunter
     [not found]   ` <1458224359-32665-10-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-09 11:09     ` Marc Zyngier
2016-04-09 11:09       ` Marc Zyngier
2016-03-17 14:19 ` [PATCH 10/15] irqchip/gic: Remove static irq_chip definition for eoimode1 Jon Hunter
     [not found]   ` <1458224359-32665-11-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-22 11:49     ` Linus Walleij
2016-03-22 11:49       ` Linus Walleij
2016-04-09 11:38   ` Marc Zyngier
2016-03-17 14:19 ` [PATCH 11/15] irqchip/gic: Return an error if GIC initialisation fails Jon Hunter
     [not found]   ` <1458224359-32665-12-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-09 11:43     ` Marc Zyngier
2016-04-09 11:43       ` Marc Zyngier
2016-03-17 14:19 ` [PATCH 12/15] irqchip/gic: Pass GIC pointer to save/restore functions Jon Hunter
2016-04-09 11:52   ` Marc Zyngier
2016-03-17 14:19 ` [PATCH 13/15] irqchip/gic: Prepare for adding platform driver Jon Hunter
     [not found]   ` <1458224359-32665-14-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-29 13:04     ` Geert Uytterhoeven
2016-03-29 13:04       ` Geert Uytterhoeven
     [not found]       ` <CAMuHMdVwZgsPNdkWooLHg5H9_Mmv_mKa=zh9T4K-mfjPUEk4CQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-29 13:59         ` Jon Hunter
2016-03-29 13:59           ` Jon Hunter
2016-03-17 14:19 ` [PATCH 14/15] dt-bindings: arm-gic: Drop 'clock-names' from binding document Jon Hunter
     [not found]   ` <1458224359-32665-15-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-17 20:14     ` Rob Herring
2016-03-17 20:14       ` Rob Herring
2016-03-18  8:37       ` Jon Hunter
     [not found]         ` <56EBBE38.6070303-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-12  8:54           ` Jon Hunter
2016-04-12  8:54             ` Jon Hunter
2016-03-18  9:13     ` Geert Uytterhoeven
2016-03-18  9:13       ` Geert Uytterhoeven
     [not found]       ` <CAMuHMdV0QiWR0bML44zhAx+MStmQhQWKd=b_TMKnEdu_hw_ReA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-18 10:13         ` Jon Hunter
2016-03-18 10:13           ` Jon Hunter
     [not found]           ` <56EBD4E5.1060002-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-18 10:52             ` Geert Uytterhoeven
2016-03-18 10:52               ` Geert Uytterhoeven
     [not found]               ` <CAMuHMdWXqS9cru74Ckr47gFVTf2MkmjZUtMt4MeXW_1V7x+KHw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-18 10:56                 ` Jon Hunter
2016-03-18 10:56                   ` Jon Hunter
     [not found]                   ` <56EBDEFA.30102-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-18 12:05                     ` Geert Uytterhoeven
2016-03-18 12:05                       ` Geert Uytterhoeven
     [not found]                       ` <CAMuHMdUkGiX6YWzbRVJaJ4BNskE8PUXq-7Zob40f=CEZyjtJiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-18 12:42                         ` Jon Hunter
2016-03-18 12:42                           ` Jon Hunter
2016-03-18 12:47                       ` Grygorii Strashko
     [not found]                         ` <56EBF8E0.8020700-l0cyMroinI0@public.gmane.org>
2016-03-18 13:02                           ` Geert Uytterhoeven
2016-03-18 13:02                             ` Geert Uytterhoeven
2016-03-18 18:36                             ` Grygorii Strashko
2016-03-17 14:19 ` [PATCH 15/15] irqchip/gic: Add support for tegra AGIC interrupt controller Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56EBD272.1040404@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=geert@linux-m68k.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jason@lakedaemon.net \
    --cc=jonathanh@nvidia.com \
    --cc=khilman@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.