From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Michael Hennerich <michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org> Cc: "Alexandre Courbot" <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "Lars-Peter Clausen" <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>, "Hartmut Knaack" <knaack.h-Mmb7MZpHnFY@public.gmane.org>, "Paul Cercueil" <paul.cercueil-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>, "Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Paweł Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>, "Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>, "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>, "linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH v3] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs Date: Mon, 28 Mar 2016 16:05:58 +0100 [thread overview] Message-ID: <56F94856.60504@kernel.org> (raw) In-Reply-To: <CACRpkdYFUUoG--47qFA_za9X07qukST1vMBEoVC6J4z2LHcs3w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> On 22/03/16 08:49, Linus Walleij wrote: > On Mon, Mar 21, 2016 at 2:48 PM, Michael Hennerich > <michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org> wrote: > >> The thing is that the device directly supports an OPEN DRAIN mode. >> >> If the consumer asks for open drain mode - everything works as expected. >> However instead of utilizing the on-chip feature, GPIOLIB will emulate open >> drain behaviour by configuring the chip for input when someone writes logic >> high. >> >> So the comment above was really meant to say - >> remove on-chip OPEN DRAIN mode, consumers should use the GPIOLIB >> implementation if required. > > This is very interesting. > > So if a hardware has *real* open drain, i.e. a bit in hardware that says > "set me in open drain mode" we should manage this in gpiolib > and provide a special callback in the vtable for it, right? Because it > is certainly better to do this with hardware, if we can. H*** yeah. Funny how open drain stuff is popping up left right and centre all of a sudden. > > I'll send a draft patch and we can see if this is what you want. Cool. I like fast solutions ;) > > Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Linus Walleij <linus.walleij@linaro.org>, Michael Hennerich <michael.hennerich@analog.com> Cc: "Alexandre Courbot" <gnurou@gmail.com>, "Lars-Peter Clausen" <lars@metafoo.de>, "Hartmut Knaack" <knaack.h@gmx.de>, "Paul Cercueil" <paul.cercueil@analog.com>, "Rob Herring" <robh+dt@kernel.org>, "Paweł Moll" <pawel.moll@arm.com>, "Mark Rutland" <mark.rutland@arm.com>, "ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>, "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org> Subject: Re: [PATCH v3] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs Date: Mon, 28 Mar 2016 16:05:58 +0100 [thread overview] Message-ID: <56F94856.60504@kernel.org> (raw) In-Reply-To: <CACRpkdYFUUoG--47qFA_za9X07qukST1vMBEoVC6J4z2LHcs3w@mail.gmail.com> On 22/03/16 08:49, Linus Walleij wrote: > On Mon, Mar 21, 2016 at 2:48 PM, Michael Hennerich > <michael.hennerich@analog.com> wrote: > >> The thing is that the device directly supports an OPEN DRAIN mode. >> >> If the consumer asks for open drain mode - everything works as expected. >> However instead of utilizing the on-chip feature, GPIOLIB will emulate open >> drain behaviour by configuring the chip for input when someone writes logic >> high. >> >> So the comment above was really meant to say - >> remove on-chip OPEN DRAIN mode, consumers should use the GPIOLIB >> implementation if required. > > This is very interesting. > > So if a hardware has *real* open drain, i.e. a bit in hardware that says > "set me in open drain mode" we should manage this in gpiolib > and provide a special callback in the vtable for it, right? Because it > is certainly better to do this with hardware, if we can. H*** yeah. Funny how open drain stuff is popping up left right and centre all of a sudden. > > I'll send a draft patch and we can see if this is what you want. Cool. I like fast solutions ;) > > Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2016-03-28 15:05 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-03 12:58 [PATCH v3] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs michael.hennerich-OyLXuOCK7orQT0dZR+AlfA 2016-03-03 12:58 ` michael.hennerich [not found] ` <1457009883-4017-1-git-send-email-michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org> 2016-03-05 4:29 ` Rob Herring 2016-03-05 4:29 ` Rob Herring 2016-03-07 12:26 ` Michael Hennerich 2016-03-07 12:26 ` Michael Hennerich 2016-03-05 14:32 ` Jonathan Cameron 2016-03-07 12:34 ` Michael Hennerich 2016-03-07 12:34 ` Michael Hennerich 2016-03-11 16:37 ` Linus Walleij 2016-03-21 13:48 ` Michael Hennerich 2016-03-22 8:49 ` Linus Walleij [not found] ` <CACRpkdYFUUoG--47qFA_za9X07qukST1vMBEoVC6J4z2LHcs3w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-03-28 15:05 ` Jonathan Cameron [this message] 2016-03-28 15:05 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56F94856.60504@kernel.org \ --to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \ --cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \ --cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \ --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org \ --cc=paul.cercueil-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org \ --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.