All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Hennerich <michael.hennerich@analog.com>
To: Rob Herring <robh@kernel.org>
Cc: jic23@kernel.org, linus.walleij@linaro.org, gnurou@gmail.com,
	lars@metafoo.de, knaack.h@gmx.de, paul.cercueil@analog.com,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs
Date: Mon, 7 Mar 2016 13:26:59 +0100	[thread overview]
Message-ID: <56DD7393.5070207@analog.com> (raw)
In-Reply-To: <20160305042952.GA13525@rob-hp-laptop>

On 03/05/2016 05:29 AM, Rob Herring wrote:
> On Thu, Mar 03, 2016 at 01:58:03PM +0100, michael.hennerich@analog.com wrote:
>> From: Paul Cercueil <paul.cercueil@analog.com>
>>
>> This patch adds support for the AD5592R (spi) and AD5593R (i2c)
>> ADC/DAC devices.
>>
>> Signed-off-by: Paul Cercueil <paul.cercueil@analog.com>
>> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
>
> [...]
>
>> +AD5592R Example:
>> +
>> +	#include <dt-bindings/iio/adi,ad5592r.h>
>> +
>> +	vref: regulator-vref {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vref-ad559x";
>> +		regulator-min-microvolt = <3300000>;
>> +		regulator-max-microvolt = <3300000>;
>> +		regulator-always-on;
>> +	};
>> +
>> +	ad5592r@0 {
>> +		#size-cells = <0>;
>> +		#address-cells = <1>;
>> +		compatible = "adi,ad5592r";
>> +		reg = <0>;
>> +		spi-max-frequency = <1000000>;
>> +		spi-cpol;
>> +
>> +		vref-supply = <&vref>; /* optional */
>> +		reset-gpios = <&gpio0 86 0>;  /* optional */
>> +
>> +		channel@0 {
>> +			reg = <0>;
>> +			mode = <CH_MODE_DAC>;
>
> You are missing the vendor prefixes thoughout.
>

Thanks

Right - I'll fix this ASAP.


-- 
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif

WARNING: multiple messages have this Message-ID (diff)
From: Michael Hennerich <michael.hennerich@analog.com>
To: Rob Herring <robh@kernel.org>
Cc: <jic23@kernel.org>, <linus.walleij@linaro.org>,
	<gnurou@gmail.com>, <lars@metafoo.de>, <knaack.h@gmx.de>,
	<paul.cercueil@analog.com>, <pawel.moll@arm.com>,
	<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
	<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v3] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs
Date: Mon, 7 Mar 2016 13:26:59 +0100	[thread overview]
Message-ID: <56DD7393.5070207@analog.com> (raw)
In-Reply-To: <20160305042952.GA13525@rob-hp-laptop>

On 03/05/2016 05:29 AM, Rob Herring wrote:
> On Thu, Mar 03, 2016 at 01:58:03PM +0100, michael.hennerich@analog.com wrote:
>> From: Paul Cercueil <paul.cercueil@analog.com>
>>
>> This patch adds support for the AD5592R (spi) and AD5593R (i2c)
>> ADC/DAC devices.
>>
>> Signed-off-by: Paul Cercueil <paul.cercueil@analog.com>
>> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
>
> [...]
>
>> +AD5592R Example:
>> +
>> +	#include <dt-bindings/iio/adi,ad5592r.h>
>> +
>> +	vref: regulator-vref {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vref-ad559x";
>> +		regulator-min-microvolt = <3300000>;
>> +		regulator-max-microvolt = <3300000>;
>> +		regulator-always-on;
>> +	};
>> +
>> +	ad5592r@0 {
>> +		#size-cells = <0>;
>> +		#address-cells = <1>;
>> +		compatible = "adi,ad5592r";
>> +		reg = <0>;
>> +		spi-max-frequency = <1000000>;
>> +		spi-cpol;
>> +
>> +		vref-supply = <&vref>; /* optional */
>> +		reset-gpios = <&gpio0 86 0>;  /* optional */
>> +
>> +		channel@0 {
>> +			reg = <0>;
>> +			mode = <CH_MODE_DAC>;
>
> You are missing the vendor prefixes thoughout.
>

Thanks

Right - I'll fix this ASAP.


-- 
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif

  reply	other threads:[~2016-03-07 12:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03 12:58 [PATCH v3] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs michael.hennerich-OyLXuOCK7orQT0dZR+AlfA
2016-03-03 12:58 ` michael.hennerich
     [not found] ` <1457009883-4017-1-git-send-email-michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
2016-03-05  4:29   ` Rob Herring
2016-03-05  4:29     ` Rob Herring
2016-03-07 12:26     ` Michael Hennerich [this message]
2016-03-07 12:26       ` Michael Hennerich
2016-03-05 14:32 ` Jonathan Cameron
2016-03-07 12:34   ` Michael Hennerich
2016-03-07 12:34     ` Michael Hennerich
2016-03-11 16:37     ` Linus Walleij
2016-03-21 13:48       ` Michael Hennerich
2016-03-22  8:49         ` Linus Walleij
     [not found]           ` <CACRpkdYFUUoG--47qFA_za9X07qukST1vMBEoVC6J4z2LHcs3w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-28 15:05             ` Jonathan Cameron
2016-03-28 15:05               ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56DD7393.5070207@analog.com \
    --to=michael.hennerich@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gnurou@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=paul.cercueil@analog.com \
    --cc=pawel.moll@arm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.