From: Marek Vasut <marex@denx.de> To: Stefan Wahren <stefan.wahren@i2se.com>, Jonathan Cameron <jic23@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net> Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>, Fabio Estevam <fabio.estevam@nxp.com>, Juergen Borleis <jbe@pengutronix.de>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RFT 2/5] iio: mxs-lradc: move TS config into suitable function Date: Thu, 14 Apr 2016 22:01:59 +0200 [thread overview] Message-ID: <570FF737.4050606@denx.de> (raw) In-Reply-To: <1460648909-2657-3-git-send-email-stefan.wahren@i2se.com> On 04/14/2016 05:48 PM, Stefan Wahren wrote: > This patch moves the touchscreen type configuration into > a more suitable function. Btw this simplifies PM ops later. > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Looks OK Reviewed-by: Marek Vasut <marex@denx.de> > --- > drivers/iio/adc/mxs-lradc.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c > index 0576953..7118fca 100644 > --- a/drivers/iio/adc/mxs-lradc.c > +++ b/drivers/iio/adc/mxs-lradc.c > @@ -686,6 +686,17 @@ static void mxs_lradc_prepare_pressure(struct mxs_lradc *lradc) > > static void mxs_lradc_enable_touch_detection(struct mxs_lradc *lradc) > { > + /* Configure the touchscreen type */ > + if (lradc->soc == IMX28_LRADC) { > + mxs_lradc_reg_clear(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > + LRADC_CTRL0); > + > + if (lradc->use_touchscreen == MXS_LRADC_TOUCHSCREEN_5WIRE) > + mxs_lradc_reg_set(lradc, > + LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > + LRADC_CTRL0); > + } > + > mxs_lradc_setup_touch_detection(lradc); > > lradc->cur_plate = LRADC_TOUCH; > @@ -1491,16 +1502,6 @@ static int mxs_lradc_hw_init(struct mxs_lradc *lradc) > mxs_lradc_reg_wrt(lradc, 0, LRADC_DELAY(2)); > mxs_lradc_reg_wrt(lradc, 0, LRADC_DELAY(3)); > > - /* Configure the touchscreen type */ > - if (lradc->soc == IMX28_LRADC) { > - mxs_lradc_reg_clear(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > - LRADC_CTRL0); > - > - if (lradc->use_touchscreen == MXS_LRADC_TOUCHSCREEN_5WIRE) > - mxs_lradc_reg_set(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > - LRADC_CTRL0); > - } > - > /* Start internal temperature sensing. */ > mxs_lradc_reg_wrt(lradc, 0, LRADC_CTRL2); > > -- Best regards, Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH RFT 2/5] iio: mxs-lradc: move TS config into suitable function Date: Thu, 14 Apr 2016 22:01:59 +0200 [thread overview] Message-ID: <570FF737.4050606@denx.de> (raw) In-Reply-To: <1460648909-2657-3-git-send-email-stefan.wahren@i2se.com> On 04/14/2016 05:48 PM, Stefan Wahren wrote: > This patch moves the touchscreen type configuration into > a more suitable function. Btw this simplifies PM ops later. > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Looks OK Reviewed-by: Marek Vasut <marex@denx.de> > --- > drivers/iio/adc/mxs-lradc.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c > index 0576953..7118fca 100644 > --- a/drivers/iio/adc/mxs-lradc.c > +++ b/drivers/iio/adc/mxs-lradc.c > @@ -686,6 +686,17 @@ static void mxs_lradc_prepare_pressure(struct mxs_lradc *lradc) > > static void mxs_lradc_enable_touch_detection(struct mxs_lradc *lradc) > { > + /* Configure the touchscreen type */ > + if (lradc->soc == IMX28_LRADC) { > + mxs_lradc_reg_clear(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > + LRADC_CTRL0); > + > + if (lradc->use_touchscreen == MXS_LRADC_TOUCHSCREEN_5WIRE) > + mxs_lradc_reg_set(lradc, > + LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > + LRADC_CTRL0); > + } > + > mxs_lradc_setup_touch_detection(lradc); > > lradc->cur_plate = LRADC_TOUCH; > @@ -1491,16 +1502,6 @@ static int mxs_lradc_hw_init(struct mxs_lradc *lradc) > mxs_lradc_reg_wrt(lradc, 0, LRADC_DELAY(2)); > mxs_lradc_reg_wrt(lradc, 0, LRADC_DELAY(3)); > > - /* Configure the touchscreen type */ > - if (lradc->soc == IMX28_LRADC) { > - mxs_lradc_reg_clear(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > - LRADC_CTRL0); > - > - if (lradc->use_touchscreen == MXS_LRADC_TOUCHSCREEN_5WIRE) > - mxs_lradc_reg_set(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE, > - LRADC_CTRL0); > - } > - > /* Start internal temperature sensing. */ > mxs_lradc_reg_wrt(lradc, 0, LRADC_CTRL2); > > -- Best regards, Marek Vasut
next prev parent reply other threads:[~2016-04-14 20:03 UTC|newest] Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-14 15:48 [PATCH RFT 0/5] iio: mxs-lradc: fix leak and implement PM ops Stefan Wahren 2016-04-14 15:48 ` Stefan Wahren 2016-04-14 15:48 ` [PATCH RFT 1/5] iio: mxs-lradc: fix memory leak Stefan Wahren 2016-04-14 15:48 ` Stefan Wahren 2016-04-14 20:01 ` Marek Vasut 2016-04-14 20:01 ` Marek Vasut 2016-04-17 10:08 ` Jonathan Cameron 2016-04-17 10:08 ` Jonathan Cameron 2016-04-18 17:16 ` Marek Vasut 2016-04-18 17:16 ` Marek Vasut 2016-04-19 6:33 ` Stefan Wahren 2016-04-19 6:33 ` Stefan Wahren 2016-04-19 10:32 ` Marek Vasut 2016-04-19 10:32 ` Marek Vasut 2016-04-19 13:37 ` Stefan Wahren 2016-04-19 13:37 ` Stefan Wahren 2016-04-19 18:58 ` Jonathan Cameron 2016-04-19 18:58 ` Jonathan Cameron 2016-04-19 19:29 ` Marek Vasut 2016-04-19 19:29 ` Marek Vasut 2016-04-18 6:19 ` Stefan Wahren 2016-04-18 6:19 ` Stefan Wahren 2016-04-18 10:45 ` Marek Vasut 2016-04-18 10:45 ` Marek Vasut 2016-04-14 15:48 ` [PATCH RFT 2/5] iio: mxs-lradc: move TS config into suitable function Stefan Wahren 2016-04-14 15:48 ` Stefan Wahren 2016-04-14 20:01 ` Marek Vasut [this message] 2016-04-14 20:01 ` Marek Vasut 2016-04-17 10:13 ` Jonathan Cameron 2016-04-17 10:13 ` Jonathan Cameron 2016-04-17 12:19 ` Torokhov 2016-04-17 12:19 ` Torokhov [not found] ` <571361DD.1090001-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2016-04-18 6:26 ` Stefan Wahren 2016-04-18 6:26 ` Stefan Wahren 2016-04-18 6:26 ` Stefan Wahren 2016-04-14 15:48 ` [PATCH RFT 3/5] iio: mxs-lradc: move STMP reset out of ADC init Stefan Wahren 2016-04-14 15:48 ` Stefan Wahren 2016-04-15 6:48 ` Juergen Borleis 2016-04-15 6:48 ` Juergen Borleis 2016-04-15 10:12 ` Marek Vasut 2016-04-15 10:12 ` Marek Vasut 2016-04-17 10:24 ` Jonathan Cameron 2016-04-17 10:24 ` Jonathan Cameron 2016-04-14 15:48 ` [PATCH RFT 4/5] iio: mxs-lradc: disable only mapped channels in mxs_lradc_hw_stop Stefan Wahren 2016-04-14 15:48 ` Stefan Wahren 2016-04-17 10:47 ` Jonathan Cameron 2016-04-17 10:47 ` Jonathan Cameron [not found] ` <571369AA.8060106-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2016-04-18 6:36 ` Stefan Wahren 2016-04-18 6:36 ` Stefan Wahren 2016-04-18 6:36 ` Stefan Wahren 2016-04-14 15:48 ` [PATCH RFT 5/5] iio: mxs-lradc: implement suspend/resume support Stefan Wahren 2016-04-14 15:48 ` Stefan Wahren 2016-04-17 10:48 ` Jonathan Cameron 2016-04-17 10:48 ` Jonathan Cameron 2016-04-14 19:55 ` [PATCH RFT 0/5] iio: mxs-lradc: fix leak and implement PM ops Marek Vasut 2016-04-14 19:55 ` Marek Vasut 2016-04-18 6:17 ` Stefan Wahren 2016-04-18 6:17 ` Stefan Wahren [not found] ` <57147BEF.4070606-eS4NqCHxEME@public.gmane.org> 2016-04-18 10:44 ` Marek Vasut 2016-04-18 10:44 ` Marek Vasut 2016-04-18 10:44 ` Marek Vasut
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=570FF737.4050606@denx.de \ --to=marex@denx.de \ --cc=alexandre.belloni@free-electrons.com \ --cc=fabio.estevam@nxp.com \ --cc=jbe@pengutronix.de \ --cc=jic23@kernel.org \ --cc=knaack.h@gmx.de \ --cc=ksenija.stanojevic@gmail.com \ --cc=lars@metafoo.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=pmeerw@pmeerw.net \ --cc=stefan.wahren@i2se.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.