* [PATCH] replace libav with ffmpeg and add a patch fixing building omxplayer after 3645b27848edd0d873925f5fa2a7686f3ff9eeb9
@ 2016-04-20 13:11 piotr.lewicki
2016-04-21 23:31 ` Khem Raj
0 siblings, 1 reply; 8+ messages in thread
From: piotr.lewicki @ 2016-04-20 13:11 UTC (permalink / raw)
To: yocto
---
.../omxplayer/explicitly_link_with_vchostif_library.patch | 13 +++++++++++++
recipes-multimedia/omxplayer/omxplayer_git.bb | 5 +++--
2 files changed, 16 insertions(+), 2 deletions(-)
create mode 100644 recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
diff --git a/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch b/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
new file mode 100644
index 0000000..642f63a
--- /dev/null
+++ b/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
@@ -0,0 +1,13 @@
+diff --git a/Makefile b/Makefile
+index 80b63b1..bcfadfb 100644
+--- a/Makefile
++++ b/Makefile
+@@ -51,7 +51,7 @@ version:
+ bash gen_version.sh > version.h
+
+ omxplayer.bin: version $(OBJS)
+- $(CXX) $(LDFLAGS) -o omxplayer.bin $(OBJS) -lvchiq_arm -lvcos -ldbus-1 -lrt -lpthread -lavutil -lavcodec -lavformat -lswscale -lswresample -lpcre
++ $(CXX) $(LDFLAGS) -o omxplayer.bin $(OBJS) -lvchiq_arm -lvchostif -lvcos -ldbus-1 -lrt -lpthread -lavutil -lavcodec -lavformat -lswscale -lswresample -lpcre
+ $(STRIP) omxplayer.bin
+
+ help.h: README.md Makefile
diff --git a/recipes-multimedia/omxplayer/omxplayer_git.bb b/recipes-multimedia/omxplayer/omxplayer_git.bb
index c8251fe..c2b1342 100644
--- a/recipes-multimedia/omxplayer/omxplayer_git.bb
+++ b/recipes-multimedia/omxplayer/omxplayer_git.bb
@@ -7,8 +7,8 @@ SECTION = "console/utils"
LICENSE = "GPLv2"
LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
-DEPENDS = "libpcre libav virtual/egl boost freetype dbus openssl samba libssh"
-PR = "r4"
+DEPENDS = "libpcre ffmpeg virtual/egl boost freetype dbus openssl samba libssh"
+PR = "r5"
SRCREV = "15a490b2397b358776c56b017a137c4716eb6b4e"
SRC_URI = "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master \
@@ -19,6 +19,7 @@ SRC_URI = "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master
file://fix-tar-command-with-DIST.patch \
file://use-native-pkg-config.patch \
file://don-t-preserve-file-attributes-when-cp.patch \
+ file://explicitly_link_with_vchostif_library.patch \
"
S = "${WORKDIR}/git"
--
2.5.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] replace libav with ffmpeg and add a patch fixing building omxplayer after 3645b27848edd0d873925f5fa2a7686f3ff9eeb9
2016-04-20 13:11 [PATCH] replace libav with ffmpeg and add a patch fixing building omxplayer after 3645b27848edd0d873925f5fa2a7686f3ff9eeb9 piotr.lewicki
@ 2016-04-21 23:31 ` Khem Raj
2016-04-22 0:44 ` Mark Hatle
2016-04-22 3:00 ` Gary Thomas
0 siblings, 2 replies; 8+ messages in thread
From: Khem Raj @ 2016-04-21 23:31 UTC (permalink / raw)
To: piotr.lewicki; +Cc: yocto
resend this patch to OE-Core mailing list. and also add
Upstream-Status: to patch
On Wed, Apr 20, 2016 at 6:11 AM, piotr.lewicki <piotr.lewicki@elfin.de> wrote:
> ---
> .../omxplayer/explicitly_link_with_vchostif_library.patch | 13 +++++++++++++
> recipes-multimedia/omxplayer/omxplayer_git.bb | 5 +++--
> 2 files changed, 16 insertions(+), 2 deletions(-)
> create mode 100644 recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>
> diff --git a/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch b/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
> new file mode 100644
> index 0000000..642f63a
> --- /dev/null
> +++ b/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
> @@ -0,0 +1,13 @@
> +diff --git a/Makefile b/Makefile
> +index 80b63b1..bcfadfb 100644
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -51,7 +51,7 @@ version:
> + bash gen_version.sh > version.h
> +
> + omxplayer.bin: version $(OBJS)
> +- $(CXX) $(LDFLAGS) -o omxplayer.bin $(OBJS) -lvchiq_arm -lvcos -ldbus-1 -lrt -lpthread -lavutil -lavcodec -lavformat -lswscale -lswresample -lpcre
> ++ $(CXX) $(LDFLAGS) -o omxplayer.bin $(OBJS) -lvchiq_arm -lvchostif -lvcos -ldbus-1 -lrt -lpthread -lavutil -lavcodec -lavformat -lswscale -lswresample -lpcre
> + $(STRIP) omxplayer.bin
> +
> + help.h: README.md Makefile
> diff --git a/recipes-multimedia/omxplayer/omxplayer_git.bb b/recipes-multimedia/omxplayer/omxplayer_git.bb
> index c8251fe..c2b1342 100644
> --- a/recipes-multimedia/omxplayer/omxplayer_git.bb
> +++ b/recipes-multimedia/omxplayer/omxplayer_git.bb
> @@ -7,8 +7,8 @@ SECTION = "console/utils"
> LICENSE = "GPLv2"
> LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>
> -DEPENDS = "libpcre libav virtual/egl boost freetype dbus openssl samba libssh"
> -PR = "r4"
> +DEPENDS = "libpcre ffmpeg virtual/egl boost freetype dbus openssl samba libssh"
> +PR = "r5"
>
> SRCREV = "15a490b2397b358776c56b017a137c4716eb6b4e"
> SRC_URI = "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master \
> @@ -19,6 +19,7 @@ SRC_URI = "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master
> file://fix-tar-command-with-DIST.patch \
> file://use-native-pkg-config.patch \
> file://don-t-preserve-file-attributes-when-cp.patch \
> + file://explicitly_link_with_vchostif_library.patch \
> "
> S = "${WORKDIR}/git"
>
> --
> 2.5.0
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] replace libav with ffmpeg and add a patch fixing building omxplayer after 3645b27848edd0d873925f5fa2a7686f3ff9eeb9
2016-04-21 23:31 ` Khem Raj
@ 2016-04-22 0:44 ` Mark Hatle
2016-04-22 3:01 ` Gary Thomas
2016-04-22 3:00 ` Gary Thomas
1 sibling, 1 reply; 8+ messages in thread
From: Mark Hatle @ 2016-04-22 0:44 UTC (permalink / raw)
To: Khem Raj, piotr.lewicki; +Cc: yocto
On 4/21/16 6:31 PM, Khem Raj wrote:
> resend this patch to OE-Core mailing list. and also add
> Upstream-Status: to patch
I don't see a "why" anywhere.
Something wrong with libav, something better with ffmpeg, etc?
--Mark
>
> On Wed, Apr 20, 2016 at 6:11 AM, piotr.lewicki <piotr.lewicki@elfin.de> wrote:
>> ---
>> .../omxplayer/explicitly_link_with_vchostif_library.patch | 13 +++++++++++++
>> recipes-multimedia/omxplayer/omxplayer_git.bb | 5 +++--
>> 2 files changed, 16 insertions(+), 2 deletions(-)
>> create mode 100644 recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>>
>> diff --git a/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch b/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>> new file mode 100644
>> index 0000000..642f63a
>> --- /dev/null
>> +++ b/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>> @@ -0,0 +1,13 @@
>> +diff --git a/Makefile b/Makefile
>> +index 80b63b1..bcfadfb 100644
>> +--- a/Makefile
>> ++++ b/Makefile
>> +@@ -51,7 +51,7 @@ version:
>> + bash gen_version.sh > version.h
>> +
>> + omxplayer.bin: version $(OBJS)
>> +- $(CXX) $(LDFLAGS) -o omxplayer.bin $(OBJS) -lvchiq_arm -lvcos -ldbus-1 -lrt -lpthread -lavutil -lavcodec -lavformat -lswscale -lswresample -lpcre
>> ++ $(CXX) $(LDFLAGS) -o omxplayer.bin $(OBJS) -lvchiq_arm -lvchostif -lvcos -ldbus-1 -lrt -lpthread -lavutil -lavcodec -lavformat -lswscale -lswresample -lpcre
>> + $(STRIP) omxplayer.bin
>> +
>> + help.h: README.md Makefile
>> diff --git a/recipes-multimedia/omxplayer/omxplayer_git.bb b/recipes-multimedia/omxplayer/omxplayer_git.bb
>> index c8251fe..c2b1342 100644
>> --- a/recipes-multimedia/omxplayer/omxplayer_git.bb
>> +++ b/recipes-multimedia/omxplayer/omxplayer_git.bb
>> @@ -7,8 +7,8 @@ SECTION = "console/utils"
>> LICENSE = "GPLv2"
>> LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>>
>> -DEPENDS = "libpcre libav virtual/egl boost freetype dbus openssl samba libssh"
>> -PR = "r4"
>> +DEPENDS = "libpcre ffmpeg virtual/egl boost freetype dbus openssl samba libssh"
>> +PR = "r5"
>>
>> SRCREV = "15a490b2397b358776c56b017a137c4716eb6b4e"
>> SRC_URI = "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master \
>> @@ -19,6 +19,7 @@ SRC_URI = "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master
>> file://fix-tar-command-with-DIST.patch \
>> file://use-native-pkg-config.patch \
>> file://don-t-preserve-file-attributes-when-cp.patch \
>> + file://explicitly_link_with_vchostif_library.patch \
>> "
>> S = "${WORKDIR}/git"
>>
>> --
>> 2.5.0
>>
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] replace libav with ffmpeg and add a patch fixing building omxplayer after 3645b27848edd0d873925f5fa2a7686f3ff9eeb9
2016-04-21 23:31 ` Khem Raj
2016-04-22 0:44 ` Mark Hatle
@ 2016-04-22 3:00 ` Gary Thomas
2016-04-27 2:37 ` Paul Eggleton
1 sibling, 1 reply; 8+ messages in thread
From: Gary Thomas @ 2016-04-22 3:00 UTC (permalink / raw)
To: yocto
On 2016-04-22 01:31, Khem Raj wrote:
> resend this patch to OE-Core mailing list. and also add
> Upstream-Status: to patch
>
Actually, it should go to the RaspberryPi mailing list, not OE-core
Also, there are no Signed-off-by lines
>
> On Wed, Apr 20, 2016 at 6:11 AM, piotr.lewicki <piotr.lewicki@elfin.de> wrote:
>> ---
>> .../omxplayer/explicitly_link_with_vchostif_library.patch | 13 +++++++++++++
>> recipes-multimedia/omxplayer/omxplayer_git.bb | 5 +++--
>> 2 files changed, 16 insertions(+), 2 deletions(-)
>> create mode 100644 recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>>
>> diff --git a/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch b/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>> new file mode 100644
>> index 0000000..642f63a
>> --- /dev/null
>> +++ b/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>> @@ -0,0 +1,13 @@
>> +diff --git a/Makefile b/Makefile
>> +index 80b63b1..bcfadfb 100644
>> +--- a/Makefile
>> ++++ b/Makefile
>> +@@ -51,7 +51,7 @@ version:
>> + bash gen_version.sh > version.h
>> +
>> + omxplayer.bin: version $(OBJS)
>> +- $(CXX) $(LDFLAGS) -o omxplayer.bin $(OBJS) -lvchiq_arm -lvcos -ldbus-1 -lrt -lpthread -lavutil -lavcodec -lavformat -lswscale -lswresample -lpcre
>> ++ $(CXX) $(LDFLAGS) -o omxplayer.bin $(OBJS) -lvchiq_arm -lvchostif -lvcos -ldbus-1 -lrt -lpthread -lavutil -lavcodec -lavformat -lswscale -lswresample -lpcre
>> + $(STRIP) omxplayer.bin
>> +
>> + help.h: README.md Makefile
>> diff --git a/recipes-multimedia/omxplayer/omxplayer_git.bb b/recipes-multimedia/omxplayer/omxplayer_git.bb
>> index c8251fe..c2b1342 100644
>> --- a/recipes-multimedia/omxplayer/omxplayer_git.bb
>> +++ b/recipes-multimedia/omxplayer/omxplayer_git.bb
>> @@ -7,8 +7,8 @@ SECTION = "console/utils"
>> LICENSE = "GPLv2"
>> LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>>
>> -DEPENDS = "libpcre libav virtual/egl boost freetype dbus openssl samba libssh"
>> -PR = "r4"
>> +DEPENDS = "libpcre ffmpeg virtual/egl boost freetype dbus openssl samba libssh"
>> +PR = "r5"
>>
>> SRCREV = "15a490b2397b358776c56b017a137c4716eb6b4e"
>> SRC_URI = "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master \
>> @@ -19,6 +19,7 @@ SRC_URI = "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master
>> file://fix-tar-command-with-DIST.patch \
>> file://use-native-pkg-config.patch \
>> file://don-t-preserve-file-attributes-when-cp.patch \
>> + file://explicitly_link_with_vchostif_library.patch \
>> "
>> S = "${WORKDIR}/git"
>>
>> --
>> 2.5.0
>>
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] replace libav with ffmpeg and add a patch fixing building omxplayer after 3645b27848edd0d873925f5fa2a7686f3ff9eeb9
2016-04-22 0:44 ` Mark Hatle
@ 2016-04-22 3:01 ` Gary Thomas
2016-04-22 6:22 ` piotr.lewicki
0 siblings, 1 reply; 8+ messages in thread
From: Gary Thomas @ 2016-04-22 3:01 UTC (permalink / raw)
To: yocto
On 2016-04-22 02:44, Mark Hatle wrote:
> On 4/21/16 6:31 PM, Khem Raj wrote:
>> resend this patch to OE-Core mailing list. and also add
>> Upstream-Status: to patch
>
> I don't see a "why" anywhere.
>
> Something wrong with libav, something better with ffmpeg, etc?
>
libav was replaced in OE-core by ffmpeg
>
>>
>> On Wed, Apr 20, 2016 at 6:11 AM, piotr.lewicki <piotr.lewicki@elfin.de> wrote:
>>> ---
>>> .../omxplayer/explicitly_link_with_vchostif_library.patch | 13 +++++++++++++
>>> recipes-multimedia/omxplayer/omxplayer_git.bb | 5 +++--
>>> 2 files changed, 16 insertions(+), 2 deletions(-)
>>> create mode 100644 recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>>>
>>> diff --git a/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch b/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>>> new file mode 100644
>>> index 0000000..642f63a
>>> --- /dev/null
>>> +++ b/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>>> @@ -0,0 +1,13 @@
>>> +diff --git a/Makefile b/Makefile
>>> +index 80b63b1..bcfadfb 100644
>>> +--- a/Makefile
>>> ++++ b/Makefile
>>> +@@ -51,7 +51,7 @@ version:
>>> + bash gen_version.sh > version.h
>>> +
>>> + omxplayer.bin: version $(OBJS)
>>> +- $(CXX) $(LDFLAGS) -o omxplayer.bin $(OBJS) -lvchiq_arm -lvcos -ldbus-1 -lrt -lpthread -lavutil -lavcodec -lavformat -lswscale -lswresample -lpcre
>>> ++ $(CXX) $(LDFLAGS) -o omxplayer.bin $(OBJS) -lvchiq_arm -lvchostif -lvcos -ldbus-1 -lrt -lpthread -lavutil -lavcodec -lavformat -lswscale -lswresample -lpcre
>>> + $(STRIP) omxplayer.bin
>>> +
>>> + help.h: README.md Makefile
>>> diff --git a/recipes-multimedia/omxplayer/omxplayer_git.bb b/recipes-multimedia/omxplayer/omxplayer_git.bb
>>> index c8251fe..c2b1342 100644
>>> --- a/recipes-multimedia/omxplayer/omxplayer_git.bb
>>> +++ b/recipes-multimedia/omxplayer/omxplayer_git.bb
>>> @@ -7,8 +7,8 @@ SECTION = "console/utils"
>>> LICENSE = "GPLv2"
>>> LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>>>
>>> -DEPENDS = "libpcre libav virtual/egl boost freetype dbus openssl samba libssh"
>>> -PR = "r4"
>>> +DEPENDS = "libpcre ffmpeg virtual/egl boost freetype dbus openssl samba libssh"
>>> +PR = "r5"
>>>
>>> SRCREV = "15a490b2397b358776c56b017a137c4716eb6b4e"
>>> SRC_URI = "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master \
>>> @@ -19,6 +19,7 @@ SRC_URI = "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master
>>> file://fix-tar-command-with-DIST.patch \
>>> file://use-native-pkg-config.patch \
>>> file://don-t-preserve-file-attributes-when-cp.patch \
>>> + file://explicitly_link_with_vchostif_library.patch \
>>> "
>>> S = "${WORKDIR}/git"
>>>
>>> --
>>> 2.5.0
>>>
>>> --
>>> _______________________________________________
>>> yocto mailing list
>>> yocto@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/yocto
>
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] replace libav with ffmpeg and add a patch fixing building omxplayer after 3645b27848edd0d873925f5fa2a7686f3ff9eeb9
2016-04-22 3:01 ` Gary Thomas
@ 2016-04-22 6:22 ` piotr.lewicki
2016-04-27 2:51 ` Paul Eggleton
0 siblings, 1 reply; 8+ messages in thread
From: piotr.lewicki @ 2016-04-22 6:22 UTC (permalink / raw)
To: Gary Thomas, yocto
Hello.
I'm new here and I didn't know how to prepare patch correctly- I just
used instructions from meta-raspberrypi README.
I can resend it if you want. Especially now when the patch is not
necessary anymore, because Andrei Gherzan has merged latest revision of
omxplayer to master (patch with explicit linking vchostif lib was taken
from there).
Please provide me with instruction on how to create a patch properly.
Thank you,
Piotr Lewicki
On 22.04.2016 05:01, Gary Thomas wrote:
> On 2016-04-22 02:44, Mark Hatle wrote:
>> On 4/21/16 6:31 PM, Khem Raj wrote:
>>> resend this patch to OE-Core mailing list. and also add
>>> Upstream-Status: to patch
>>
>> I don't see a "why" anywhere.
>>
>> Something wrong with libav, something better with ffmpeg, etc?
>>
>
> libav was replaced in OE-core by ffmpeg
>
>>
>>>
>>> On Wed, Apr 20, 2016 at 6:11 AM, piotr.lewicki
>>> <piotr.lewicki@elfin.de> wrote:
>>>> ---
>>>> .../omxplayer/explicitly_link_with_vchostif_library.patch | 13
>>>> +++++++++++++
>>>> recipes-multimedia/omxplayer/omxplayer_git.bb | 5 +++--
>>>> 2 files changed, 16 insertions(+), 2 deletions(-)
>>>> create mode 100644
>>>> recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>>>>
>>>> diff --git
>>>> a/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>>>> b/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>>>>
>>>> new file mode 100644
>>>> index 0000000..642f63a
>>>> --- /dev/null
>>>> +++
>>>> b/recipes-multimedia/omxplayer/omxplayer/explicitly_link_with_vchostif_library.patch
>>>> @@ -0,0 +1,13 @@
>>>> +diff --git a/Makefile b/Makefile
>>>> +index 80b63b1..bcfadfb 100644
>>>> +--- a/Makefile
>>>> ++++ b/Makefile
>>>> +@@ -51,7 +51,7 @@ version:
>>>> + bash gen_version.sh > version.h
>>>> +
>>>> + omxplayer.bin: version $(OBJS)
>>>> +- $(CXX) $(LDFLAGS) -o omxplayer.bin $(OBJS) -lvchiq_arm
>>>> -lvcos -ldbus-1 -lrt -lpthread -lavutil -lavcodec -lavformat
>>>> -lswscale -lswresample -lpcre
>>>> ++ $(CXX) $(LDFLAGS) -o omxplayer.bin $(OBJS) -lvchiq_arm
>>>> -lvchostif -lvcos -ldbus-1 -lrt -lpthread -lavutil -lavcodec
>>>> -lavformat -lswscale -lswresample -lpcre
>>>> + $(STRIP) omxplayer.bin
>>>> +
>>>> + help.h: README.md Makefile
>>>> diff --git a/recipes-multimedia/omxplayer/omxplayer_git.bb
>>>> b/recipes-multimedia/omxplayer/omxplayer_git.bb
>>>> index c8251fe..c2b1342 100644
>>>> --- a/recipes-multimedia/omxplayer/omxplayer_git.bb
>>>> +++ b/recipes-multimedia/omxplayer/omxplayer_git.bb
>>>> @@ -7,8 +7,8 @@ SECTION = "console/utils"
>>>> LICENSE = "GPLv2"
>>>> LIC_FILES_CHKSUM =
>>>> "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>>>>
>>>> -DEPENDS = "libpcre libav virtual/egl boost freetype dbus openssl
>>>> samba libssh"
>>>> -PR = "r4"
>>>> +DEPENDS = "libpcre ffmpeg virtual/egl boost freetype dbus openssl
>>>> samba libssh"
>>>> +PR = "r5"
>>>>
>>>> SRCREV = "15a490b2397b358776c56b017a137c4716eb6b4e"
>>>> SRC_URI =
>>>> "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master
>>>> \
>>>> @@ -19,6 +19,7 @@ SRC_URI =
>>>> "git://github.com/popcornmix/omxplayer.git;protocol=git;branch=master
>>>> file://fix-tar-command-with-DIST.patch \
>>>> file://use-native-pkg-config.patch \
>>>> file://don-t-preserve-file-attributes-when-cp.patch \
>>>> + file://explicitly_link_with_vchostif_library.patch \
>>>> "
>>>> S = "${WORKDIR}/git"
>>>>
>>>> --
>>>> 2.5.0
>>>>
>>>> --
>>>> _______________________________________________
>>>> yocto mailing list
>>>> yocto@yoctoproject.org
>>>> https://lists.yoctoproject.org/listinfo/yocto
>>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] replace libav with ffmpeg and add a patch fixing building omxplayer after 3645b27848edd0d873925f5fa2a7686f3ff9eeb9
2016-04-22 3:00 ` Gary Thomas
@ 2016-04-27 2:37 ` Paul Eggleton
0 siblings, 0 replies; 8+ messages in thread
From: Paul Eggleton @ 2016-04-27 2:37 UTC (permalink / raw)
To: Gary Thomas; +Cc: yocto
On Fri, 22 Apr 2016 05:00:23 Gary Thomas wrote:
> On 2016-04-22 01:31, Khem Raj wrote:
> > resend this patch to OE-Core mailing list. and also add
> > Upstream-Status: to patch
>
> Actually, it should go to the RaspberryPi mailing list, not OE-core
There isn't such a thing - the yocto list is currently where patches to the
meta-raspberrypi layer are supposed to be sent (though the subject should have
been prefixed).
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] replace libav with ffmpeg and add a patch fixing building omxplayer after 3645b27848edd0d873925f5fa2a7686f3ff9eeb9
2016-04-22 6:22 ` piotr.lewicki
@ 2016-04-27 2:51 ` Paul Eggleton
0 siblings, 0 replies; 8+ messages in thread
From: Paul Eggleton @ 2016-04-27 2:51 UTC (permalink / raw)
To: piotr.lewicki; +Cc: yocto, Gary Thomas
Hi Piotr,
On Fri, 22 Apr 2016 08:22:45 piotr.lewicki wrote:
> I'm new here and I didn't know how to prepare patch correctly- I just
> used instructions from meta-raspberrypi README.
>
> I can resend it if you want. Especially now when the patch is not
> necessary anymore, because Andrei Gherzan has merged latest revision of
> omxplayer to master (patch with explicit linking vchostif lib was taken
> from there).
>
> Please provide me with instruction on how to create a patch properly.
There are a couple of git command lines in the meta-raspberrypi README which
if used will add Signed-off-by and the proper "[meta-raspberrypi]" subject
prefix. Also, the shortlog (the first line of the commit message which ends up
as the rest of the email subject) should start with the name of the recipe or
item you're changing - in this case it would be omxplayer. The rest of the
commit message after the blank line should then describe in a little more
detail, most importantly covering why the patch is needed.
You may find this useful:
http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
I know all of this seems a little onerous to begin with, but it not only makes
patch review a bit easier for us, it also helps us keep the commit history
readable in the (likely) event that someone wants to look back later on and
find out why a particular change was made.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-04-27 2:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-20 13:11 [PATCH] replace libav with ffmpeg and add a patch fixing building omxplayer after 3645b27848edd0d873925f5fa2a7686f3ff9eeb9 piotr.lewicki
2016-04-21 23:31 ` Khem Raj
2016-04-22 0:44 ` Mark Hatle
2016-04-22 3:01 ` Gary Thomas
2016-04-22 6:22 ` piotr.lewicki
2016-04-27 2:51 ` Paul Eggleton
2016-04-22 3:00 ` Gary Thomas
2016-04-27 2:37 ` Paul Eggleton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.