From: "Andrew F. Davis" <afd@ti.com>
To: Andreas Dannenberg <dannenberg@ti.com>,
<alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier
Date: Tue, 26 Apr 2016 12:19:05 -0500 [thread overview]
Message-ID: <571FA309.7080809@ti.com> (raw)
In-Reply-To: <1461615456-19510-3-git-send-email-dannenberg@ti.com>
On 04/25/2016 03:17 PM, Andreas Dannenberg wrote:
> The Texas Instruments TAS5720L/M device is a high-efficiency mono
> Class-D audio power amplifier optimized for high transient power
> capability to use the dynamic power headroom of small loudspeakers.
> Its digital time division multiplexed (TDM) interface enables up to
> 16 devices to share the same bus.
>
> Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> ---
> sound/soc/codecs/Kconfig | 10 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/tas5720.c | 638 +++++++++++++++++++++++++++++++++++++++++++++
> sound/soc/codecs/tas5720.h | 90 +++++++
> 4 files changed, 740 insertions(+)
> create mode 100644 sound/soc/codecs/tas5720.c
> create mode 100644 sound/soc/codecs/tas5720.h
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 290f921..3949dae 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -125,6 +125,7 @@ config SND_SOC_ALL_CODECS
> select SND_SOC_TAS2552 if I2C
> select SND_SOC_TAS5086 if I2C
> select SND_SOC_TAS571X if I2C
> + select SND_SOC_TAS5720 if I2C
> select SND_SOC_TFA9879 if I2C
> select SND_SOC_TLV320AIC23_I2C if I2C
> select SND_SOC_TLV320AIC23_SPI if SPI_MASTER
> @@ -748,6 +749,15 @@ config SND_SOC_TAS571X
> tristate "Texas Instruments TAS5711/TAS5717/TAS5719/TAS5721 power amplifiers"
> depends on I2C
>
> +config SND_SOC_TAS5720
> + tristate "Texas Instruments TAS5720 Mono Audio amplifier"
> + depends on I2C
> + help
> + Enable support for Texas Instruments TAS5720L/M high-efficiency mono
> + Class-D audio power amplifiers. The devices use an I2C interface for
> + setup/control and support an optional GPIO interrupt signal for fault
> + reporting.
If fault reporting is no longer interrupt based could this be re-worded?
[...]
> +
> +static struct i2c_driver tas5720_i2c_driver = {
> + .driver = {
> + .name = "tas5720",
> + .owner = THIS_MODULE,
This shouldn't be needed.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: "Andrew F. Davis" <afd@ti.com>
To: Andreas Dannenberg <dannenberg@ti.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier
Date: Tue, 26 Apr 2016 12:19:05 -0500 [thread overview]
Message-ID: <571FA309.7080809@ti.com> (raw)
In-Reply-To: <1461615456-19510-3-git-send-email-dannenberg@ti.com>
On 04/25/2016 03:17 PM, Andreas Dannenberg wrote:
> The Texas Instruments TAS5720L/M device is a high-efficiency mono
> Class-D audio power amplifier optimized for high transient power
> capability to use the dynamic power headroom of small loudspeakers.
> Its digital time division multiplexed (TDM) interface enables up to
> 16 devices to share the same bus.
>
> Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> ---
> sound/soc/codecs/Kconfig | 10 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/tas5720.c | 638 +++++++++++++++++++++++++++++++++++++++++++++
> sound/soc/codecs/tas5720.h | 90 +++++++
> 4 files changed, 740 insertions(+)
> create mode 100644 sound/soc/codecs/tas5720.c
> create mode 100644 sound/soc/codecs/tas5720.h
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 290f921..3949dae 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -125,6 +125,7 @@ config SND_SOC_ALL_CODECS
> select SND_SOC_TAS2552 if I2C
> select SND_SOC_TAS5086 if I2C
> select SND_SOC_TAS571X if I2C
> + select SND_SOC_TAS5720 if I2C
> select SND_SOC_TFA9879 if I2C
> select SND_SOC_TLV320AIC23_I2C if I2C
> select SND_SOC_TLV320AIC23_SPI if SPI_MASTER
> @@ -748,6 +749,15 @@ config SND_SOC_TAS571X
> tristate "Texas Instruments TAS5711/TAS5717/TAS5719/TAS5721 power amplifiers"
> depends on I2C
>
> +config SND_SOC_TAS5720
> + tristate "Texas Instruments TAS5720 Mono Audio amplifier"
> + depends on I2C
> + help
> + Enable support for Texas Instruments TAS5720L/M high-efficiency mono
> + Class-D audio power amplifiers. The devices use an I2C interface for
> + setup/control and support an optional GPIO interrupt signal for fault
> + reporting.
If fault reporting is no longer interrupt based could this be re-worded?
[...]
> +
> +static struct i2c_driver tas5720_i2c_driver = {
> + .driver = {
> + .name = "tas5720",
> + .owner = THIS_MODULE,
This shouldn't be needed.
Andrew
next prev parent reply other threads:[~2016-04-26 17:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 20:17 [PATCH v3 0/2] ASoC: codecs: add support for TAS5720 digital amplifier Andreas Dannenberg
2016-04-25 20:17 ` Andreas Dannenberg
2016-04-25 20:17 ` [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings Andreas Dannenberg
2016-04-25 20:17 ` Andreas Dannenberg
2016-04-26 15:37 ` Mark Brown
2016-04-26 15:37 ` Mark Brown
2016-04-26 16:14 ` Andreas Dannenberg
2016-04-26 16:14 ` Andreas Dannenberg
2016-04-26 16:50 ` Mark Brown
2016-04-26 16:50 ` Mark Brown
2016-04-26 17:00 ` Andreas Dannenberg
2016-04-26 17:00 ` Andreas Dannenberg
2016-04-25 20:17 ` [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier Andreas Dannenberg
2016-04-25 20:17 ` Andreas Dannenberg
2016-04-26 15:43 ` Mark Brown
2016-04-26 15:43 ` Mark Brown
2016-04-26 16:22 ` Andreas Dannenberg
2016-04-26 16:22 ` Andreas Dannenberg
2016-04-26 17:29 ` Mark Brown
2016-04-26 17:29 ` Mark Brown
2016-04-26 18:01 ` Andreas Dannenberg
2016-04-26 18:01 ` Andreas Dannenberg
2016-05-13 11:55 ` Mark Brown
2016-05-13 14:04 ` Andreas Dannenberg
2016-05-13 14:04 ` Andreas Dannenberg
2016-04-26 17:19 ` Andrew F. Davis [this message]
2016-04-26 17:19 ` Andrew F. Davis
2016-04-26 17:37 ` Andreas Dannenberg
2016-04-26 17:37 ` Andreas Dannenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571FA309.7080809@ti.com \
--to=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dannenberg@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.