* [PATCH] arm64: dts: exynos: Fix i2s0 pins pull control for Exynos5433 SoCs [not found] <CGME20170119135856eucas1p149239f274848d61b9aa785e8497d957a@eucas1p1.samsung.com> @ 2017-01-19 13:58 ` Marek Szyprowski 2017-01-19 15:18 ` Javier Martinez Canillas 2017-01-19 20:35 ` Krzysztof Kozlowski 0 siblings, 2 replies; 5+ messages in thread From: Marek Szyprowski @ 2017-01-19 13:58 UTC (permalink / raw) To: linux-samsung-soc Cc: Marek Szyprowski, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Chanwoo Choi Common definition for I2S0 bus should not define any pull control for the individual I2S pins. Correct this by changing samsung,pin-pud property to EXYNOS_PIN_PULL_NONE like it is used for other Exynos SoCs. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi index d49879bd34bb..2171ff965212 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi @@ -135,7 +135,7 @@ samsung,pins = "gpz0-0", "gpz0-1", "gpz0-2", "gpz0-3", "gpz0-4", "gpz0-5", "gpz0-6"; samsung,pin-function = <EXYNOS_PIN_FUNC_2>; - samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; samsung,pin-drv = <EXYNOS5433_PIN_DRV_FAST_SR1>; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: exynos: Fix i2s0 pins pull control for Exynos5433 SoCs 2017-01-19 13:58 ` [PATCH] arm64: dts: exynos: Fix i2s0 pins pull control for Exynos5433 SoCs Marek Szyprowski @ 2017-01-19 15:18 ` Javier Martinez Canillas 2017-01-19 20:35 ` Krzysztof Kozlowski 1 sibling, 0 replies; 5+ messages in thread From: Javier Martinez Canillas @ 2017-01-19 15:18 UTC (permalink / raw) To: Marek Szyprowski, linux-samsung-soc Cc: Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Chanwoo Choi Hello Marek, On 01/19/2017 10:58 AM, Marek Szyprowski wrote: > Common definition for I2S0 bus should not define any pull control for > the individual I2S pins. Correct this by changing samsung,pin-pud property > to EXYNOS_PIN_PULL_NONE like it is used for other Exynos SoCs. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- Looks good to me. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: exynos: Fix i2s0 pins pull control for Exynos5433 SoCs 2017-01-19 13:58 ` [PATCH] arm64: dts: exynos: Fix i2s0 pins pull control for Exynos5433 SoCs Marek Szyprowski 2017-01-19 15:18 ` Javier Martinez Canillas @ 2017-01-19 20:35 ` Krzysztof Kozlowski 2017-01-20 6:51 ` Marek Szyprowski 1 sibling, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2017-01-19 20:35 UTC (permalink / raw) To: Marek Szyprowski Cc: linux-samsung-soc, Sylwester Nawrocki, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Chanwoo Choi On Thu, Jan 19, 2017 at 02:58:30PM +0100, Marek Szyprowski wrote: > Common definition for I2S0 bus should not define any pull control for > the individual I2S pins. Correct this by changing samsung,pin-pud property > to EXYNOS_PIN_PULL_NONE like it is used for other Exynos SoCs. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Makes sense. Two questions here: 1. The same for pcm0_bus? 2. This will affect the specific boards: TM2s. Do they need pull down or in fact you wanted to fix them as well? Usage of words "common definition" suggests the board might be different and in fact you are changing the board now. Best regards, Krzysztof > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi > index d49879bd34bb..2171ff965212 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi > @@ -135,7 +135,7 @@ > samsung,pins = "gpz0-0", "gpz0-1", "gpz0-2", "gpz0-3", > "gpz0-4", "gpz0-5", "gpz0-6"; > samsung,pin-function = <EXYNOS_PIN_FUNC_2>; > - samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>; > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > samsung,pin-drv = <EXYNOS5433_PIN_DRV_FAST_SR1>; > }; > > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: exynos: Fix i2s0 pins pull control for Exynos5433 SoCs 2017-01-19 20:35 ` Krzysztof Kozlowski @ 2017-01-20 6:51 ` Marek Szyprowski 2017-01-20 15:00 ` Krzysztof Kozlowski 0 siblings, 1 reply; 5+ messages in thread From: Marek Szyprowski @ 2017-01-20 6:51 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: linux-samsung-soc, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz, Chanwoo Choi Hi Krzysztof, On 2017-01-19 21:35, Krzysztof Kozlowski wrote: > On Thu, Jan 19, 2017 at 02:58:30PM +0100, Marek Szyprowski wrote: >> Common definition for I2S0 bus should not define any pull control for >> the individual I2S pins. Correct this by changing samsung,pin-pud property >> to EXYNOS_PIN_PULL_NONE like it is used for other Exynos SoCs. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >> --- >> arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > Makes sense. Two questions here: > 1. The same for pcm0_bus? Right, and for I2S1, PMC1 and SPDIF. I will send a new patch. > 2. This will affect the specific boards: TM2s. Do they need pull down or > in fact you wanted to fix them as well? Usage of words "common > definition" suggests the board might be different and in fact you are > changing the board now. I've check, audio on TM2 works fine without this pull down. I wrote 'common' because all other Exynos SoCs define audio pins without pull down. If pull down would be really needed for some reasons on TM2, I would override pull control in tm2.dts > > Best regards, > Krzysztof > >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi >> index d49879bd34bb..2171ff965212 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi >> @@ -135,7 +135,7 @@ >> samsung,pins = "gpz0-0", "gpz0-1", "gpz0-2", "gpz0-3", >> "gpz0-4", "gpz0-5", "gpz0-6"; >> samsung,pin-function = <EXYNOS_PIN_FUNC_2>; >> - samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>; >> + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; >> samsung,pin-drv = <EXYNOS5433_PIN_DRV_FAST_SR1>; >> }; >> >> -- >> 1.9.1 >> > > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: exynos: Fix i2s0 pins pull control for Exynos5433 SoCs 2017-01-20 6:51 ` Marek Szyprowski @ 2017-01-20 15:00 ` Krzysztof Kozlowski 0 siblings, 0 replies; 5+ messages in thread From: Krzysztof Kozlowski @ 2017-01-20 15:00 UTC (permalink / raw) To: Marek Szyprowski Cc: Krzysztof Kozlowski, linux-samsung-soc, Sylwester Nawrocki, Bartlomiej Zolnierkiewicz, Chanwoo Choi On Fri, Jan 20, 2017 at 07:51:43AM +0100, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2017-01-19 21:35, Krzysztof Kozlowski wrote: > > On Thu, Jan 19, 2017 at 02:58:30PM +0100, Marek Szyprowski wrote: > > > Common definition for I2S0 bus should not define any pull control for > > > the individual I2S pins. Correct this by changing samsung,pin-pud property > > > to EXYNOS_PIN_PULL_NONE like it is used for other Exynos SoCs. > > > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > > > --- > > > arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > Makes sense. Two questions here: > > 1. The same for pcm0_bus? > > Right, and for I2S1, PMC1 and SPDIF. I will send a new patch. > > > 2. This will affect the specific boards: TM2s. Do they need pull down or > > in fact you wanted to fix them as well? Usage of words "common > > definition" suggests the board might be different and in fact you are > > changing the board now. > > I've check, audio on TM2 works fine without this pull down. I wrote 'common' > because all other Exynos SoCs define audio pins without pull down. If pull > down would be really needed for some reasons on TM2, I would override pull > control in tm2.dts OK, thanks for explanation. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-20 15:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170119135856eucas1p149239f274848d61b9aa785e8497d957a@eucas1p1.samsung.com>
2017-01-19 13:58 ` [PATCH] arm64: dts: exynos: Fix i2s0 pins pull control for Exynos5433 SoCs Marek Szyprowski
2017-01-19 15:18 ` Javier Martinez Canillas
2017-01-19 20:35 ` Krzysztof Kozlowski
2017-01-20 6:51 ` Marek Szyprowski
2017-01-20 15:00 ` Krzysztof Kozlowski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.