From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Neil Armstrong <narmstrong@baylibre.com>,
kbuild test robot <lkp@intel.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, tglx@linutronix.de,
Ma Haijun <mahaijuns@gmail.com>
Subject: Re: [PATCH v3 1/2] clocksource: Add Oxford Semiconductor RPS Dual Timer
Date: Thu, 16 Jun 2016 16:14:19 +0200 [thread overview]
Message-ID: <5762B43B.9030104@linaro.org> (raw)
In-Reply-To: <5762AE08.50506@baylibre.com>
On 06/16/2016 03:47 PM, Neil Armstrong wrote:
> On 06/16/2016 03:33 PM, Daniel Lezcano wrote:
>> On 06/15/2016 05:35 PM, kbuild test robot wrote:
>>> Hi,
>>>
>>> [auto build test WARNING on tip/timers/core]
>>> [also build test WARNING on v4.7-rc3 next-20160615]
>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>>
>>> url: https://github.com/0day-ci/linux/commits/Neil-Armstrong/clocksource-Add-support-for-Oxford-Semiconductor-RPS-Dual-Timer/20160615-181650
>>> config: blackfin-allmodconfig (attached as .config)
>>> compiler: bfin-uclinux-gcc (GCC) 4.6.3
>>> reproduce:
>>> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>> chmod +x ~/bin/make.cross
>>> # save the attached .config to linux build tree
>>> make.cross ARCH=blackfin
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>>>> drivers/clocksource/timer-oxnas-rps.c:50:0: warning: "TIMER_ENABLE" redefined [enabled by default]
>>> arch/blackfin/mach-bf533/include/mach/defBF532.h:97:0: note: this is the location of the previous definition
>>>
>>> vim +/TIMER_ENABLE +50 drivers/clocksource/timer-oxnas-rps.c
>>>
>>> 34 /* TIMER1 used as tick
>>> 35 * TIMER2 used as clocksource
>>> 36 */
>>> 37
>>> 38 /* Registers definitions */
>>> 39
>>> 40 #define TIMER_LOAD_REG 0x0
>>> 41 #define TIMER_CURR_REG 0x4
>>> 42 #define TIMER_CTRL_REG 0x8
>>> 43 #define TIMER_CLRINT_REG 0xC
>>> 44
>>> 45 #define TIMER_BITS 24
>>> 46
>>> 47 #define TIMER_MAX_VAL (BIT(TIMER_BITS) - 1)
>>> 48
>>> 49 #define TIMER_PERIODIC BIT(6)
>>> > 50 #define TIMER_ENABLE BIT(7)
>>
>> It is already defined in the arch/blackfin/include dir.
>>
>
> Hi Daniel,
>
> This should never happen due to the blackfin headers.
> Actually the COMPILE_TEST option made these two happen.
>
> Should I push a v4 to keep COMPILE_TEST ?
The easier way would be:
depends on !BLACKFIN
I will take care of cleaning up this macro name collision when moving
the timer driver in drivers/clocksource (that's really in the future ...).
The idea is to have all the drivers with the COMPILE_TEST option set, so
we can spot more issues at compile time earlier. This change reveals, of
course, some errors we were not facing before and at least it has the
benefit to enlighten some arch-shadowed drivers.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] clocksource: Add Oxford Semiconductor RPS Dual Timer
Date: Thu, 16 Jun 2016 16:14:19 +0200 [thread overview]
Message-ID: <5762B43B.9030104@linaro.org> (raw)
In-Reply-To: <5762AE08.50506@baylibre.com>
On 06/16/2016 03:47 PM, Neil Armstrong wrote:
> On 06/16/2016 03:33 PM, Daniel Lezcano wrote:
>> On 06/15/2016 05:35 PM, kbuild test robot wrote:
>>> Hi,
>>>
>>> [auto build test WARNING on tip/timers/core]
>>> [also build test WARNING on v4.7-rc3 next-20160615]
>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>>
>>> url: https://github.com/0day-ci/linux/commits/Neil-Armstrong/clocksource-Add-support-for-Oxford-Semiconductor-RPS-Dual-Timer/20160615-181650
>>> config: blackfin-allmodconfig (attached as .config)
>>> compiler: bfin-uclinux-gcc (GCC) 4.6.3
>>> reproduce:
>>> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>> chmod +x ~/bin/make.cross
>>> # save the attached .config to linux build tree
>>> make.cross ARCH=blackfin
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>>>> drivers/clocksource/timer-oxnas-rps.c:50:0: warning: "TIMER_ENABLE" redefined [enabled by default]
>>> arch/blackfin/mach-bf533/include/mach/defBF532.h:97:0: note: this is the location of the previous definition
>>>
>>> vim +/TIMER_ENABLE +50 drivers/clocksource/timer-oxnas-rps.c
>>>
>>> 34 /* TIMER1 used as tick
>>> 35 * TIMER2 used as clocksource
>>> 36 */
>>> 37
>>> 38 /* Registers definitions */
>>> 39
>>> 40 #define TIMER_LOAD_REG 0x0
>>> 41 #define TIMER_CURR_REG 0x4
>>> 42 #define TIMER_CTRL_REG 0x8
>>> 43 #define TIMER_CLRINT_REG 0xC
>>> 44
>>> 45 #define TIMER_BITS 24
>>> 46
>>> 47 #define TIMER_MAX_VAL (BIT(TIMER_BITS) - 1)
>>> 48
>>> 49 #define TIMER_PERIODIC BIT(6)
>>> > 50 #define TIMER_ENABLE BIT(7)
>>
>> It is already defined in the arch/blackfin/include dir.
>>
>
> Hi Daniel,
>
> This should never happen due to the blackfin headers.
> Actually the COMPILE_TEST option made these two happen.
>
> Should I push a v4 to keep COMPILE_TEST ?
The easier way would be:
depends on !BLACKFIN
I will take care of cleaning up this macro name collision when moving
the timer driver in drivers/clocksource (that's really in the future ...).
The idea is to have all the drivers with the COMPILE_TEST option set, so
we can spot more issues at compile time earlier. This change reveals, of
course, some errors we were not facing before and at least it has the
benefit to enlighten some arch-shadowed drivers.
-- Daniel
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2016-06-16 14:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 10:13 [PATCH v3 0/2] clocksource: Add support for Oxford Semiconductor RPS Dual Timer Neil Armstrong
2016-06-15 10:13 ` Neil Armstrong
2016-06-15 10:13 ` [PATCH v3 1/2] clocksource: Add " Neil Armstrong
2016-06-15 10:13 ` Neil Armstrong
2016-06-15 15:35 ` kbuild test robot
2016-06-15 15:35 ` kbuild test robot
2016-06-16 13:33 ` Daniel Lezcano
2016-06-16 13:33 ` Daniel Lezcano
2016-06-16 13:47 ` Neil Armstrong
2016-06-16 13:47 ` Neil Armstrong
2016-06-16 14:14 ` Daniel Lezcano [this message]
2016-06-16 14:14 ` Daniel Lezcano
2016-06-16 14:15 ` Daniel Lezcano
2016-06-16 14:15 ` Daniel Lezcano
2016-06-15 15:51 ` kbuild test robot
2016-06-15 15:51 ` kbuild test robot
2016-06-16 13:29 ` Daniel Lezcano
2016-06-16 13:29 ` Daniel Lezcano
2016-06-15 10:13 ` [PATCH v3 2/2] dt-bindings: clocksource: Add Add Oxford Semiconductor RPS Timer bindings Neil Armstrong
2016-06-15 10:13 ` Neil Armstrong
2016-06-15 10:13 ` Neil Armstrong
2016-06-15 10:23 ` Daniel Lezcano
2016-06-15 10:23 ` Daniel Lezcano
2016-06-15 10:26 ` Daniel Lezcano
2016-06-15 10:26 ` Daniel Lezcano
2016-06-15 10:39 ` Neil Armstrong
2016-06-15 10:39 ` Neil Armstrong
2016-06-16 15:01 ` Neil Armstrong
2016-06-16 15:01 ` Neil Armstrong
2016-06-16 15:05 ` Daniel Lezcano
2016-06-16 15:05 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5762B43B.9030104@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mahaijuns@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.