From: james.morse@arm.com (James Morse)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v19 05/13] arm64/kexec: Add pr_debug output
Date: Mon, 20 Jun 2016 17:06:22 +0100 [thread overview]
Message-ID: <5768147E.1050900@arm.com> (raw)
In-Reply-To: <dd245cadf97ea0d8fd5b0fe5743ecf9fa512d3c0.1466120418.git.geoff@infradead.org>
Hi Geoff,
On 17/06/16 00:48, Geoff Levand wrote:
> To aid in debugging kexec problems or when adding new functionality to
> kexec add a new routine kexec_image_info() and several inline pr_debug
> statements.
>
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
> index a6dcb9c..7372e58 100644
> --- a/arch/arm64/kernel/machine_kexec.c
> +++ b/arch/arm64/kernel/machine_kexec.c
> @@ -11,6 +11,7 @@
>
> #include <linux/kexec.h>
> #include <linux/smp.h>
> +#include <linux/uaccess.h>
Now that the get_user(maybe_dtb_addr,.. has gone, I don't think we need this header.
>
> #include <asm/cacheflush.h>
> #include <asm/cpu_ops.h>
Reviewed-by: James Morse <james.morse@arm.com>
Thanks,
James
WARNING: multiple messages have this Message-ID (diff)
From: James Morse <james.morse@arm.com>
To: Geoff Levand <geoff@infradead.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
marc.zyngier@arm.com, Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v19 05/13] arm64/kexec: Add pr_debug output
Date: Mon, 20 Jun 2016 17:06:22 +0100 [thread overview]
Message-ID: <5768147E.1050900@arm.com> (raw)
In-Reply-To: <dd245cadf97ea0d8fd5b0fe5743ecf9fa512d3c0.1466120418.git.geoff@infradead.org>
Hi Geoff,
On 17/06/16 00:48, Geoff Levand wrote:
> To aid in debugging kexec problems or when adding new functionality to
> kexec add a new routine kexec_image_info() and several inline pr_debug
> statements.
>
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
> index a6dcb9c..7372e58 100644
> --- a/arch/arm64/kernel/machine_kexec.c
> +++ b/arch/arm64/kernel/machine_kexec.c
> @@ -11,6 +11,7 @@
>
> #include <linux/kexec.h>
> #include <linux/smp.h>
> +#include <linux/uaccess.h>
Now that the get_user(maybe_dtb_addr,.. has gone, I don't think we need this header.
>
> #include <asm/cacheflush.h>
> #include <asm/cpu_ops.h>
Reviewed-by: James Morse <james.morse@arm.com>
Thanks,
James
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-06-20 16:06 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 23:48 [PATCH v19 00/13] arm64 kexec kernel patches Geoff Levand
2016-06-16 23:48 ` Geoff Levand
2016-06-16 23:48 ` [PATCH v19 05/13] arm64/kexec: Add pr_debug output Geoff Levand
2016-06-16 23:48 ` Geoff Levand
2016-06-20 16:06 ` James Morse [this message]
2016-06-20 16:06 ` James Morse
2016-06-20 16:50 ` Geoff Levand
2016-06-20 16:50 ` Geoff Levand
2016-06-16 23:48 ` [PATCH v19 02/13] arm64: Add back cpu reset routines Geoff Levand
2016-06-16 23:48 ` Geoff Levand
2016-06-16 23:48 ` [PATCH v19 04/13] arm64/kexec: Enable kexec in the arm64 defconfig Geoff Levand
2016-06-16 23:48 ` Geoff Levand
2016-06-16 23:48 ` [PATCH v19 01/13] arm64: Add cpus_are_stuck_in_kernel Geoff Levand
2016-06-16 23:48 ` Geoff Levand
2016-06-16 23:48 ` [PATCH v19 03/13] arm64/kexec: Add core kexec support Geoff Levand
2016-06-16 23:48 ` Geoff Levand
2016-06-20 15:36 ` James Morse
2016-06-20 15:36 ` James Morse
2016-06-20 16:49 ` Geoff Levand
2016-06-20 16:49 ` Geoff Levand
2016-06-16 23:48 ` [PATCH v19 11/13] arm64: kdump: enable kdump in the arm64 defconfig Geoff Levand
2016-06-16 23:48 ` Geoff Levand
2016-06-16 23:48 ` [PATCH v19 13/13] Documentation: dt: usable-memory and elfcorehdr nodes for arm64 kexec Geoff Levand
2016-06-16 23:48 ` Geoff Levand
2016-06-16 23:48 ` [PATCH v19 12/13] arm64: kdump: update a kernel doc Geoff Levand
2016-06-16 23:48 ` Geoff Levand
2016-06-16 23:48 ` [PATCH v19 10/13] arm64: kdump: add VMCOREINFO's for user-space coredump tools Geoff Levand
2016-06-16 23:48 ` Geoff Levand
2016-06-20 5:32 ` Pratyush Anand
2016-06-20 5:32 ` Pratyush Anand
2016-06-22 5:59 ` AKASHI Takahiro
2016-06-22 5:59 ` AKASHI Takahiro
2016-06-23 7:14 ` Pratyush Anand
2016-06-23 7:14 ` Pratyush Anand
2016-06-23 8:42 ` AKASHI Takahiro
2016-06-23 8:42 ` AKASHI Takahiro
2016-06-23 15:46 ` Pratyush Anand
2016-06-23 15:46 ` Pratyush Anand
2016-06-30 0:44 ` AKASHI Takahiro
2016-06-30 0:44 ` AKASHI Takahiro
2016-06-16 23:48 ` [PATCH v19 07/13] arm64: limit memory regions based on DT property, usable-memory Geoff Levand
2016-06-16 23:48 ` Geoff Levand
2016-06-16 23:48 ` [PATCH v19 08/13] arm64: kdump: implement machine_crash_shutdown() Geoff Levand
2016-06-16 23:48 ` Geoff Levand
2016-06-16 23:48 ` [PATCH v19 06/13] arm64: kdump: reserve memory for crash dump kernel Geoff Levand
2016-06-16 23:48 ` Geoff Levand
2016-06-20 16:07 ` James Morse
2016-06-20 16:07 ` James Morse
2016-06-21 1:23 ` AKASHI Takahiro
2016-06-21 1:23 ` AKASHI Takahiro
2016-06-16 23:48 ` [PATCH v19 09/13] arm64: kdump: add kdump support Geoff Levand
2016-06-16 23:48 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5768147E.1050900@arm.com \
--to=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.