From: wangyijing <wangyijing@huawei.com> To: Coly Li <colyli@suse.de>, Coly Li <i@coly.li>, axboe@fb.com, Kent Overstreet <kent.overstreet@gmail.com> Cc: Eric Wheeler <git@linux.ewheeler.net>, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH 1/3] bcache: Remove redundant parameter for cache_alloc() Date: Fri, 1 Jul 2016 14:18:56 +0800 [thread overview] Message-ID: <57760B50.5040107@huawei.com> (raw) In-Reply-To: <f97f9fd3-de1d-5de0-3593-c3fd1901d455@suse.de> 在 2016/7/1 12:24, Coly Li 写道: > 在 16/7/1 上午10:09, wangyijing 写道: >> >> >> 在 2016/6/29 18:20, Coly Li 写道: >>> 在 16/6/22 上午10:10, Yijing Wang 写道: >>>> Cache_sb is not used in cache_alloc, and we have copied >>>> sb info to cache->sb already, remove it. >>>> >>>> Signed-off-by: Yijing Wang <wangyijing@huawei.com> >>>> --- >>>> drivers/md/bcache/super.c | 4 ++-- >>>> 1 files changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c >>>> index f5dbb4e..aecaace 100644 >>>> --- a/drivers/md/bcache/super.c >>>> +++ b/drivers/md/bcache/super.c >>>> @@ -1803,7 +1803,7 @@ void bch_cache_release(struct kobject *kobj) >>>> module_put(THIS_MODULE); >>>> } >>>> >>>> -static int cache_alloc(struct cache_sb *sb, struct cache *ca) >>>> +static int cache_alloc(struct cache *ca) >>>> { >>>> size_t free; >>>> struct bucket *b; >>>> @@ -1858,7 +1858,7 @@ static int register_cache(struct cache_sb *sb, struct page *sb_page, >>>> if (blk_queue_discard(bdev_get_queue(ca->bdev))) >>>> ca->discard = CACHE_DISCARD(&ca->sb); >>>> >>>> - ret = cache_alloc(sb, ca); >>>> + ret = cache_alloc(ca); >>> >>> I am not sure whether struct cache_b *sb will be used in future, I >>> suggest to let it be for now. >>> >> >> We have copied sb to ca->sb, so if we need sb info in future, we could get info from ca->sb. >> > > Hi Yijing, > > Your point makes sense, please add > Reviewed-by: Coly Li <colyli@suse.de> > in your patch, if you don't mind :-) > > Thanks for your interpretation. > > Coly Thanks for your review very much! Thanks! Yijing. > > . >
WARNING: multiple messages have this Message-ID (diff)
From: wangyijing <wangyijing@huawei.com> To: Coly Li <colyli@suse.de>, Coly Li <i@coly.li>, <axboe@fb.com>, "Kent Overstreet" <kent.overstreet@gmail.com> Cc: Eric Wheeler <git@linux.ewheeler.net>, <linux-bcache@vger.kernel.org>, <linux-raid@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [RESEND PATCH 1/3] bcache: Remove redundant parameter for cache_alloc() Date: Fri, 1 Jul 2016 14:18:56 +0800 [thread overview] Message-ID: <57760B50.5040107@huawei.com> (raw) In-Reply-To: <f97f9fd3-de1d-5de0-3593-c3fd1901d455@suse.de> 在 2016/7/1 12:24, Coly Li 写道: > 在 16/7/1 上午10:09, wangyijing 写道: >> >> >> 在 2016/6/29 18:20, Coly Li 写道: >>> 在 16/6/22 上午10:10, Yijing Wang 写道: >>>> Cache_sb is not used in cache_alloc, and we have copied >>>> sb info to cache->sb already, remove it. >>>> >>>> Signed-off-by: Yijing Wang <wangyijing@huawei.com> >>>> --- >>>> drivers/md/bcache/super.c | 4 ++-- >>>> 1 files changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c >>>> index f5dbb4e..aecaace 100644 >>>> --- a/drivers/md/bcache/super.c >>>> +++ b/drivers/md/bcache/super.c >>>> @@ -1803,7 +1803,7 @@ void bch_cache_release(struct kobject *kobj) >>>> module_put(THIS_MODULE); >>>> } >>>> >>>> -static int cache_alloc(struct cache_sb *sb, struct cache *ca) >>>> +static int cache_alloc(struct cache *ca) >>>> { >>>> size_t free; >>>> struct bucket *b; >>>> @@ -1858,7 +1858,7 @@ static int register_cache(struct cache_sb *sb, struct page *sb_page, >>>> if (blk_queue_discard(bdev_get_queue(ca->bdev))) >>>> ca->discard = CACHE_DISCARD(&ca->sb); >>>> >>>> - ret = cache_alloc(sb, ca); >>>> + ret = cache_alloc(ca); >>> >>> I am not sure whether struct cache_b *sb will be used in future, I >>> suggest to let it be for now. >>> >> >> We have copied sb to ca->sb, so if we need sb info in future, we could get info from ca->sb. >> > > Hi Yijing, > > Your point makes sense, please add > Reviewed-by: Coly Li <colyli@suse.de> > in your patch, if you don't mind :-) > > Thanks for your interpretation. > > Coly Thanks for your review very much! Thanks! Yijing. > > . >
next prev parent reply other threads:[~2016-07-01 6:18 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-22 2:10 [RESEND PATCH 1/3] bcache: Remove redundant parameter for cache_alloc() Yijing Wang 2016-06-22 2:10 ` Yijing Wang 2016-06-29 10:20 ` Coly Li 2016-07-01 2:09 ` wangyijing 2016-07-01 2:09 ` wangyijing 2016-07-01 4:24 ` Coly Li 2016-07-01 6:18 ` wangyijing [this message] 2016-07-01 6:18 ` wangyijing
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=57760B50.5040107@huawei.com \ --to=wangyijing@huawei.com \ --cc=axboe@fb.com \ --cc=colyli@suse.de \ --cc=git@linux.ewheeler.net \ --cc=i@coly.li \ --cc=kent.overstreet@gmail.com \ --cc=linux-bcache@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-raid@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.