From: Oleksij Rempel <linux@rempel-privat.de>
To: "Bjørn Mork" <bjorn@mork.no>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>
Cc: ath9k-devel@venema.h4ckr.net, devicetree@vger.kernel.org,
linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com,
mcgrof@do-not-panic.com, galak@codeaurora.org,
ijc+devicetree@hellion.org.uk, mark.rutland@arm.com,
pawel.moll@arm.com, robh+dt@kernel.org, kvalo@codeaurora.org,
chunkeey@googlemail.com, arend.vanspriel@broadcom.com,
julian.calaby@gmail.com
Subject: Re: [PATCH v4 3/3] ath9k: parse the device configuration from an OF node
Date: Sun, 10 Jul 2016 11:28:22 +0200 [thread overview]
Message-ID: <57821536.3020000@rempel-privat.de> (raw)
In-Reply-To: <87inwe9wfb.fsf@miraculix.mork.no>
[-- Attachment #1.1: Type: text/plain, Size: 802 bytes --]
Am 10.07.2016 um 02:19 schrieb Bjørn Mork:
> Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
>
>> + if (of_property_read_bool(np, "qca,clk-25mhz"))
>> + ah->is_clk_25mhz = true;
>> +
>> + if (of_property_read_bool(np, "qca,disable-2ghz"))
>> + ah->disable_2ghz = true;
>> +
>> + if (of_property_read_bool(np, "qca,disable-5ghz"))
>> + ah->disable_5ghz = true;
>
> This is bike-shedding, but how about
>
> ah->is_clk_25mhz = of_property_read_bool(np, "qca,clk-25mhz");
> ah->disable_2ghz = of_property_read_bool(np, "qca,disable-2ghz");
> ah->disable_5ghz = of_property_read_bool(np, "qca,disable-5ghz");
>
> instead?
Hm... i assume each WiFi hw in the world can reuse this settings, may be
it i worth to use generic names?
--
Regards,
Oleksij
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <linux-YEK0n+YFykbzxQdaRaTXBw@public.gmane.org>
To: "Bjørn Mork" <bjorn-yOkvZcmFvRU@public.gmane.org>,
"Martin Blumenstingl"
<martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Cc: ath9k-devel-juf53994utBLZpfksSYvnA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ath9k-devel-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org,
mcgrof-3uybbJdB1yH774rrrx3eTA@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
chunkeey-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org,
arend.vanspriel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v4 3/3] ath9k: parse the device configuration from an OF node
Date: Sun, 10 Jul 2016 11:28:22 +0200 [thread overview]
Message-ID: <57821536.3020000@rempel-privat.de> (raw)
In-Reply-To: <87inwe9wfb.fsf-3F4PFWf5pNjpjLOzFPqGjWGXanvQGlWp@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 827 bytes --]
Am 10.07.2016 um 02:19 schrieb Bjørn Mork:
> Martin Blumenstingl <martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> writes:
>
>> + if (of_property_read_bool(np, "qca,clk-25mhz"))
>> + ah->is_clk_25mhz = true;
>> +
>> + if (of_property_read_bool(np, "qca,disable-2ghz"))
>> + ah->disable_2ghz = true;
>> +
>> + if (of_property_read_bool(np, "qca,disable-5ghz"))
>> + ah->disable_5ghz = true;
>
> This is bike-shedding, but how about
>
> ah->is_clk_25mhz = of_property_read_bool(np, "qca,clk-25mhz");
> ah->disable_2ghz = of_property_read_bool(np, "qca,disable-2ghz");
> ah->disable_5ghz = of_property_read_bool(np, "qca,disable-5ghz");
>
> instead?
Hm... i assume each WiFi hw in the world can reuse this settings, may be
it i worth to use generic names?
--
Regards,
Oleksij
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <linux@rempel-privat.de>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH v4 3/3] ath9k: parse the device configuration from an OF node
Date: Sun, 10 Jul 2016 11:28:22 +0200 [thread overview]
Message-ID: <57821536.3020000@rempel-privat.de> (raw)
In-Reply-To: <87inwe9wfb.fsf@miraculix.mork.no>
Am 10.07.2016 um 02:19 schrieb Bj?rn Mork:
> Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
>
>> + if (of_property_read_bool(np, "qca,clk-25mhz"))
>> + ah->is_clk_25mhz = true;
>> +
>> + if (of_property_read_bool(np, "qca,disable-2ghz"))
>> + ah->disable_2ghz = true;
>> +
>> + if (of_property_read_bool(np, "qca,disable-5ghz"))
>> + ah->disable_5ghz = true;
>
> This is bike-shedding, but how about
>
> ah->is_clk_25mhz = of_property_read_bool(np, "qca,clk-25mhz");
> ah->disable_2ghz = of_property_read_bool(np, "qca,disable-2ghz");
> ah->disable_5ghz = of_property_read_bool(np, "qca,disable-5ghz");
>
> instead?
Hm... i assume each WiFi hw in the world can reuse this settings, may be
it i worth to use generic names?
--
Regards,
Oleksij
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: OpenPGP digital signature
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20160710/c6337c74/attachment.pgp
next prev parent reply other threads:[~2016-07-10 9:29 UTC|newest]
Thread overview: 161+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 12:34 [RFC v3] ath9k: add devicetree support to ath9k Martin Blumenstingl
2016-06-24 12:34 ` [ath9k-devel] " Martin Blumenstingl
2016-06-24 12:34 ` [PATCH RFC v3 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl
2016-06-24 12:34 ` [ath9k-devel] " Martin Blumenstingl
2016-06-27 0:20 ` Julian Calaby
2016-06-27 0:20 ` [ath9k-devel] " Julian Calaby
2016-06-27 9:49 ` Kalle Valo
2016-06-27 9:49 ` [ath9k-devel] " Kalle Valo
2016-06-24 12:34 ` [PATCH v3 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl
2016-06-24 12:34 ` [ath9k-devel] " Martin Blumenstingl
2016-06-27 10:26 ` Felix Fietkau
2016-06-27 10:26 ` [ath9k-devel] " Felix Fietkau
2016-06-29 22:37 ` Martin Blumenstingl
2016-06-29 22:37 ` [ath9k-devel] " Martin Blumenstingl
2016-06-24 12:34 ` [PATCH RFC v3 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl
2016-06-24 12:34 ` [ath9k-devel] " Martin Blumenstingl
2016-06-25 12:01 ` Christian Lamparter
2016-06-25 12:01 ` [ath9k-devel] " Christian Lamparter
2016-06-25 15:08 ` Martin Blumenstingl
2016-06-25 15:08 ` [ath9k-devel] " Martin Blumenstingl
2016-06-25 19:26 ` Christian Lamparter
2016-06-25 19:26 ` [ath9k-devel] " Christian Lamparter
2016-06-26 23:38 ` Martin Blumenstingl
2016-06-26 23:38 ` [ath9k-devel] " Martin Blumenstingl
2016-07-07 0:47 ` Luis R. Rodriguez
2016-07-07 1:03 ` [ath9k-devel] " Luis R. Rodriguez
2016-07-09 23:28 ` [PATCH v4 0/3] add devicetree support to ath9k Martin Blumenstingl
2016-07-09 23:28 ` [ath9k-devel] " Martin Blumenstingl
2016-07-09 23:28 ` Martin Blumenstingl
2016-07-09 23:28 ` [PATCH v4 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl
2016-07-09 23:28 ` [ath9k-devel] " Martin Blumenstingl
2016-07-09 23:28 ` Martin Blumenstingl
2016-07-10 20:52 ` Arnd Bergmann
2016-07-10 20:52 ` [ath9k-devel] " Arnd Bergmann
2016-07-10 20:52 ` Arnd Bergmann
2016-07-10 20:54 ` Martin Blumenstingl
2016-07-10 20:54 ` [ath9k-devel] " Martin Blumenstingl
2016-07-10 20:54 ` Martin Blumenstingl
2016-07-10 22:01 ` Arnd Bergmann
2016-07-10 22:01 ` [ath9k-devel] " Arnd Bergmann
2016-07-10 22:01 ` Arnd Bergmann
2016-07-11 21:21 ` Martin Blumenstingl
2016-07-11 21:21 ` [ath9k-devel] " Martin Blumenstingl
2016-07-11 21:21 ` Martin Blumenstingl
2016-07-14 12:33 ` Arnd Bergmann
2016-07-14 12:33 ` [ath9k-devel] " Arnd Bergmann
2016-07-14 12:33 ` Arnd Bergmann
2016-07-13 7:02 ` Kalle Valo
2016-07-13 7:02 ` [ath9k-devel] " Kalle Valo
2016-07-13 7:02 ` Kalle Valo
2016-07-13 7:47 ` Arnd Bergmann
2016-07-13 7:47 ` [ath9k-devel] " Arnd Bergmann
2016-07-13 7:47 ` Arnd Bergmann
2016-07-09 23:28 ` [PATCH v4 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl
2016-07-09 23:28 ` [ath9k-devel] " Martin Blumenstingl
2016-07-09 23:28 ` Martin Blumenstingl
2016-07-09 23:28 ` [PATCH v4 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl
2016-07-09 23:28 ` [ath9k-devel] " Martin Blumenstingl
2016-07-09 23:28 ` Martin Blumenstingl
2016-07-10 0:19 ` Bjørn Mork
2016-07-10 0:32 ` [ath9k-devel] " Bjørn Mork
2016-07-10 0:19 ` Bjørn Mork
2016-07-10 9:28 ` Oleksij Rempel [this message]
2016-07-10 9:28 ` [ath9k-devel] " Oleksij Rempel
2016-07-10 9:28 ` Oleksij Rempel
2016-07-10 20:56 ` Martin Blumenstingl
2016-07-10 20:56 ` [ath9k-devel] " Martin Blumenstingl
2016-07-10 20:56 ` Martin Blumenstingl
2016-08-21 14:31 ` [PATCH v5 0/3] add devicetree support to ath9k Martin Blumenstingl
2016-08-21 14:31 ` [ath9k-devel] " Martin Blumenstingl
2016-08-21 14:31 ` Martin Blumenstingl
2016-08-21 14:31 ` [PATCH v5 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl
2016-08-21 14:31 ` [ath9k-devel] " Martin Blumenstingl
2016-08-21 14:31 ` Martin Blumenstingl
2016-08-22 9:08 ` Arnd Bergmann
2016-08-22 9:08 ` [ath9k-devel] " Arnd Bergmann
2016-08-22 9:08 ` Arnd Bergmann
2016-08-28 20:51 ` Martin Blumenstingl
2016-08-28 20:51 ` [ath9k-devel] " Martin Blumenstingl
2016-08-28 20:51 ` Martin Blumenstingl
2016-08-29 12:12 ` Arnd Bergmann
2016-08-29 12:12 ` [ath9k-devel] " Arnd Bergmann
2016-08-29 12:12 ` Arnd Bergmann
2016-08-21 14:31 ` [PATCH v5 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl
2016-08-21 14:31 ` [ath9k-devel] " Martin Blumenstingl
2016-08-21 14:31 ` Martin Blumenstingl
2016-08-21 14:31 ` [PATCH v5 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl
2016-08-21 14:31 ` [ath9k-devel] " Martin Blumenstingl
2016-08-21 14:31 ` Martin Blumenstingl
2016-09-06 21:46 ` [PATCH v6 0/3] add devicetree support to ath9k Martin Blumenstingl
2016-09-06 21:46 ` [ath9k-devel] " Martin Blumenstingl
2016-09-06 21:46 ` Martin Blumenstingl
2016-09-06 21:46 ` [PATCH v6 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl
2016-09-06 21:46 ` [ath9k-devel] " Martin Blumenstingl
2016-09-06 21:46 ` Martin Blumenstingl
2016-09-09 7:48 ` Oleksij Rempel
2016-09-09 7:48 ` [ath9k-devel] " Oleksij Rempel
2016-09-09 7:48 ` Oleksij Rempel
2016-09-09 20:57 ` Martin Blumenstingl
2016-09-09 20:57 ` [ath9k-devel] " Martin Blumenstingl
2016-09-09 20:57 ` Martin Blumenstingl
2016-09-13 7:28 ` Oleksij Rempel
2016-09-13 7:28 ` [ath9k-devel] " Oleksij Rempel
2016-09-13 7:28 ` Oleksij Rempel
2016-09-16 12:45 ` Rob Herring
2016-09-16 12:45 ` [ath9k-devel] " Rob Herring
2016-09-16 12:45 ` Rob Herring
2016-09-18 21:51 ` Martin Blumenstingl
2016-09-18 21:51 ` [ath9k-devel] " Martin Blumenstingl
2016-09-18 21:51 ` Martin Blumenstingl
2016-09-16 12:37 ` Rob Herring
2016-09-16 12:55 ` [ath9k-devel] " Rob Herring
2016-09-16 12:37 ` Rob Herring
2016-09-06 21:46 ` [PATCH v6 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl
2016-09-06 21:46 ` [ath9k-devel] " Martin Blumenstingl
2016-09-06 21:46 ` Martin Blumenstingl
2016-09-06 21:46 ` [PATCH v6 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl
2016-09-06 21:46 ` [ath9k-devel] " Martin Blumenstingl
2016-09-06 21:46 ` Martin Blumenstingl
2016-10-02 21:47 ` [PATCH v7 0/3] add devicetree support to ath9k Martin Blumenstingl
2016-10-02 21:47 ` [ath9k-devel] " Martin Blumenstingl
2016-10-02 21:47 ` Martin Blumenstingl
2016-10-02 21:47 ` [PATCH v7 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl
2016-10-02 21:47 ` [ath9k-devel] " Martin Blumenstingl
2016-10-02 21:47 ` Martin Blumenstingl
2016-10-07 12:17 ` [v7, " Kalle Valo
2016-10-07 12:17 ` Kalle Valo
2016-10-07 12:17 ` [ath9k-devel] " Kalle Valo
2016-10-07 12:17 ` Kalle Valo
2016-10-07 12:17 ` Kalle Valo
2016-10-08 22:50 ` [PATCH v7 " Rob Herring
2016-10-09 1:28 ` Rob Herring
2016-10-09 1:29 ` [ath9k-devel] " Rob Herring
2016-10-09 1:28 ` Rob Herring
2016-10-09 9:54 ` Martin Blumenstingl
2016-10-09 9:54 ` [ath9k-devel] " Martin Blumenstingl
2016-10-09 9:54 ` Martin Blumenstingl
2016-10-02 21:47 ` [PATCH v7 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl
2016-10-02 21:47 ` [ath9k-devel] " Martin Blumenstingl
2016-10-02 21:47 ` Martin Blumenstingl
2016-10-02 21:47 ` [PATCH v7 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl
2016-10-02 21:47 ` [ath9k-devel] " Martin Blumenstingl
2016-10-02 21:47 ` Martin Blumenstingl
2016-10-16 20:59 ` [PATCH v8 0/3] add devicetree support to ath9k Martin Blumenstingl
2016-10-16 20:59 ` [ath9k-devel] " Martin Blumenstingl
2016-10-16 20:59 ` Martin Blumenstingl
2016-10-16 20:59 ` [PATCH v8 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl
2016-10-16 20:59 ` [ath9k-devel] " Martin Blumenstingl
2016-10-16 20:59 ` Martin Blumenstingl
2016-10-18 15:31 ` Rob Herring
2016-10-18 15:31 ` [ath9k-devel] " Rob Herring
2016-10-18 15:31 ` Rob Herring
2016-11-15 14:56 ` [v8, " Kalle Valo
2016-11-15 14:56 ` [ath9k-devel] " Kalle Valo
2016-11-15 14:56 ` Kalle Valo
2016-10-16 20:59 ` [PATCH v8 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl
2016-10-16 20:59 ` [ath9k-devel] " Martin Blumenstingl
2016-10-16 20:59 ` Martin Blumenstingl
2016-10-16 20:59 ` [PATCH v8 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl
2016-10-16 20:59 ` [ath9k-devel] " Martin Blumenstingl
2016-10-16 20:59 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57821536.3020000@rempel-privat.de \
--to=linux@rempel-privat.de \
--cc=arend.vanspriel@broadcom.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=bjorn@mork.no \
--cc=chunkeey@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=julian.calaby@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcgrof@do-not-panic.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.