From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> To: Christian Lamparter <chunkeey@googlemail.com> Cc: ath9k-devel@qca.qualcomm.com, linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org, nbd@nbd.name, mark.rutland@arm.com, robh+dt@kernel.org, arend.vanspriel@broadcom.com, Mathias Kresin <dev@kresin.me> Subject: Re: [PATCH RFC v3 3/3] ath9k: parse the device configuration from an OF node Date: Sat, 25 Jun 2016 17:08:29 +0200 [thread overview] Message-ID: <CAFBinCBtjv4XoUyO6007hs0Aiut-mFxeq9jdEBq9d22dqzTvLw@mail.gmail.com> (raw) In-Reply-To: <2421107.Vh3zsAgVDf@debian64> On Sat, Jun 25, 2016 at 2:01 PM, Christian Lamparter <chunkeey@googlemail.com> wrote: > On Friday, June 24, 2016 02:34:30 PM Martin Blumenstingl wrote: >> This makes it possible to configure ath9k based devices using >> devicetree. That makes some out-of-tree "convert devicetree to >> ath9k_platform_data glue"-code obsolete. > > Hm, what about the embedded ath9k pcie chips that need the early > pci-fixup routine for the device to work properly [0], [1]? How > will this be handled/integrated? I know that the ar71xx and the > lantiq platforms use similar pci-fixup routines that need a few > bytes from the eeprom/cal data. So lantiq has a few extra properties: > "ath,pci-slot", "ath,device-id" and "ath,eep-flash". that is exactly the use-case I want to use your owl-loader for (see [0], it's a small kernel module which adds the PCI configuration for ath9k devices). This makes ath,pci-slot and ath,eep-flash obsolete. As far as I'm aware ath,device-id is a bit of a special case (mtd_read issues when the caldata is stored at an unaligned position on NOR flash). So this might be obsolete as well when using owl-loader. > As an example: the AR9280 in the Cisco Z1 AP is initially > 0x168c:0xff1f (<-- ath9k doesn't know about that id). The > pci-fixup routine will change it to 0x168c:0x002A. Only > then ath9k can take it over and will initialize it. > Thing is: this is all currently done by platform code for > those architectures... And currently, the request_firmware > doesn't work for caldata on UBI partitions. request_firmware is working on UBI partitions in many cases. It's just not working when request_firmware is called too early (and this is not UBI specific, other filesystems might be affected as well): if it is called before rootfs is mounted (which is the case when you call it from a PCI fixup function) then it's not working (like you said). The "solution" to this is to compile the driver as kernel module (once this is loadable everything else should be readable as well). Not only ath9k is affected by this "issue", this is simply a limitation of request_firmware and/or the linux boot chain. A few words regarding your owl-loader: First of all I would like to say "thank you"! Mathias and I are working on changing the lantiq target in LEDE to use owl-loader for all (ath9k) devices. All I had to do was to add another OWL PCI ID, implement a fallback for the firmware filename when there is no ath9k_platform_data (I'm using the same pattern as in PATCH 3/3 in this series). You can find the WIP code here: [1] Regards, Martin [0] https://patchwork.ozlabs.org/patch/607682/ [1] https://github.com/xdarklight/source/commits/ath9k-owl-loader-20160624
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> To: ath9k-devel@lists.ath9k.org Subject: [ath9k-devel] [PATCH RFC v3 3/3] ath9k: parse the device configuration from an OF node Date: Sat, 25 Jun 2016 17:08:29 +0200 [thread overview] Message-ID: <CAFBinCBtjv4XoUyO6007hs0Aiut-mFxeq9jdEBq9d22dqzTvLw@mail.gmail.com> (raw) In-Reply-To: <2421107.Vh3zsAgVDf@debian64> On Sat, Jun 25, 2016 at 2:01 PM, Christian Lamparter <chunkeey@googlemail.com> wrote: > On Friday, June 24, 2016 02:34:30 PM Martin Blumenstingl wrote: >> This makes it possible to configure ath9k based devices using >> devicetree. That makes some out-of-tree "convert devicetree to >> ath9k_platform_data glue"-code obsolete. > > Hm, what about the embedded ath9k pcie chips that need the early > pci-fixup routine for the device to work properly [0], [1]? How > will this be handled/integrated? I know that the ar71xx and the > lantiq platforms use similar pci-fixup routines that need a few > bytes from the eeprom/cal data. So lantiq has a few extra properties: > "ath,pci-slot", "ath,device-id" and "ath,eep-flash". that is exactly the use-case I want to use your owl-loader for (see [0], it's a small kernel module which adds the PCI configuration for ath9k devices). This makes ath,pci-slot and ath,eep-flash obsolete. As far as I'm aware ath,device-id is a bit of a special case (mtd_read issues when the caldata is stored at an unaligned position on NOR flash). So this might be obsolete as well when using owl-loader. > As an example: the AR9280 in the Cisco Z1 AP is initially > 0x168c:0xff1f (<-- ath9k doesn't know about that id). The > pci-fixup routine will change it to 0x168c:0x002A. Only > then ath9k can take it over and will initialize it. > Thing is: this is all currently done by platform code for > those architectures... And currently, the request_firmware > doesn't work for caldata on UBI partitions. request_firmware is working on UBI partitions in many cases. It's just not working when request_firmware is called too early (and this is not UBI specific, other filesystems might be affected as well): if it is called before rootfs is mounted (which is the case when you call it from a PCI fixup function) then it's not working (like you said). The "solution" to this is to compile the driver as kernel module (once this is loadable everything else should be readable as well). Not only ath9k is affected by this "issue", this is simply a limitation of request_firmware and/or the linux boot chain. A few words regarding your owl-loader: First of all I would like to say "thank you"! Mathias and I are working on changing the lantiq target in LEDE to use owl-loader for all (ath9k) devices. All I had to do was to add another OWL PCI ID, implement a fallback for the firmware filename when there is no ath9k_platform_data (I'm using the same pattern as in PATCH 3/3 in this series). You can find the WIP code here: [1] Regards, Martin [0] https://patchwork.ozlabs.org/patch/607682/ [1] https://github.com/xdarklight/source/commits/ath9k-owl-loader-20160624
next prev parent reply other threads:[~2016-06-25 15:09 UTC|newest] Thread overview: 161+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-24 12:34 [RFC v3] ath9k: add devicetree support to ath9k Martin Blumenstingl 2016-06-24 12:34 ` [ath9k-devel] " Martin Blumenstingl 2016-06-24 12:34 ` [PATCH RFC v3 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl 2016-06-24 12:34 ` [ath9k-devel] " Martin Blumenstingl 2016-06-27 0:20 ` Julian Calaby 2016-06-27 0:20 ` [ath9k-devel] " Julian Calaby 2016-06-27 9:49 ` Kalle Valo 2016-06-27 9:49 ` [ath9k-devel] " Kalle Valo 2016-06-24 12:34 ` [PATCH v3 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl 2016-06-24 12:34 ` [ath9k-devel] " Martin Blumenstingl 2016-06-27 10:26 ` Felix Fietkau 2016-06-27 10:26 ` [ath9k-devel] " Felix Fietkau 2016-06-29 22:37 ` Martin Blumenstingl 2016-06-29 22:37 ` [ath9k-devel] " Martin Blumenstingl 2016-06-24 12:34 ` [PATCH RFC v3 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl 2016-06-24 12:34 ` [ath9k-devel] " Martin Blumenstingl 2016-06-25 12:01 ` Christian Lamparter 2016-06-25 12:01 ` [ath9k-devel] " Christian Lamparter 2016-06-25 15:08 ` Martin Blumenstingl [this message] 2016-06-25 15:08 ` Martin Blumenstingl 2016-06-25 19:26 ` Christian Lamparter 2016-06-25 19:26 ` [ath9k-devel] " Christian Lamparter 2016-06-26 23:38 ` Martin Blumenstingl 2016-06-26 23:38 ` [ath9k-devel] " Martin Blumenstingl 2016-07-07 0:47 ` Luis R. Rodriguez 2016-07-07 1:03 ` [ath9k-devel] " Luis R. Rodriguez 2016-07-09 23:28 ` [PATCH v4 0/3] add devicetree support to ath9k Martin Blumenstingl 2016-07-09 23:28 ` [ath9k-devel] " Martin Blumenstingl 2016-07-09 23:28 ` Martin Blumenstingl 2016-07-09 23:28 ` [PATCH v4 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl 2016-07-09 23:28 ` [ath9k-devel] " Martin Blumenstingl 2016-07-09 23:28 ` Martin Blumenstingl 2016-07-10 20:52 ` Arnd Bergmann 2016-07-10 20:52 ` [ath9k-devel] " Arnd Bergmann 2016-07-10 20:52 ` Arnd Bergmann 2016-07-10 20:54 ` Martin Blumenstingl 2016-07-10 20:54 ` [ath9k-devel] " Martin Blumenstingl 2016-07-10 20:54 ` Martin Blumenstingl 2016-07-10 22:01 ` Arnd Bergmann 2016-07-10 22:01 ` [ath9k-devel] " Arnd Bergmann 2016-07-10 22:01 ` Arnd Bergmann 2016-07-11 21:21 ` Martin Blumenstingl 2016-07-11 21:21 ` [ath9k-devel] " Martin Blumenstingl 2016-07-11 21:21 ` Martin Blumenstingl 2016-07-14 12:33 ` Arnd Bergmann 2016-07-14 12:33 ` [ath9k-devel] " Arnd Bergmann 2016-07-14 12:33 ` Arnd Bergmann 2016-07-13 7:02 ` Kalle Valo 2016-07-13 7:02 ` [ath9k-devel] " Kalle Valo 2016-07-13 7:02 ` Kalle Valo 2016-07-13 7:47 ` Arnd Bergmann 2016-07-13 7:47 ` [ath9k-devel] " Arnd Bergmann 2016-07-13 7:47 ` Arnd Bergmann 2016-07-09 23:28 ` [PATCH v4 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl 2016-07-09 23:28 ` [ath9k-devel] " Martin Blumenstingl 2016-07-09 23:28 ` Martin Blumenstingl 2016-07-09 23:28 ` [PATCH v4 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl 2016-07-09 23:28 ` [ath9k-devel] " Martin Blumenstingl 2016-07-09 23:28 ` Martin Blumenstingl 2016-07-10 0:19 ` Bjørn Mork 2016-07-10 0:32 ` [ath9k-devel] " Bjørn Mork 2016-07-10 0:19 ` Bjørn Mork 2016-07-10 9:28 ` Oleksij Rempel 2016-07-10 9:28 ` [ath9k-devel] " Oleksij Rempel 2016-07-10 9:28 ` Oleksij Rempel 2016-07-10 20:56 ` Martin Blumenstingl 2016-07-10 20:56 ` [ath9k-devel] " Martin Blumenstingl 2016-07-10 20:56 ` Martin Blumenstingl 2016-08-21 14:31 ` [PATCH v5 0/3] add devicetree support to ath9k Martin Blumenstingl 2016-08-21 14:31 ` [ath9k-devel] " Martin Blumenstingl 2016-08-21 14:31 ` Martin Blumenstingl 2016-08-21 14:31 ` [PATCH v5 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl 2016-08-21 14:31 ` [ath9k-devel] " Martin Blumenstingl 2016-08-21 14:31 ` Martin Blumenstingl 2016-08-22 9:08 ` Arnd Bergmann 2016-08-22 9:08 ` [ath9k-devel] " Arnd Bergmann 2016-08-22 9:08 ` Arnd Bergmann 2016-08-28 20:51 ` Martin Blumenstingl 2016-08-28 20:51 ` [ath9k-devel] " Martin Blumenstingl 2016-08-28 20:51 ` Martin Blumenstingl 2016-08-29 12:12 ` Arnd Bergmann 2016-08-29 12:12 ` [ath9k-devel] " Arnd Bergmann 2016-08-29 12:12 ` Arnd Bergmann 2016-08-21 14:31 ` [PATCH v5 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl 2016-08-21 14:31 ` [ath9k-devel] " Martin Blumenstingl 2016-08-21 14:31 ` Martin Blumenstingl 2016-08-21 14:31 ` [PATCH v5 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl 2016-08-21 14:31 ` [ath9k-devel] " Martin Blumenstingl 2016-08-21 14:31 ` Martin Blumenstingl 2016-09-06 21:46 ` [PATCH v6 0/3] add devicetree support to ath9k Martin Blumenstingl 2016-09-06 21:46 ` [ath9k-devel] " Martin Blumenstingl 2016-09-06 21:46 ` Martin Blumenstingl 2016-09-06 21:46 ` [PATCH v6 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl 2016-09-06 21:46 ` [ath9k-devel] " Martin Blumenstingl 2016-09-06 21:46 ` Martin Blumenstingl 2016-09-09 7:48 ` Oleksij Rempel 2016-09-09 7:48 ` [ath9k-devel] " Oleksij Rempel 2016-09-09 7:48 ` Oleksij Rempel 2016-09-09 20:57 ` Martin Blumenstingl 2016-09-09 20:57 ` [ath9k-devel] " Martin Blumenstingl 2016-09-09 20:57 ` Martin Blumenstingl 2016-09-13 7:28 ` Oleksij Rempel 2016-09-13 7:28 ` [ath9k-devel] " Oleksij Rempel 2016-09-13 7:28 ` Oleksij Rempel 2016-09-16 12:45 ` Rob Herring 2016-09-16 12:45 ` [ath9k-devel] " Rob Herring 2016-09-16 12:45 ` Rob Herring 2016-09-18 21:51 ` Martin Blumenstingl 2016-09-18 21:51 ` [ath9k-devel] " Martin Blumenstingl 2016-09-18 21:51 ` Martin Blumenstingl 2016-09-16 12:37 ` Rob Herring 2016-09-16 12:55 ` [ath9k-devel] " Rob Herring 2016-09-16 12:37 ` Rob Herring 2016-09-06 21:46 ` [PATCH v6 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl 2016-09-06 21:46 ` [ath9k-devel] " Martin Blumenstingl 2016-09-06 21:46 ` Martin Blumenstingl 2016-09-06 21:46 ` [PATCH v6 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl 2016-09-06 21:46 ` [ath9k-devel] " Martin Blumenstingl 2016-09-06 21:46 ` Martin Blumenstingl 2016-10-02 21:47 ` [PATCH v7 0/3] add devicetree support to ath9k Martin Blumenstingl 2016-10-02 21:47 ` [ath9k-devel] " Martin Blumenstingl 2016-10-02 21:47 ` Martin Blumenstingl 2016-10-02 21:47 ` [PATCH v7 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl 2016-10-02 21:47 ` [ath9k-devel] " Martin Blumenstingl 2016-10-02 21:47 ` Martin Blumenstingl 2016-10-07 12:17 ` [v7, " Kalle Valo 2016-10-07 12:17 ` Kalle Valo 2016-10-07 12:17 ` [ath9k-devel] " Kalle Valo 2016-10-07 12:17 ` Kalle Valo 2016-10-07 12:17 ` Kalle Valo 2016-10-08 22:50 ` [PATCH v7 " Rob Herring 2016-10-09 1:28 ` Rob Herring 2016-10-09 1:29 ` [ath9k-devel] " Rob Herring 2016-10-09 1:28 ` Rob Herring 2016-10-09 9:54 ` Martin Blumenstingl 2016-10-09 9:54 ` [ath9k-devel] " Martin Blumenstingl 2016-10-09 9:54 ` Martin Blumenstingl 2016-10-02 21:47 ` [PATCH v7 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl 2016-10-02 21:47 ` [ath9k-devel] " Martin Blumenstingl 2016-10-02 21:47 ` Martin Blumenstingl 2016-10-02 21:47 ` [PATCH v7 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl 2016-10-02 21:47 ` [ath9k-devel] " Martin Blumenstingl 2016-10-02 21:47 ` Martin Blumenstingl 2016-10-16 20:59 ` [PATCH v8 0/3] add devicetree support to ath9k Martin Blumenstingl 2016-10-16 20:59 ` [ath9k-devel] " Martin Blumenstingl 2016-10-16 20:59 ` Martin Blumenstingl 2016-10-16 20:59 ` [PATCH v8 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl 2016-10-16 20:59 ` [ath9k-devel] " Martin Blumenstingl 2016-10-16 20:59 ` Martin Blumenstingl 2016-10-18 15:31 ` Rob Herring 2016-10-18 15:31 ` [ath9k-devel] " Rob Herring 2016-10-18 15:31 ` Rob Herring 2016-11-15 14:56 ` [v8, " Kalle Valo 2016-11-15 14:56 ` [ath9k-devel] " Kalle Valo 2016-11-15 14:56 ` Kalle Valo 2016-10-16 20:59 ` [PATCH v8 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl 2016-10-16 20:59 ` [ath9k-devel] " Martin Blumenstingl 2016-10-16 20:59 ` Martin Blumenstingl 2016-10-16 20:59 ` [PATCH v8 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl 2016-10-16 20:59 ` [ath9k-devel] " Martin Blumenstingl 2016-10-16 20:59 ` Martin Blumenstingl
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAFBinCBtjv4XoUyO6007hs0Aiut-mFxeq9jdEBq9d22dqzTvLw@mail.gmail.com \ --to=martin.blumenstingl@googlemail.com \ --cc=arend.vanspriel@broadcom.com \ --cc=ath9k-devel@lists.ath9k.org \ --cc=ath9k-devel@qca.qualcomm.com \ --cc=chunkeey@googlemail.com \ --cc=dev@kresin.me \ --cc=linux-wireless@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=nbd@nbd.name \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.