All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: "Juergen Gross" <JGross@suse.com>
Cc: <david.vrabel@citrix.com>, <xen-devel@lists.xenproject.org>,
	<boris.ostrovsky@oracle.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH v2] xen: Make VPMU init message look less scary
Date: Tue, 02 Aug 2016 01:10:02 -0600	[thread overview]
Message-ID: <57A0636A0200007800101998@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1470120213-16683-1-git-send-email-jgross@suse.com>

>>> On 02.08.16 at 08:43, <JGross@suse.com> wrote:
> --- a/arch/x86/xen/pmu.c
> +++ b/arch/x86/xen/pmu.c
> @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu)
>  	return;
>  
>  fail:
> -	pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
> -		cpu, err);
> +	if (err == -EOPNOTSUPP)
> +		pr_info_once("VPMU disabled by hypervisor.\n");
> +	else
> +		pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
> +			cpu, err);

I'm sorry for not already having thought about this for v1, but
what about older hypervisors, where the hypercall would return
-ENOSYS?

Jan

WARNING: multiple messages have this Message-ID (diff)
From: "Jan Beulich" <JBeulich@suse.com>
To: Juergen Gross <JGross@suse.com>
Cc: xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
	david.vrabel@citrix.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xen: Make VPMU init message look less scary
Date: Tue, 02 Aug 2016 01:10:02 -0600	[thread overview]
Message-ID: <57A0636A0200007800101998@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1470120213-16683-1-git-send-email-jgross@suse.com>

>>> On 02.08.16 at 08:43, <JGross@suse.com> wrote:
> --- a/arch/x86/xen/pmu.c
> +++ b/arch/x86/xen/pmu.c
> @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu)
>  	return;
>  
>  fail:
> -	pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
> -		cpu, err);
> +	if (err == -EOPNOTSUPP)
> +		pr_info_once("VPMU disabled by hypervisor.\n");
> +	else
> +		pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
> +			cpu, err);

I'm sorry for not already having thought about this for v1, but
what about older hypervisors, where the hypercall would return
-ENOSYS?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-08-02  8:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02  6:43 [PATCH v2] xen: Make VPMU init message look less scary Juergen Gross
2016-08-02  6:43 ` Juergen Gross
2016-08-02  7:10 ` Jan Beulich [this message]
2016-08-02  7:10   ` Jan Beulich
     [not found] ` <57A0636A0200007800101998@suse.com>
2016-08-02  7:12   ` [Xen-devel] " Juergen Gross
2016-08-02  7:12     ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57A0636A0200007800101998@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=JGross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.