* [U-Boot] [PATCH 0/5] power: pmic: Add support for Palmas family of PMICs
@ 2016-09-14 4:28 Keerthy
2016-09-14 4:28 ` [U-Boot] [PATCH 1/5] power: regulator: Add ctrl_reg and volt_reg fields for pmic Keerthy
` (4 more replies)
0 siblings, 5 replies; 13+ messages in thread
From: Keerthy @ 2016-09-14 4:28 UTC (permalink / raw)
To: u-boot
The series adds support for Palmas family of PMICs.
Implements functions to configure regulators. Enable/Disable
Get/Set voltages of regulators.
Supports TPS659038, TPS65917, Palmas.
Tested on TPS659038, TPS65917 using DRA7XX-EVM and AM57XX-EVM.
Keerthy (5):
power: regulator: Add ctrl_reg and volt_reg fields for pmic
power: pmic: Palmas: Add the base pmic support
power: regulator: palmas: Add regulator support
configs: am57xx_evm_defconfig: Enable PALMAS options
configs: dra7xx_evm_defconfig: Enable PALMAS options
configs/am57xx_evm_defconfig | 3 +
configs/dra7xx_evm_defconfig | 3 +
drivers/power/pmic/Kconfig | 7 +
drivers/power/pmic/Makefile | 1 +
drivers/power/pmic/palmas.c | 77 +++++
drivers/power/regulator/Kconfig | 8 +
drivers/power/regulator/Makefile | 1 +
drivers/power/regulator/palmas_regulator.c | 460 +++++++++++++++++++++++++++++
include/power/palmas.h | 25 ++
include/power/regulator.h | 2 +
10 files changed, 587 insertions(+)
create mode 100644 drivers/power/pmic/palmas.c
create mode 100644 drivers/power/regulator/palmas_regulator.c
create mode 100644 include/power/palmas.h
--
1.9.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 1/5] power: regulator: Add ctrl_reg and volt_reg fields for pmic
2016-09-14 4:28 [U-Boot] [PATCH 0/5] power: pmic: Add support for Palmas family of PMICs Keerthy
@ 2016-09-14 4:28 ` Keerthy
2016-09-14 8:03 ` Przemyslaw Marczak
2016-09-14 4:28 ` [U-Boot] [PATCH 2/5] power: pmic: Palmas: Add the base pmic support Keerthy
` (3 subsequent siblings)
4 siblings, 1 reply; 13+ messages in thread
From: Keerthy @ 2016-09-14 4:28 UTC (permalink / raw)
To: u-boot
The ctrl reg contains bit fields to enable and disable regulators,
and volt_reg has the bit fields to configure the voltage values.
The registers are frequently accessed hence make them part
of dm_regulator_uclass_platdata structure.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
include/power/regulator.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/power/regulator.h b/include/power/regulator.h
index 9bcd728..57b14a3 100644
--- a/include/power/regulator.h
+++ b/include/power/regulator.h
@@ -171,6 +171,8 @@ struct dm_regulator_uclass_platdata {
bool boot_on;
const char *name;
int flags;
+ u8 ctrl_reg;
+ u8 volt_reg;
};
/* Regulator device operations */
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 2/5] power: pmic: Palmas: Add the base pmic support
2016-09-14 4:28 [U-Boot] [PATCH 0/5] power: pmic: Add support for Palmas family of PMICs Keerthy
2016-09-14 4:28 ` [U-Boot] [PATCH 1/5] power: regulator: Add ctrl_reg and volt_reg fields for pmic Keerthy
@ 2016-09-14 4:28 ` Keerthy
2016-09-19 0:58 ` Simon Glass
2016-09-14 4:28 ` [U-Boot] [PATCH 3/5] power: regulator: palmas: Add regulator support Keerthy
` (2 subsequent siblings)
4 siblings, 1 reply; 13+ messages in thread
From: Keerthy @ 2016-09-14 4:28 UTC (permalink / raw)
To: u-boot
Add support to bind the regulators/child nodes with the pmic.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/pmic/Kconfig | 7 +++++
drivers/power/pmic/Makefile | 1 +
drivers/power/pmic/palmas.c | 77 +++++++++++++++++++++++++++++++++++++++++++++
include/power/palmas.h | 25 +++++++++++++++
4 files changed, 110 insertions(+)
create mode 100644 drivers/power/pmic/palmas.c
create mode 100644 include/power/palmas.h
diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig
index 69f8d51..92931c5 100644
--- a/drivers/power/pmic/Kconfig
+++ b/drivers/power/pmic/Kconfig
@@ -135,3 +135,10 @@ config PMIC_TPS65090
FETs and a battery charger. This driver provides register access
only, and you can enable the regulator/charger drivers separately if
required.
+
+config PMIC_PALMAS
+ bool "Enable driver for Texas Instruments PALMAS PMIC"
+ depends on DM_PMIC
+ ---help---
+ The PALMAS is a PMIC containing several LDOs, SMPS.
+ This driver binds the pmic children.
diff --git a/drivers/power/pmic/Makefile b/drivers/power/pmic/Makefile
index 52b4f71..828c0cf 100644
--- a/drivers/power/pmic/Makefile
+++ b/drivers/power/pmic/Makefile
@@ -15,6 +15,7 @@ obj-$(CONFIG_PMIC_PM8916) += pm8916.o
obj-$(CONFIG_PMIC_RK808) += rk808.o
obj-$(CONFIG_PMIC_TPS65090) += tps65090.o
obj-$(CONFIG_PMIC_S5M8767) += s5m8767.o
+obj-$(CONFIG_$(SPL_)PMIC_PALMAS) += palmas.o
obj-$(CONFIG_POWER_LTC3676) += pmic_ltc3676.o
obj-$(CONFIG_POWER_MAX77696) += pmic_max77696.o
diff --git a/drivers/power/pmic/palmas.c b/drivers/power/pmic/palmas.c
new file mode 100644
index 0000000..3cef2c9
--- /dev/null
+++ b/drivers/power/pmic/palmas.c
@@ -0,0 +1,77 @@
+/*
+ * (C) Copyright 2016 Texas Instruments Incorporated, <www.ti.com>
+ * Keerthy <j-keerthy@ti.com>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include <common.h>
+#include <fdtdec.h>
+#include <errno.h>
+#include <dm.h>
+#include <i2c.h>
+#include <power/pmic.h>
+#include <power/regulator.h>
+#include <power/palmas.h>
+#include <dm/device.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+static const struct pmic_child_info pmic_children_info[] = {
+ { .prefix = "ldo", .driver = PALMAS_LDO_DRIVER },
+ { .prefix = "smps", .driver = PALMAS_SMPS_DRIVER },
+ { },
+};
+
+static int palmas_bind(struct udevice *dev)
+{
+ int pmic_node = -1, regulators_node;
+ const void *blob = gd->fdt_blob;
+ int children;
+ int node = dev->of_offset;
+ int subnode, len;
+
+ fdt_for_each_subnode(blob, subnode, node) {
+ const char *name;
+ char *temp;
+
+ name = fdt_get_name(blob, subnode, &len);
+ temp = strstr(name, "pmic");
+ if (temp) {
+ pmic_node = subnode;
+ break;
+ }
+ }
+
+ if (pmic_node <= 0) {
+ printf("%s: %s pmic subnode not found!", __func__, dev->name);
+ return -ENXIO;
+ }
+
+ regulators_node = fdt_subnode_offset(blob, pmic_node, "regulators");
+
+ if (regulators_node <= 0) {
+ printf("%s: %s reg subnode not found!", __func__, dev->name);
+ return -ENXIO;
+ }
+
+ children = pmic_bind_children(dev, regulators_node, pmic_children_info);
+ if (!children)
+ printf("%s: %s - no child found\n", __func__, dev->name);
+
+ /* Always return success for this device */
+ return 0;
+}
+
+static const struct udevice_id palmas_ids[] = {
+ { .compatible = "ti,tps659038", .data = TPS659038 },
+ { .compatible = "ti,tps65917" , .data = TPS65917 },
+ { }
+};
+
+U_BOOT_DRIVER(pmic_palmas) = {
+ .name = "palmas_pmic",
+ .id = UCLASS_PMIC,
+ .of_match = palmas_ids,
+ .bind = palmas_bind,
+};
diff --git a/include/power/palmas.h b/include/power/palmas.h
new file mode 100644
index 0000000..bad5a35
--- /dev/null
+++ b/include/power/palmas.h
@@ -0,0 +1,25 @@
+#define PALMAS 0x0
+#define TPS659038 0x1
+#define TPS65917 0x2
+
+/* I2C device address for pmic palmas */
+#define PALMAS_I2C_ADDR (0x12 >> 1)
+#define PALMAS_LDO_NUM 11
+#define PALMAS_SMPS_NUM 8
+
+/* Drivers name */
+#define PALMAS_LDO_DRIVER "palmas_ldo"
+#define PALMAS_SMPS_DRIVER "palmas_smps"
+
+#define PALMAS_SMPS_VOLT_MASK 0x7F
+#define PALMAS_SMPS_RANGE_MASK 0x80
+#define PALMAS_SMPS_VOLT_MAX_HEX 0x7F
+#define PALMAS_SMPS_VOLT_MAX 3300000
+#define PALMAS_SMPS_MODE_MASK 0x3
+#define PALMAS_SMPS_STATUS_MASK 0x30
+
+#define PALMAS_LDO_VOLT_MASK 0x3F
+#define PALMAS_LDO_VOLT_MAX_HEX 0x3F
+#define PALMAS_LDO_VOLT_MAX 3300000
+#define PALMAS_LDO_MODE_MASK 0x1
+#define PALMAS_LDO_STATUS_MASK 0x10
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 3/5] power: regulator: palmas: Add regulator support
2016-09-14 4:28 [U-Boot] [PATCH 0/5] power: pmic: Add support for Palmas family of PMICs Keerthy
2016-09-14 4:28 ` [U-Boot] [PATCH 1/5] power: regulator: Add ctrl_reg and volt_reg fields for pmic Keerthy
2016-09-14 4:28 ` [U-Boot] [PATCH 2/5] power: pmic: Palmas: Add the base pmic support Keerthy
@ 2016-09-14 4:28 ` Keerthy
2016-09-19 0:58 ` Simon Glass
2016-09-14 4:28 ` [U-Boot] [PATCH 4/5] configs: am57xx_evm_defconfig: Enable PALMAS options Keerthy
2016-09-14 4:28 ` [U-Boot] [PATCH 5/5] configs: dra7xx_evm_defconfig: " Keerthy
4 siblings, 1 reply; 13+ messages in thread
From: Keerthy @ 2016-09-14 4:28 UTC (permalink / raw)
To: u-boot
The driver provides regulator set/get voltage
enable/disable functions for palmas family of PMICs.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/regulator/Kconfig | 8 +
drivers/power/regulator/Makefile | 1 +
drivers/power/regulator/palmas_regulator.c | 460 +++++++++++++++++++++++++++++
3 files changed, 469 insertions(+)
create mode 100644 drivers/power/regulator/palmas_regulator.c
diff --git a/drivers/power/regulator/Kconfig b/drivers/power/regulator/Kconfig
index 17f22dd..adb710a 100644
--- a/drivers/power/regulator/Kconfig
+++ b/drivers/power/regulator/Kconfig
@@ -115,3 +115,11 @@ config REGULATOR_TPS65090
regulators, one for each FET. The standard regulator interface is
supported, but it is only possible to turn the regulators on or off.
There is no voltage/current control.
+
+config DM_REGULATOR_PALMAS
+ bool "Enable driver for PALMAS PMIC regulators"
+ depends on PMIC_PALMAS
+ ---help---
+ This enables implementation of driver-model regulator uclass
+ features for REGULATOR PALMAS and the family of PALMAS PMICs.
+ The driver implements get/set api for: value and enable.
diff --git a/drivers/power/regulator/Makefile b/drivers/power/regulator/Makefile
index 1590d85..75080d4 100644
--- a/drivers/power/regulator/Makefile
+++ b/drivers/power/regulator/Makefile
@@ -14,3 +14,4 @@ obj-$(CONFIG_REGULATOR_RK808) += rk808.o
obj-$(CONFIG_REGULATOR_S5M8767) += s5m8767.o
obj-$(CONFIG_DM_REGULATOR_SANDBOX) += sandbox.o
obj-$(CONFIG_REGULATOR_TPS65090) += tps65090_regulator.o
+obj-$(CONFIG_$(SPL_)DM_REGULATOR_PALMAS) += palmas_regulator.o
diff --git a/drivers/power/regulator/palmas_regulator.c b/drivers/power/regulator/palmas_regulator.c
new file mode 100644
index 0000000..6a506fd
--- /dev/null
+++ b/drivers/power/regulator/palmas_regulator.c
@@ -0,0 +1,460 @@
+/*
+ * (C) Copyright 2016
+ * Texas Instruments Incorporated, <www.ti.com>
+ *
+ * Keerthy <j-keerthy@ti.com>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include <common.h>
+#include <fdtdec.h>
+#include <errno.h>
+#include <dm.h>
+#include <i2c.h>
+#include <power/pmic.h>
+#include <power/regulator.h>
+#include <power/palmas.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#define REGULATOR_ON 0x1
+#define REGULATOR_OFF 0x0
+
+#define SMPS_MODE_MASK 0x3
+#define SMPS_MODE_SHIFT 0x0
+#define LDO_MODE_MASK 0x1
+#define LDO_MODE_SHIFT 0x0
+
+static const char palmas_smps_ctrl[][PALMAS_SMPS_NUM] = {
+ {0x20, 0x24, 0x28, 0x2c, 0x30, 0x34, 0x38, 0x3c},
+ {0x20, 0x24, 0x28, 0x2c, 0x30, 0x34, 0x38},
+ {0x20, 0x24, 0x2c, 0x30, 0x38},
+};
+
+static const char palmas_smps_volt[][PALMAS_SMPS_NUM] = {
+ {0x23, 0x27, 0x2b, 0x2f, 0x33, 0x37, 0x3b, 0x3c},
+ {0x23, 0x27, 0x2b, 0x2f, 0x33, 0x37, 0x3b},
+ {0x23, 0x27, 0x2f, 0x33, 0x3B}
+};
+
+static const char palmas_ldo_ctrl[][PALMAS_LDO_NUM] = {
+ {0x50, 0x52, 0x54, 0x56, 0x58, 0x5a, 0x5c, 0x5e, 0x60, 0x62, 0x64},
+ {0x50, 0x52, 0x54, 0x56, 0x58, 0x5a, 0x5c, 0x5e, 0x60, 0x62, 0x64},
+ {0x50, 0x52, 0x54, 0x5e, 0x62}
+};
+
+static const char palmas_ldo_volt[][PALMAS_LDO_NUM] = {
+ {0x51, 0x53, 0x55, 0x57, 0x59, 0x5b, 0x5d, 0x5f, 0x61, 0x63, 0x65},
+ {0x51, 0x53, 0x55, 0x57, 0x59, 0x5b, 0x5d, 0x5f, 0x61, 0x63, 0x65},
+ {0x51, 0x53, 0x55, 0x5f, 0x63}
+};
+
+static int palmas_smps_enable(struct udevice *dev, int op, bool *enable)
+{
+ int ret;
+ uint8_t val;
+ unsigned int adr;
+ struct dm_regulator_uclass_platdata *uc_pdata;
+
+ uc_pdata = dev_get_uclass_platdata(dev);
+ adr = uc_pdata->ctrl_reg;
+
+ ret = dm_i2c_read(dev->parent, adr, &val, 1);
+ if (ret)
+ return ret;
+
+ if (op == PMIC_OP_GET) {
+ val &= PALMAS_SMPS_STATUS_MASK;
+
+ if (val)
+ *enable = true;
+ else
+ *enable = false;
+
+ return 0;
+ } else if (op == PMIC_OP_SET) {
+ if (*enable)
+ val |= PALMAS_SMPS_MODE_MASK;
+ else
+ val &= ~(PALMAS_SMPS_MODE_MASK);
+
+ dm_i2c_write(dev->parent, adr, &val, 1);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
+static int palmas_smps_volt2hex(int uV)
+{
+ if (uV > PALMAS_LDO_VOLT_MAX)
+ return -EINVAL;
+
+ if (uV > 1650000)
+ return (uV - 1000000) / 20000 + 0x6;
+
+ if (uV == 500000)
+ return 0x6;
+ else
+ return 0x6 + ((uV - 500000) / 10000);
+}
+
+static int palmas_smps_hex2volt(int hex, bool range)
+{
+ unsigned int uV = 0;
+
+ if (hex > PALMAS_SMPS_VOLT_MAX_HEX)
+ return -EINVAL;
+
+ if (hex < 0x7)
+ uV = 500000;
+ else
+ uV = 500000 + (hex - 0x6) * 10000;
+
+ if (range)
+ uV *= 2;
+
+ return uV;
+}
+
+static int palmas_smps_val(struct udevice *dev, int op, int *uV)
+{
+ unsigned int hex, adr;
+ unsigned char val;
+ int ret;
+ bool range;
+ struct dm_regulator_uclass_platdata *uc_pdata;
+
+ uc_pdata = dev_get_uclass_platdata(dev);
+
+ if (op == PMIC_OP_GET)
+ *uV = 0;
+
+ adr = uc_pdata->volt_reg;
+
+ ret = dm_i2c_read(dev->parent, adr, &val, 1);
+ if (ret)
+ return ret;
+
+ if (op == PMIC_OP_GET) {
+ if (val & PALMAS_SMPS_RANGE_MASK)
+ range = true;
+ else
+ range = false;
+
+ val &= PALMAS_SMPS_VOLT_MASK;
+ ret = palmas_smps_hex2volt(val, range);
+ if (ret < 0)
+ return ret;
+ *uV = ret;
+
+ return 0;
+ }
+
+ hex = palmas_smps_volt2hex(*uV);
+ if (hex < 0)
+ return hex;
+
+ val &= ~PALMAS_SMPS_VOLT_MASK;
+ val |= hex;
+ if (*uV > 1650000)
+ val |= PALMAS_SMPS_RANGE_MASK;
+ ret = dm_i2c_write(dev->parent, adr, &val, 1);
+
+ return ret;
+}
+
+static int palmas_ldo_enable(struct udevice *dev, int op, bool *enable)
+{
+ int ret;
+ uint8_t val;
+ unsigned int adr;
+ struct dm_regulator_uclass_platdata *uc_pdata;
+
+ uc_pdata = dev_get_uclass_platdata(dev);
+ adr = uc_pdata->ctrl_reg;
+
+ ret = dm_i2c_read(dev->parent, adr, &val, 1);
+ if (ret)
+ return ret;
+
+ if (op == PMIC_OP_GET) {
+ val &= PALMAS_LDO_STATUS_MASK;
+
+ if (val)
+ *enable = true;
+ else
+ *enable = false;
+
+ return 0;
+ } else if (op == PMIC_OP_SET) {
+ if (*enable)
+ val |= PALMAS_LDO_MODE_MASK;
+ else
+ val &= ~(PALMAS_LDO_MODE_MASK);
+
+ dm_i2c_write(dev->parent, adr, &val, 1);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
+static int palmas_ldo_volt2hex(int uV)
+{
+ if (uV > PALMAS_LDO_VOLT_MAX)
+ return -EINVAL;
+
+ return (uV - 850000) / 50000;
+}
+
+static int palmas_ldo_hex2volt(int hex)
+{
+ if (hex > PALMAS_LDO_VOLT_MAX_HEX)
+ return -EINVAL;
+
+ if (!hex)
+ return 0;
+
+ return (hex * 50000) + 850000;
+}
+
+static int palmas_ldo_val(struct udevice *dev, int op, int *uV)
+{
+ unsigned int hex, adr;
+ unsigned char val;
+ int ret;
+
+ struct dm_regulator_uclass_platdata *uc_pdata;
+
+ if (op == PMIC_OP_GET)
+ *uV = 0;
+
+ uc_pdata = dev_get_uclass_platdata(dev);
+
+ adr = uc_pdata->volt_reg;
+
+ ret = dm_i2c_read(dev->parent, adr, &val, 1);
+ if (ret)
+ return ret;
+
+ if (op == PMIC_OP_GET) {
+ val &= PALMAS_LDO_VOLT_MASK;
+ ret = palmas_ldo_hex2volt(val);
+ if (ret < 0)
+ return ret;
+ *uV = ret;
+ return 0;
+ }
+
+ hex = palmas_ldo_volt2hex(*uV);
+ if (hex < 0)
+ return hex;
+
+ val &= ~PALMAS_LDO_VOLT_MASK;
+ val |= hex;
+ if (*uV > 1650000)
+ val |= 0x80;
+ ret = dm_i2c_write(dev->parent, adr, &val, 1);
+
+ return ret;
+}
+
+static int palmas_ldo_probe(struct udevice *dev)
+{
+ struct dm_regulator_uclass_platdata *uc_pdata;
+ struct udevice *parent;
+
+ uc_pdata = dev_get_uclass_platdata(dev);
+
+ parent = dev_get_parent(dev);
+ int type = dev_get_driver_data(parent);
+
+ uc_pdata->type = REGULATOR_TYPE_LDO;
+
+ if (dev->driver_data) {
+ u8 idx = dev->driver_data - 1;
+ uc_pdata->ctrl_reg = palmas_ldo_ctrl[type][idx];
+ uc_pdata->volt_reg = palmas_ldo_volt[type][idx];
+ } else {
+ /* check for ldoln and ldousb cases */
+ if (!strcmp("ldoln", dev->name)) {
+ uc_pdata->ctrl_reg = palmas_ldo_ctrl[type][9];
+ uc_pdata->volt_reg = palmas_ldo_volt[type][9];
+ } else if (!strcmp("ldousb", dev->name)) {
+ uc_pdata->ctrl_reg = palmas_ldo_ctrl[type][10];
+ uc_pdata->volt_reg = palmas_ldo_volt[type][10];
+ }
+ }
+
+ return 0;
+}
+
+static int ldo_get_value(struct udevice *dev)
+{
+ int uV;
+ int ret;
+
+ ret = palmas_ldo_val(dev, PMIC_OP_GET, &uV);
+ if (ret)
+ return ret;
+
+ return uV;
+}
+
+static int ldo_set_value(struct udevice *dev, int uV)
+{
+ return palmas_ldo_val(dev, PMIC_OP_SET, &uV);
+}
+
+static bool ldo_get_enable(struct udevice *dev)
+{
+ bool enable = false;
+ int ret;
+
+ ret = palmas_ldo_enable(dev, PMIC_OP_GET, &enable);
+ if (ret)
+ return ret;
+
+ return enable;
+}
+
+static int ldo_set_enable(struct udevice *dev, bool enable)
+{
+ return palmas_ldo_enable(dev, PMIC_OP_SET, &enable);
+}
+
+static int palmas_smps_probe(struct udevice *dev)
+{
+ struct dm_regulator_uclass_platdata *uc_pdata;
+ struct udevice *parent;
+ int idx;
+
+ uc_pdata = dev_get_uclass_platdata(dev);
+
+ parent = dev_get_parent(dev);
+ int type = dev_get_driver_data(parent);
+
+ uc_pdata->type = REGULATOR_TYPE_BUCK;
+
+ switch (type) {
+ case PALMAS:
+ case TPS659038:
+ switch (dev->driver_data) {
+ case 123:
+ case 12:
+ uc_pdata->ctrl_reg = palmas_smps_ctrl[type][0];
+ uc_pdata->volt_reg = palmas_smps_volt[type][0];
+ break;
+ case 3:
+ uc_pdata->ctrl_reg = palmas_smps_ctrl[type][1];
+ uc_pdata->volt_reg = palmas_smps_volt[type][1];
+ break;
+ case 45:
+ uc_pdata->ctrl_reg = palmas_smps_ctrl[type][2];
+ uc_pdata->volt_reg = palmas_smps_volt[type][2];
+ break;
+ case 6:
+ case 7:
+ case 8:
+ case 9:
+ case 10:
+ idx = dev->driver_data - 4;
+ uc_pdata->ctrl_reg = palmas_smps_ctrl[type][idx];
+ uc_pdata->volt_reg = palmas_smps_volt[type][idx];
+ break;
+
+ default:
+ printf("Wrong ID for regulator\n");
+ }
+ break;
+
+ case TPS65917:
+ switch (dev->driver_data) {
+ case 1:
+ case 2:
+ case 3:
+ case 4:
+ case 5:
+ idx = dev->driver_data - 1;
+ uc_pdata->ctrl_reg = palmas_smps_ctrl[type][idx];
+ uc_pdata->volt_reg = palmas_smps_volt[type][idx];
+ break;
+
+ default:
+ printf("Wrong ID for regulator\n");
+ }
+ break;
+
+ default:
+ printf("Invalid PMIC ID\n");
+ }
+
+ return 0;
+}
+
+static int smps_get_value(struct udevice *dev)
+{
+ int uV;
+ int ret;
+
+ ret = palmas_smps_val(dev, PMIC_OP_GET, &uV);
+ if (ret)
+ return ret;
+
+ return uV;
+}
+
+static int smps_set_value(struct udevice *dev, int uV)
+{
+ return palmas_smps_val(dev, PMIC_OP_SET, &uV);
+}
+
+static bool smps_get_enable(struct udevice *dev)
+{
+ bool enable = false;
+ int ret;
+
+
+ ret = palmas_smps_enable(dev, PMIC_OP_GET, &enable);
+ if (ret)
+ return ret;
+
+ return enable;
+}
+
+static int smps_set_enable(struct udevice *dev, bool enable)
+{
+ return palmas_smps_enable(dev, PMIC_OP_SET, &enable);
+}
+
+static const struct dm_regulator_ops palmas_ldo_ops = {
+ .get_value = ldo_get_value,
+ .set_value = ldo_set_value,
+ .get_enable = ldo_get_enable,
+ .set_enable = ldo_set_enable,
+};
+
+U_BOOT_DRIVER(palmas_ldo) = {
+ .name = PALMAS_LDO_DRIVER,
+ .id = UCLASS_REGULATOR,
+ .ops = &palmas_ldo_ops,
+ .probe = palmas_ldo_probe,
+};
+
+static const struct dm_regulator_ops palmas_smps_ops = {
+ .get_value = smps_get_value,
+ .set_value = smps_set_value,
+ .get_enable = smps_get_enable,
+ .set_enable = smps_set_enable,
+};
+
+U_BOOT_DRIVER(palmas_smps) = {
+ .name = PALMAS_SMPS_DRIVER,
+ .id = UCLASS_REGULATOR,
+ .ops = &palmas_smps_ops,
+ .probe = palmas_smps_probe,
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 4/5] configs: am57xx_evm_defconfig: Enable PALMAS options
2016-09-14 4:28 [U-Boot] [PATCH 0/5] power: pmic: Add support for Palmas family of PMICs Keerthy
` (2 preceding siblings ...)
2016-09-14 4:28 ` [U-Boot] [PATCH 3/5] power: regulator: palmas: Add regulator support Keerthy
@ 2016-09-14 4:28 ` Keerthy
2016-09-14 4:28 ` [U-Boot] [PATCH 5/5] configs: dra7xx_evm_defconfig: " Keerthy
4 siblings, 0 replies; 13+ messages in thread
From: Keerthy @ 2016-09-14 4:28 UTC (permalink / raw)
To: u-boot
Enable palmas PMIC config options.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
configs/am57xx_evm_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/am57xx_evm_defconfig b/configs/am57xx_evm_defconfig
index d49129d..b277783 100644
--- a/configs/am57xx_evm_defconfig
+++ b/configs/am57xx_evm_defconfig
@@ -39,6 +39,9 @@ CONFIG_DM_SPI_FLASH=y
CONFIG_SPI_FLASH=y
CONFIG_SPI_FLASH_BAR=y
CONFIG_SPI_FLASH_SPANSION=y
+CONFIG_DM_PMIC=y
+CONFIG_PMIC_PALMAS=y
+CONFIG_DM_REGULATOR_PALMAS=y
CONFIG_DM_SERIAL=y
CONFIG_SYS_NS16550=y
CONFIG_DM_SPI=y
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 5/5] configs: dra7xx_evm_defconfig: Enable PALMAS options
2016-09-14 4:28 [U-Boot] [PATCH 0/5] power: pmic: Add support for Palmas family of PMICs Keerthy
` (3 preceding siblings ...)
2016-09-14 4:28 ` [U-Boot] [PATCH 4/5] configs: am57xx_evm_defconfig: Enable PALMAS options Keerthy
@ 2016-09-14 4:28 ` Keerthy
4 siblings, 0 replies; 13+ messages in thread
From: Keerthy @ 2016-09-14 4:28 UTC (permalink / raw)
To: u-boot
Enable palmas PMIC config options.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
configs/dra7xx_evm_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configs/dra7xx_evm_defconfig b/configs/dra7xx_evm_defconfig
index 64184de..882e615 100644
--- a/configs/dra7xx_evm_defconfig
+++ b/configs/dra7xx_evm_defconfig
@@ -43,8 +43,11 @@ CONFIG_SPI_FLASH=y
CONFIG_SPI_FLASH_BAR=y
CONFIG_SPI_FLASH_SPANSION=y
CONFIG_DM_ETH=y
+CONFIG_DM_PMIC=y
+CONFIG_PMIC_PALMAS=y
CONFIG_DM_REGULATOR=y
CONFIG_DM_REGULATOR_FIXED=y
+CONFIG_DM_REGULATOR_PALMAS=y
CONFIG_DM_SERIAL=y
CONFIG_SYS_NS16550=y
CONFIG_DM_SPI=y
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 1/5] power: regulator: Add ctrl_reg and volt_reg fields for pmic
2016-09-14 4:28 ` [U-Boot] [PATCH 1/5] power: regulator: Add ctrl_reg and volt_reg fields for pmic Keerthy
@ 2016-09-14 8:03 ` Przemyslaw Marczak
2016-09-14 8:24 ` Keerthy
0 siblings, 1 reply; 13+ messages in thread
From: Przemyslaw Marczak @ 2016-09-14 8:03 UTC (permalink / raw)
To: u-boot
Hello Keerthy,
On 09/14/2016 06:28 AM, Keerthy wrote:
> The ctrl reg contains bit fields to enable and disable regulators,
> and volt_reg has the bit fields to configure the voltage values.
> The registers are frequently accessed hence make them part
> of dm_regulator_uclass_platdata structure.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> include/power/regulator.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/power/regulator.h b/include/power/regulator.h
> index 9bcd728..57b14a3 100644
> --- a/include/power/regulator.h
> +++ b/include/power/regulator.h
> @@ -171,6 +171,8 @@ struct dm_regulator_uclass_platdata {
> bool boot_on;
> const char *name;
> int flags;
> + u8 ctrl_reg;
> + u8 volt_reg;
> };
>
> /* Regulator device operations */
This structure above is used for some common "high-level" data, which
can be used by regulator uclass driver.
Even if most of PMICs has some ctrl/volt/etc regs, the regulator uclass
driver doesn't know, how to use it, so from this point of view it is
useless.
But, you can keep device/driver data in a proper fields. Please look at
those files:
drivers/power/regulator/fixed.c:119
drivers/power/regulator/pfuze100.c:567
To store some device internal data, you can use:
.platdata_auto_alloc_size -> with access by dev_get_platdata()
.priv_auto_alloc_size -> with access by dev_get_priv()
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 1/5] power: regulator: Add ctrl_reg and volt_reg fields for pmic
2016-09-14 8:03 ` Przemyslaw Marczak
@ 2016-09-14 8:24 ` Keerthy
2016-09-14 11:56 ` Przemyslaw Marczak
0 siblings, 1 reply; 13+ messages in thread
From: Keerthy @ 2016-09-14 8:24 UTC (permalink / raw)
To: u-boot
Hi Marczak,
On Wednesday 14 September 2016 01:33 PM, Przemyslaw Marczak wrote:
> Hello Keerthy,
>
> On 09/14/2016 06:28 AM, Keerthy wrote:
>> The ctrl reg contains bit fields to enable and disable regulators,
>> and volt_reg has the bit fields to configure the voltage values.
>> The registers are frequently accessed hence make them part
>> of dm_regulator_uclass_platdata structure.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> include/power/regulator.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/include/power/regulator.h b/include/power/regulator.h
>> index 9bcd728..57b14a3 100644
>> --- a/include/power/regulator.h
>> +++ b/include/power/regulator.h
>> @@ -171,6 +171,8 @@ struct dm_regulator_uclass_platdata {
>> bool boot_on;
>> const char *name;
>> int flags;
>> + u8 ctrl_reg;
>> + u8 volt_reg;
>> };
>> /* Regulator device operations */
>
> This structure above is used for some common "high-level" data, which
> can be used by regulator uclass driver.
>
> Even if most of PMICs has some ctrl/volt/etc regs, the regulator uclass
> driver doesn't know, how to use it, so from this point of view it is
> useless.
>
> But, you can keep device/driver data in a proper fields. Please look at
> those files:
>
> drivers/power/regulator/fixed.c:119
> drivers/power/regulator/pfuze100.c:567
>
> To store some device internal data, you can use:
> .platdata_auto_alloc_size -> with access by dev_get_platdata()
> .priv_auto_alloc_size -> with access by dev_get_priv()
Thanks for a quick review. I did look at some of those options before
introducing volt and ctrl here.
Many PMICs will have ctrl/volt registers we might end up having lot of
private strutures with the same ctrl/volt fields. I agree uclass driver
will not know how to use it.
If i have to draw parallels from the kernel world regulator_desc is a
common structure which hosts vsel_reg/enable_reg fields.
Isn't it better to have a common structure instead of having a some
platform specific structure that might have the same fields?
Let me know your thoughts on this.
>
> Best regards,
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 1/5] power: regulator: Add ctrl_reg and volt_reg fields for pmic
2016-09-14 8:24 ` Keerthy
@ 2016-09-14 11:56 ` Przemyslaw Marczak
2016-09-15 8:17 ` Keerthy
0 siblings, 1 reply; 13+ messages in thread
From: Przemyslaw Marczak @ 2016-09-14 11:56 UTC (permalink / raw)
To: u-boot
Hello Keerthy,
On 09/14/2016 10:24 AM, Keerthy wrote:
> Hi Marczak,
>
> On Wednesday 14 September 2016 01:33 PM, Przemyslaw Marczak wrote:
>> Hello Keerthy,
>>
>> On 09/14/2016 06:28 AM, Keerthy wrote:
>>> The ctrl reg contains bit fields to enable and disable regulators,
>>> and volt_reg has the bit fields to configure the voltage values.
>>> The registers are frequently accessed hence make them part
>>> of dm_regulator_uclass_platdata structure.
>>>
>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>> ---
>>> include/power/regulator.h | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/include/power/regulator.h b/include/power/regulator.h
>>> index 9bcd728..57b14a3 100644
>>> --- a/include/power/regulator.h
>>> +++ b/include/power/regulator.h
>>> @@ -171,6 +171,8 @@ struct dm_regulator_uclass_platdata {
>>> bool boot_on;
>>> const char *name;
>>> int flags;
>>> + u8 ctrl_reg;
>>> + u8 volt_reg;
>>> };
>>> /* Regulator device operations */
>>
>> This structure above is used for some common "high-level" data, which
>> can be used by regulator uclass driver.
>>
>> Even if most of PMICs has some ctrl/volt/etc regs, the regulator uclass
>> driver doesn't know, how to use it, so from this point of view it is
>> useless.
>>
>> But, you can keep device/driver data in a proper fields. Please look at
>> those files:
>>
>> drivers/power/regulator/fixed.c:119
>> drivers/power/regulator/pfuze100.c:567
>>
>> To store some device internal data, you can use:
>> .platdata_auto_alloc_size -> with access by dev_get_platdata()
>> .priv_auto_alloc_size -> with access by dev_get_priv()
>
> Thanks for a quick review. I did look at some of those options before
> introducing volt and ctrl here.
>
> Many PMICs will have ctrl/volt registers we might end up having lot of
> private strutures with the same ctrl/volt fields. I agree uclass
> driver will not know how to use it.
>
> If i have to draw parallels from the kernel world regulator_desc is a
> common structure which hosts vsel_reg/enable_reg fields.
>
> Isn't it better to have a common structure instead of having a some
> platform specific structure that might have the same fields?
>
> Let me know your thoughts on this.
>
>>
>> Best regards,
>
>
>
You are right and I agree with you that make things common is a good
approach.
At the begin of introducing this framework, I just wanted to provide a
simple user interface for regulators, so I didn't tried to put all
common things into a single structure, because not always it could be
useful.
The present structure layout seems to be a good representation of
regulator's node in the device-tree.
In the other hand, each driver can provide a static arrays with proper
data like reg/mask/etc,
the driver:
drivers/power/regulator/s5m8767.c- is a good example.
I'm not going to break your solution, but let's wait for Simon's opinion.
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 1/5] power: regulator: Add ctrl_reg and volt_reg fields for pmic
2016-09-14 11:56 ` Przemyslaw Marczak
@ 2016-09-15 8:17 ` Keerthy
0 siblings, 0 replies; 13+ messages in thread
From: Keerthy @ 2016-09-15 8:17 UTC (permalink / raw)
To: u-boot
On Wednesday 14 September 2016 05:26 PM, Przemyslaw Marczak wrote:
> Hello Keerthy,
>
> On 09/14/2016 10:24 AM, Keerthy wrote:
>> Hi Marczak,
>>
>> On Wednesday 14 September 2016 01:33 PM, Przemyslaw Marczak wrote:
>>> Hello Keerthy,
>>>
>>> On 09/14/2016 06:28 AM, Keerthy wrote:
>>>> The ctrl reg contains bit fields to enable and disable regulators,
>>>> and volt_reg has the bit fields to configure the voltage values.
>>>> The registers are frequently accessed hence make them part
>>>> of dm_regulator_uclass_platdata structure.
>>>>
>>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>>> ---
>>>> include/power/regulator.h | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/include/power/regulator.h b/include/power/regulator.h
>>>> index 9bcd728..57b14a3 100644
>>>> --- a/include/power/regulator.h
>>>> +++ b/include/power/regulator.h
>>>> @@ -171,6 +171,8 @@ struct dm_regulator_uclass_platdata {
>>>> bool boot_on;
>>>> const char *name;
>>>> int flags;
>>>> + u8 ctrl_reg;
>>>> + u8 volt_reg;
>>>> };
>>>> /* Regulator device operations */
>>>
>>> This structure above is used for some common "high-level" data, which
>>> can be used by regulator uclass driver.
>>>
>>> Even if most of PMICs has some ctrl/volt/etc regs, the regulator uclass
>>> driver doesn't know, how to use it, so from this point of view it is
>>> useless.
>>>
>>> But, you can keep device/driver data in a proper fields. Please look at
>>> those files:
>>>
>>> drivers/power/regulator/fixed.c:119
>>> drivers/power/regulator/pfuze100.c:567
>>>
>>> To store some device internal data, you can use:
>>> .platdata_auto_alloc_size -> with access by dev_get_platdata()
>>> .priv_auto_alloc_size -> with access by dev_get_priv()
>>
>> Thanks for a quick review. I did look at some of those options before
>> introducing volt and ctrl here.
>>
>> Many PMICs will have ctrl/volt registers we might end up having lot of
>> private strutures with the same ctrl/volt fields. I agree uclass
>> driver will not know how to use it.
>>
>> If i have to draw parallels from the kernel world regulator_desc is a
>> common structure which hosts vsel_reg/enable_reg fields.
>>
>> Isn't it better to have a common structure instead of having a some
>> platform specific structure that might have the same fields?
>>
>> Let me know your thoughts on this.
>>
>>>
>>> Best regards,
>>
>>
>>
>
> You are right and I agree with you that make things common is a good
> approach.
>
> At the begin of introducing this framework, I just wanted to provide a
> simple user interface for regulators, so I didn't tried to put all
> common things into a single structure, because not always it could be
> useful.
>
> The present structure layout seems to be a good representation of
> regulator's node in the device-tree.
>
> In the other hand, each driver can provide a static arrays with proper
> data like reg/mask/etc,
> the driver:
> drivers/power/regulator/s5m8767.c- is a good example.
>
> I'm not going to break your solution, but let's wait for Simon's opinion.
okay.
>
> Best regards,
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 2/5] power: pmic: Palmas: Add the base pmic support
2016-09-14 4:28 ` [U-Boot] [PATCH 2/5] power: pmic: Palmas: Add the base pmic support Keerthy
@ 2016-09-19 0:58 ` Simon Glass
0 siblings, 0 replies; 13+ messages in thread
From: Simon Glass @ 2016-09-19 0:58 UTC (permalink / raw)
To: u-boot
On 13 September 2016 at 22:28, Keerthy <j-keerthy@ti.com> wrote:
> Add support to bind the regulators/child nodes with the pmic.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/power/pmic/Kconfig | 7 +++++
> drivers/power/pmic/Makefile | 1 +
> drivers/power/pmic/palmas.c | 77 +++++++++++++++++++++++++++++++++++++++++++++
> include/power/palmas.h | 25 +++++++++++++++
> 4 files changed, 110 insertions(+)
> create mode 100644 drivers/power/pmic/palmas.c
> create mode 100644 include/power/palmas.h
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 3/5] power: regulator: palmas: Add regulator support
2016-09-14 4:28 ` [U-Boot] [PATCH 3/5] power: regulator: palmas: Add regulator support Keerthy
@ 2016-09-19 0:58 ` Simon Glass
2016-09-19 3:31 ` Keerthy
0 siblings, 1 reply; 13+ messages in thread
From: Simon Glass @ 2016-09-19 0:58 UTC (permalink / raw)
To: u-boot
On 13 September 2016 at 22:28, Keerthy <j-keerthy@ti.com> wrote:
> The driver provides regulator set/get voltage
> enable/disable functions for palmas family of PMICs.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/power/regulator/Kconfig | 8 +
> drivers/power/regulator/Makefile | 1 +
> drivers/power/regulator/palmas_regulator.c | 460 +++++++++++++++++++++++++++++
> 3 files changed, 469 insertions(+)
> create mode 100644 drivers/power/regulator/palmas_regulator.c
Reviewed-by: Simon Glass <sjg@chromium.org>
But please consider using dm_i2c_reg_read()
Also you have two blank lines at one point.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [U-Boot] [PATCH 3/5] power: regulator: palmas: Add regulator support
2016-09-19 0:58 ` Simon Glass
@ 2016-09-19 3:31 ` Keerthy
0 siblings, 0 replies; 13+ messages in thread
From: Keerthy @ 2016-09-19 3:31 UTC (permalink / raw)
To: u-boot
On Monday 19 September 2016 06:28 AM, Simon Glass wrote:
> On 13 September 2016 at 22:28, Keerthy <j-keerthy@ti.com> wrote:
>> The driver provides regulator set/get voltage
>> enable/disable functions for palmas family of PMICs.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> drivers/power/regulator/Kconfig | 8 +
>> drivers/power/regulator/Makefile | 1 +
>> drivers/power/regulator/palmas_regulator.c | 460 +++++++++++++++++++++++++++++
>> 3 files changed, 469 insertions(+)
>> create mode 100644 drivers/power/regulator/palmas_regulator.c
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> But please consider using dm_i2c_reg_read()
>
> Also you have two blank lines at one point.
Sure i will fix them and repost.
Thanks for the review.
>
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2016-09-19 3:31 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14 4:28 [U-Boot] [PATCH 0/5] power: pmic: Add support for Palmas family of PMICs Keerthy
2016-09-14 4:28 ` [U-Boot] [PATCH 1/5] power: regulator: Add ctrl_reg and volt_reg fields for pmic Keerthy
2016-09-14 8:03 ` Przemyslaw Marczak
2016-09-14 8:24 ` Keerthy
2016-09-14 11:56 ` Przemyslaw Marczak
2016-09-15 8:17 ` Keerthy
2016-09-14 4:28 ` [U-Boot] [PATCH 2/5] power: pmic: Palmas: Add the base pmic support Keerthy
2016-09-19 0:58 ` Simon Glass
2016-09-14 4:28 ` [U-Boot] [PATCH 3/5] power: regulator: palmas: Add regulator support Keerthy
2016-09-19 0:58 ` Simon Glass
2016-09-19 3:31 ` Keerthy
2016-09-14 4:28 ` [U-Boot] [PATCH 4/5] configs: am57xx_evm_defconfig: Enable PALMAS options Keerthy
2016-09-14 4:28 ` [U-Boot] [PATCH 5/5] configs: dra7xx_evm_defconfig: " Keerthy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.