All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v1] ARM: dts: Makefile: Use board to decide to compile dts
@ 2016-09-18  7:40 Wenyou Yang
  2016-09-19 13:38 ` Heiko Schocher
  2016-09-23  4:16 ` Simon Glass
  0 siblings, 2 replies; 4+ messages in thread
From: Wenyou Yang @ 2016-09-18  7:40 UTC (permalink / raw)
  To: u-boot

To avoid to compile all AT91 SoCs' board dts files, use the board
to decide to build its corresponding dts, instead of
CONFIG_AT91FAMILY.

Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---

 arch/arm/dts/Makefile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 223124e..2ac1f20 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -2,10 +2,10 @@
 # SPDX-License-Identifier:	GPL-2.0+
 #
 
-dtb-$(CONFIG_AT91FAMILY) += at91sam9260-smartweb.dtb \
-	at91sam9g20-taurus.dtb \
-	at91sam9g45-corvus.dtb \
-	at91sam9g45-gurnard.dtb
+dtb-$(CONFIG_TARGET_SMARTWEB) += at91sam9260-smartweb.dtb
+dtb-$(CONFIG_TARGET_TAURUS) += at91sam9g20-taurus.dtb
+dtb-$(CONFIG_TARGET_CORVUS) += at91sam9g45-corvus.dtb
+dtb-$(CONFIG_TARGET_GURNARD) += at91sam9g45-gurnard.dtb
 
 dtb-$(CONFIG_S5PC100) += s5pc1xx-smdkc100.dtb
 dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH v1] ARM: dts: Makefile: Use board to decide to compile dts
  2016-09-18  7:40 [U-Boot] [PATCH v1] ARM: dts: Makefile: Use board to decide to compile dts Wenyou Yang
@ 2016-09-19 13:38 ` Heiko Schocher
  2016-09-23  4:16 ` Simon Glass
  1 sibling, 0 replies; 4+ messages in thread
From: Heiko Schocher @ 2016-09-19 13:38 UTC (permalink / raw)
  To: u-boot

Hello Wenyou Yang,

Am 18.09.2016 um 09:40 schrieb Wenyou Yang:
> To avoid to compile all AT91 SoCs' board dts files, use the board
> to decide to build its corresponding dts, instead of
> CONFIG_AT91FAMILY.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
>   arch/arm/dts/Makefile | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 223124e..2ac1f20 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -2,10 +2,10 @@
>   # SPDX-License-Identifier:	GPL-2.0+
>   #
>
> -dtb-$(CONFIG_AT91FAMILY) += at91sam9260-smartweb.dtb \
> -	at91sam9g20-taurus.dtb \
> -	at91sam9g45-corvus.dtb \
> -	at91sam9g45-gurnard.dtb
> +dtb-$(CONFIG_TARGET_SMARTWEB) += at91sam9260-smartweb.dtb
> +dtb-$(CONFIG_TARGET_TAURUS) += at91sam9g20-taurus.dtb
> +dtb-$(CONFIG_TARGET_CORVUS) += at91sam9g45-corvus.dtb
> +dtb-$(CONFIG_TARGET_GURNARD) += at91sam9g45-gurnard.dtb
>
>   dtb-$(CONFIG_S5PC100) += s5pc1xx-smdkc100.dtb
>   dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH v1] ARM: dts: Makefile: Use board to decide to compile dts
  2016-09-18  7:40 [U-Boot] [PATCH v1] ARM: dts: Makefile: Use board to decide to compile dts Wenyou Yang
  2016-09-19 13:38 ` Heiko Schocher
@ 2016-09-23  4:16 ` Simon Glass
  2016-09-23  6:01   ` Wenyou.Yang at microchip.com
  1 sibling, 1 reply; 4+ messages in thread
From: Simon Glass @ 2016-09-23  4:16 UTC (permalink / raw)
  To: u-boot

Hi,

On 18 September 2016 at 01:40, Wenyou Yang <wenyou.yang@atmel.com> wrote:
> To avoid to compile all AT91 SoCs' board dts files, use the board
> to decide to build its corresponding dts, instead of
> CONFIG_AT91FAMILY.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
>  arch/arm/dts/Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

What is the purpose of this? It seems unnecessary to me. Compiling a
few more .dts files will be quick.

>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 223124e..2ac1f20 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -2,10 +2,10 @@
>  # SPDX-License-Identifier:     GPL-2.0+
>  #
>
> -dtb-$(CONFIG_AT91FAMILY) += at91sam9260-smartweb.dtb \
> -       at91sam9g20-taurus.dtb \
> -       at91sam9g45-corvus.dtb \
> -       at91sam9g45-gurnard.dtb
> +dtb-$(CONFIG_TARGET_SMARTWEB) += at91sam9260-smartweb.dtb
> +dtb-$(CONFIG_TARGET_TAURUS) += at91sam9g20-taurus.dtb
> +dtb-$(CONFIG_TARGET_CORVUS) += at91sam9g45-corvus.dtb
> +dtb-$(CONFIG_TARGET_GURNARD) += at91sam9g45-gurnard.dtb
>
>  dtb-$(CONFIG_S5PC100) += s5pc1xx-smdkc100.dtb
>  dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb
> --
> 2.7.4
>

Regards,
Simon

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH v1] ARM: dts: Makefile: Use board to decide to compile dts
  2016-09-23  4:16 ` Simon Glass
@ 2016-09-23  6:01   ` Wenyou.Yang at microchip.com
  0 siblings, 0 replies; 4+ messages in thread
From: Wenyou.Yang at microchip.com @ 2016-09-23  6:01 UTC (permalink / raw)
  To: u-boot



> -----Original Message-----
> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
> Sent: 2016?9?23? 12:17
> To: Wenyou Yang - A41535 <Wenyou.Yang@microchip.com>
> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Stephen Warren
> <swarren@nvidia.com>; Andreas Bie?mann <andreas@biessmann.org>; Wenyou
> Yang - A41535 <Wenyou.Yang@microchip.com>
> Subject: Re: [PATCH v1] ARM: dts: Makefile: Use board to decide to compile dts
> 
> Hi,
> 
> On 18 September 2016 at 01:40, Wenyou Yang <wenyou.yang@atmel.com> wrote:
> > To avoid to compile all AT91 SoCs' board dts files, use the board to
> > decide to build its corresponding dts, instead of CONFIG_AT91FAMILY.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
> >
> >  arch/arm/dts/Makefile | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> What is the purpose of this? It seems unnecessary to me. Compiling a few
> more .dts files will be quick.

Why we need to compile all AT91FAMILY dts files, not be used for a specific AT91 board?

It is enough to compile the dts file used for the target board. Others is unnecessary.

> 
> >
> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
> > 223124e..2ac1f20 100644
> > --- a/arch/arm/dts/Makefile
> > +++ b/arch/arm/dts/Makefile
> > @@ -2,10 +2,10 @@
> >  # SPDX-License-Identifier:     GPL-2.0+
> >  #
> >
> > -dtb-$(CONFIG_AT91FAMILY) += at91sam9260-smartweb.dtb \
> > -       at91sam9g20-taurus.dtb \
> > -       at91sam9g45-corvus.dtb \
> > -       at91sam9g45-gurnard.dtb
> > +dtb-$(CONFIG_TARGET_SMARTWEB) += at91sam9260-smartweb.dtb
> > +dtb-$(CONFIG_TARGET_TAURUS) += at91sam9g20-taurus.dtb
> > +dtb-$(CONFIG_TARGET_CORVUS) += at91sam9g45-corvus.dtb
> > +dtb-$(CONFIG_TARGET_GURNARD) += at91sam9g45-gurnard.dtb
> >
> >  dtb-$(CONFIG_S5PC100) += s5pc1xx-smdkc100.dtb
> >  dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb
> > --
> > 2.7.4
> >
> 
> Regards,
> Simon


Best Regards,
Wenyou Yang

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-09-23  6:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-18  7:40 [U-Boot] [PATCH v1] ARM: dts: Makefile: Use board to decide to compile dts Wenyou Yang
2016-09-19 13:38 ` Heiko Schocher
2016-09-23  4:16 ` Simon Glass
2016-09-23  6:01   ` Wenyou.Yang at microchip.com

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.