From: Kishon Vijay Abraham I <kishon@ti.com> To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>, <bhelgaas@google.com>, <lorenzo.pieralisi@arm.com>, <Joao.Pinto@synopsys.com>, <jingoohan1@gmail.com>, <robh+dt@kernel.org>, <mark.rutland@arm.com> Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org> Subject: Re: [PATCH v6 3/9] PCI: endpoint: functions/pci-epf-test: Add second entry Date: Tue, 24 Apr 2018 18:11:41 +0530 [thread overview] Message-ID: <57e5c94a-1e9a-6b4f-cbf8-5ac85ae1a919@ti.com> (raw) In-Reply-To: <9efd4af2f91e1be2b65d2df93444b35871673e8b.1524062073.git.gustavo.pimentel@synopsys.com> On Wednesday 18 April 2018 08:16 PM, Gustavo Pimentel wrote: > Adds a seconds entry on the pci_epf_test_ids structure that disables the > linkup_notifier parameter on driver for the designware EP. > > This allows designware EPs that doesn't have linkup notification signal > to work with pcitest. > > Updates the binding documentation accordingly. > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > --- > Change v2->v3: > - Added second entry in pci_epf_test_ids structure. > - Remove test_reg_bar field assignment on second entry. > Changes v3->v4: > - Nothing changed, just to follow the patch set version. > Changes v4->v5: > - Changed pci_epf_test_cfg2 to pci_epf_test_designware. > Changes v5->v6: > - Changed name field from pci_epf_test_designware to pci_epf_test_dw. > > Documentation/PCI/endpoint/function/binding/pci-test.txt | 2 ++ > drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/Documentation/PCI/endpoint/function/binding/pci-test.txt b/Documentation/PCI/endpoint/function/binding/pci-test.txt > index 3b68b95..dc39f47 100644 > --- a/Documentation/PCI/endpoint/function/binding/pci-test.txt > +++ b/Documentation/PCI/endpoint/function/binding/pci-test.txt > @@ -1,6 +1,8 @@ > PCI TEST ENDPOINT FUNCTION > > name: Should be "pci_epf_test" to bind to the pci_epf_test driver. > +name: Should be "pci_epf_test_dw" to bind to the pci_epf_test driver > + with a custom configuration for the designware EP. > > Configurable Fields: > vendorid : should be 0x104c > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index 7cef851..b7dff87 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -459,10 +459,18 @@ static int pci_epf_test_bind(struct pci_epf *epf) > return 0; > } > > +static const struct pci_epf_test_data data_cfg2 = { Would prefer a descriptive name, otherwise Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > + .linkup_notifier = false > +}; > + > static const struct pci_epf_device_id pci_epf_test_ids[] = { > { > .name = "pci_epf_test", > }, > + { > + .name = "pci_epf_test_dw", > + .driver_data = (kernel_ulong_t)&data_cfg2, > + }, > {}, > }; > >
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com> To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>, bhelgaas@google.com, lorenzo.pieralisi@arm.com, Joao.Pinto@synopsys.com, jingoohan1@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 3/9] PCI: endpoint: functions/pci-epf-test: Add second entry Date: Tue, 24 Apr 2018 18:11:41 +0530 [thread overview] Message-ID: <57e5c94a-1e9a-6b4f-cbf8-5ac85ae1a919@ti.com> (raw) In-Reply-To: <9efd4af2f91e1be2b65d2df93444b35871673e8b.1524062073.git.gustavo.pimentel@synopsys.com> On Wednesday 18 April 2018 08:16 PM, Gustavo Pimentel wrote: > Adds a seconds entry on the pci_epf_test_ids structure that disables the > linkup_notifier parameter on driver for the designware EP. > > This allows designware EPs that doesn't have linkup notification signal > to work with pcitest. > > Updates the binding documentation accordingly. > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > --- > Change v2->v3: > - Added second entry in pci_epf_test_ids structure. > - Remove test_reg_bar field assignment on second entry. > Changes v3->v4: > - Nothing changed, just to follow the patch set version. > Changes v4->v5: > - Changed pci_epf_test_cfg2 to pci_epf_test_designware. > Changes v5->v6: > - Changed name field from pci_epf_test_designware to pci_epf_test_dw. > > Documentation/PCI/endpoint/function/binding/pci-test.txt | 2 ++ > drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/Documentation/PCI/endpoint/function/binding/pci-test.txt b/Documentation/PCI/endpoint/function/binding/pci-test.txt > index 3b68b95..dc39f47 100644 > --- a/Documentation/PCI/endpoint/function/binding/pci-test.txt > +++ b/Documentation/PCI/endpoint/function/binding/pci-test.txt > @@ -1,6 +1,8 @@ > PCI TEST ENDPOINT FUNCTION > > name: Should be "pci_epf_test" to bind to the pci_epf_test driver. > +name: Should be "pci_epf_test_dw" to bind to the pci_epf_test driver > + with a custom configuration for the designware EP. > > Configurable Fields: > vendorid : should be 0x104c > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index 7cef851..b7dff87 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -459,10 +459,18 @@ static int pci_epf_test_bind(struct pci_epf *epf) > return 0; > } > > +static const struct pci_epf_test_data data_cfg2 = { Would prefer a descriptive name, otherwise Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > + .linkup_notifier = false > +}; > + > static const struct pci_epf_device_id pci_epf_test_ids[] = { > { > .name = "pci_epf_test", > }, > + { > + .name = "pci_epf_test_dw", > + .driver_data = (kernel_ulong_t)&data_cfg2, > + }, > {}, > }; > >
next prev parent reply other threads:[~2018-04-24 12:41 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-18 14:46 [PATCH v6 0/9] Designware EP support and code clean up Gustavo Pimentel 2018-04-18 14:46 ` [PATCH v6 1/9] bindings: PCI: designware: Example update Gustavo Pimentel 2018-04-18 14:46 ` [PATCH v6 2/9] PCI: dwc: Add support for endpoint mode Gustavo Pimentel 2018-04-18 14:46 ` [PATCH v6 3/9] PCI: endpoint: functions/pci-epf-test: Add second entry Gustavo Pimentel 2018-04-24 12:41 ` Kishon Vijay Abraham I [this message] 2018-04-24 12:41 ` Kishon Vijay Abraham I 2018-04-18 14:46 ` [PATCH v6 4/9] bindings: PCI: designware: Add support for the EP in Designware driver Gustavo Pimentel 2018-04-18 14:46 ` [PATCH v6 5/9] misc: pci_endpoint_test: Add designware EP entry Gustavo Pimentel 2018-04-18 14:46 ` [PATCH v6 6/9] PCI: dwc: Define maximum number of vectors Gustavo Pimentel 2018-04-18 14:46 ` [PATCH v6 7/9] PCI: dwc: Replace lower into upper case characters Gustavo Pimentel 2018-04-18 14:46 ` [PATCH v6 8/9] PCI: dwc: Small computation improvement Gustavo Pimentel 2018-04-18 14:46 ` [PATCH v6 9/9] PCI: dwc: Replace magic number by defines Gustavo Pimentel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=57e5c94a-1e9a-6b4f-cbf8-5ac85ae1a919@ti.com \ --to=kishon@ti.com \ --cc=Joao.Pinto@synopsys.com \ --cc=bhelgaas@google.com \ --cc=devicetree@vger.kernel.org \ --cc=gustavo.pimentel@synopsys.com \ --cc=jingoohan1@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.