From: Anshuman Khandual <khandual@linux.vnet.ibm.com> To: Balbir Singh <bsingharora@gmail.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: mhocko@suse.com, js1304@gmail.com, vbabka@suse.cz, mgorman@suse.de, minchan@kernel.org, akpm@linux-foundation.org, aneesh.kumar@linux.vnet.ibm.com Subject: Re: [RFC 8/8] mm: Add N_COHERENT_DEVICE node type into node_states[] Date: Wed, 26 Oct 2016 10:22:30 +0530 [thread overview] Message-ID: <5810368E.5070403@linux.vnet.ibm.com> (raw) In-Reply-To: <14c44d50-3461-8a2c-d043-881110ae6f6b@gmail.com> On 10/25/2016 12:52 PM, Balbir Singh wrote: > > > On 24/10/16 15:31, Anshuman Khandual wrote: >> Add a new member N_COHERENT_DEVICE into node_states[] nodemask array to >> enlist all those nodes which contain only coherent device memory. Also >> creates a new sysfs interface /sys/devices/system/node/is_coherent_device >> to list down all those nodes which has coherent device memory. >> >> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> >> --- >> Documentation/ABI/stable/sysfs-devices-node | 7 +++++++ >> drivers/base/node.c | 6 ++++++ >> include/linux/nodemask.h | 3 +++ >> mm/memory_hotplug.c | 10 ++++++++++ >> 4 files changed, 26 insertions(+) >> >> diff --git a/Documentation/ABI/stable/sysfs-devices-node b/Documentation/ABI/stable/sysfs-devices-node >> index 5b2d0f0..5538791 100644 >> --- a/Documentation/ABI/stable/sysfs-devices-node >> +++ b/Documentation/ABI/stable/sysfs-devices-node >> @@ -29,6 +29,13 @@ Description: >> Nodes that have regular or high memory. >> Depends on CONFIG_HIGHMEM. >> >> +What: /sys/devices/system/node/is_coherent_device >> +Date: October 2016 >> +Contact: Linux Memory Management list <linux-mm@kvack.org> >> +Description: >> + Lists the nodemask of nodes that have coherent memory. >> + Depends on CONFIG_COHERENT_DEVICE. >> + >> What: /sys/devices/system/node/nodeX >> Date: October 2002 >> Contact: Linux Memory Management list <linux-mm@kvack.org> >> diff --git a/drivers/base/node.c b/drivers/base/node.c >> index 5548f96..5b5dd89 100644 >> --- a/drivers/base/node.c >> +++ b/drivers/base/node.c >> @@ -661,6 +661,9 @@ static struct node_attr node_state_attr[] = { >> [N_MEMORY] = _NODE_ATTR(has_memory, N_MEMORY), >> #endif >> [N_CPU] = _NODE_ATTR(has_cpu, N_CPU), >> +#ifdef CONFIG_COHERENT_DEVICE >> + [N_COHERENT_DEVICE] = _NODE_ATTR(is_coherent_device, N_COHERENT_DEVICE), >> +#endif >> }; >> >> static struct attribute *node_state_attrs[] = { >> @@ -674,6 +677,9 @@ static struct attribute *node_state_attrs[] = { >> &node_state_attr[N_MEMORY].attr.attr, >> #endif >> &node_state_attr[N_CPU].attr.attr, >> +#ifdef CONFIG_COHERENT_DEVICE >> + &node_state_attr[N_COHERENT_DEVICE].attr.attr, >> +#endif >> NULL >> }; >> >> diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h >> index f746e44..605cb0d 100644 >> --- a/include/linux/nodemask.h >> +++ b/include/linux/nodemask.h >> @@ -393,6 +393,9 @@ enum node_states { >> N_MEMORY = N_HIGH_MEMORY, >> #endif >> N_CPU, /* The node has one or more cpus */ >> +#ifdef CONFIG_COHERENT_DEVICE >> + N_COHERENT_DEVICE, /* The node has coherent device memory */ >> +#endif >> NR_NODE_STATES >> }; >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 9629273..8f03962 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -1044,6 +1044,11 @@ static void node_states_set_node(int node, struct memory_notify *arg) >> if (arg->status_change_nid_high >= 0) >> node_set_state(node, N_HIGH_MEMORY); >> >> +#ifdef CONFIG_COHERENT_DEVICE >> + if (isolated_cdm_node(node)) >> + node_set_state(node, N_COHERENT_DEVICE); >> +#endif >> + > > #ifdef not required, see below > Right, will change. >> node_set_state(node, N_MEMORY); >> } >> >> @@ -1858,6 +1863,11 @@ static void node_states_clear_node(int node, struct memory_notify *arg) >> if ((N_MEMORY != N_HIGH_MEMORY) && >> (arg->status_change_nid >= 0)) >> node_clear_state(node, N_MEMORY); >> + >> +#ifdef CONFIG_COHERENT_DEVICE >> + if (isolated_cdm_node(node)) >> + node_clear_state(node, N_COHERENT_DEVICE); >> +#endif >> } >> > > I think the #ifdefs are not needed if isolated_cdm_node > is defined for both with and without CONFIG_COHERENT_DEVICE. > > I think this patch needs to move up in the series so that > node state can be examined by other core algorithms Okay, will move up.
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <khandual@linux.vnet.ibm.com> To: Balbir Singh <bsingharora@gmail.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: mhocko@suse.com, js1304@gmail.com, vbabka@suse.cz, mgorman@suse.de, minchan@kernel.org, akpm@linux-foundation.org, aneesh.kumar@linux.vnet.ibm.com Subject: Re: [RFC 8/8] mm: Add N_COHERENT_DEVICE node type into node_states[] Date: Wed, 26 Oct 2016 10:22:30 +0530 [thread overview] Message-ID: <5810368E.5070403@linux.vnet.ibm.com> (raw) In-Reply-To: <14c44d50-3461-8a2c-d043-881110ae6f6b@gmail.com> On 10/25/2016 12:52 PM, Balbir Singh wrote: > > > On 24/10/16 15:31, Anshuman Khandual wrote: >> Add a new member N_COHERENT_DEVICE into node_states[] nodemask array to >> enlist all those nodes which contain only coherent device memory. Also >> creates a new sysfs interface /sys/devices/system/node/is_coherent_device >> to list down all those nodes which has coherent device memory. >> >> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> >> --- >> Documentation/ABI/stable/sysfs-devices-node | 7 +++++++ >> drivers/base/node.c | 6 ++++++ >> include/linux/nodemask.h | 3 +++ >> mm/memory_hotplug.c | 10 ++++++++++ >> 4 files changed, 26 insertions(+) >> >> diff --git a/Documentation/ABI/stable/sysfs-devices-node b/Documentation/ABI/stable/sysfs-devices-node >> index 5b2d0f0..5538791 100644 >> --- a/Documentation/ABI/stable/sysfs-devices-node >> +++ b/Documentation/ABI/stable/sysfs-devices-node >> @@ -29,6 +29,13 @@ Description: >> Nodes that have regular or high memory. >> Depends on CONFIG_HIGHMEM. >> >> +What: /sys/devices/system/node/is_coherent_device >> +Date: October 2016 >> +Contact: Linux Memory Management list <linux-mm@kvack.org> >> +Description: >> + Lists the nodemask of nodes that have coherent memory. >> + Depends on CONFIG_COHERENT_DEVICE. >> + >> What: /sys/devices/system/node/nodeX >> Date: October 2002 >> Contact: Linux Memory Management list <linux-mm@kvack.org> >> diff --git a/drivers/base/node.c b/drivers/base/node.c >> index 5548f96..5b5dd89 100644 >> --- a/drivers/base/node.c >> +++ b/drivers/base/node.c >> @@ -661,6 +661,9 @@ static struct node_attr node_state_attr[] = { >> [N_MEMORY] = _NODE_ATTR(has_memory, N_MEMORY), >> #endif >> [N_CPU] = _NODE_ATTR(has_cpu, N_CPU), >> +#ifdef CONFIG_COHERENT_DEVICE >> + [N_COHERENT_DEVICE] = _NODE_ATTR(is_coherent_device, N_COHERENT_DEVICE), >> +#endif >> }; >> >> static struct attribute *node_state_attrs[] = { >> @@ -674,6 +677,9 @@ static struct attribute *node_state_attrs[] = { >> &node_state_attr[N_MEMORY].attr.attr, >> #endif >> &node_state_attr[N_CPU].attr.attr, >> +#ifdef CONFIG_COHERENT_DEVICE >> + &node_state_attr[N_COHERENT_DEVICE].attr.attr, >> +#endif >> NULL >> }; >> >> diff --git a/include/linux/nodemask.h b/include/linux/nodemask.h >> index f746e44..605cb0d 100644 >> --- a/include/linux/nodemask.h >> +++ b/include/linux/nodemask.h >> @@ -393,6 +393,9 @@ enum node_states { >> N_MEMORY = N_HIGH_MEMORY, >> #endif >> N_CPU, /* The node has one or more cpus */ >> +#ifdef CONFIG_COHERENT_DEVICE >> + N_COHERENT_DEVICE, /* The node has coherent device memory */ >> +#endif >> NR_NODE_STATES >> }; >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 9629273..8f03962 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -1044,6 +1044,11 @@ static void node_states_set_node(int node, struct memory_notify *arg) >> if (arg->status_change_nid_high >= 0) >> node_set_state(node, N_HIGH_MEMORY); >> >> +#ifdef CONFIG_COHERENT_DEVICE >> + if (isolated_cdm_node(node)) >> + node_set_state(node, N_COHERENT_DEVICE); >> +#endif >> + > > #ifdef not required, see below > Right, will change. >> node_set_state(node, N_MEMORY); >> } >> >> @@ -1858,6 +1863,11 @@ static void node_states_clear_node(int node, struct memory_notify *arg) >> if ((N_MEMORY != N_HIGH_MEMORY) && >> (arg->status_change_nid >= 0)) >> node_clear_state(node, N_MEMORY); >> + >> +#ifdef CONFIG_COHERENT_DEVICE >> + if (isolated_cdm_node(node)) >> + node_clear_state(node, N_COHERENT_DEVICE); >> +#endif >> } >> > > I think the #ifdefs are not needed if isolated_cdm_node > is defined for both with and without CONFIG_COHERENT_DEVICE. > > I think this patch needs to move up in the series so that > node state can be examined by other core algorithms Okay, will move up. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-10-26 4:52 UTC|newest] Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-24 4:31 [RFC 0/8] Define coherent device memory node Anshuman Khandual 2016-10-24 4:31 ` Anshuman Khandual 2016-10-24 4:31 ` [RFC 1/8] mm: " Anshuman Khandual 2016-10-24 4:31 ` Anshuman Khandual 2016-10-24 17:09 ` Dave Hansen 2016-10-24 17:09 ` Dave Hansen 2016-10-25 1:22 ` Anshuman Khandual 2016-10-25 1:22 ` Anshuman Khandual 2016-10-25 15:47 ` Dave Hansen 2016-10-25 15:47 ` Dave Hansen 2016-10-24 4:31 ` [RFC 2/8] mm: Add specialized fallback zonelist for coherent device memory nodes Anshuman Khandual 2016-10-24 4:31 ` Anshuman Khandual 2016-10-24 17:10 ` Dave Hansen 2016-10-24 17:10 ` Dave Hansen 2016-10-25 1:27 ` Anshuman Khandual 2016-10-25 1:27 ` Anshuman Khandual 2016-11-17 7:40 ` Anshuman Khandual 2016-11-17 7:40 ` Anshuman Khandual 2016-11-17 7:59 ` [DRAFT 1/2] mm/cpuset: Exclude CDM nodes from each task's mems_allowed node mask Anshuman Khandual 2016-11-17 7:59 ` Anshuman Khandual 2016-11-17 7:59 ` [DRAFT 2/2] mm/hugetlb: Restrict HugeTLB allocations only to the system RAM nodes Anshuman Khandual 2016-11-17 7:59 ` Anshuman Khandual 2016-11-17 8:28 ` [DRAFT 1/2] mm/cpuset: Exclude CDM nodes from each task's mems_allowed node mask kbuild test robot 2016-10-24 4:31 ` [RFC 3/8] mm: Isolate coherent device memory nodes from HugeTLB allocation paths Anshuman Khandual 2016-10-24 4:31 ` Anshuman Khandual 2016-10-24 17:16 ` Dave Hansen 2016-10-24 17:16 ` Dave Hansen 2016-10-25 4:15 ` Aneesh Kumar K.V 2016-10-25 4:15 ` Aneesh Kumar K.V 2016-10-25 7:17 ` Balbir Singh 2016-10-25 7:17 ` Balbir Singh 2016-10-25 7:25 ` Balbir Singh 2016-10-25 7:25 ` Balbir Singh 2016-10-24 4:31 ` [RFC 4/8] mm: Accommodate coherent device memory nodes in MPOL_BIND implementation Anshuman Khandual 2016-10-24 4:31 ` Anshuman Khandual 2016-10-24 4:31 ` [RFC 5/8] mm: Add new flag VM_CDM for coherent device memory Anshuman Khandual 2016-10-24 4:31 ` Anshuman Khandual 2016-10-24 17:38 ` Dave Hansen 2016-10-24 17:38 ` Dave Hansen 2016-10-24 18:00 ` Dave Hansen 2016-10-24 18:00 ` Dave Hansen 2016-10-25 12:36 ` Balbir Singh 2016-10-25 12:36 ` Balbir Singh 2016-10-25 19:20 ` Aneesh Kumar K.V 2016-10-25 19:20 ` Aneesh Kumar K.V 2016-10-25 20:01 ` Dave Hansen 2016-10-25 20:01 ` Dave Hansen 2016-10-24 4:31 ` [RFC 6/8] mm: Make VM_CDM marked VMAs non migratable Anshuman Khandual 2016-10-24 4:31 ` Anshuman Khandual 2016-10-24 4:31 ` [RFC 7/8] mm: Add a new migration function migrate_virtual_range() Anshuman Khandual 2016-10-24 4:31 ` Anshuman Khandual 2016-10-24 4:31 ` [RFC 8/8] mm: Add N_COHERENT_DEVICE node type into node_states[] Anshuman Khandual 2016-10-24 4:31 ` Anshuman Khandual 2016-10-25 7:22 ` Balbir Singh 2016-10-25 7:22 ` Balbir Singh 2016-10-26 4:52 ` Anshuman Khandual [this message] 2016-10-26 4:52 ` Anshuman Khandual 2016-10-24 4:42 ` [DEBUG 00/10] Test and debug patches for coherent device memory Anshuman Khandual 2016-10-24 4:42 ` Anshuman Khandual 2016-10-24 4:42 ` [DEBUG 01/10] dt-bindings: Add doc for ibm,hotplug-aperture Anshuman Khandual 2016-10-24 4:42 ` Anshuman Khandual 2016-10-24 4:42 ` [DEBUG 02/10] powerpc/mm: Create numa nodes for hotplug memory Anshuman Khandual 2016-10-24 4:42 ` Anshuman Khandual 2016-10-24 4:42 ` [DEBUG 03/10] powerpc/mm: Allow memory hotplug into a memory less node Anshuman Khandual 2016-10-24 4:42 ` Anshuman Khandual 2016-10-24 4:42 ` [DEBUG 04/10] mm: Enable CONFIG_MOVABLE_NODE on powerpc Anshuman Khandual 2016-10-24 4:42 ` Anshuman Khandual 2016-10-24 4:42 ` [DEBUG 05/10] powerpc/mm: Identify isolation seeking coherent memory nodes during boot Anshuman Khandual 2016-10-24 4:42 ` Anshuman Khandual 2016-10-24 4:42 ` [DEBUG 06/10] mm: Export definition of 'zone_names' array through mmzone.h Anshuman Khandual 2016-10-24 4:42 ` Anshuman Khandual 2016-10-24 4:42 ` [DEBUG 07/10] mm: Add debugfs interface to dump each node's zonelist information Anshuman Khandual 2016-10-24 4:42 ` Anshuman Khandual 2016-10-24 4:42 ` [DEBUG 08/10] powerpc: Enable CONFIG_MOVABLE_NODE for PPC64 platform Anshuman Khandual 2016-10-24 4:42 ` Anshuman Khandual 2016-10-24 4:42 ` [DEBUG 09/10] drivers: Add two drivers for coherent device memory tests Anshuman Khandual 2016-10-24 4:42 ` Anshuman Khandual 2016-10-24 4:42 ` [DEBUG 10/10] test: Add a script to perform random VMA migrations across nodes Anshuman Khandual 2016-10-24 4:42 ` Anshuman Khandual 2016-10-24 17:09 ` [RFC 0/8] Define coherent device memory node Jerome Glisse 2016-10-24 17:09 ` Jerome Glisse 2016-10-25 4:26 ` Aneesh Kumar K.V 2016-10-25 4:26 ` Aneesh Kumar K.V 2016-10-25 15:16 ` Jerome Glisse 2016-10-25 15:16 ` Jerome Glisse 2016-10-26 11:09 ` Aneesh Kumar K.V 2016-10-26 11:09 ` Aneesh Kumar K.V 2016-10-26 16:07 ` Jerome Glisse 2016-10-26 16:07 ` Jerome Glisse 2016-10-28 5:29 ` Aneesh Kumar K.V 2016-10-28 5:29 ` Aneesh Kumar K.V 2016-10-28 16:16 ` Jerome Glisse 2016-10-28 16:16 ` Jerome Glisse 2016-11-05 5:21 ` Anshuman Khandual 2016-11-05 5:21 ` Anshuman Khandual 2016-11-05 18:02 ` Jerome Glisse 2016-11-05 18:02 ` Jerome Glisse 2016-10-25 4:59 ` Aneesh Kumar K.V 2016-10-25 4:59 ` Aneesh Kumar K.V 2016-10-25 15:32 ` Jerome Glisse 2016-10-25 15:32 ` Jerome Glisse 2016-10-25 17:31 ` Aneesh Kumar K.V 2016-10-25 17:31 ` Aneesh Kumar K.V 2016-10-25 18:52 ` Jerome Glisse 2016-10-25 18:52 ` Jerome Glisse 2016-10-26 11:13 ` Anshuman Khandual 2016-10-26 11:13 ` Anshuman Khandual 2016-10-26 16:02 ` Jerome Glisse 2016-10-26 16:02 ` Jerome Glisse 2016-10-27 4:38 ` Anshuman Khandual 2016-10-27 4:38 ` Anshuman Khandual 2016-10-27 7:03 ` Anshuman Khandual 2016-10-27 7:03 ` Anshuman Khandual 2016-10-27 15:05 ` Jerome Glisse 2016-10-27 15:05 ` Jerome Glisse 2016-10-28 5:47 ` Anshuman Khandual 2016-10-28 5:47 ` Anshuman Khandual 2016-10-28 16:08 ` Jerome Glisse 2016-10-28 16:08 ` Jerome Glisse 2016-10-26 12:56 ` Anshuman Khandual 2016-10-26 12:56 ` Anshuman Khandual 2016-10-26 16:28 ` Jerome Glisse 2016-10-26 16:28 ` Jerome Glisse 2016-10-27 10:23 ` Balbir Singh 2016-10-27 10:23 ` Balbir Singh 2016-10-25 12:07 ` Balbir Singh 2016-10-25 12:07 ` Balbir Singh 2016-10-25 15:21 ` Jerome Glisse 2016-10-25 15:21 ` Jerome Glisse 2016-10-24 18:04 ` Dave Hansen 2016-10-24 18:04 ` Dave Hansen 2016-10-24 18:32 ` David Nellans 2016-10-24 18:32 ` David Nellans 2016-10-24 19:36 ` Dave Hansen 2016-10-24 19:36 ` Dave Hansen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5810368E.5070403@linux.vnet.ibm.com \ --to=khandual@linux.vnet.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=aneesh.kumar@linux.vnet.ibm.com \ --cc=bsingharora@gmail.com \ --cc=js1304@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@suse.com \ --cc=minchan@kernel.org \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.