All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mason <slash.tmp-GANU6spQydw@public.gmane.org>
To: Boris Brezillon
	<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Marc Gonzalez
	<marc_gonzalez-y1yR0Z3OICC7zZZRDBGcUA@public.gmane.org>,
	linux-mtd
	<linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>,
	DT <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Sebastian Frias <sf84-QFKgK+z4sOrR7s880joybQ@public.gmane.org>
Subject: Re: [PATCH v8] mtd: nand: add tango NAND flash controller support
Date: Fri, 11 Nov 2016 17:01:52 +0100	[thread overview]
Message-ID: <5825EB70.4070406@free.fr> (raw)
In-Reply-To: <20161106235812.0bcbbdc5@bbrezillon>

On 06/11/2016 23:58, Boris Brezillon wrote:

> Applied after fixing a few coding style issues to make checkpatch happy.

First of all, I want to thank you for all the help you provided
along the way.

I have to admit that I'm a bit frustrated by some of the changes you made
to the patch.

Specifically, changing

from:  if (ptr_expr == NULL)
  to:  if (!ptr_expr)

I dislike the second form, because it "hides" what is being tested.
I've even seen people use !count to mean count == 0, and I find that
very unintuitive.

I also have a hard time discerning a '!' after a '('


The other change is the chip->options initialization. I thought
you said on IRC I could keep my preferred formatting.


In the end, these are tiny issues in the grand scheme of things,
but it was important for me to point them out.

Regards.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Mason <slash.tmp@free.fr>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>,
	linux-mtd <linux-mtd@lists.infradead.org>,
	Richard Weinberger <richard@nod.at>,
	DT <devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Sebastian Frias <sf84@laposte.net>
Subject: Re: [PATCH v8] mtd: nand: add tango NAND flash controller support
Date: Fri, 11 Nov 2016 17:01:52 +0100	[thread overview]
Message-ID: <5825EB70.4070406@free.fr> (raw)
In-Reply-To: <20161106235812.0bcbbdc5@bbrezillon>

On 06/11/2016 23:58, Boris Brezillon wrote:

> Applied after fixing a few coding style issues to make checkpatch happy.

First of all, I want to thank you for all the help you provided
along the way.

I have to admit that I'm a bit frustrated by some of the changes you made
to the patch.

Specifically, changing

from:  if (ptr_expr == NULL)
  to:  if (!ptr_expr)

I dislike the second form, because it "hides" what is being tested.
I've even seen people use !count to mean count == 0, and I find that
very unintuitive.

I also have a hard time discerning a '!' after a '('


The other change is the chip->options initialization. I thought
you said on IRC I could keep my preferred formatting.


In the end, these are tiny issues in the grand scheme of things,
but it was important for me to point them out.

Regards.

  reply	other threads:[~2016-11-11 16:01 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 13:14 [PATCH v7 0/2] tango NFC support + bindings doc Marc Gonzalez
2016-10-25 13:14 ` Marc Gonzalez
2016-10-25 13:15 ` [PATCH v7 1/2] mtd: nand: add tango NFC dt " Marc Gonzalez
2016-10-25 13:15   ` Marc Gonzalez
     [not found]   ` <580F5B06.6030608-y1yR0Z3OICC7zZZRDBGcUA@public.gmane.org>
2016-10-25 13:25     ` Boris Brezillon
2016-10-25 13:25       ` Boris Brezillon
2016-10-31  2:45     ` Rob Herring
2016-10-31  2:45       ` Rob Herring
2016-11-06 22:57     ` Boris Brezillon
2016-11-06 22:57       ` Boris Brezillon
2016-11-07  9:18     ` Arnd Bergmann
2016-11-07  9:18       ` Arnd Bergmann
2016-11-07  9:26       ` Marc Gonzalez
2016-11-07  9:26         ` Marc Gonzalez
     [not found]         ` <582048D8.3000000-y1yR0Z3OICC7zZZRDBGcUA@public.gmane.org>
2016-11-07  9:40           ` Boris Brezillon
2016-11-07  9:40             ` Boris Brezillon
2016-12-16 10:56       ` Marc Gonzalez
2016-12-16 10:56         ` Marc Gonzalez
2016-12-16 13:26         ` Marc Gonzalez
2016-12-16 13:26           ` Marc Gonzalez
     [not found]           ` <ee9efd0a-59f5-8c21-0cad-40ca30e3a3e7-y1yR0Z3OICC7zZZRDBGcUA@public.gmane.org>
2016-12-16 13:33             ` Mark Rutland
2016-12-16 13:33               ` Mark Rutland
     [not found]         ` <d3cbfda6-23bf-4ad1-b1ce-c179b765272f-y1yR0Z3OICC7zZZRDBGcUA@public.gmane.org>
2016-12-19 12:59           ` Boris Brezillon
2016-12-19 12:59             ` Boris Brezillon
2016-10-25 13:16 ` [PATCH v7 2/2] mtd: nand: add tango NAND flash controller support Marc Gonzalez
2016-10-25 13:16   ` Marc Gonzalez
     [not found]   ` <580F5B37.5090100-y1yR0Z3OICC7zZZRDBGcUA@public.gmane.org>
2016-10-25 16:10     ` [PATCH v8] " Marc Gonzalez
2016-10-25 16:10       ` Marc Gonzalez
     [not found]       ` <580F8407.5070706-y1yR0Z3OICC7zZZRDBGcUA@public.gmane.org>
2016-11-06 22:58         ` Boris Brezillon
2016-11-06 22:58           ` Boris Brezillon
2016-11-11 16:01           ` Mason [this message]
2016-11-11 16:01             ` Mason
     [not found]             ` <5825EB70.4070406-GANU6spQydw@public.gmane.org>
2016-11-11 17:14               ` Boris Brezillon
2016-11-11 17:14                 ` Boris Brezillon
2016-12-01  1:44         ` Brian Norris
2016-12-01  1:44           ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5825EB70.4070406@free.fr \
    --to=slash.tmp-ganu6spqydw@public.gmane.org \
    --cc=boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=marc_gonzalez-y1yR0Z3OICC7zZZRDBGcUA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=richard-/L3Ra7n9ekc@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sf84-QFKgK+z4sOrR7s880joybQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.