From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com> To: Arnd Bergmann <arnd@arndb.de> Cc: Mark Rutland <mark.rutland@arm.com>, Boris Brezillon <boris.brezillon@free-electrons.com>, DT <devicetree@vger.kernel.org>, Richard Weinberger <richard@nod.at>, Mason <slash.tmp@free.fr>, Rob Herring <robh+dt@kernel.org>, linux-mtd <linux-mtd@lists.infradead.org>, Sebastian Frias <sf84@laposte.net> Subject: Re: [PATCH v7 1/2] mtd: nand: add tango NFC dt bindings doc Date: Mon, 7 Nov 2016 10:26:48 +0100 [thread overview] Message-ID: <582048D8.3000000@sigmadesigns.com> (raw) In-Reply-To: <1978954.SRtJpfOGp1@wuerfel> On 07/11/2016 10:18, Arnd Bergmann wrote: > On Tuesday, October 25, 2016 3:15:50 PM CET Marc Gonzalez wrote: >> Add the tango NAND Flash Controller dt bindings documentation. >> >> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com> >> --- >> Documentation/devicetree/bindings/mtd/tango-nand.txt | 38 ++++++++++++++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mtd/tango-nand.txt b/Documentation/devicetree/bindings/mtd/tango-nand.txt >> new file mode 100644 >> index 000000000000..3cbf95d6595a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mtd/tango-nand.txt >> @@ -0,0 +1,38 @@ >> +Sigma Designs Tango4 NAND Flash Controller (NFC) >> + >> +Required properties: >> + >> +- compatible: "sigma,smp8758-nand" >> +- reg: address/size of nfc_reg, nfc_mem, and pbus_reg >> +- dmas: reference to the DMA channel used by the controller >> +- dma-names: "nfc_sbox" > > Drop the "nfc_" prefix here, it seems redundant. I don't think it's redundant; there are switch boxes for several different HW blocks; nfc_sbox is the first one to be exposed. >> +- clocks: reference to the system clock >> +- #address-cells: <1> >> +- #size-cells: <0> >> + >> +Children nodes represent the available NAND chips. >> +See Documentation/devicetree/bindings/mtd/nand.txt for generic bindings. >> + >> +Example: >> + >> + nand: nand@2c000 { >> + compatible = "sigma,smp8758-nand"; >> + reg = <0x2c000 0x30 0x2d000 0x800 0x20000 0x1000>; > > It would be nicer to write this as > > reg = <0x2c000 0x30>, <0x2d000 0x800>, <0x20000 0x1000>; > > which is identical in binary format. I didn't know that, thanks for pointing it out. Unfortunately, Boris already accepted the patch yesterday :-( Boris, do you fixup patches in your tree? Regards. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com> To: Arnd Bergmann <arnd@arndb.de> Cc: linux-mtd <linux-mtd@lists.infradead.org>, Boris Brezillon <boris.brezillon@free-electrons.com>, Richard Weinberger <richard@nod.at>, DT <devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Mason <slash.tmp@free.fr>, Sebastian Frias <sf84@laposte.net> Subject: Re: [PATCH v7 1/2] mtd: nand: add tango NFC dt bindings doc Date: Mon, 7 Nov 2016 10:26:48 +0100 [thread overview] Message-ID: <582048D8.3000000@sigmadesigns.com> (raw) In-Reply-To: <1978954.SRtJpfOGp1@wuerfel> On 07/11/2016 10:18, Arnd Bergmann wrote: > On Tuesday, October 25, 2016 3:15:50 PM CET Marc Gonzalez wrote: >> Add the tango NAND Flash Controller dt bindings documentation. >> >> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com> >> --- >> Documentation/devicetree/bindings/mtd/tango-nand.txt | 38 ++++++++++++++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mtd/tango-nand.txt b/Documentation/devicetree/bindings/mtd/tango-nand.txt >> new file mode 100644 >> index 000000000000..3cbf95d6595a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mtd/tango-nand.txt >> @@ -0,0 +1,38 @@ >> +Sigma Designs Tango4 NAND Flash Controller (NFC) >> + >> +Required properties: >> + >> +- compatible: "sigma,smp8758-nand" >> +- reg: address/size of nfc_reg, nfc_mem, and pbus_reg >> +- dmas: reference to the DMA channel used by the controller >> +- dma-names: "nfc_sbox" > > Drop the "nfc_" prefix here, it seems redundant. I don't think it's redundant; there are switch boxes for several different HW blocks; nfc_sbox is the first one to be exposed. >> +- clocks: reference to the system clock >> +- #address-cells: <1> >> +- #size-cells: <0> >> + >> +Children nodes represent the available NAND chips. >> +See Documentation/devicetree/bindings/mtd/nand.txt for generic bindings. >> + >> +Example: >> + >> + nand: nand@2c000 { >> + compatible = "sigma,smp8758-nand"; >> + reg = <0x2c000 0x30 0x2d000 0x800 0x20000 0x1000>; > > It would be nicer to write this as > > reg = <0x2c000 0x30>, <0x2d000 0x800>, <0x20000 0x1000>; > > which is identical in binary format. I didn't know that, thanks for pointing it out. Unfortunately, Boris already accepted the patch yesterday :-( Boris, do you fixup patches in your tree? Regards.
next prev parent reply other threads:[~2016-11-07 9:26 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-25 13:14 [PATCH v7 0/2] tango NFC support + bindings doc Marc Gonzalez 2016-10-25 13:14 ` Marc Gonzalez 2016-10-25 13:15 ` [PATCH v7 1/2] mtd: nand: add tango NFC dt " Marc Gonzalez 2016-10-25 13:15 ` Marc Gonzalez [not found] ` <580F5B06.6030608-y1yR0Z3OICC7zZZRDBGcUA@public.gmane.org> 2016-10-25 13:25 ` Boris Brezillon 2016-10-25 13:25 ` Boris Brezillon 2016-10-31 2:45 ` Rob Herring 2016-10-31 2:45 ` Rob Herring 2016-11-06 22:57 ` Boris Brezillon 2016-11-06 22:57 ` Boris Brezillon 2016-11-07 9:18 ` Arnd Bergmann 2016-11-07 9:18 ` Arnd Bergmann 2016-11-07 9:26 ` Marc Gonzalez [this message] 2016-11-07 9:26 ` Marc Gonzalez [not found] ` <582048D8.3000000-y1yR0Z3OICC7zZZRDBGcUA@public.gmane.org> 2016-11-07 9:40 ` Boris Brezillon 2016-11-07 9:40 ` Boris Brezillon 2016-12-16 10:56 ` Marc Gonzalez 2016-12-16 10:56 ` Marc Gonzalez 2016-12-16 13:26 ` Marc Gonzalez 2016-12-16 13:26 ` Marc Gonzalez [not found] ` <ee9efd0a-59f5-8c21-0cad-40ca30e3a3e7-y1yR0Z3OICC7zZZRDBGcUA@public.gmane.org> 2016-12-16 13:33 ` Mark Rutland 2016-12-16 13:33 ` Mark Rutland [not found] ` <d3cbfda6-23bf-4ad1-b1ce-c179b765272f-y1yR0Z3OICC7zZZRDBGcUA@public.gmane.org> 2016-12-19 12:59 ` Boris Brezillon 2016-12-19 12:59 ` Boris Brezillon 2016-10-25 13:16 ` [PATCH v7 2/2] mtd: nand: add tango NAND flash controller support Marc Gonzalez 2016-10-25 13:16 ` Marc Gonzalez [not found] ` <580F5B37.5090100-y1yR0Z3OICC7zZZRDBGcUA@public.gmane.org> 2016-10-25 16:10 ` [PATCH v8] " Marc Gonzalez 2016-10-25 16:10 ` Marc Gonzalez [not found] ` <580F8407.5070706-y1yR0Z3OICC7zZZRDBGcUA@public.gmane.org> 2016-11-06 22:58 ` Boris Brezillon 2016-11-06 22:58 ` Boris Brezillon 2016-11-11 16:01 ` Mason 2016-11-11 16:01 ` Mason [not found] ` <5825EB70.4070406-GANU6spQydw@public.gmane.org> 2016-11-11 17:14 ` Boris Brezillon 2016-11-11 17:14 ` Boris Brezillon 2016-12-01 1:44 ` Brian Norris 2016-12-01 1:44 ` Brian Norris
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=582048D8.3000000@sigmadesigns.com \ --to=marc_gonzalez@sigmadesigns.com \ --cc=arnd@arndb.de \ --cc=boris.brezillon@free-electrons.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ --cc=sf84@laposte.net \ --cc=slash.tmp@free.fr \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.