From: Jike Song <jike.song@intel.com> To: Kirti Wankhede <kwankhede@nvidia.com> Cc: alex.williamson@redhat.com, pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, kevin.tian@intel.com, bjsdjshi@linux.vnet.ibm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 12/22] vfio: Add notifier callback to parent's ops structure of mdev Date: Tue, 15 Nov 2016 14:45:42 +0800 [thread overview] Message-ID: <582AAF16.5080906@intel.com> (raw) In-Reply-To: <1479138156-28905-13-git-send-email-kwankhede@nvidia.com> On 11/14/2016 11:42 PM, Kirti Wankhede wrote: > Add a notifier calback to parent's ops structure of mdev device so that per > device notifer for vfio module is registered through vfio_mdev module. > > Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com> > Signed-off-by: Neo Jia <cjia@nvidia.com> > Change-Id: Iafa6f1721aecdd6e50eb93b153b5621e6d29b637 > --- > drivers/vfio/mdev/vfio_mdev.c | 19 +++++++++++++++++++ > include/linux/mdev.h | 9 +++++++++ > 2 files changed, 28 insertions(+) > > diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c > index ffc36758cb84..1694b1635607 100644 > --- a/drivers/vfio/mdev/vfio_mdev.c > +++ b/drivers/vfio/mdev/vfio_mdev.c > @@ -24,6 +24,15 @@ > #define DRIVER_AUTHOR "NVIDIA Corporation" > #define DRIVER_DESC "VFIO based driver for Mediated device" > > +static int vfio_mdev_notifier(struct notifier_block *nb, unsigned long action, > + void *data) > +{ > + struct mdev_device *mdev = container_of(nb, struct mdev_device, nb); > + struct parent_device *parent = mdev->parent; > + > + return parent->ops->notifier(mdev, action, data); > +} > + > static int vfio_mdev_open(void *device_data) > { > struct mdev_device *mdev = device_data; > @@ -40,6 +49,11 @@ static int vfio_mdev_open(void *device_data) > if (ret) > module_put(THIS_MODULE); > > + if (likely(parent->ops->notifier)) { > + mdev->nb.notifier_call = vfio_mdev_notifier; > + if (vfio_register_notifier(&mdev->dev, &mdev->nb)) > + pr_err("Failed to register notifier for mdev\n"); > + } Hi Kirti, Could you please move the notifier registration before parent->ops->open()? as you might know, I'm extending your vfio_register_notifier to also include the attaching/detaching events of vfio_group and kvm. Basically if vfio_group not attached to any kvm instance, the parent->ops->open() should return -ENODEV to indicate the failure, but to know whether kvm is available in open(), the notifier registration should be earlier. Of course I can call vfio_register_notifier() from an earlier place to workaround it, but it doesn't seem a canonical way. -- Thanks, Jike > return ret; > } > > @@ -48,6 +62,11 @@ static void vfio_mdev_release(void *device_data) > struct mdev_device *mdev = device_data; > struct parent_device *parent = mdev->parent; > > + if (likely(parent->ops->notifier)) { > + if (vfio_unregister_notifier(&mdev->dev, &mdev->nb)) > + pr_err("Failed to unregister notifier for mdev\n"); > + } > + > if (likely(parent->ops->release)) > parent->ops->release(mdev); > > diff --git a/include/linux/mdev.h b/include/linux/mdev.h > index 4900cc472364..665afe0a4c31 100644 > --- a/include/linux/mdev.h > +++ b/include/linux/mdev.h > @@ -37,6 +37,7 @@ struct mdev_device { > struct kref ref; > struct list_head next; > struct kobject *type_kobj; > + struct notifier_block nb; > }; > > /** > @@ -85,6 +86,12 @@ struct mdev_device { > * @mmap: mmap callback > * @mdev: mediated device structure > * @vma: vma structure > + * @notifer: Notifier callback, currently only for > + * VFIO_IOMMU_NOTIFY_DMA_UNMAP action notified duing > + * DMA_UNMAP call on mapped iova range. > + * @mdev: mediated device structure > + * @action: Action for which notifier is called > + * @data: Data associated with the notifier > * Parent device that support mediated device should be registered with mdev > * module with parent_ops structure. > **/ > @@ -106,6 +113,8 @@ struct parent_ops { > ssize_t (*ioctl)(struct mdev_device *mdev, unsigned int cmd, > unsigned long arg); > int (*mmap)(struct mdev_device *mdev, struct vm_area_struct *vma); > + int (*notifier)(struct mdev_device *mdev, unsigned long action, > + void *data); > }; > > /* interface for exporting mdev supported type attributes */ >
WARNING: multiple messages have this Message-ID (diff)
From: Jike Song <jike.song@intel.com> To: Kirti Wankhede <kwankhede@nvidia.com> Cc: alex.williamson@redhat.com, pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, kevin.tian@intel.com, bjsdjshi@linux.vnet.ibm.com, linux-kernel@vger.kernel.org Subject: Re: [Qemu-devel] [PATCH v12 12/22] vfio: Add notifier callback to parent's ops structure of mdev Date: Tue, 15 Nov 2016 14:45:42 +0800 [thread overview] Message-ID: <582AAF16.5080906@intel.com> (raw) In-Reply-To: <1479138156-28905-13-git-send-email-kwankhede@nvidia.com> On 11/14/2016 11:42 PM, Kirti Wankhede wrote: > Add a notifier calback to parent's ops structure of mdev device so that per > device notifer for vfio module is registered through vfio_mdev module. > > Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com> > Signed-off-by: Neo Jia <cjia@nvidia.com> > Change-Id: Iafa6f1721aecdd6e50eb93b153b5621e6d29b637 > --- > drivers/vfio/mdev/vfio_mdev.c | 19 +++++++++++++++++++ > include/linux/mdev.h | 9 +++++++++ > 2 files changed, 28 insertions(+) > > diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c > index ffc36758cb84..1694b1635607 100644 > --- a/drivers/vfio/mdev/vfio_mdev.c > +++ b/drivers/vfio/mdev/vfio_mdev.c > @@ -24,6 +24,15 @@ > #define DRIVER_AUTHOR "NVIDIA Corporation" > #define DRIVER_DESC "VFIO based driver for Mediated device" > > +static int vfio_mdev_notifier(struct notifier_block *nb, unsigned long action, > + void *data) > +{ > + struct mdev_device *mdev = container_of(nb, struct mdev_device, nb); > + struct parent_device *parent = mdev->parent; > + > + return parent->ops->notifier(mdev, action, data); > +} > + > static int vfio_mdev_open(void *device_data) > { > struct mdev_device *mdev = device_data; > @@ -40,6 +49,11 @@ static int vfio_mdev_open(void *device_data) > if (ret) > module_put(THIS_MODULE); > > + if (likely(parent->ops->notifier)) { > + mdev->nb.notifier_call = vfio_mdev_notifier; > + if (vfio_register_notifier(&mdev->dev, &mdev->nb)) > + pr_err("Failed to register notifier for mdev\n"); > + } Hi Kirti, Could you please move the notifier registration before parent->ops->open()? as you might know, I'm extending your vfio_register_notifier to also include the attaching/detaching events of vfio_group and kvm. Basically if vfio_group not attached to any kvm instance, the parent->ops->open() should return -ENODEV to indicate the failure, but to know whether kvm is available in open(), the notifier registration should be earlier. Of course I can call vfio_register_notifier() from an earlier place to workaround it, but it doesn't seem a canonical way. -- Thanks, Jike > return ret; > } > > @@ -48,6 +62,11 @@ static void vfio_mdev_release(void *device_data) > struct mdev_device *mdev = device_data; > struct parent_device *parent = mdev->parent; > > + if (likely(parent->ops->notifier)) { > + if (vfio_unregister_notifier(&mdev->dev, &mdev->nb)) > + pr_err("Failed to unregister notifier for mdev\n"); > + } > + > if (likely(parent->ops->release)) > parent->ops->release(mdev); > > diff --git a/include/linux/mdev.h b/include/linux/mdev.h > index 4900cc472364..665afe0a4c31 100644 > --- a/include/linux/mdev.h > +++ b/include/linux/mdev.h > @@ -37,6 +37,7 @@ struct mdev_device { > struct kref ref; > struct list_head next; > struct kobject *type_kobj; > + struct notifier_block nb; > }; > > /** > @@ -85,6 +86,12 @@ struct mdev_device { > * @mmap: mmap callback > * @mdev: mediated device structure > * @vma: vma structure > + * @notifer: Notifier callback, currently only for > + * VFIO_IOMMU_NOTIFY_DMA_UNMAP action notified duing > + * DMA_UNMAP call on mapped iova range. > + * @mdev: mediated device structure > + * @action: Action for which notifier is called > + * @data: Data associated with the notifier > * Parent device that support mediated device should be registered with mdev > * module with parent_ops structure. > **/ > @@ -106,6 +113,8 @@ struct parent_ops { > ssize_t (*ioctl)(struct mdev_device *mdev, unsigned int cmd, > unsigned long arg); > int (*mmap)(struct mdev_device *mdev, struct vm_area_struct *vma); > + int (*notifier)(struct mdev_device *mdev, unsigned long action, > + void *data); > }; > > /* interface for exporting mdev supported type attributes */ >
next prev parent reply other threads:[~2016-11-15 6:49 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-14 15:42 [PATCH v12 00/22] Add Mediated device support Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 01/22] vfio: Mediated device Core driver Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-15 8:30 ` Dong Jia Shi 2016-11-15 8:30 ` [Qemu-devel] " Dong Jia Shi 2016-11-15 15:16 ` Kirti Wankhede 2016-11-15 15:16 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 02/22] vfio: VFIO based driver for Mediated devices Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 03/22] vfio: Rearrange functions to get vfio_group from dev Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 04/22] vfio: Common function to increment container_users Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 05/22] vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 19:43 ` Alex Williamson 2016-11-14 19:43 ` [Qemu-devel] " Alex Williamson 2016-11-15 15:03 ` Kirti Wankhede 2016-11-15 15:03 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 06/22] vfio iommu type1: Update arguments of vfio_lock_acct Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 07/22] vfio iommu type1: Update argument of vaddr_get_pfn() Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 08/22] vfio iommu type1: Add find_iommu_group() function Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 09/22] vfio iommu type1: Add task structure to vfio_dma Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-15 5:26 ` Alexey Kardashevskiy 2016-11-15 5:26 ` [Qemu-devel] " Alexey Kardashevskiy 2016-11-14 15:42 ` [PATCH v12 10/22] vfio iommu type1: Add support for mediated devices Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 23:25 ` Alex Williamson 2016-11-14 23:25 ` [Qemu-devel] " Alex Williamson 2016-11-15 15:09 ` Kirti Wankhede 2016-11-15 15:09 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 23:58 ` Alex Williamson 2016-11-14 23:58 ` [Qemu-devel] " Alex Williamson 2016-11-15 15:11 ` Kirti Wankhede 2016-11-15 15:11 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 12/22] vfio: Add notifier callback to parent's ops structure of mdev Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-15 6:45 ` Jike Song [this message] 2016-11-15 6:45 ` Jike Song 2016-11-15 8:11 ` Kirti Wankhede 2016-11-15 8:11 ` [Qemu-devel] " Kirti Wankhede 2016-11-15 9:30 ` Jike Song 2016-11-15 9:30 ` [Qemu-devel] " Jike Song 2016-11-15 15:19 ` Alex Williamson 2016-11-15 15:19 ` [Qemu-devel] " Alex Williamson 2016-11-16 5:52 ` Jike Song 2016-11-16 5:52 ` [Qemu-devel] " Jike Song 2016-11-14 15:42 ` [PATCH v12 13/22] vfio: Introduce common function to add capabilities Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 14/22] vfio_pci: Update vfio_pci to use vfio_info_add_capability() Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 15/22] vfio: Introduce vfio_set_irqs_validate_and_prepare() Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 16/22] vfio_pci: Updated to use vfio_set_irqs_validate_and_prepare() Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 17/22] vfio_platform: " Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 18/22] vfio: Define device_api strings Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 19/22] docs: Add Documentation for Mediated devices Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 20/22] docs: Sysfs ABI for mediated device framework Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 21/22] docs: Sample driver to demonstrate how to use Mediated " Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede 2016-11-14 15:42 ` [PATCH v12 22/22] MAINTAINERS: Add entry VFIO based Mediated device drivers Kirti Wankhede 2016-11-14 15:42 ` [Qemu-devel] " Kirti Wankhede
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=582AAF16.5080906@intel.com \ --to=jike.song@intel.com \ --cc=alex.williamson@redhat.com \ --cc=bjsdjshi@linux.vnet.ibm.com \ --cc=cjia@nvidia.com \ --cc=kevin.tian@intel.com \ --cc=kraxel@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=kwankhede@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.