Untested PRs merged to jewel before 10.2.6 release?

Untested PRs merged to jewel before 10.2.6 release?

[Nathan Cutler]

I noticed that the v10.2.6 tag was added today and, as far as I can 
tell, it was added to the tip of the jewel branch. That would be fine, 
except that the tip of the jewel branch at the time the tag was added 
(420a9a0796e327676cb704bc18b2020f9941d7b6) is several PRs ahead of the 
jewel SHA1 that underwent integration testing 
(d9eaab456ff45ae88e83bd633f0c4efb5902bf07).

$ git log --oneline --no-merges 
d9eaab456ff45ae88e83bd633f0c4efb5902bf07..420a9a0796e327676cb704bc18b2020f9941d7b6
88f4895 qa/suites/upgrade/hammer-x: Add some volumes
0c242d1 qa/suites/ceph-deploy: Drop OpenStack volume count
ccd0265 qa: replace centos 7.2 with centos 7.3
2cbec5b Removed dumplin test 13234.yaml as not needed anymore
771e1d9 qa/suites/rest: Openstack volumes
a18640f qa/suites/ceph-ansible: Openstack volumes
841688b qa/suites/fs: Add openstack volume configuration
9778743 qa/suites/samba: Openstack volume configuration
cd1e8ef qa/suites/hadoop: Openstack volume configuration
ac7add1 qa/suites/knfs: Add openstack volume configuration
ba35859 qa/suites/kcephfs: Openstack volume configuration
aced718 qa/suites/krbd: Add openstack volume configuration
94d5888 qa/suites/rgw: Add openstack volume configuration

Am I seeing that right? If so, that appears to potentially defeat the 
purpose of the integration testing we do. Maybe I'm overstating the 
danger here -- the commits look innocuous enough -- but it seems to set 
a rather dangerous precedent.

Nathan

Re: Untested PRs merged to jewel before 10.2.6 release?

[Robin H. Johnson]

On Tue, Mar 07, 2017 at 10:38:52PM +0100, Nathan Cutler wrote:
> Am I seeing that right? If so, that appears to potentially defeat the 
> purpose of the integration testing we do. Maybe I'm overstating the 
> danger here -- the commits look innocuous enough -- but it seems to set 
> a rather dangerous precedent.
There's a merge error in them too:
qa/suites/rgw/singleton/all/radosgw-admin.yaml
>>>>>>> 8af4c35f95... qa/suites/rgw: Add openstack volume configuration
-- 
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation Trustee & Treasurer
E-Mail   : robbat2@gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136

Re: Untested PRs merged to jewel before 10.2.6 release?

[Nathan Cutler]

>> Am I seeing that right? If so, that appears to potentially defeat the
>> purpose of the integration testing we do. Maybe I'm overstating the
>> danger here -- the commits look innocuous enough -- but it seems to set
>> a rather dangerous precedent.
> There's a merge error in them too:
> qa/suites/rgw/singleton/all/radosgw-admin.yaml
>>>>>>>> 8af4c35f95... qa/suites/rgw: Add openstack volume configuration

Thanks, Robin. Opened https://github.com/ceph/ceph/pull/13952 with fix.

Nathan