[PATCH] iomap: set did_zero to true when zeroing successfully

* [PATCH] iomap: set did_zero to true when zeroing successfully
@ 2022-06-14  9:14 xiakaixu1987
  2022-06-15 22:07 ` Chaitanya Kulkarni
  2022-06-16  7:28 ` Christoph Hellwig
  0 siblings, 2 replies; 4+ messages in thread
From: xiakaixu1987 @ 2022-06-14  9:14 UTC (permalink / raw)
  To: linux-xfs, linux-fsdevel; +Cc: djwong, hch, Kaixu Xia

From: Kaixu Xia <kaixuxia@tencent.com>

It is unnecessary to check and set did_zero value in while() loop,
we can set did_zero to true only when zeroing successfully at last.

Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
 fs/dax.c               | 4 ++--
 fs/iomap/buffered-io.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/dax.c b/fs/dax.c
index 4155a6107fa1..649ff51c9a26 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -1088,10 +1088,10 @@ static s64 dax_zero_iter(struct iomap_iter *iter, bool *did_zero)
 		pos += size;
 		length -= size;
 		written += size;
-		if (did_zero)
-			*did_zero = true;
 	} while (length > 0);
 
+	if (did_zero)
+		*did_zero = true;
 	return written;
 }
 
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index d2a9f699e17e..1cadb24a1498 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -917,10 +917,10 @@ static loff_t iomap_zero_iter(struct iomap_iter *iter, bool *did_zero)
 		pos += bytes;
 		length -= bytes;
 		written += bytes;
-		if (did_zero)
-			*did_zero = true;
 	} while (length > 0);
 
+	if (did_zero)
+		*did_zero = true;
 	return written;
 }
 
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread