All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: Alex Deucher <alexdeucher@gmail.com>, amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>, stable@vger.kernel.org
Subject: Re: [PATCH] drm/amdgpu/si: fix crash on headless asics
Date: Fri, 27 Jan 2017 18:17:28 +0100	[thread overview]
Message-ID: <59c3126d-086e-c83d-b5b3-3cf1ac337bf3@vodafone.de> (raw)
In-Reply-To: <1485531205-32138-1-git-send-email-alexander.deucher@amd.com>

Am 27.01.2017 um 16:33 schrieb Alex Deucher:
> Missing check for crtcs present.
>
> Fixes:
> https://bugzilla.kernel.org/show_bug.cgi?id=193341
> https://bugs.freedesktop.org/show_bug.cgi?id=99387
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org

Reviewed-by: Christian König <christian.koenig@amd.com>.

> ---
>   drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> index 2341cf0..ea3779d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> @@ -227,6 +227,9 @@ static void gmc_v6_0_mc_program(struct amdgpu_device *adev)
>   	}
>   	WREG32(HDP_REG_COHERENCY_FLUSH_CNTL, 0);
>   
> +	if (adev->mode_info.num_crtc)
> +		amdgpu_display_set_vga_render_state(adev, false);
> +
>   	gmc_v6_0_mc_stop(adev, &save);
>   
>   	if (gmc_v6_0_wait_for_idle((void *)adev)) {
> @@ -256,7 +259,6 @@ static void gmc_v6_0_mc_program(struct amdgpu_device *adev)
>   		dev_warn(adev->dev, "Wait for MC idle timedout !\n");
>   	}
>   	gmc_v6_0_mc_resume(adev, &save);
> -	amdgpu_display_set_vga_render_state(adev, false);
>   }
>   
>   static int gmc_v6_0_mc_init(struct amdgpu_device *adev)



WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
To: Alex Deucher
	<alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
	stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu/si: fix crash on headless asics
Date: Fri, 27 Jan 2017 18:17:28 +0100	[thread overview]
Message-ID: <59c3126d-086e-c83d-b5b3-3cf1ac337bf3@vodafone.de> (raw)
In-Reply-To: <1485531205-32138-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>

Am 27.01.2017 um 16:33 schrieb Alex Deucher:
> Missing check for crtcs present.
>
> Fixes:
> https://bugzilla.kernel.org/show_bug.cgi?id=193341
> https://bugs.freedesktop.org/show_bug.cgi?id=99387
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org

Reviewed-by: Christian König <christian.koenig@amd.com>.

> ---
>   drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> index 2341cf0..ea3779d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> @@ -227,6 +227,9 @@ static void gmc_v6_0_mc_program(struct amdgpu_device *adev)
>   	}
>   	WREG32(HDP_REG_COHERENCY_FLUSH_CNTL, 0);
>   
> +	if (adev->mode_info.num_crtc)
> +		amdgpu_display_set_vga_render_state(adev, false);
> +
>   	gmc_v6_0_mc_stop(adev, &save);
>   
>   	if (gmc_v6_0_wait_for_idle((void *)adev)) {
> @@ -256,7 +259,6 @@ static void gmc_v6_0_mc_program(struct amdgpu_device *adev)
>   		dev_warn(adev->dev, "Wait for MC idle timedout !\n");
>   	}
>   	gmc_v6_0_mc_resume(adev, &save);
> -	amdgpu_display_set_vga_render_state(adev, false);
>   }
>   
>   static int gmc_v6_0_mc_init(struct amdgpu_device *adev)


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2017-01-27 17:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27 15:33 [PATCH] drm/amdgpu/si: fix crash on headless asics Alex Deucher
2017-01-27 15:33 ` Alex Deucher
2017-01-27 17:17 ` Christian König [this message]
2017-01-27 17:17   ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59c3126d-086e-c83d-b5b3-3cf1ac337bf3@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.