* [PATCH] drm/amdgpu/si: fix crash on headless asics
@ 2017-01-27 15:33 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2017-01-27 15:33 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher, stable
Missing check for crtcs present.
Fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=193341
https://bugs.freedesktop.org/show_bug.cgi?id=99387
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
index 2341cf0..ea3779d 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
@@ -227,6 +227,9 @@ static void gmc_v6_0_mc_program(struct amdgpu_device *adev)
}
WREG32(HDP_REG_COHERENCY_FLUSH_CNTL, 0);
+ if (adev->mode_info.num_crtc)
+ amdgpu_display_set_vga_render_state(adev, false);
+
gmc_v6_0_mc_stop(adev, &save);
if (gmc_v6_0_wait_for_idle((void *)adev)) {
@@ -256,7 +259,6 @@ static void gmc_v6_0_mc_program(struct amdgpu_device *adev)
dev_warn(adev->dev, "Wait for MC idle timedout !\n");
}
gmc_v6_0_mc_resume(adev, &save);
- amdgpu_display_set_vga_render_state(adev, false);
}
static int gmc_v6_0_mc_init(struct amdgpu_device *adev)
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/amdgpu/si: fix crash on headless asics
@ 2017-01-27 15:33 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2017-01-27 15:33 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Alex Deucher, stable-u79uwXL29TY76Z2rM5mHXA
Missing check for crtcs present.
Fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=193341
https://bugs.freedesktop.org/show_bug.cgi?id=99387
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
index 2341cf0..ea3779d 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
@@ -227,6 +227,9 @@ static void gmc_v6_0_mc_program(struct amdgpu_device *adev)
}
WREG32(HDP_REG_COHERENCY_FLUSH_CNTL, 0);
+ if (adev->mode_info.num_crtc)
+ amdgpu_display_set_vga_render_state(adev, false);
+
gmc_v6_0_mc_stop(adev, &save);
if (gmc_v6_0_wait_for_idle((void *)adev)) {
@@ -256,7 +259,6 @@ static void gmc_v6_0_mc_program(struct amdgpu_device *adev)
dev_warn(adev->dev, "Wait for MC idle timedout !\n");
}
gmc_v6_0_mc_resume(adev, &save);
- amdgpu_display_set_vga_render_state(adev, false);
}
static int gmc_v6_0_mc_init(struct amdgpu_device *adev)
--
2.5.5
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu/si: fix crash on headless asics
@ 2017-01-27 17:17 ` Christian König
0 siblings, 0 replies; 4+ messages in thread
From: Christian König @ 2017-01-27 17:17 UTC (permalink / raw)
To: Alex Deucher, amd-gfx; +Cc: Alex Deucher, stable
Am 27.01.2017 um 16:33 schrieb Alex Deucher:
> Missing check for crtcs present.
>
> Fixes:
> https://bugzilla.kernel.org/show_bug.cgi?id=193341
> https://bugs.freedesktop.org/show_bug.cgi?id=99387
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org
Reviewed-by: Christian König <christian.koenig@amd.com>.
> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> index 2341cf0..ea3779d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> @@ -227,6 +227,9 @@ static void gmc_v6_0_mc_program(struct amdgpu_device *adev)
> }
> WREG32(HDP_REG_COHERENCY_FLUSH_CNTL, 0);
>
> + if (adev->mode_info.num_crtc)
> + amdgpu_display_set_vga_render_state(adev, false);
> +
> gmc_v6_0_mc_stop(adev, &save);
>
> if (gmc_v6_0_wait_for_idle((void *)adev)) {
> @@ -256,7 +259,6 @@ static void gmc_v6_0_mc_program(struct amdgpu_device *adev)
> dev_warn(adev->dev, "Wait for MC idle timedout !\n");
> }
> gmc_v6_0_mc_resume(adev, &save);
> - amdgpu_display_set_vga_render_state(adev, false);
> }
>
> static int gmc_v6_0_mc_init(struct amdgpu_device *adev)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu/si: fix crash on headless asics
@ 2017-01-27 17:17 ` Christian König
0 siblings, 0 replies; 4+ messages in thread
From: Christian König @ 2017-01-27 17:17 UTC (permalink / raw)
To: Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Alex Deucher, stable-u79uwXL29TY76Z2rM5mHXA
Am 27.01.2017 um 16:33 schrieb Alex Deucher:
> Missing check for crtcs present.
>
> Fixes:
> https://bugzilla.kernel.org/show_bug.cgi?id=193341
> https://bugs.freedesktop.org/show_bug.cgi?id=99387
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org
Reviewed-by: Christian König <christian.koenig@amd.com>.
> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> index 2341cf0..ea3779d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
> @@ -227,6 +227,9 @@ static void gmc_v6_0_mc_program(struct amdgpu_device *adev)
> }
> WREG32(HDP_REG_COHERENCY_FLUSH_CNTL, 0);
>
> + if (adev->mode_info.num_crtc)
> + amdgpu_display_set_vga_render_state(adev, false);
> +
> gmc_v6_0_mc_stop(adev, &save);
>
> if (gmc_v6_0_wait_for_idle((void *)adev)) {
> @@ -256,7 +259,6 @@ static void gmc_v6_0_mc_program(struct amdgpu_device *adev)
> dev_warn(adev->dev, "Wait for MC idle timedout !\n");
> }
> gmc_v6_0_mc_resume(adev, &save);
> - amdgpu_display_set_vga_render_state(adev, false);
> }
>
> static int gmc_v6_0_mc_init(struct amdgpu_device *adev)
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-27 17:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-27 15:33 [PATCH] drm/amdgpu/si: fix crash on headless asics Alex Deucher
2017-01-27 15:33 ` Alex Deucher
2017-01-27 17:17 ` Christian König
2017-01-27 17:17 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.