* + checkpatch-printks-always-need-a-kern_level.patch added to -mm tree
@ 2017-10-03 21:37 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2017-10-03 21:37 UTC (permalink / raw)
To: joe, mm-commits
The patch titled
Subject: checkpatch: printks always need a KERN_<LEVEL>
has been added to the -mm tree. Its filename is
checkpatch-printks-always-need-a-kern_level.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/checkpatch-printks-always-need-a-kern_level.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/checkpatch-printks-always-need-a-kern_level.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Joe Perches <joe@perches.com>
Subject: checkpatch: printks always need a KERN_<LEVEL>
There was code in checkpatch that allowed continuation printks to be used
without KERN_CONT. Remove the continuation check and always require a
KERN_<LEVEL>.
Link: http://lkml.kernel.org/r/61980ef41d5b9b6543da1c49055042e0ab74d308.1507047008.git.joe@perches.com
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
scripts/checkpatch.pl | 26 ++++----------------------
1 file changed, 4 insertions(+), 22 deletions(-)
diff -puN scripts/checkpatch.pl~checkpatch-printks-always-need-a-kern_level scripts/checkpatch.pl
--- a/scripts/checkpatch.pl~checkpatch-printks-always-need-a-kern_level
+++ a/scripts/checkpatch.pl
@@ -3829,28 +3829,10 @@ sub process {
"Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit\n" . $herecurr);
}
-# printk should use KERN_* levels. Note that follow on printk's on the
-# same line do not need a level, so we use the current block context
-# to try and find and validate the current printk. In summary the current
-# printk includes all preceding printk's which have no newline on the end.
-# we assume the first bad printk is the one to report.
- if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
- my $ok = 0;
- for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
- #print "CHECK<$lines[$ln - 1]\n";
- # we have a preceding printk if it ends
- # with "\n" ignore it, else it is to blame
- if ($lines[$ln - 1] =~ m{\bprintk\(}) {
- if ($rawlines[$ln - 1] !~ m{\\n"}) {
- $ok = 1;
- }
- last;
- }
- }
- if ($ok == 0) {
- WARN("PRINTK_WITHOUT_KERN_LEVEL",
- "printk() should include KERN_ facility level\n" . $herecurr);
- }
+# printk should use KERN_* levels
+ if ($line =~ /\bprintk\s*\(\s*(?!KERN_[A-Z]+\b)/) {
+ WARN("PRINTK_WITHOUT_KERN_LEVEL",
+ "printk() should include KERN_<LEVEL> facility level\n" . $herecurr);
}
if ($line =~ /\bprintk\s*\(\s*KERN_([A-Z]+)/) {
_
Patches currently in -mm which might be from joe@perches.com are
spellingtxt-add-unnecessary-typo-variants.patch
parse-maintainers-add-ability-to-specify-filenames.patch
checkpatch-printks-always-need-a-kern_level.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-10-03 21:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-03 21:37 + checkpatch-printks-always-need-a-kern_level.patch added to -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.