* [PATCH] ext4: no need flush workqueue before destroying it
@ 2017-12-01 7:44 piaojun
2017-12-04 0:43 ` piaojun
0 siblings, 1 reply; 7+ messages in thread
From: piaojun @ 2017-12-01 7:44 UTC (permalink / raw)
To: linux-ext4
destroy_workqueue() will do flushing work for us.
Signed-off-by: Jun Piao <piaojun@huawei.com>
---
fs/ext4/super.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 0556cd0..2f46b0b 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
ext4_unregister_li_request(sb);
ext4_quota_off_umount(sb);
- flush_workqueue(sbi->rsv_conversion_wq);
destroy_workqueue(sbi->rsv_conversion_wq);
if (sbi->s_journal) {
--
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ext4: no need flush workqueue before destroying it
2017-12-01 7:44 [PATCH] ext4: no need flush workqueue before destroying it piaojun
@ 2017-12-04 0:43 ` piaojun
0 siblings, 0 replies; 7+ messages in thread
From: piaojun @ 2017-12-04 0:43 UTC (permalink / raw)
To: linux-ext4, tytso
Hi Ted,
Could you help reviewing my patch?
thanks,
Jun
On 2017/12/1 15:44, piaojun wrote:
> destroy_workqueue() will do flushing work for us.
>
> Signed-off-by: Jun Piao <piaojun@huawei.com>
> ---
> fs/ext4/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 0556cd0..2f46b0b 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
> ext4_unregister_li_request(sb);
> ext4_quota_off_umount(sb);
>
> - flush_workqueue(sbi->rsv_conversion_wq);
> destroy_workqueue(sbi->rsv_conversion_wq);
>
> if (sbi->s_journal) {
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ext4: no need flush workqueue before destroying it
2018-01-10 0:16 ` piaojun
@ 2018-01-10 2:42 ` Theodore Ts'o
0 siblings, 0 replies; 7+ messages in thread
From: Theodore Ts'o @ 2018-01-10 2:42 UTC (permalink / raw)
To: piaojun; +Cc: Jan Kara, adilger.kernel, arnd, linux-ext4
On Wed, Jan 10, 2018 at 08:16:47AM +0800, piaojun wrote:
>
> On 2018/1/9 23:07, Jan Kara wrote:
> > On Tue 09-01-18 20:37:54, piaojun wrote:
> >> destroy_workqueue() will do flushing work for us.
> >>
> >> Signed-off-by: Jun Piao <piaojun@huawei.com>
> >
> > Looks good. You can add:
> >
> > Reviewed-by: Jan Kara <jack@suse.cz>
Thanks, applied. (Note, you don't have resend the patch after it's
been reviewed; I can append the Reviewed-by line.)
- Ted
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ext4: no need flush workqueue before destroying it
@ 2018-01-10 0:19 piaojun
0 siblings, 0 replies; 7+ messages in thread
From: piaojun @ 2018-01-10 0:19 UTC (permalink / raw)
To: Jan Kara; +Cc: adilger.kernel, arnd, Ted Tso, linux-ext4
destroy_workqueue() will do flushing work for us.
Signed-off-by: Jun Piao <piaojun@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
fs/ext4/super.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 0556cd0..2f46b0b 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
ext4_unregister_li_request(sb);
ext4_quota_off_umount(sb);
- flush_workqueue(sbi->rsv_conversion_wq);
destroy_workqueue(sbi->rsv_conversion_wq);
if (sbi->s_journal) {
--
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ext4: no need flush workqueue before destroying it
2018-01-09 15:07 ` Jan Kara
@ 2018-01-10 0:16 ` piaojun
2018-01-10 2:42 ` Theodore Ts'o
0 siblings, 1 reply; 7+ messages in thread
From: piaojun @ 2018-01-10 0:16 UTC (permalink / raw)
To: Jan Kara; +Cc: adilger.kernel, arnd, linux-ext4, Ted Tso
Hi Jan,
Thanks for reviewing, and I will resend this patch again.
thanks,
Jun
On 2018/1/9 23:07, Jan Kara wrote:
> On Tue 09-01-18 20:37:54, piaojun wrote:
>> destroy_workqueue() will do flushing work for us.
>>
>> Signed-off-by: Jun Piao <piaojun@huawei.com>
>
> Looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Adding Ted to CC as a maintainer...
>
> Honza
>
>> ---
>> fs/ext4/super.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
>> index 0556cd0..2f46b0b 100644
>> --- a/fs/ext4/super.c
>> +++ b/fs/ext4/super.c
>> @@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
>> ext4_unregister_li_request(sb);
>> ext4_quota_off_umount(sb);
>>
>> - flush_workqueue(sbi->rsv_conversion_wq);
>> destroy_workqueue(sbi->rsv_conversion_wq);
>>
>> if (sbi->s_journal) {
>> --
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ext4: no need flush workqueue before destroying it
2018-01-09 12:37 piaojun
@ 2018-01-09 15:07 ` Jan Kara
2018-01-10 0:16 ` piaojun
0 siblings, 1 reply; 7+ messages in thread
From: Jan Kara @ 2018-01-09 15:07 UTC (permalink / raw)
To: piaojun; +Cc: Jan Kara, adilger.kernel, arnd, linux-ext4, Ted Tso
On Tue 09-01-18 20:37:54, piaojun wrote:
> destroy_workqueue() will do flushing work for us.
>
> Signed-off-by: Jun Piao <piaojun@huawei.com>
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Adding Ted to CC as a maintainer...
Honza
> ---
> fs/ext4/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 0556cd0..2f46b0b 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
> ext4_unregister_li_request(sb);
> ext4_quota_off_umount(sb);
>
> - flush_workqueue(sbi->rsv_conversion_wq);
> destroy_workqueue(sbi->rsv_conversion_wq);
>
> if (sbi->s_journal) {
> --
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ext4: no need flush workqueue before destroying it
@ 2018-01-09 12:37 piaojun
2018-01-09 15:07 ` Jan Kara
0 siblings, 1 reply; 7+ messages in thread
From: piaojun @ 2018-01-09 12:37 UTC (permalink / raw)
To: Jan Kara; +Cc: adilger.kernel, arnd, linux-ext4
destroy_workqueue() will do flushing work for us.
Signed-off-by: Jun Piao <piaojun@huawei.com>
---
fs/ext4/super.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 0556cd0..2f46b0b 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
ext4_unregister_li_request(sb);
ext4_quota_off_umount(sb);
- flush_workqueue(sbi->rsv_conversion_wq);
destroy_workqueue(sbi->rsv_conversion_wq);
if (sbi->s_journal) {
--
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-01-10 2:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-01 7:44 [PATCH] ext4: no need flush workqueue before destroying it piaojun
2017-12-04 0:43 ` piaojun
2018-01-09 12:37 piaojun
2018-01-09 15:07 ` Jan Kara
2018-01-10 0:16 ` piaojun
2018-01-10 2:42 ` Theodore Ts'o
2018-01-10 0:19 piaojun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.